@ngocsangairvds/vsaf 3.1.26 → 3.2.1

package/tools/vds-scripts/jira_orchestrator/tests/test_filter_management.py

@@ -0,0 +1,333 @@
+"""Tests for JIRA filter management."""
+
+from __future__ import annotations
+
+from unittest.mock import MagicMock, patch
+
+import pytest
+from typer.testing import CliRunner
+from vds_jira_orchestrator.adapter import JiraAdapter, JiraNotFound
+from vds_jira_orchestrator.cli import app
+
+runner = CliRunner()
+
+
+# ---------------------------------------------------------------------------
+# Adapter method tests
+# ---------------------------------------------------------------------------
+
+
+@patch("vds_jira_orchestrator.adapter.Jira")
+def test_get_filters_calls_client(mock_jira: MagicMock) -> None:
+    """Test that get_filters calls the SDK client."""
+    client = MagicMock()
+    client.resource_url.return_value = "https://jira.example.com/rest/api/2/filter"
+    client.get.return_value = {"values": [{"id": 10000, "name": "Filter 1"}, {"id": 10001, "name": "Filter 2"}]}
+    mock_jira.return_value = client
+
+    adapter = JiraAdapter(url="https://jira.example.com", username="user", password="pass")
+    result = adapter.get_filters()
+
+    assert len(result) == 2
+    assert result[0]["id"] == 10000
+
+
+@patch("vds_jira_orchestrator.adapter.Jira")
+def test_get_filters_with_owner(mock_jira: MagicMock) -> None:
+    """Test that get_filters filters by owner."""
+    client = MagicMock()
+    client.resource_url.return_value = "https://jira.example.com/rest/api/2/filter"
+    client.get.return_value = {"values": [{"id": 10000, "name": "My Filter", "owner": {"name": "user"}}]}
+    mock_jira.return_value = client
+
+    adapter = JiraAdapter(url="https://jira.example.com", username="user", password="pass")
+    adapter.get_filters(owner="user")
+
+    client.get.assert_called_once()
+    assert "username" in str(client.get.call_args)
+
+
+@patch("vds_jira_orchestrator.adapter.Jira")
+def test_get_filter_calls_client(mock_jira: MagicMock) -> None:
+    """Test that get_filter calls the SDK client."""
+    client = MagicMock()
+    client.get_filter.return_value = {"id": 10000, "name": "Test Filter", "jql": "project = TEST"}
+    mock_jira.return_value = client
+
+    adapter = JiraAdapter(url="https://jira.example.com", username="user", password="pass")
+    result = adapter.get_filter(10000)
+
+    client.get_filter.assert_called_once_with(10000)
+    assert result["id"] == 10000
+
+
+@patch("vds_jira_orchestrator.adapter.Jira")
+def test_get_filter_not_found(mock_jira: MagicMock) -> None:
+    """Test that get_filter raises JiraNotFound when filter is not found."""
+    client = MagicMock()
+    client.get_filter.return_value = None
+    mock_jira.return_value = client
+
+    adapter = JiraAdapter(url="https://jira.example.com", username="user", password="pass")
+
+    with pytest.raises(JiraNotFound, match="Filter not found: 99999"):
+        adapter.get_filter(99999)
+
+
+@patch("vds_jira_orchestrator.adapter.Jira")
+def test_create_filter_calls_client(mock_jira: MagicMock) -> None:
+    """Test that create_filter calls the SDK client."""
+    client = MagicMock()
+    client.create_filter.return_value = {"id": 10000, "name": "New Filter", "jql": "project = TEST"}
+    mock_jira.return_value = client
+
+    adapter = JiraAdapter(url="https://jira.example.com", username="user", password="pass")
+    result = adapter.create_filter(name="New Filter", jql="project = TEST", description="Test filter")
+
+    client.create_filter.assert_called_once_with(name="New Filter", jql="project = TEST", description="Test filter", favourite=False)
+    assert result["id"] == 10000
+
+
+@patch("vds_jira_orchestrator.adapter.Jira")
+def test_create_filter_with_favourite(mock_jira: MagicMock) -> None:
+    """Test that create_filter can mark filter as favourite."""
+    client = MagicMock()
+    client.create_filter.return_value = {"id": 10000, "name": "Favourite Filter", "favourite": True}
+    mock_jira.return_value = client
+
+    adapter = JiraAdapter(url="https://jira.example.com", username="user", password="pass")
+    result = adapter.create_filter(name="Favourite Filter", jql="project = TEST", favourite=True)
+
+    client.create_filter.assert_called_once_with(name="Favourite Filter", jql="project = TEST", description=None, favourite=True)
+    assert result["favourite"] is True
+
+
+@patch("vds_jira_orchestrator.adapter.Jira")
+def test_update_filter_calls_client(mock_jira: MagicMock) -> None:
+    """Test that update_filter calls the SDK client."""
+    client = MagicMock()
+    client.get_filter.return_value = {"id": 10000, "name": "Old Name", "jql": "project = TEST"}
+    client.update_filter.return_value = {"id": 10000, "name": "New Name", "jql": "project = TEST"}
+    mock_jira.return_value = client
+
+    adapter = JiraAdapter(url="https://jira.example.com", username="user", password="pass")
+    result = adapter.update_filter(filter_id=10000, name="New Name")
+
+    client.update_filter.assert_called_once()
+    assert result["name"] == "New Name"
+
+
+@patch("vds_jira_orchestrator.adapter.Jira")
+def test_update_filter_with_jql(mock_jira: MagicMock) -> None:
+    """Test that update_filter can update JQL."""
+    client = MagicMock()
+    client.update_filter.return_value = {"id": 10000, "name": "Filter", "jql": "project = NEW"}
+    mock_jira.return_value = client
+
+    adapter = JiraAdapter(url="https://jira.example.com", username="user", password="pass")
+    result = adapter.update_filter(filter_id=10000, jql="project = NEW")
+
+    client.update_filter.assert_called_once()
+    assert result["jql"] == "project = NEW"
+
+
+@patch("vds_jira_orchestrator.adapter.Jira")
+def test_delete_filter_calls_client(mock_jira: MagicMock) -> None:
+    """Test that delete_filter calls the SDK client."""
+    client = MagicMock()
+    client.delete_filter.return_value = None
+    mock_jira.return_value = client
+
+    adapter = JiraAdapter(url="https://jira.example.com", username="user", password="pass")
+    adapter.delete_filter(10000)
+
+    client.delete_filter.assert_called_once_with(10000)
+
+
+@patch("vds_jira_orchestrator.adapter.Jira")
+def test_get_filters_handles_list_response(mock_jira: MagicMock) -> None:
+    """Test that get_filters handles list response format."""
+    client = MagicMock()
+    client.resource_url.return_value = "https://jira.example.com/rest/api/2/filter"
+    client.get.return_value = [{"id": 10000, "name": "Filter 1"}]
+    mock_jira.return_value = client
+
+    adapter = JiraAdapter(url="https://jira.example.com", username="user", password="pass")
+    result = adapter.get_filters()
+
+    assert len(result) == 1
+    assert result[0]["id"] == 10000
+
+
+# ---------------------------------------------------------------------------
+# CLI command tests
+# ---------------------------------------------------------------------------
+
+
+@patch("vds_jira_orchestrator.cli.JiraAdapter")
+@patch("vds_jira_orchestrator.cli.JiraSettings")
+def test_cli_filter_list_success(mock_settings: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test filter list CLI command success."""
+    mock_adapter = MagicMock()
+    mock_adapter.get_filters.return_value = [{"id": 10000, "name": "Filter 1"}]
+    mock_adapter_class.return_value = mock_adapter
+
+    result = runner.invoke(app, ["filter", "list"])
+
+    assert result.exit_code == 0
+    assert "filters" in result.stdout
+    mock_adapter.get_filters.assert_called_once_with(owner=None)
+
+
+@patch("vds_jira_orchestrator.cli.JiraAdapter")
+@patch("vds_jira_orchestrator.cli.JiraSettings")
+def test_cli_filter_list_with_owner(mock_settings: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test filter list CLI command with owner filter."""
+    mock_adapter = MagicMock()
+    mock_adapter.get_filters.return_value = [{"id": 10000, "name": "My Filter"}]
+    mock_adapter_class.return_value = mock_adapter
+
+    result = runner.invoke(app, ["filter", "list", "--owner", "user"])
+
+    assert result.exit_code == 0
+    mock_adapter.get_filters.assert_called_once_with(owner="user")
+
+
+@patch("vds_jira_orchestrator.cli.JiraAdapter")
+@patch("vds_jira_orchestrator.cli.JiraSettings")
+def test_cli_filter_get_success(mock_settings: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test filter get CLI command success."""
+    mock_adapter = MagicMock()
+    mock_adapter.get_filter.return_value = {"id": 10000, "name": "Test Filter", "jql": "project = TEST"}
+    mock_adapter_class.return_value = mock_adapter
+
+    result = runner.invoke(app, ["filter", "get", "--filter-id", "10000"])
+
+    assert result.exit_code == 0
+    assert "10000" in result.stdout
+    mock_adapter.get_filter.assert_called_once_with(10000)
+
+
+@patch("vds_jira_orchestrator.cli.JiraAdapter")
+@patch("vds_jira_orchestrator.cli.JiraSettings")
+def test_cli_filter_get_requires_id(mock_settings: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test filter get CLI command requires filter ID."""
+    result = runner.invoke(app, ["filter", "get"])
+
+    assert result.exit_code != 0
+    assert "--filter-id required" in result.stdout or "--filter-id required" in result.stderr
+
+
+@patch("vds_jira_orchestrator.cli.JiraAdapter")
+@patch("vds_jira_orchestrator.cli.JiraSettings")
+def test_cli_filter_create_success(mock_settings: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test filter create CLI command success."""
+    mock_adapter = MagicMock()
+    mock_adapter.create_filter.return_value = {"id": 10000, "name": "New Filter", "jql": "project = TEST"}
+    mock_adapter_class.return_value = mock_adapter
+
+    result = runner.invoke(app, ["filter", "create", "--name", "New Filter", "--jql", "project = TEST", "--yes"])
+
+    assert result.exit_code == 0
+    mock_adapter.create_filter.assert_called_once()
+
+
+@patch("vds_jira_orchestrator.cli.JiraAdapter")
+@patch("vds_jira_orchestrator.cli.JiraSettings")
+def test_cli_filter_create_requires_yes(mock_settings: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test filter create CLI command requires --yes flag."""
+    result = runner.invoke(app, ["filter", "create", "--name", "New Filter", "--jql", "project = TEST"])
+
+    assert result.exit_code != 0
+    assert "--yes" in result.stdout or "--yes" in result.stderr or "without --yes" in result.stdout or "without --yes" in result.stderr or "Refusing" in result.stdout or "Refusing" in result.stderr
+
+
+@patch("vds_jira_orchestrator.cli.JiraAdapter")
+@patch("vds_jira_orchestrator.cli.JiraSettings")
+def test_cli_filter_create_requires_name(mock_settings: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test filter create CLI command requires name."""
+    result = runner.invoke(app, ["filter", "create", "--jql", "project = TEST", "--yes"])
+
+    assert result.exit_code != 0
+    assert "--name required" in result.stdout or "--name required" in result.stderr
+
+
+@patch("vds_jira_orchestrator.cli.JiraAdapter")
+@patch("vds_jira_orchestrator.cli.JiraSettings")
+def test_cli_filter_create_requires_jql(mock_settings: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test filter create CLI command requires JQL."""
+    result = runner.invoke(app, ["filter", "create", "--name", "New Filter", "--yes"])
+
+    assert result.exit_code != 0
+    assert "--jql required" in result.stdout or "--jql required" in result.stderr
+
+
+@patch("vds_jira_orchestrator.cli.JiraAdapter")
+@patch("vds_jira_orchestrator.cli.JiraSettings")
+def test_cli_filter_update_success(mock_settings: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test filter update CLI command success."""
+    mock_adapter = MagicMock()
+    mock_adapter.get_filter.return_value = {"id": 10000, "name": "Old Name", "jql": "project = TEST"}
+    mock_adapter.update_filter.return_value = {"id": 10000, "name": "New Name", "jql": "project = TEST"}
+    mock_adapter_class.return_value = mock_adapter
+
+    result = runner.invoke(app, ["filter", "update", "--filter-id", "10000", "--name", "New Name", "--yes"])
+
+    assert result.exit_code == 0
+    mock_adapter.update_filter.assert_called_once()
+
+
+@patch("vds_jira_orchestrator.cli.JiraAdapter")
+@patch("vds_jira_orchestrator.cli.JiraSettings")
+def test_cli_filter_update_requires_yes(mock_settings: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test filter update CLI command requires --yes flag."""
+    result = runner.invoke(app, ["filter", "update", "--filter-id", "10000", "--name", "New Name"])
+
+    assert result.exit_code != 0
+    assert "--yes" in result.stdout or "--yes" in result.stderr or "without --yes" in result.stdout or "without --yes" in result.stderr or "Refusing" in result.stdout or "Refusing" in result.stderr
+
+
+@patch("vds_jira_orchestrator.cli.JiraAdapter")
+@patch("vds_jira_orchestrator.cli.JiraSettings")
+def test_cli_filter_update_requires_field(mock_settings: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test filter update CLI command requires at least one field."""
+    result = runner.invoke(app, ["filter", "update", "--filter-id", "10000", "--yes"])
+
+    assert result.exit_code != 0
+    assert "At least one" in result.stdout or "At least one" in result.stderr
+
+
+@patch("vds_jira_orchestrator.cli.JiraAdapter")
+@patch("vds_jira_orchestrator.cli.JiraSettings")
+def test_cli_filter_delete_success(mock_settings: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test filter delete CLI command success."""
+    mock_adapter = MagicMock()
+    mock_adapter.delete_filter.return_value = None
+    mock_adapter_class.return_value = mock_adapter
+
+    result = runner.invoke(app, ["filter", "delete", "--filter-id", "10000", "--yes"])
+
+    assert result.exit_code == 0
+    assert "success" in result.stdout
+    mock_adapter.delete_filter.assert_called_once_with(10000)
+
+
+@patch("vds_jira_orchestrator.cli.JiraAdapter")
+@patch("vds_jira_orchestrator.cli.JiraSettings")
+def test_cli_filter_delete_requires_yes(mock_settings: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test filter delete CLI command requires --yes flag."""
+    result = runner.invoke(app, ["filter", "delete", "--filter-id", "10000"])
+
+    assert result.exit_code != 0
+    assert "--yes" in result.stdout or "--yes" in result.stderr or "without --yes" in result.stdout or "without --yes" in result.stderr or "Refusing" in result.stdout or "Refusing" in result.stderr
+
+
+@patch("vds_jira_orchestrator.cli.JiraAdapter")
+@patch("vds_jira_orchestrator.cli.JiraSettings")
+def test_cli_filter_invalid_action(mock_settings: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test filter CLI command with invalid action."""
+    result = runner.invoke(app, ["filter", "invalid"])
+
+    assert result.exit_code != 0
+    assert "Unknown action" in result.stdout or "Unknown action" in result.stderr
+

package/tools/vds-scripts/jira_orchestrator/tests/test_issue_archiving.py

@@ -0,0 +1,164 @@
+from __future__ import annotations
+
+from unittest.mock import MagicMock, Mock, patch
+
+import pytest
+from typer.testing import CliRunner
+from vds_jira_orchestrator.adapter import JiraAdapter, JiraAdapterError
+from vds_jira_orchestrator.cli import app
+
+
+@pytest.fixture
+def mock_adapter() -> JiraAdapter:
+    """Fixture for a JiraAdapter."""
+    with patch("vds_jira_orchestrator.adapter.Jira") as mock_jira_class:
+        mock_client = MagicMock()
+        mock_jira_class.return_value = mock_client
+        adapter = JiraAdapter(url="https://jira.example.com", username="user", password="pass")
+        adapter._client = mock_client
+        return adapter
+
+
+@pytest.fixture
+def runner() -> CliRunner:
+    return CliRunner()
+
+
+@pytest.fixture
+def mock_settings_class() -> MagicMock:
+    """Mock JiraSettings for CLI tests."""
+    mock_settings = Mock()
+    mock_settings.base_url = "https://jira.example.com"
+    mock_settings.username = "testuser"
+    mock_settings.password = "testpass"
+    mock_settings.token = None
+    mock_settings.require_basic_or_token = Mock()
+    with patch("vds_jira_orchestrator.cli.JiraSettings") as mock_class:
+        mock_class.return_value = mock_settings
+        yield mock_class
+
+
+@pytest.fixture
+def mock_adapter_class() -> MagicMock:
+    """Mock JiraAdapter for CLI tests."""
+    with patch("vds_jira_orchestrator.cli.JiraAdapter") as mock_class:
+        yield mock_class
+
+
+# ---------------------------------------------------------------------------
+# Adapter method tests
+# ---------------------------------------------------------------------------
+
+
+def test_issue_archive_calls_client(mock_adapter: JiraAdapter) -> None:
+    """Test that issue_archive calls the SDK client."""
+    mock_adapter._client.issue_archive.return_value = None
+    mock_adapter.issue_archive("PROJ-1")
+    mock_adapter._client.issue_archive.assert_called_once_with("PROJ-1")
+
+
+def test_issue_archive_handles_error(mock_adapter: JiraAdapter) -> None:
+    """Test that issue_archive handles errors from the SDK client."""
+    mock_adapter._client.issue_archive.side_effect = Exception("API Error")
+    with pytest.raises(JiraAdapterError, match="API Error"):
+        mock_adapter.issue_archive("PROJ-1")
+
+
+def test_issue_restore_calls_client(mock_adapter: JiraAdapter) -> None:
+    """Test that issue_restore calls the SDK client."""
+    mock_adapter._client.issue_restore.return_value = None
+    mock_adapter.issue_restore("PROJ-1")
+    mock_adapter._client.issue_restore.assert_called_once_with("PROJ-1")
+
+
+def test_issue_restore_handles_error(mock_adapter: JiraAdapter) -> None:
+    """Test that issue_restore handles errors from the SDK client."""
+    mock_adapter._client.issue_restore.side_effect = Exception("API Error")
+    with pytest.raises(JiraAdapterError, match="API Error"):
+        mock_adapter.issue_restore("PROJ-1")
+
+
+# ---------------------------------------------------------------------------
+# CLI command tests
+# ---------------------------------------------------------------------------
+
+
+def test_issue_archive_success(runner: CliRunner, mock_settings_class: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test successful issue archive."""
+    mock_adapter = MagicMock()
+    mock_adapter_class.return_value = mock_adapter
+    mock_adapter.issue_archive.return_value = None
+
+    result = runner.invoke(app, ["issue-archive", "--issue-key", "PROJ-1", "--yes"])
+    assert result.exit_code == 0
+    assert "archived" in result.stdout
+    assert "PROJ-1" in result.stdout
+    mock_adapter.issue_archive.assert_called_once_with("PROJ-1")
+
+
+def test_issue_archive_requires_yes(runner: CliRunner, mock_settings_class: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test issue archive requires --yes flag."""
+    result = runner.invoke(app, ["issue-archive", "--issue-key", "PROJ-1"])
+    assert result.exit_code != 0
+    assert "Refusing to archive issue without --yes" in result.stderr
+    mock_adapter_class.return_value.issue_archive.assert_not_called()
+
+
+def test_issue_archive_requires_issue_key(runner: CliRunner, mock_settings_class: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test issue archive requires --issue-key."""
+    result = runner.invoke(app, ["issue-archive", "--yes"])
+    assert result.exit_code != 0
+    # Typer will show error about missing required option
+    mock_adapter_class.return_value.issue_archive.assert_not_called()
+
+
+def test_issue_restore_success(runner: CliRunner, mock_settings_class: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test successful issue restore."""
+    mock_adapter = MagicMock()
+    mock_adapter_class.return_value = mock_adapter
+    mock_adapter.issue_restore.return_value = None
+
+    result = runner.invoke(app, ["issue-restore", "--issue-key", "PROJ-1", "--yes"])
+    assert result.exit_code == 0
+    assert "restored" in result.stdout
+    assert "PROJ-1" in result.stdout
+    mock_adapter.issue_restore.assert_called_once_with("PROJ-1")
+
+
+def test_issue_restore_requires_yes(runner: CliRunner, mock_settings_class: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test issue restore requires --yes flag."""
+    result = runner.invoke(app, ["issue-restore", "--issue-key", "PROJ-1"])
+    assert result.exit_code != 0
+    assert "Refusing to restore issue without --yes" in result.stderr
+    mock_adapter_class.return_value.issue_restore.assert_not_called()
+
+
+def test_issue_restore_requires_issue_key(runner: CliRunner, mock_settings_class: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test issue restore requires --issue-key."""
+    result = runner.invoke(app, ["issue-restore", "--yes"])
+    assert result.exit_code != 0
+    # Typer will show error about missing required option
+    mock_adapter_class.return_value.issue_restore.assert_not_called()
+
+
+def test_issue_archive_cli_handles_error(runner: CliRunner, mock_settings_class: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test issue archive CLI handles adapter errors."""
+    mock_adapter = MagicMock()
+    mock_adapter_class.return_value = mock_adapter
+    mock_adapter.issue_archive.side_effect = JiraAdapterError("Issue not found")
+
+    result = runner.invoke(app, ["issue-archive", "--issue-key", "PROJ-999", "--yes"])
+    assert result.exit_code != 0
+    assert "Issue not found" in result.stderr
+
+
+def test_issue_restore_cli_handles_error(runner: CliRunner, mock_settings_class: MagicMock, mock_adapter_class: MagicMock) -> None:
+    """Test issue restore CLI handles adapter errors."""
+    mock_adapter = MagicMock()
+    mock_adapter_class.return_value = mock_adapter
+    mock_adapter.issue_restore.side_effect = JiraAdapterError("Issue not found")
+
+    result = runner.invoke(app, ["issue-restore", "--issue-key", "PROJ-999", "--yes"])
+    assert result.exit_code != 0
+    assert "Issue not found" in result.stderr
+