@ngockhoale/ukit 2.6.2 → 2.6.4

package/templates/.omp/hooks/pre/ukit-bridge.js

@@ -394,12 +394,16 @@ function sweepHookErrorsDir(dir, {
     return { scanned: 0, removed: 0 };
   }
   const cutoff = now() - maxAgeMs;
+  // BUG-C22-13: eligible count comes from the full name listing (bounded by the
+  // single readdir, no per-name stat) so the count cap is enforceable even
+  // though maxFiles > maxEntries — capping `scanned` first made
+  // `entries.length` an under-count and `overflow` was always 0.
+  const eligibleNames = names.filter((name) => name.endsWith('.jsonl'));
   const entries = [];
   let scanned = 0;
-  for (const name of names) {
+  for (const name of eligibleNames) {
     if (scanned >= maxEntries) break;
     scanned += 1;
-    if (!name.endsWith('.jsonl')) continue;
     try {
       const stats = fs.statSync(path.join(dir, name));
       if (stats.isFile()) entries.push({ name, mtimeMs: stats.mtimeMs });
@@ -409,7 +413,7 @@ function sweepHookErrorsDir(dir, {
   // Overflow counts eligible FILES only — foreign entries (non-matching names,
   // dirs) inflate `names.length` and would evict real entries while the dir is
   // actually under the cap.
-  const overflow = Math.max(0, entries.length - maxFiles);
+  const overflow = Math.max(0, eligibleNames.length - maxFiles);
   let removed = 0;
   for (const entry of entries) {
     if (removed >= maxRemovals) break;
@@ -820,6 +824,42 @@ export async function runSessionCompact(pi, event, { projectRoot, context: exten
   return undefined;
 }
 
+// ── BUG-C22-05 crash-streak breaker (parity with .claude/hooks/completion-gate.sh) ──
+// A persistently crashing completion evaluator must not fail every Stop forever.
+// The byte-append file is shared with the shell hook so one streak tracks both
+// harnesses; a clean evaluation deletes it, so the count is consecutive crashes.
+const COMPLETION_CRASH_STREAK_FILE = path.join('.ukit', 'storage', 'cache', 'completion-gate-crash.streak');
+
+async function bumpCompletionCrashStreak(projectRoot) {
+  const file = path.join(projectRoot, COMPLETION_CRASH_STREAK_FILE);
+  try {
+    await fs.promises.mkdir(path.dirname(file), { recursive: true });
+    await fs.promises.appendFile(file, '.');
+    const buf = await fs.promises.readFile(file);
+    return buf.length || 1;
+  } catch {
+    return 1;
+  }
+}
+
+async function resetCompletionCrashStreak(projectRoot) {
+  try {
+    await fs.promises.rm(path.join(projectRoot, COMPLETION_CRASH_STREAK_FILE), { force: true });
+  } catch { /* best effort */ }
+}
+
+async function readStopGateMaxCrashStreaks(projectRoot) {
+  try {
+    const parsed = JSON.parse(
+      await fs.promises.readFile(path.join(projectRoot, '.ukit', 'storage', 'config.json'), 'utf8'),
+    );
+    const value = parsed?.handoff?.fullstack?.stopGateMaxCrashStreaks;
+    return Number.isFinite(value) ? Math.max(1, value) : 3;
+  } catch {
+    return 3;
+  }
+}
+
 export async function runSessionStop(
   pi,
   event,
@@ -834,7 +874,35 @@ export async function runSessionStop(
   const payload = buildHookPayload('Stop', metadata);
   const state = suppliedState ?? await readRouteState(projectRoot, payload);
   const ledger = suppliedLedger ?? await readExecutionLedger(projectRoot, payload) ?? {};
-  const evaluation = evaluateCompletion({ state, ledger });
+  let evaluation;
+  try {
+    evaluation = evaluateCompletion({ state, ledger });
+  } catch (error) {
+    // BUG-C22-05: fail-closed like the shell gate (continue the turn), but only up
+    // to the configured consecutive-crash cap — a persistently broken evaluator
+    // must release loudly instead of looping every Stop forever.
+    const streak = await bumpCompletionCrashStreak(projectRoot);
+    const maxStreak = await readStopGateMaxCrashStreaks(projectRoot);
+    if (streak > maxStreak) {
+      await resetCompletionCrashStreak(projectRoot);
+      sendContext(pi, [
+        `[UKit] stop coordinator released this stop after ${maxStreak} consecutive infrastructure failures `
+        + '(the completion evaluator crashed every Stop — gate fail-closed cap reached). '
+        + 'The completion gate is DOWN, not your work: run `ukit install` to repair, '
+        + 'then re-send the task in a new message if the run must continue.',
+      ], 'nextTurn', { display: true });
+      return undefined;
+    }
+    pi.logger?.warn?.(`[UKit] completion evaluator crashed (streak ${streak}/${maxStreak}): ${error?.message || error}`);
+    return {
+      continue: true,
+      additionalContext:
+        `UKit stop coordinator: infrastructure failure while evaluating this stop (crash streak ${streak}/${maxStreak}) — `
+        + 'the stop is blocked fail-closed (details withheld). Run: ukit install, then re-send the task in a new message.',
+    };
+  }
+  // A clean evaluation resets the consecutive-crash streak (shared with the shell hook).
+  await resetCompletionCrashStreak(projectRoot);
   if (!evaluation.continue) {
     if (evaluation.capped) pi.logger?.warn?.(`[UKit] ${evaluation.reason}`);
     const missingEvidence = Array.isArray(evaluation.missingEvidence) ? evaluation.missingEvidence : [];

package/templates/ukit/storage/config.json

@@ -273,6 +273,7 @@
     "fullstack": {
       "stopGateEnabled": true,
       "stopGateMaxStalledBlocks": 12,
+      "stopGateMaxCrashStreaks": 3,
       "quietScansRequired": 2,
       "idleWatchdogMin": 5,
       "autoArchive": true,
@@ -580,6 +581,7 @@
       "fullstack": {
         "stopGateEnabled": "Bật Stop gate handoff: RUN.md Phase != done/blocked → Stop hook từ chối stop kèm Next step, giữ handoff-fullstack chạy tiếp thay vì đứng sau recap. Tắt chỉ khi debug.",
         "stopGateMaxStalledBlocks": "Liveness breaker: cursor không nhích qua N lần block liên tiếp thì gate thả stop (tránh vòng lặp vô tận). Mặc định 12.",
+        "stopGateMaxCrashStreaks": "Liveness breaker cho coordinator crash: sau N lần block liên tiếp do infrastructure failure, gate thả stop kèm cảnh báo lớn. Mặc định 3.",
         "quietScansRequired": "Số scan liên tiếp không thấy việc mới trước khi handoff-fullstack được phép đóng run. Mặc định 2.",
         "idleWatchdogMin": "Khoảng phút cho scheduled wakeup nếu harness hỗ trợ (cron/loop). Mặc định 5.",
         "autoArchive": "true = Phase F tự archive cycle vào docs/AI_HANDOFF/archive/cycle-NN/ khi hoàn tất.",