@ngockhoale/ukit 2.6.0 → 2.6.3

package/templates/.claude/hooks/pre-edit-backup.sh

@@ -11,7 +11,15 @@ if source "$SCRIPT_DIR/../ukit/runtime/hook-input.sh" 2>/dev/null; then
 source "$SCRIPT_DIR/../ukit/runtime/hook-telemetry.sh" 2>/dev/null || true
   trap ukit_cleanup_hook_input EXIT
   # Bounded stdin (H01): stage before anything reads it; the shell var is capped.
-  ukit_stage_hook_input 2097152 truncate || exit 0
+  ukit_stage_hook_input 2097152 truncate
+  __ukit_main_stage_rc=$?
+  if [ "$__ukit_main_stage_rc" -ne 0 ]; then
+    # Infra failure during staging (mktemp/truncate): payload was never
+    # inspected — announce the degrade (SPEC §8), never a silent pass.
+    ukit_emit_input_degraded advisory "pre-edit-backup"
+  fi
+# BUG-C21-01: a truncated/stalled staged payload must be announced (SPEC §8), never silently passed.
+ukit_input_degraded && ukit_emit_input_degraded advisory "pre-edit-backup"
 else
   # Runtime helper missing (pre-install tree): the SAME bounded staging,
   # inline - `cat >/dev/null` used to block forever on a producer that never
@@ -38,10 +46,14 @@ else
   wait "$__ukit_waiter" 2>/dev/null
   exec 8<&-
   __ukit_size="$(wc -c < "$UKIT_INPUT_FILE" 2>/dev/null | tr -d '[:space:]')"
-  # A bounded cut (rc != 0) leaves a short payload that the JSON consumer
-  # already degrades on - the shared helper's truncate posture (R4.5).
-  if [ "$__ukit_size" -gt 2097152 ]; then
-    truncate -s 2097152 "$UKIT_INPUT_FILE" 2>/dev/null
+  if [ "$__ukit_stage_rc" -ne 0 ] || [ "$__ukit_size" -gt 2097152 ]; then
+    # BUG-C21-01 fallback parity (SPEC §8): a truncated/stalled staged payload
+    # must be announced, never silently acted on — same shape as the helper
+    # path's ukit_emit_input_degraded.
+    rm -f "$UKIT_INPUT_FILE"
+    UKIT_INPUT_FILE=""
+    printf '%s\n' '{"systemMessage":"UKit pre-edit-backup: tool-call payload was truncated or stalled during stdin staging; skipped this pass rather than act on incomplete input."}'
+    exit 0
   fi
   trap '[ -n "$UKIT_INPUT_FILE" ] && rm -f "$UKIT_INPUT_FILE"' EXIT
 fi

package/templates/.claude/hooks/project-important.sh

@@ -15,7 +15,15 @@ source "$SCRIPT_DIR/../ukit/runtime/hook-telemetry.sh" 2>/dev/null || true
   # Bounded stdin (H01): the SessionStart payload is unused, but it still flows
   # through the staging bound so a producer that never closes the pipe cannot
   # hold this hook open (R4.5).
-  ukit_stage_hook_input 1048576 truncate || exit 0
+  ukit_stage_hook_input 1048576 truncate
+  __ukit_main_stage_rc=$?
+  if [ "$__ukit_main_stage_rc" -ne 0 ]; then
+    # Infra failure during staging (mktemp/truncate): payload was never
+    # inspected — announce the degrade (SPEC §8), never a silent pass.
+    ukit_emit_input_degraded advisory "project-important"
+  fi
+# BUG-C21-01: a truncated/stalled staged payload must be announced (SPEC §8), never silently passed.
+ukit_input_degraded && ukit_emit_input_degraded advisory "project-important"
 else
   # Runtime helper missing (pre-install tree): the SAME bounded staging,
   # inline — read cap+1 in the background, bound the wait, never drain with an
@@ -37,9 +45,18 @@ else
   ( sleep "$__ukit_stage_s" 2>/dev/null; kill -9 "$__ukit_reader" 2>/dev/null ) <&- >/dev/null 2>&1 &
   __ukit_waiter=$!
   wait "$__ukit_reader" 2>/dev/null
+  __ukit_stage_rc=$?
   kill "$__ukit_waiter" 2>/dev/null
   wait "$__ukit_waiter" 2>/dev/null
   exec 8<&-
+  if [ "$__ukit_stage_rc" -ne 0 ]; then
+    # BUG-C21-01 fallback parity (SPEC §8): a stalled SessionStart payload is
+    # announced, never silently swallowed.
+    rm -f "$UKIT_INPUT_FILE"
+    UKIT_INPUT_FILE=""
+    printf '%s\n' '{"systemMessage":"UKit project-important: session payload stalled during stdin staging; skipped this pass rather than act on incomplete input."}'
+    exit 0
+  fi
   trap '[ -n "$UKIT_INPUT_FILE" ] && rm -f "$UKIT_INPUT_FILE"' EXIT
 fi
 

package/templates/.claude/hooks/protect-files.sh

@@ -11,7 +11,15 @@ if source "$SCRIPT_DIR/../ukit/runtime/hook-input.sh" 2>/dev/null; then
 source "$SCRIPT_DIR/../ukit/runtime/hook-telemetry.sh" 2>/dev/null || true
   trap ukit_cleanup_hook_input EXIT
   # Bounded stdin (H01): stage before anything reads it; the shell var is capped.
-  ukit_stage_hook_input 2097152 truncate || exit 0
+  ukit_stage_hook_input 2097152 truncate
+  __ukit_main_stage_rc=$?
+  if [ "$__ukit_main_stage_rc" -ne 0 ]; then
+    # Infra failure during staging (mktemp/truncate): payload was never
+    # inspected — announce the degrade (SPEC §8), never a silent pass.
+    ukit_emit_input_degraded failclosed "protected-file gate"
+  fi
+# BUG-C21-01: a truncated/stalled staged payload must be announced (SPEC §8), never silently passed.
+ukit_input_degraded && ukit_emit_input_degraded failclosed "protected-file gate"
 else
   # Runtime helper missing (pre-install tree): the SAME bounded staging,
   # inline - `cat >/dev/null` used to block forever on a producer that never
@@ -38,10 +46,15 @@ else
   wait "$__ukit_waiter" 2>/dev/null
   exec 8<&-
   __ukit_size="$(wc -c < "$UKIT_INPUT_FILE" 2>/dev/null | tr -d '[:space:]')"
-  # A bounded cut (rc != 0) leaves a short payload that the JSON consumer
-  # already degrades on - the shared helper's truncate posture (R4.5).
-  if [ "$__ukit_size" -gt 2097152 ]; then
-    truncate -s 2097152 "$UKIT_INPUT_FILE" 2>/dev/null
+  if [ "$__ukit_stage_rc" -ne 0 ] || [ "$__ukit_size" -gt 2097152 ]; then
+    # BUG-C21-01 fallback parity (SPEC §8): a truncated/stalled staged payload
+    # must be announced, never silently acted on — same shape as the helper
+    # path's ukit_emit_input_degraded.
+    rm -f "$UKIT_INPUT_FILE"
+    UKIT_INPUT_FILE=""
+    printf '%s\n' '{"hookSpecificOutput":{"hookEventName":"PreToolUse","permissionDecision":"ask","permissionDecisionReason":"UKit could not fully read this tool-call payload (stdin staging was cut at the deadline/size bound), so protected-file gate cannot prove it safe. UKit defers this to a human decision."}}'
+    echo "BLOCKED: protected-file gate could not inspect a truncated/stalled payload; deferred to human." >&2
+    exit 2
   fi
   trap '[ -n "$UKIT_INPUT_FILE" ] && rm -f "$UKIT_INPUT_FILE"' EXIT
 fi

package/templates/.claude/hooks/record-execution.sh

@@ -12,7 +12,15 @@ source "$SCRIPT_DIR/../ukit/runtime/hook-telemetry.sh" 2>/dev/null || true
   trap ukit_cleanup_hook_input EXIT
   # Bounded stdin (H01): receipts can legitimately be large, so the staged file
   # is the transport and the shell var only mirrors the capped payload.
-  ukit_stage_hook_input 33554432 temp-file || exit 0
+  ukit_stage_hook_input 33554432 temp-file
+  __ukit_main_stage_rc=$?
+  if [ "$__ukit_main_stage_rc" -ne 0 ]; then
+    # Infra failure during staging (mktemp/truncate): payload was never
+    # inspected — announce the degrade (SPEC §8), never a silent pass.
+    ukit_emit_input_degraded advisory "record-execution"
+  fi
+# BUG-C21-01: a truncated/stalled staged payload must be announced (SPEC §8), never silently passed.
+ukit_input_degraded && ukit_emit_input_degraded advisory "record-execution"
 else
   # Runtime helper missing (pre-install tree): the SAME bounded staging,
   # inline - `cat >/dev/null` used to block forever on a producer that never
@@ -39,10 +47,14 @@ else
   wait "$__ukit_waiter" 2>/dev/null
   exec 8<&-
   __ukit_size="$(wc -c < "$UKIT_INPUT_FILE" 2>/dev/null | tr -d '[:space:]')"
-  # A bounded cut (rc != 0) leaves a short payload that the JSON consumer
-  # already degrades on - the shared helper's truncate posture (R4.5).
-  if [ "$__ukit_size" -gt 33554432 ]; then
-    truncate -s 33554432 "$UKIT_INPUT_FILE" 2>/dev/null
+  if [ "$__ukit_stage_rc" -ne 0 ] || [ "$__ukit_size" -gt 33554432 ]; then
+    # BUG-C21-01 fallback parity (SPEC §8): a truncated/stalled staged payload
+    # must be announced, never silently acted on — same shape as the helper
+    # path's ukit_emit_input_degraded.
+    rm -f "$UKIT_INPUT_FILE"
+    UKIT_INPUT_FILE=""
+    printf '%s\n' '{"systemMessage":"UKit record-execution: tool-call payload was truncated or stalled during stdin staging; skipped this pass rather than act on incomplete input."}'
+    exit 0
   fi
   trap '[ -n "$UKIT_INPUT_FILE" ] && rm -f "$UKIT_INPUT_FILE"' EXIT
 fi

package/templates/.claude/hooks/sensitive-data-guard.sh

@@ -43,7 +43,13 @@ source "$SCRIPT_DIR/../ukit/runtime/hook-telemetry.sh" 2>/dev/null || true
   ukit_stage_hook_input 2097152 refuse
   STAGE_RC=$?
   if [ "$STAGE_RC" -ne 0 ]; then
-    exit "$STAGE_RC"
+    # BUG-C21-02: a fail-closed refusal must never be a SILENT block — emit the
+    # §8 reason (labels only, no payload bytes) so the user sees why it stopped.
+    # Any non-zero rc is fail-closed: rc=1 is a staging infra failure and a bare
+    # exit 1 is a *non-blocking* hook error that would let unscanned input pass.
+    printf '%s\n' '{"systemMessage":"UKit sensitive-data gate blocked this call: the payload could not be staged within bounds (oversized or stalled stdin), so it was never scanned. Fail-closed — reduce the payload or check for a stalled producer."}'
+    echo 'BLOCKED (sensitive data gate): payload could not be staged within bounds; never scanned (fail-closed).' >&2
+    exit 2
   fi
 else
   # Runtime helper missing (pre-install tree): the SAME bounded staging,
@@ -73,8 +79,12 @@ else
   __ukit_size="$(wc -c < "$UKIT_INPUT_FILE" 2>/dev/null | tr -d '[:space:]')"
   if [ "$__ukit_stage_rc" -ne 0 ] || [ "$__ukit_size" -gt 2097152 ]; then
     # Fail-closed: an unstaged/oversized payload was never inspected
-    # (exit 2 blocks; 1 would be a non-blocking hook error).
+    # (exit 2 blocks; 1 would be a non-blocking hook error). BUG-C21-02: the
+    # refusal announces its §8 reason — a silent block is indistinguishable
+    # from a stall in the UI.
     rm -f "$UKIT_INPUT_FILE"
+    printf '%s\n' '{"systemMessage":"UKit sensitive-data gate blocked this call: the payload could not be staged within bounds (oversized or stalled stdin), so it was never scanned. Fail-closed — reduce the payload or check for a stalled producer."}'
+    echo 'BLOCKED (sensitive data gate): payload could not be staged within bounds; never scanned (fail-closed).' >&2
     exit 2
   fi
   trap '[ -n "$UKIT_INPUT_FILE" ] && rm -f "$UKIT_INPUT_FILE"' EXIT
@@ -82,13 +92,32 @@ fi
 
 INPUT_FILE="$UKIT_INPUT_FILE" PROJECT_ROOT="$PROJECT_ROOT" SCRIPT_PATH="$SCRIPT_PATH" UKIT_HOOK_DEADLINE_MS="${UKIT_HOOK_DEADLINE_MS:-3000}" node <<'NODE'
 const HOOK_DEADLINE_MS = Number.parseInt(process.env.UKIT_HOOK_DEADLINE_MS || '', 10) || 3000;
-setTimeout(() => process.exit(0), HOOK_DEADLINE_MS).unref();
+// BUG-C21-03 (chosen posture: FAIL-CLOSED, parity with the staging refusal):
+// a wedged scan must never pass an uninspected payload. The deadline emits a
+// redacted §8 degrade reason and exits 2 — never a silent exit-0 pass.
+setTimeout(() => {
+  try {
+    process.stdout.write(`${JSON.stringify({
+      systemMessage: 'UKit sensitive-data gate timed out before finishing its scan; blocked fail-closed rather than pass an uninspected payload.',
+    })}\n`);
+  } catch {}
+  try {
+    // stderr mirror: piped stdout is async and process.exit() can truncate the
+    // pending write — without this the block can arrive with no visible reason.
+    process.stderr.write('BLOCKED (sensitive data gate): scan timed out; blocked fail-closed rather than pass an uninspected payload.\n');
+  } catch {}
+  process.exit(2);
+}, HOOK_DEADLINE_MS).unref();
 const fs = require('fs');
+const fsp = fs.promises;
 const path = require('path');
 const { createHash } = require('crypto');
 
+// BUG-C21-04: every fs call below is async — a sync read on a stalled mount
+// parks the event loop and the deadline above could never fire.
+void (async () => {
 let rawInput = '';
-try { rawInput = fs.readFileSync(process.env.INPUT_FILE || '', 'utf8'); } catch {}
+try { rawInput = await fsp.readFile(process.env.INPUT_FILE || '', 'utf8'); } catch {}
 const payload = (() => {
   try {
     const parsed = JSON.parse(rawInput);
@@ -100,20 +129,20 @@ const payload = (() => {
 
 const projectRoot = process.env.PROJECT_ROOT || process.cwd();
 
-function readJsonSafe(filePath, fallback) {
+async function readJsonSafe(filePath, fallback) {
   try {
-    return JSON.parse(fs.readFileSync(filePath, 'utf8'));
+    return JSON.parse(await fsp.readFile(filePath, 'utf8'));
   } catch {
     return fallback;
   }
 }
 
-const config = readJsonSafe(path.join(projectRoot, '.ukit', 'storage', 'config.json'), null);
+const config = await readJsonSafe(path.join(projectRoot, '.ukit', 'storage', 'config.json'), null);
 if (config && config.security && config.security.sensitiveDataGate === false) {
   process.exit(0);
 }
 
-const allowlist = readJsonSafe(path.join(projectRoot, '.ukit', 'storage', 'security', 'allowlist.json'), null) || {};
+const allowlist = (await readJsonSafe(path.join(projectRoot, '.ukit', 'storage', 'security', 'allowlist.json'), null)) || {};
 const allowedValueHashes = new Set(
   Array.isArray(allowlist.values) ? allowlist.values.filter((v) => typeof v === 'string') : [],
 );
@@ -395,6 +424,16 @@ process.stdout.write(`${JSON.stringify({
 })}\n`);
 process.exit(2);
 })();
+})();
 NODE
 
-exit $?
+NODE_RC=$?
+# BUG-C21-03: a node crash (any non-blocking non-zero exit) means the payload
+# was never fully scanned — fail-closed parity: announce + block, never a
+# silent non-blocking hook error.
+if [ "$NODE_RC" -ne 0 ] && [ "$NODE_RC" -ne 2 ]; then
+  printf '%s\n' '{"systemMessage":"UKit sensitive-data gate crashed before finishing its scan; blocked fail-closed rather than pass an uninspected payload. Run `ukit install` if this repeats."}'
+  echo "BLOCKED (sensitive data gate): scanner process exited $NODE_RC; payload never inspected (fail-closed)." >&2
+  exit 2
+fi
+exit "$NODE_RC"