@ngockhoale/ukit 2.4.2 → 2.4.3

package/templates/.claude/hooks/vision-router.sh

@@ -22,16 +22,42 @@
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # shellcheck source=/dev/null
 if source "$SCRIPT_DIR/../ukit/runtime/hook-input.sh" 2>/dev/null; then
+# TASK-019: arm advisory latency telemetry; the finish row is written by the
+# shared cleanup path before the staged payload is removed. A missing
+# runtime (pre-install tree) simply leaves telemetry off.
+source "$SCRIPT_DIR/../ukit/runtime/hook-telemetry.sh" 2>/dev/null || true
   trap ukit_cleanup_hook_input EXIT
   # Bounded stdin (H01): stage before anything reads it; Node gets a path, never the payload.
   ukit_stage_hook_input 2097152 truncate || exit 0
 else
-  # Runtime helper missing (pre-install tree): bounded inline staging keeps the
-  # advisory/fail-open behavior below alive with a capped payload file.
+  # Runtime helper missing (pre-install tree): the SAME bounded staging,
+  # inline - `cat >/dev/null` used to block forever on a producer that never
+  # closes the pipe (R4.5). Read cap+1 in the background, bound the wait.
   UKIT_INPUT_FILE="$(mktemp "${TMPDIR:-/tmp}/ukit-hook-in.XXXXXX")"
-  head -c 2097153 > "$UKIT_INPUT_FILE" 2>/dev/null
-  cat >/dev/null 2>&1
-  if [ "$(wc -c < "$UKIT_INPUT_FILE" | tr -d '[:space:]')" -gt 2097152 ]; then
+  if [ -e /dev/fd/0 ]; then
+    exec 8<&0
+    head -c 2097153 <&8 > "$UKIT_INPUT_FILE" 2>/dev/null &
+  else
+    head -c 2097153 > "$UKIT_INPUT_FILE" 2>/dev/null &
+  fi
+  __ukit_reader=$!
+  __ukit_stage_ms="${UKIT_HOOK_STAGE_MS:-2000}"
+  case "$__ukit_stage_ms" in
+    ''|*[!0-9]*) __ukit_stage_ms=2000 ;;
+  esac
+  [ "$__ukit_stage_ms" -gt 0 ] 2>/dev/null || __ukit_stage_ms=2000
+  printf -v __ukit_stage_s '%d.%03d' $((__ukit_stage_ms / 1000)) $((__ukit_stage_ms % 1000))
+  ( sleep "$__ukit_stage_s" 2>/dev/null; kill -9 "$__ukit_reader" 2>/dev/null ) <&- >/dev/null 2>&1 &
+  __ukit_waiter=$!
+  wait "$__ukit_reader" 2>/dev/null
+  __ukit_stage_rc=$?
+  kill "$__ukit_waiter" 2>/dev/null
+  wait "$__ukit_waiter" 2>/dev/null
+  exec 8<&-
+  __ukit_size="$(wc -c < "$UKIT_INPUT_FILE" 2>/dev/null | tr -d '[:space:]')"
+  # A bounded cut (rc != 0) leaves a short payload that the JSON consumer
+  # already degrades on - the shared helper's truncate posture (R4.5).
+  if [ "$__ukit_size" -gt 2097152 ]; then
     truncate -s 2097152 "$UKIT_INPUT_FILE" 2>/dev/null
   fi
   trap '[ -n "$UKIT_INPUT_FILE" ] && rm -f "$UKIT_INPUT_FILE"' EXIT
@@ -41,7 +67,7 @@ PROJECT_ROOT="${CLAUDE_PROJECT_DIR:-$PWD}"
 INPUT_FILE="$UKIT_INPUT_FILE" PROJECT_ROOT="$PROJECT_ROOT" node <<'NODE' || true
 const HOOK_DEADLINE_MS = Number.parseInt(process.env.UKIT_HOOK_DEADLINE_MS || '', 10) || 8000;
 setTimeout(() => process.exit(0), HOOK_DEADLINE_MS).unref();
-const fs = require('fs');
+const fs = require('fs').promises;
 const path = require('path');
 const { spawn } = require('child_process');
 const { pathToFileURL } = require('url');
@@ -59,9 +85,15 @@ process.on('exit', () => {
   }
 });
 
-let rawInput = '';
-try { rawInput = fs.readFileSync(process.env.INPUT_FILE || '', 'utf8'); } catch {}
+// TASK-015 fix round 1: every hot-path fs call is awaited. A synchronous read
+// parks the event loop for the whole syscall, so the unref'd self-deadline above
+// could never fire while a project filesystem stalled.
+async function readTextSafe(filePath) {
+  try { return await fs.readFile(filePath, 'utf8'); } catch { return ''; }
+}
+
 (async () => {
+  const rawInput = await readTextSafe(process.env.INPUT_FILE || '');
   const payload = (() => {
     try {
       const parsed = JSON.parse(rawInput);
@@ -86,7 +118,7 @@ try { rawInput = fs.readFileSync(process.env.INPUT_FILE || '', 'utf8'); } catch
   async function detectUnicModeSafe() {
     try {
       const gatewayPath = path.join(projectRoot, '.claude', 'ukit', 'index', 'unic-gateway.mjs');
-      if (!fs.existsSync(gatewayPath)) return null;
+      try { await fs.access(gatewayPath); } catch { return null; }
       const mod = await import(pathToFileURL(gatewayPath).href);
       if (typeof mod.detectUnicGateway !== 'function') return null;
       return !!mod.detectUnicGateway({ rootDir: projectRoot })?.unicMode;
@@ -135,7 +167,7 @@ try { rawInput = fs.readFileSync(process.env.INPUT_FILE || '', 'utf8'); } catch
   // pair) and silently skips it. Kept here as a small inline copy rather than
   // a cross-file import — the contract is a few lines, the cost of drift is
   // small, and the hook must stay self-contained (no module resolution).
-  function stripPathNoise(raw) {
+  async function stripPathNoise(raw) {
     const value = String(raw ?? '').trim();
     if (!value) return value;
     const pairs = { '(': ')', '[': ']', '{': '}', '"': '"', "'": "'" };
@@ -168,7 +200,8 @@ try { rawInput = fs.readFileSync(process.env.INPUT_FILE || '', 'utf8'); } catch
     for (const c of candidates) {
       if (!c) continue;
       try {
-        if (fs.existsSync(path.resolve(c))) return c;
+        await fs.access(path.resolve(c));
+        return c;
       } catch {
         // ignore
       }
@@ -236,7 +269,8 @@ try { rawInput = fs.readFileSync(process.env.INPUT_FILE || '', 'utf8'); } catch
   // string inside the extractor.
   let extractorJson = null;
   const extractorPath = path.join(projectRoot, '.claude', 'ukit', 'index', 'extract-image.mjs');
-  if (fs.existsSync(extractorPath)) {
+  try {
+    await fs.access(extractorPath);
     const args = [extractorPath, '--detect', '--mark-pending', '--json'];
     if (typeof payload?.transcript_path === 'string' && payload.transcript_path.trim()) {
       args.push('--session', payload.transcript_path.trim());
@@ -248,7 +282,7 @@ try { rawInput = fs.readFileSync(process.env.INPUT_FILE || '', 'utf8'); } catch
       // Mirror extractor's resolveRefs input contract: the LLM sometimes leaves
       // trailing punctuation/quotes on a path named in a prompt. Clean before
       // handing off so the hook and the extractor agree on the ref string.
-      args.push('--ref', stripPathNoise(ref));
+      args.push('--ref', await stripPathNoise(ref));
     }
     let out = null;
     try {
@@ -260,6 +294,8 @@ try { rawInput = fs.readFileSync(process.env.INPUT_FILE || '', 'utf8'); } catch
       const head = typeof out === 'string' && out ? `; output head: ${out.slice(0, 200)}` : '';
       process.stderr.write(`vision-router: extractor call skipped (${err?.message ?? err})${head}\n`);
     }
+  } catch {
+    // Missing extractor is a normal fail-open condition.
   }
 
   // TASK-006 contract: in --mark-pending --json mode `images[]` is the

package/templates/.claude/settings.json

@@ -208,11 +208,6 @@
             "type": "command",
             "command": "\"$CLAUDE_PROJECT_DIR/.claude/hooks/completion-gate.sh\"",
             "timeout": 4
-          },
-          {
-            "type": "command",
-            "command": "\"$CLAUDE_PROJECT_DIR/.claude/hooks/task-watchdog.sh\"",
-            "timeout": 4
           }
         ]
       }