@ngockhoale/ukit 2.3.4 → 2.3.5

package/CHANGELOG.md

@@ -2,6 +2,33 @@
 
 All notable changes to UKit are documented here.
 
+## 2.3.5 - 2026-09-10
+
+Source-audit hardening release: the code index cannot corrupt itself, and a corrupt runtime
+cache can no longer take down `ukit status` or `ukit memory`.
+
+Index artifacts (`files`, `symbols`, `imports`, `calls`, `tests-map`, `hotspots`,
+`archetypes`, `relations`, `analogs`, `meta`) are now written through same-directory
+`.tmp-<timestamp>-<random>` files followed by an atomic `rename`, in both the source builder
+(`src/index/buildIndex.js`) and the shipped `templates/.claude/ukit/index/lib/index-core.mjs`
+runtime mirror. A build that crashes mid-write — or two builds racing in one repo — can no
+longer leave a half-written artifact that poisons every subsequent index read; failed writes
+clean their temp file up before rethrowing.
+
+`ukit status` and `ukit memory` now read their cache/memory JSON through tolerant readers:
+a corrupt `compact-history.json`, `compact-pressure.json`, `prompt-cache.json`,
+`output-history.json`, or memory file prints a warning naming the exact file path and falls
+back to defaults instead of crashing the whole command mid-report. `readJsonIfExists` itself
+stays strict everywhere else, so genuinely bad callers still fail loudly.
+
+Nested test layouts (`packages/widget/tests/unit/...`) are now recognized as tests by the
+source path classifier and both runtime-mirror predicates — those files previously slipped
+past test detection, broke archetype classification, and never appeared in the test map.
+
+Each fix ships with regression coverage: a rename-spy test asserting all ten artifacts move
+through temp files, corrupt-fixture tests asserting the warned paths and surviving output,
+and a nested-`tests/` mapping/archetype test. Full suite: 77 files, 1,348 tests green.
+
 ## 2.3.4 - 2026-09-10
 
 Silent-stall audit and compact-recovery release. Two themes: every block reports a

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ngockhoale/ukit",
-  "version": "2.3.4",
+  "version": "2.3.5",
   "description": "Install/update an index-first AI workspace for Claude Code, OpenAI Codex, OpenCode, and omp (Oh My Pi).",
   "license": "MIT",
   "type": "module",

package/src/core/memory/store.js

@@ -14,6 +14,15 @@ function defaultUserMemory() {
   };
 }
 
+async function readMemoryJson(filePath) {
+  try {
+    return await readJsonIfExists(filePath);
+  } catch (error) {
+    console.warn(`[UKit] Ignoring corrupt memory JSON file ${filePath}: ${error?.message ?? String(error)}`);
+    return null;
+  }
+}
+
 async function readDirectoryJsonItems(dirPath) {
   let entries = [];
   try {
@@ -29,7 +38,7 @@ async function readDirectoryJsonItems(dirPath) {
     }
 
     const fullPath = path.join(dirPath, entry.name);
-    const content = await readJsonIfExists(fullPath);
+    const content = await readMemoryJson(fullPath);
     if (content) {
       items.push({
         fileName: entry.name,
@@ -91,7 +100,7 @@ function createSearchableText(type, content) {
 
 export async function exportMemory(projectRoot) {
   const runtimePaths = buildRuntimePaths(projectRoot);
-  const user = (await readJsonIfExists(runtimePaths.userMemoryPath)) ?? defaultUserMemory();
+  const user = (await readMemoryJson(runtimePaths.userMemoryPath)) ?? defaultUserMemory();
   const projects = (await readDirectoryJsonItems(runtimePaths.projectsDir)).map((item) => item.content);
   const sessions = (await readDirectoryJsonItems(runtimePaths.sessionsDir)).map((item) => item.content);
 
@@ -100,7 +109,7 @@ export async function exportMemory(projectRoot) {
 
 export async function listMemoryItems(projectRoot) {
   const runtimePaths = buildRuntimePaths(projectRoot);
-  const userMemory = (await readJsonIfExists(runtimePaths.userMemoryPath)) ?? defaultUserMemory();
+  const userMemory = (await readMemoryJson(runtimePaths.userMemoryPath)) ?? defaultUserMemory();
   const projectMemories = await readDirectoryJsonItems(runtimePaths.projectsDir);
   const sessionMemories = await readDirectoryJsonItems(runtimePaths.sessionsDir);
 
@@ -188,7 +197,7 @@ function projectMemoryPath(runtimePaths, projectId) {
 
 async function readProjectMemoryForId(runtimePaths, projectId) {
   const filePath = projectMemoryPath(runtimePaths, projectId);
-  const existing = await readJsonIfExists(filePath);
+  const existing = await readMemoryJson(filePath);
   const memory = {
     id: projectId,
     conventions: [],
@@ -204,7 +213,7 @@ async function appendSessionArchive(runtimePaths, projectId, archivedSessions) {
   }
 
   const archivePath = path.join(runtimePaths.projectsDir, `${sanitizeProjectId(projectId)}.archive.json`);
-  const existing = (await readJsonIfExists(archivePath)) ?? { sessions: [] };
+  const existing = (await readMemoryJson(archivePath)) ?? { sessions: [] };
   const sessions = Array.isArray(existing.sessions) ? existing.sessions : [];
   await writeJson(archivePath, { sessions: [...sessions, ...archivedSessions] });
 }

package/src/core/status.js

@@ -5,7 +5,7 @@ import { loadRuntimeConfig } from './runtimeConfig.js';
 import { summarizeOutputHistory } from './output/index.js';
 import { buildPromptCacheStats } from './token/index.js';
 import { countMemoryItems } from './memory/store.js';
-import { readCompactPressureState } from './compact/threshold.js';
+import { buildCompactPressureState } from './compact/threshold.js';
 import { detectProjectContext } from '../context/detectProjectContext.js';
 
 function formatPrimaryAgent(agentKey) {
@@ -122,6 +122,15 @@ function formatRecoveryLabel(count) {
   return ` / ${count} recover${count === 1 ? 'y' : 'ies'}`;
 }
 
+async function readStatusJson(filePath) {
+  try {
+    return await readJsonIfExists(filePath);
+  } catch (error) {
+    console.warn(`[UKit] Ignoring corrupt status JSON file ${filePath}: ${error?.message ?? String(error)}`);
+    return null;
+  }
+}
+
 export async function buildStatusReport(projectRoot) {
   const runtimePaths = buildRuntimePaths(projectRoot);
   const runtimeExists = await pathExists(runtimePaths.runtimeRoot);
@@ -131,11 +140,14 @@ export async function buildStatusReport(projectRoot) {
 
   const projectContext = await detectProjectContext(projectRoot);
   const config = await loadRuntimeConfig(projectRoot);
-  const compactHistory = normalizeCompactEntries(await readJsonIfExists(runtimePaths.compactHistoryPath));
+  const compactHistory = normalizeCompactEntries(await readStatusJson(runtimePaths.compactHistoryPath));
   const compactSummary = buildCompactSummary(compactHistory);
-  const compactPressure = await readCompactPressureState(projectRoot, config);
-  const promptCacheStats = buildPromptCacheStats(await readJsonIfExists(runtimePaths.promptCachePath));
-  const outputCompressionStats = summarizeOutputHistory(await readJsonIfExists(runtimePaths.outputHistoryPath));
+  const compactPressure = buildCompactPressureState(
+    await readStatusJson(runtimePaths.compactPressurePath),
+    config,
+  );
+  const promptCacheStats = buildPromptCacheStats(await readStatusJson(runtimePaths.promptCachePath));
+  const outputCompressionStats = summarizeOutputHistory(await readStatusJson(runtimePaths.outputHistoryPath));
   const memoryCounts = await countMemoryItems(projectRoot);
   const adapters = await detectAdapterLabels(projectRoot, config.agent);
 

package/src/index/buildIndex.js

@@ -1197,7 +1197,20 @@ function areSourceFingerprintsEqual(previousFingerprint, nextFingerprint) {
 
 async function writeArtifact(rootDir, artifactName, payload) {
   const artifactPath = getArtifactPath(rootDir, artifactName);
-  await fs.writeFile(artifactPath, JSON.stringify(payload, null, 2));
+  const temporaryPath = `${artifactPath}.tmp-${Date.now()}-${Math.random().toString(16).slice(2)}`;
+
+  try {
+    await fs.writeFile(temporaryPath, JSON.stringify(payload, null, 2));
+    await fs.rename(temporaryPath, artifactPath);
+  } catch (error) {
+    try {
+      await fs.rm(temporaryPath, { force: true });
+    } catch {
+      // ignore cleanup errors
+    }
+
+    throw error;
+  }
 }
 
 async function readArtifactIfExists(rootDir, artifactName) {

package/src/index/paths.js

@@ -37,6 +37,7 @@ export function isLikelyTestFilePath(filePath) {
     || lower.startsWith('specs/')
     || lower.includes('/__tests__/')
     || lower.includes('/test/')
+    || lower.includes('/tests/')
     || lower.includes('/spec/')
     || lower.includes('/specs/')
     || lower.endsWith('.test.js')

package/templates/.claude/ukit/index/lib/index-core.mjs

@@ -2028,7 +2028,21 @@ function areBugIndexSnapshotsEqual(previousSnapshot, nextSnapshot) {
 }
 
 async function writeArtifact(rootDir, artifactName, payload) {
-  await fs.writeFile(getArtifactPath(rootDir, artifactName), JSON.stringify(payload, null, 2));
+  const artifactPath = getArtifactPath(rootDir, artifactName);
+  const temporaryPath = `${artifactPath}.tmp-${Date.now()}-${Math.random().toString(16).slice(2)}`;
+
+  try {
+    await fs.writeFile(temporaryPath, JSON.stringify(payload, null, 2));
+    await fs.rename(temporaryPath, artifactPath);
+  } catch (error) {
+    try {
+      await fs.rm(temporaryPath, { force: true });
+    } catch {
+      // ignore cleanup errors
+    }
+
+    throw error;
+  }
 }
 
 async function readArtifact(rootDir, artifactName) {
@@ -2557,6 +2571,7 @@ function isLikelyTestFilePath(filePath) {
     || lower.startsWith('specs/')
     || lower.includes('/__tests__/')
     || lower.includes('/test/')
+    || lower.includes('/tests/')
     || lower.includes('/spec/')
     || lower.includes('/specs/')
     || lower.endsWith('.test.js')
@@ -2988,6 +3003,7 @@ function isLikelyTestFile(filePath) {
     || lower.startsWith('specs/')
     || lower.includes('/__tests__/')
     || lower.includes('/test/')
+    || lower.includes('/tests/')
     || lower.includes('/spec/')
     || lower.includes('/specs/')
     || lower.endsWith('.test.js')