@ngockhoale/ukit 1.4.1 → 1.4.2

package/templates/.claude/ukit/index/route-task.mjs

@@ -138,12 +138,23 @@ async function main() {
     requestKey,
   });
   if (cachedRouteState) {
+    const rescuedRouteSummary = cachedRouteState.routeSummary
+      ? {
+          ...cachedRouteState.routeSummary,
+          continuationState: advanceContinuationState(
+            cachedRouteState.routeSummary.continuationState ?? null,
+            cachedRouteState.routeSummary.continuationState ?? null,
+          ),
+        }
+      : null;
     const sharedState = {
       ...cachedRouteState,
       source: 'task-route',
       ts: Date.now(),
       requestKey,
+      routeSummary: rescuedRouteSummary,
     };
+    sharedState.fingerprint = buildRouteStateFingerprint(sharedState);
     await writeJson(sharedStatePath, sharedState);
     printRouteState(sharedState);
     return;
@@ -166,6 +177,7 @@ async function main() {
     useIndexedContext,
     previousContextSnapshot,
     recentOutputSnapshot,
+    previousRouteSummary: previousState?.routeSummary ?? null,
   });
   await seedHelperCaches({
     rootDir,
@@ -255,6 +267,21 @@ async function prepareTaskRoute({
     selectedIds,
     targetFile: normalizedTarget,
   });
+  const executionScores = deriveExecutionScores({
+    promptText: normalizedPrompt,
+    commandText: normalizedCommand,
+    targetFile: normalizedTarget,
+    intentMode,
+    taskType: inferredTaskType,
+  });
+  const executionMode = deriveExecutionMode({
+    promptText: normalizedPrompt,
+    commandText: normalizedCommand,
+    targetFile: normalizedTarget,
+    intentMode,
+    taskType: inferredTaskType,
+    executionScores,
+  });
   const preservedPrompt = normalizedPrompt || String(lastExplicitUserPromptText || '').trim();
 
   return {
@@ -269,6 +296,8 @@ async function prepareTaskRoute({
       contextIntent,
       taskType: inferredTaskType,
       intentMode,
+      executionScores,
+      executionMode,
     },
   };
 }
@@ -283,6 +312,7 @@ async function finalizeTaskRoute({
   useIndexedContext = true,
   previousContextSnapshot = null,
   recentOutputSnapshot = null,
+  previousRouteSummary = null,
 } = {}) {
   const absoluteRoot = path.resolve(rootDir);
   const activeSkills = preparedRoute?.activeSkills ?? [];
@@ -347,10 +377,16 @@ async function finalizeTaskRoute({
     verificationRecommendation,
     nextAction,
   });
+  routeSummary.continuationState = advanceContinuationState(
+    routeSummary.continuationState,
+    previousRouteSummary?.continuationState ?? null,
+  );
+  const approachSelector = routeSummary?.approachSelector ?? null;
 
   return {
     activeSkills,
     routingContext,
+    approachSelector,
     previousContext: previousContextSnapshot,
     recentOutput: recentOutputSnapshot,
     contextRecommendation,
@@ -445,7 +481,11 @@ function formatDisplayNextAction(routeSummary = null) {
   }
 
   const nextActionType = String(routeSummary.nextActionType ?? '').trim();
-  if (!nextActionType || nextActionType === 'read-skill-instructions') {
+  if (
+    !nextActionType
+    || nextActionType === 'read-skill-instructions'
+    || nextActionType === 'pull-indexed-context'
+  ) {
     return '';
   }
 
@@ -492,6 +532,10 @@ function formatDisplayHelperHint(routeSummary = null, compactSummary = '') {
     return '';
   }
 
+  if (String(routeSummary.nextActionType ?? '').trim() === 'pull-indexed-context') {
+    return '';
+  }
+
   let helperHint = String(routeSummary.helperHint ?? '').trim().replace(/\s+/g, ' ');
   if (!helperHint) {
     return '';
@@ -671,6 +715,10 @@ function shouldKeepRouteEntryForIntent(entry, intentMode) {
     return false;
   }
 
+  if (entry.id === 'code-review' && intentMode === 'implement-specific') {
+    return false;
+  }
+
   return true;
 }
 
@@ -710,6 +758,10 @@ function deriveSkillPriorityBoost(skillId, routeSignals = {}) {
     routeSignals.commandRawText ?? '',
     routeSignals.commandNormalizedText ?? '',
   ].join('\n');
+  const rawPromptSignals = [
+    routeSignals.promptRawText ?? '',
+    routeSignals.commandRawText ?? '',
+  ].join('\n');
 
   if (
     skillId === 'testing-quality'
@@ -718,6 +770,14 @@ function deriveSkillPriorityBoost(skillId, routeSignals = {}) {
     return 1;
   }
 
+  if (
+    skillId === 'code-review'
+    && /\b(implement|build|create|add|ship|deliver|refactor|integrate|integration|scaffold|feature|update|change|modify|inject|apply)\b/.test(rawPromptSignals)
+    && !/\b(review|audit|diff|pr feedback|code review|kiem tra|soat)\b/.test(rawPromptSignals)
+  ) {
+    return -4;
+  }
+
   return 0;
 }
 
@@ -771,10 +831,10 @@ function deriveIntentMode({ promptText = '', commandText = '', targetFile = null
     if (/\b(bug|debug|error|crash|broken|failing|stack trace|triage|fix|login|timeout)\b/.test(lower)) {
       return 'debug-specific';
     }
-    if (/\b(review|audit|diff|pr feedback|code review|kiem tra|soat)\b/.test(lower)) {
+    if (/\b(review|audit|diff|pr feedback|code review|kiem tra|soat)\b/.test(raw)) {
       return 'review-specific';
     }
-    if (/\b(implement|build|create|add|ship|deliver|refactor|integrate|integration|scaffold|feature)\b/.test(lower)) {
+    if (/\b(implement|build|create|add|ship|deliver|refactor|integrate|integration|scaffold|feature|update|change|modify|inject|apply)\b/.test(raw)) {
       return 'implement-specific';
     }
   }
@@ -806,7 +866,7 @@ function hasConcreteTaskSignal(lower, raw, targetFile, { taskQueueNext = false }
     return true;
   }
 
-  return /\b(bug|debug|error|crash|broken|failing|stack trace|triage|fix|implement|build|create|add|ship|deliver|refactor|integrate|integration|scaffold|feature|review|audit|diff|pr feedback|code review|auth|login|api|endpoint|test|spec)\b/.test(lower)
+  return /\b(bug|debug|error|crash|broken|failing|stack trace|triage|fix|implement|build|create|add|ship|deliver|refactor|integrate|integration|scaffold|feature|update|change|modify|inject|apply|review|audit|diff|pr feedback|code review|auth|login|api|endpoint|test|spec)\b/.test(lower)
     || /\b(sửa|fix|lỗi|bug|debug|implement|cài|thêm|review|kiểm tra|soát|đăng nhập)\b/.test(raw);
 }
 
@@ -1225,6 +1285,21 @@ function buildRouteSummary({
   const compactHelperLane = nextAction?.type === 'pull-indexed-context'
     && typeof contextRecommendation?.command === 'string'
     && contextRecommendation.command.trim();
+  const executionMode = routingContext.executionMode ?? null;
+  const executionScores = routingContext.executionScores ?? null;
+  const approachSelector = buildApproachSelectorResult({
+    executionMode,
+    executionScores,
+  });
+  const executionContract = buildExecutionContract(executionMode);
+  const completionState = buildCompletionState({
+    executionMode,
+    verificationRecommendation,
+  });
+  const continuationState = buildContinuationState({
+    nextActionType: nextAction?.type ?? null,
+    completionState,
+  });
   const helperHint = compactHelperHint(
     compactHelperLane
       ? contextRecommendation?.command
@@ -1243,7 +1318,6 @@ function buildRouteSummary({
     editGuardHint ? `editGuard=${editGuardHint}` : null,
     delegationRecommendation?.hint ? `delegate=${delegationRecommendation.hint}` : null,
     policyMode ? `policy=${policyMode}` : null,
-    contextMode ? `mode=${contextMode}` : null,
   ].filter(Boolean).join(' | ');
 
   return {
@@ -1252,6 +1326,12 @@ function buildRouteSummary({
     preferredOrder,
     policyMode,
     editGuardHint,
+    executionMode,
+    executionScores,
+    approachSelector,
+    executionContract,
+    completionState,
+    continuationState,
     intentMode: routingContext.intentMode ?? null,
     delegateHint: delegationRecommendation?.hint ?? null,
     nextActionType: nextAction?.type ?? null,
@@ -1268,6 +1348,375 @@ function deriveContextMode(taskType) {
   return null;
 }
 
+function deriveExecutionScores({
+  promptText = '',
+  commandText = '',
+  targetFile = null,
+  intentMode = null,
+  taskType = null,
+} = {}) {
+  const raw = `${promptText ?? ''}\n${commandText ?? ''}`.toLowerCase();
+  const sharedRisk = isSharedImpactFile(targetFile);
+  const directTransformSignal = /\b(change|replace|set|rename|convert|swap)\b/.test(raw) || /\bchange\s+.+\s+to\s+.+\b/.test(raw);
+  const smallFixSignal = /\b(adjust|tweak|patch|fix|modify|update|apply)\b/.test(raw);
+  const buildSignal = /\b(build|create|add|implement|feature)\b/.test(raw);
+  const debugSignal = intentMode === 'debug-specific' || /\b(root cause|debug|triage|flaky|investigate|why)\b/.test(raw);
+  const reviewSignal = intentMode === 'review-specific' || /\b(review|audit|verify|release readiness)\b/.test(raw);
+
+  let editCertainty = 0;
+  if (directTransformSignal) {
+    editCertainty = 3;
+  } else if (smallFixSignal) {
+    editCertainty = 2;
+  } else if (buildSignal) {
+    editCertainty = 1;
+  }
+
+  let investigationNeed = 0;
+  if (debugSignal) {
+    investigationNeed = 3;
+  } else if (/\b(failing|broken|error|crash|timeout)\b/.test(raw)) {
+    investigationNeed = 2;
+  }
+
+  let blastRadius = 0;
+  if (sharedRisk) {
+    blastRadius = 3;
+  } else if (taskType === 'non-trivial' || taskType === 'shared-simple') {
+    blastRadius = 2;
+  } else if (!targetFile) {
+    blastRadius = 1;
+  }
+
+  let verificationBurden = 1;
+  if (reviewSignal || sharedRisk) {
+    verificationBurden = 3;
+  } else if (debugSignal || taskType === 'non-trivial') {
+    verificationBurden = 2;
+  }
+
+  let ambiguity = 0;
+  if (!targetFile) {
+    ambiguity = 2;
+  } else if (buildSignal && !directTransformSignal && !smallFixSignal) {
+    ambiguity = 1;
+  }
+
+  return {
+    editCertainty,
+    investigationNeed,
+    blastRadius,
+    verificationBurden,
+    ambiguity,
+  };
+}
+
+function deriveExecutionMode({
+  promptText = '',
+  commandText = '',
+  targetFile = null,
+  intentMode = null,
+  executionScores = {},
+} = {}) {
+  const raw = `${promptText ?? ''}\n${commandText ?? ''}`.toLowerCase();
+  const scores = executionScores;
+  const explicitReviewLead = /\b(review this|audit this|review\b.*\brelease readiness|verify\b.*\brelease readiness)\b/.test(raw);
+
+  if (intentMode === 'review-specific' || explicitReviewLead) {
+    return 'review-release';
+  }
+
+  if (scores.blastRadius >= 3 && (scores.ambiguity >= 2 || scores.investigationNeed >= 2)) {
+    return 'map-impact';
+  }
+
+  if (scores.blastRadius >= 3 || isSharedImpactFile(targetFile)) {
+    return 'shared-edit';
+  }
+
+  if (scores.investigationNeed >= 3) {
+    return 'find-cause';
+  }
+
+  if (
+    scores.editCertainty >= 3
+    && scores.ambiguity === 0
+    && scores.blastRadius === 0
+    && scores.verificationBurden <= 1
+  ) {
+    return 'tiny-fix';
+  }
+
+  if (
+    /\b(build|create|add|implement|feature|summary card)\b/.test(raw)
+    && scores.investigationNeed === 0
+    && scores.blastRadius < 3
+  ) {
+    return 'local-build';
+  }
+
+  if (scores.editCertainty >= 2 && scores.investigationNeed === 0 && scores.blastRadius === 0) {
+    return 'local-fix';
+  }
+
+  return 'local-build';
+}
+
+function buildExecutionContract(executionMode = null) {
+  if (!executionMode) {
+    return null;
+  }
+
+  const contracts = {
+    'tiny-fix': {
+      maxReadPasses: 0,
+      maxContextPulls: 0,
+      verificationPolicy: 'minimal-or-targeted',
+      completionRule: 'never-claim-done-without-write',
+      delegationPolicy: 'disallow',
+      completionEvidence: ['write-evidence'],
+    },
+    'local-fix': {
+      maxReadPasses: 1,
+      maxContextPulls: 1,
+      verificationPolicy: 'targeted-if-covered',
+      completionRule: 'require-write',
+      delegationPolicy: 'disallow',
+      completionEvidence: ['write-evidence'],
+    },
+    'local-build': {
+      maxReadPasses: 2,
+      maxContextPulls: 1,
+      verificationPolicy: 'targeted-if-covered',
+      completionRule: 'require-write',
+      delegationPolicy: 'disallow-by-default',
+      completionEvidence: ['write-evidence'],
+    },
+    'find-cause': {
+      maxReadPassesBeforeReassess: 3,
+      verificationPolicy: 'root-cause-then-targeted',
+      completionRule: 'never-claim-fixed-without-write-and-verification',
+      delegationPolicy: 'allow-specialized-debug-lane',
+      completionEvidence: ['write-evidence', 'verification-evidence'],
+    },
+    'shared-edit': {
+      maxReadPasses: 2,
+      maxContextPulls: 2,
+      verificationPolicy: 'targeted-then-widen-on-risk',
+      completionRule: 'require-write-and-verification',
+      delegationPolicy: 'allow-qualified-sidecar',
+      completionEvidence: ['write-evidence', 'verification-evidence'],
+      mirrorConsistencyRequired: true,
+    },
+    'map-impact': {
+      maxReadPasses: 3,
+      maxContextPulls: 3,
+      verificationPolicy: 'impact-first-then-targeted-then-widen-on-risk',
+      completionRule: 'require-impact-evidence-before-edit-claim',
+      delegationPolicy: 'allow-impact-sidecar',
+      completionEvidence: ['impact-evidence', 'write-evidence', 'verification-evidence'],
+      mirrorConsistencyRequired: true,
+    },
+    'review-release': {
+      verificationPolicy: 'evidence-first',
+      completionRule: 'report-findings-not-implementation',
+      delegationPolicy: 'allow-review-sidecar',
+      completionEvidence: ['verification-evidence'],
+    },
+  };
+
+  return contracts[executionMode] ? { ...contracts[executionMode] } : null;
+}
+
+function buildApproachSelectorResult({
+  executionMode = null,
+  executionScores = null,
+} = {}) {
+  if (!executionMode) {
+    return null;
+  }
+
+  const executionContract = buildExecutionContract(executionMode);
+  const policyByMode = {
+    'tiny-fix': {
+      riskLevel: 'minimal',
+      contextPolicy: 'confirm-target-only',
+    },
+    'local-fix': {
+      riskLevel: 'local',
+      contextPolicy: 'bounded-local',
+    },
+    'local-build': {
+      riskLevel: 'local',
+      contextPolicy: 'bounded-with-related-files',
+    },
+    'find-cause': {
+      riskLevel: 'investigation',
+      contextPolicy: 'trace-then-bounded-context',
+    },
+    'shared-edit': {
+      riskLevel: 'shared',
+      contextPolicy: 'bounded-with-related-tests',
+    },
+    'map-impact': {
+      riskLevel: 'wide',
+      contextPolicy: 'impact-map-first',
+    },
+    'review-release': {
+      riskLevel: 'release',
+      contextPolicy: 'evidence-review-only',
+    },
+  };
+  const selectedPolicy = policyByMode[executionMode] ?? {
+    riskLevel: 'local',
+    contextPolicy: 'bounded-local',
+  };
+
+  return {
+    executionMode,
+    executionScores: executionScores ? { ...executionScores } : null,
+    riskLevel: selectedPolicy.riskLevel,
+    contextPolicy: selectedPolicy.contextPolicy,
+    verificationPolicy: executionContract?.verificationPolicy ?? null,
+    completionRule: executionContract?.completionRule ?? null,
+  };
+}
+
+function buildCompletionState({ executionMode = null, verificationRecommendation = null } = {}) {
+  if (!executionMode) {
+    return null;
+  }
+
+  const contract = buildExecutionContract(executionMode);
+  const missingEvidence = [...(contract?.completionEvidence ?? [])];
+  const requiresVerification = missingEvidence.includes('verification-evidence');
+  if (
+    requiresVerification
+    && verificationRecommendation
+    && !(verificationRecommendation.commands?.length || verificationRecommendation.fallbackCommands?.length)
+  ) {
+    missingEvidence.push('verification-plan');
+  }
+
+  let reason = 'completion evidence is still required';
+  if (['tiny-fix', 'local-fix', 'local-build', 'shared-edit'].includes(executionMode)) {
+    reason = 'implement request has not produced an edit yet';
+  } else if (executionMode === 'review-release') {
+    reason = 'review/release evidence is still required before final claim';
+  } else if (executionMode === 'map-impact') {
+    reason = 'impact evidence is still required before safe completion claim';
+  }
+
+  return {
+    claimAllowed: false,
+    missingEvidence,
+    reason,
+  };
+}
+
+function buildContinuationState({
+  nextActionType = null,
+  completionState = null,
+} = {}) {
+  const reasons = [];
+  const missingEvidence = unique(completionState?.missingEvidence ?? []);
+
+  if (nextActionType === 'pull-indexed-context') {
+    reasons.push('pending-bounded-context');
+  }
+
+  if (nextActionType === 'read-skill-instructions') {
+    reasons.push('pending-skill-read');
+  }
+
+  if (missingEvidence.includes('write-evidence')) {
+    reasons.push('missing-write-evidence');
+  }
+
+  if (missingEvidence.includes('verification-evidence') || missingEvidence.includes('verification-plan')) {
+    reasons.push('missing-verification-evidence');
+  }
+
+  if (missingEvidence.includes('impact-evidence')) {
+    reasons.push('missing-impact-evidence');
+  }
+
+  const nextMilestone = reasons.includes('pending-bounded-context')
+    ? 'complete-bounded-context-then-continue'
+    : (
+      reasons.includes('missing-write-evidence')
+        ? 'produce-write-evidence'
+        : (
+          reasons.includes('missing-verification-evidence')
+            ? 'produce-verification-evidence'
+            : (
+              reasons.includes('missing-impact-evidence')
+                ? 'produce-impact-evidence'
+                : null
+            )
+        )
+    );
+
+  return {
+    required: reasons.length > 0,
+    reasons,
+    doneLanguageBlocked: reasons.length > 0,
+    stopAllowedOnlyFor: reasons.length > 0 ? ['real-blocker'] : [],
+    nextMilestone,
+    repeatCount: reasons.length > 0 ? 1 : 0,
+    stuckRisk: null,
+    rescueMode: null,
+  };
+}
+
+function advanceContinuationState(continuationState = null, previousContinuationState = null) {
+  if (!continuationState || typeof continuationState !== 'object') {
+    return continuationState;
+  }
+
+  if (!continuationState.required) {
+    return {
+      ...continuationState,
+      repeatCount: 0,
+      stuckRisk: null,
+      rescueMode: null,
+    };
+  }
+
+  const currentReasons = unique(continuationState.reasons ?? []);
+  const previousReasons = unique(previousContinuationState?.reasons ?? []);
+  const sameMilestone = Boolean(
+    previousContinuationState?.required
+    && continuationState.nextMilestone
+    && previousContinuationState.nextMilestone === continuationState.nextMilestone
+    && JSON.stringify(previousReasons) === JSON.stringify(currentReasons)
+  );
+  const repeatCount = sameMilestone
+    ? Math.max(1, Number(previousContinuationState?.repeatCount ?? 1) + 1)
+    : 1;
+  const rescueMode = repeatCount >= 2
+    ? (
+      currentReasons.includes('pending-bounded-context')
+        ? 'finish-current-milestone-before-more-reading'
+        : (
+          currentReasons.includes('missing-write-evidence')
+            ? 'finish-write-before-more-analysis'
+            : 'finish-required-milestone-before-widening'
+        )
+    )
+    : null;
+  const stuckRisk = repeatCount >= 3
+    ? 'high'
+    : (repeatCount === 2 ? 'elevated' : null);
+
+  return {
+    ...continuationState,
+    repeatCount,
+    stuckRisk,
+    rescueMode,
+  };
+}
+
 function deriveExecutionPolicy({
   taskType = 'simple',
   mode = 'minimal',
@@ -1687,6 +2136,7 @@ function buildRouteRequestKey({
     targetFile: routingContext.targetFile ?? '',
     contextIntent: routingContext.contextIntent ?? '',
     taskType: routingContext.taskType ?? '',
+    executionMode: routingContext.executionMode ?? '',
   });
 }
 
@@ -1704,10 +2154,23 @@ function buildStructuredRouteFingerprintPayload(route = {}) {
     previousContextIds: unique(route.previousContext?.selectedIds ?? []),
     recentOutputLine: route.recentOutput?.line ?? null,
     policyMode: routeSummary?.policyMode ?? null,
+    executionMode: routeSummary?.executionMode ?? null,
+    approachRiskLevel: routeSummary?.approachSelector?.riskLevel ?? null,
+    approachContextPolicy: routeSummary?.approachSelector?.contextPolicy ?? null,
+    approachVerificationPolicy: routeSummary?.approachSelector?.verificationPolicy ?? null,
+    approachCompletionRule: routeSummary?.approachSelector?.completionRule ?? null,
+    continuationRequired: routeSummary?.continuationState?.required ?? null,
+    continuationReasons: unique(routeSummary?.continuationState?.reasons ?? []),
+    continuationMilestone: routeSummary?.continuationState?.nextMilestone ?? null,
+    continuationRepeatCount: routeSummary?.continuationState?.repeatCount ?? null,
+    continuationStuckRisk: routeSummary?.continuationState?.stuckRisk ?? null,
+    continuationRescueMode: routeSummary?.continuationState?.rescueMode ?? null,
     delegateHint: routeSummary?.delegateHint ?? null,
     nextActionType: routeSummary?.nextActionType ?? null,
     nextActionCommand: routeSummary?.nextActionCommand ?? null,
     helperHint: routeSummary?.helperHint ?? null,
+    completionRule: routeSummary?.executionContract?.completionRule ?? null,
+    completionMissingEvidence: unique(routeSummary?.completionState?.missingEvidence ?? []),
     primaryCommands: unique(routeSummary?.primaryCommands ?? []),
     fallbackCommands: unique(routeSummary?.fallbackCommands ?? []),
     preferredOrder: unique(routeSummary?.preferredOrder ?? []),
@@ -1784,6 +2247,7 @@ function compactRoutingContext(routingContext = {}) {
     lastExplicitUserPromptText: routingContext.lastExplicitUserPromptText ?? '',
     taskType: routingContext.taskType ?? null,
     intentMode: routingContext.intentMode ?? null,
+    executionMode: routingContext.executionMode ?? null,
   };
 }
 
@@ -1846,6 +2310,12 @@ function compactRouteSummary(routeSummary = null) {
     fallbackCommands: unique(routeSummary.fallbackCommands ?? []).slice(0, 3),
     preferredOrder: unique(routeSummary.preferredOrder ?? []).slice(0, 5),
     policyMode: routeSummary.policyMode ?? null,
+    executionMode: routeSummary.executionMode ?? null,
+    executionScores: routeSummary.executionScores ?? null,
+    approachSelector: routeSummary.approachSelector ?? null,
+    executionContract: routeSummary.executionContract ?? null,
+    completionState: routeSummary.completionState ?? null,
+    continuationState: routeSummary.continuationState ?? null,
     delegateHint: routeSummary.delegateHint ?? null,
     nextActionType: routeSummary.nextActionType ?? null,
     nextActionCommand: routeSummary.nextActionCommand ?? null,