@ng-cn/core 1.0.17 → 1.0.18

package/src/app/lib/components/ui/hover-card/hover-card-content.component.ts

@@ -1,12 +1,16 @@
-import { cn, Presence } from '@/lib/utils';
+import { Align, cn, computePosition, getTransformOrigin, Presence, Side } from '@/lib/utils';
 import {
+  afterNextRender,
   ChangeDetectionStrategy,
   Component,
   computed,
+  effect,
   ElementRef,
   inject,
+  Injector,
   input,
   OnDestroy,
+  signal,
 } from '@angular/core';
 import { HOVER_CARD_CONTEXT, HoverCardAlign, HoverCardSide } from './hover-card-context';
 
@@ -38,31 +42,6 @@ export interface HoverCardContentProps {
  * HoverCardContent displays the preview content. It stays open when
  * hovered, allowing users to interact with the content.
  *
- * ## Features
- * - Stays open when content is hovered
- * - Configurable side and alignment
- * - Smooth animations
- * - Escape key to dismiss
- *
- * ## Accessibility
- * - `role="dialog"` on the content
- * - Focusable content items
- * - Escape returns focus to trigger
- *
- * @example Basic usage
- * ```html
- * <HoverCardContent>
- *   <p>Preview content</p>
- * </HoverCardContent>
- * ```
- *
- * @example With positioning
- * ```html
- * <HoverCardContent side="right" align="start">
- *   <p>Right-aligned content</p>
- * </HoverCardContent>
- * ```
- *
  * @data-attributes
  * - `data-state` - 'open' | 'closed'
  * - `data-side` - 'top' | 'right' | 'bottom' | 'left'
@@ -78,9 +57,10 @@ export interface HoverCardContentProps {
         [attr.aria-modal]="false"
         tabindex="-1"
         [class]="computedClass()"
+        [style]="positionStyles()"
         [attr.data-state]="state()"
-        [attr.data-side]="side()"
-        [attr.data-align]="align()"
+        [attr.data-side]="computedSide()"
+        [attr.data-align]="computedAlign()"
         data-slot="hover-card-content"
         (mouseenter)="onMouseEnter()"
         (mouseleave)="onMouseLeave()"
@@ -99,6 +79,25 @@ export interface HoverCardContentProps {
   changeDetection: ChangeDetectionStrategy.OnPush,
 })
 export class HoverCardContent implements OnDestroy {
+  constructor() {
+    effect(() => {
+      const isOpen = this.context.open();
+      if (isOpen) {
+        this.isPositioned.set(false);
+        afterNextRender(
+          () => {
+            this.schedulePositionUpdate();
+          },
+          { injector: this._injector },
+        );
+      } else {
+        this.cancelScheduledPositionUpdate();
+        this.isPositioned.set(false);
+        this.positionStyles.set({ position: 'fixed', top: '-9999px', left: '-9999px' });
+      }
+    });
+  }
+
   /** The preferred side of the trigger to render against */
   readonly side = input<HoverCardSide>('bottom');
   /** The distance in pixels from the trigger */
@@ -109,80 +108,129 @@ export class HoverCardContent implements OnDestroy {
   readonly class = input<string>('');
 
   private readonly _elementRef = inject(ElementRef<HTMLElement>);
+  private readonly _injector = inject(Injector);
 
   protected readonly context = inject(HOVER_CARD_CONTEXT);
 
-  protected readonly computedClass = computed(() => {
-    const sideClasses = {
-      top: 'bottom-full mb-2',
-      bottom: 'top-full mt-2',
-      left: 'right-full mr-2',
-      right: 'left-full ml-2',
-    };
-
-    const alignClasses = {
-      start: 'left-0',
-      center: 'left-1/2 -translate-x-1/2',
-      end: 'right-0',
-    };
-
-    return cn(
-      'absolute z-50 w-64 rounded-md border bg-popover p-4 text-popover-foreground shadow-md outline-none',
+  protected readonly computedClass = computed(() =>
+    cn(
+      'fixed z-50 w-64 rounded-md border bg-popover p-4 text-popover-foreground shadow-md outline-none',
       'data-[state=open]:animate-in data-[state=closed]:animate-out',
       'data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0',
       'data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95',
       'data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2',
       'data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2',
-      sideClasses[this.side()],
-      this.side() === 'top' || this.side() === 'bottom' ? alignClasses[this.align()] : '',
+      !this.isPositioned() && 'pointer-events-none opacity-0',
       this.class(),
-    );
+    ),
+  );
+
+  protected readonly positionStyles = signal<Record<string, string>>({
+    position: 'fixed',
+    top: '-9999px',
+    left: '-9999px',
   });
+  protected readonly isPositioned = signal(false);
+  protected readonly computedSide = signal<Side>('bottom');
+  protected readonly computedAlign = signal<Align>('center');
 
-  private closeTimeout: ReturnType<typeof setTimeout> | null = null;
   /** Current state: open or closed */
   protected readonly state = computed<HoverCardContentState>(() =>
     this.context.open() ? 'open' : 'closed',
   );
 
+  private closeTimeout: ReturnType<typeof setTimeout> | null = null;
+  private positionFrameId: number | null = null;
+
   ngOnDestroy(): void {
-    this.clearTimeout();
+    this.clearCloseTimeout();
+    this.cancelScheduledPositionUpdate();
   }
 
   onMouseEnter(): void {
-    this.clearTimeout();
+    this.clearCloseTimeout();
   }
   onMouseLeave(): void {
     this.closeTimeout = setTimeout(() => {
       this.context.setOpen(false);
-    }, this.context.closeDelay);
+    }, this.context.closeDelay());
   }
   onFocusIn(): void {
-    this.clearTimeout();
+    this.clearCloseTimeout();
   }
   onFocusOut(event: FocusEvent): void {
     const relatedTarget = event.relatedTarget as HTMLElement | null;
-    const trigger = this._elementRef.nativeElement.parentElement?.querySelector('[data-state]');
+    const trigger = this.context.triggerRef();
 
-    // Check if focus moved to trigger or stayed within content
     if (relatedTarget && (trigger === relatedTarget || trigger?.contains(relatedTarget))) {
       return;
     }
 
     this.closeTimeout = setTimeout(() => {
       this.context.setOpen(false);
-    }, this.context.closeDelay);
+    }, this.context.closeDelay());
   }
   onEscape(): void {
     this.context.setOpen(false);
-    // Return focus to trigger
-    const trigger = this._elementRef.nativeElement.parentElement?.querySelector(
-      '[data-state]',
+    this.context.triggerRef()?.focus();
+  }
+
+  private schedulePositionUpdate(): void {
+    this.cancelScheduledPositionUpdate();
+    this.positionFrameId = requestAnimationFrame(() => {
+      this.updatePosition();
+      this.positionFrameId = requestAnimationFrame(() => {
+        this.updatePosition();
+        this.positionFrameId = null;
+      });
+    });
+  }
+  private cancelScheduledPositionUpdate(): void {
+    if (this.positionFrameId !== null) {
+      cancelAnimationFrame(this.positionFrameId);
+      this.positionFrameId = null;
+    }
+  }
+  private updatePosition(): void {
+    const triggerElement = this.context.triggerRef();
+    const contentElement = this._elementRef.nativeElement.querySelector(
+      '[role="dialog"]',
     ) as HTMLElement;
-    trigger?.focus();
+
+    if (!triggerElement || !contentElement) return;
+
+    const triggerRect = triggerElement.getBoundingClientRect();
+    const contentRect = contentElement.getBoundingClientRect();
+    const overlayWidth = Math.round(contentRect.width || 256);
+    const overlayHeight = Math.round(contentRect.height || 100);
+
+    const result = computePosition(
+      triggerRect,
+      { width: overlayWidth, height: overlayHeight },
+      {
+        side: this.side(),
+        align: this.align(),
+        sideOffset: this.sideOffset(),
+        alignOffset: 0,
+        avoidCollisions: true,
+        collisionPadding: 8,
+      },
+    );
+
+    this.computedSide.set(result.side);
+    this.computedAlign.set(result.align);
+
+    const transformOrigin = getTransformOrigin(result.side, result.align);
+    this.positionStyles.set({
+      position: 'fixed',
+      top: result.styles.top || '',
+      left: result.styles.left || '',
+      '--radix-hover-card-content-transform-origin': transformOrigin,
+    });
+    this.isPositioned.set(true);
   }
 
-  private clearTimeout(): void {
+  private clearCloseTimeout(): void {
     if (this.closeTimeout) {
       clearTimeout(this.closeTimeout);
       this.closeTimeout = null;

package/src/app/lib/components/ui/hover-card/hover-card-context.ts

@@ -9,9 +9,11 @@ export interface HoverCardContextValue {
   /** Set open state */
   setOpen: (open: boolean) => void;
   /** The duration from when the pointer enters the trigger until the hover card opens (ms) */
-  openDelay: number;
+  openDelay: () => number;
   /** The duration from when the pointer leaves the trigger/content until the hover card closes (ms) */
-  closeDelay: number;
+  closeDelay: () => number;
+  /** Reference to the trigger element for fixed positioning */
+  triggerRef: WritableSignal<HTMLElement | null>;
 }
 
 export const HOVER_CARD_CONTEXT = new InjectionToken<HoverCardContextValue>('HOVER_CARD_CONTEXT');

package/src/app/lib/components/ui/hover-card/hover-card-trigger.component.ts

@@ -96,18 +96,20 @@ export class HoverCardTrigger implements OnDestroy {
   }
 
   onMouseEnter(): void {
+    this.context.triggerRef.set(this._elementRef.nativeElement);
     this.clearTimeouts();
     this.openTimeout = setTimeout(() => {
       this.context.setOpen(true);
-    }, this.context.openDelay);
+    }, this.context.openDelay());
   }
   onMouseLeave(): void {
     this.clearTimeouts();
     this.closeTimeout = setTimeout(() => {
       this.context.setOpen(false);
-    }, this.context.closeDelay);
+    }, this.context.closeDelay());
   }
   onFocus(): void {
+    this.context.triggerRef.set(this._elementRef.nativeElement);
     this.clearTimeouts();
     // Open immediately on focus for keyboard users
     this.context.setOpen(true);
@@ -127,7 +129,7 @@ export class HoverCardTrigger implements OnDestroy {
     this.clearTimeouts();
     this.closeTimeout = setTimeout(() => {
       this.context.setOpen(false);
-    }, this.context.closeDelay);
+    }, this.context.closeDelay());
   }
   onKeyDown(event: Event): void {
     event.preventDefault();

package/src/app/lib/components/ui/hover-card/hover-card.component.ts

@@ -5,6 +5,8 @@ import {
   input,
   output,
   signal,
+  Signal,
+  WritableSignal,
 } from '@angular/core';
 import { HOVER_CARD_CONTEXT, type HoverCardContextValue } from './hover-card-context';
 
@@ -93,7 +95,7 @@ export interface HoverCardProps {
   template: `<ng-content />`,
   host: {
     'attr.data-slot': '"hover-card"',
-    class: 'relative inline-block',
+    class: 'inline-block',
   },
   providers: [
     {
@@ -120,10 +122,13 @@ export class HoverCard implements HoverCardContextValue {
 
   readonly open = signal(false);
 
+  /** Reference to the trigger element for fixed positioning */
+  readonly triggerRef: WritableSignal<HTMLElement | null> = signal<HTMLElement | null>(null);
+
   /** The duration from when the pointer enters the trigger until the hover card opens (ms) */
-  readonly openDelay = 700;
+  readonly openDelay = input<number>(700);
   /** The duration from when the pointer leaves the trigger/content until the hover card closes (ms) */
-  readonly closeDelay = 300;
+  readonly closeDelay = input<number>(300);
 
   setOpen(open: boolean): void {
     if (this.controlledOpen() === undefined) {

package/src/app/lib/components/ui/input-group/input-group-addon.component.ts

@@ -14,6 +14,7 @@ import { ChangeDetectionStrategy, Component, computed, input } from '@angular/co
   selector: 'InputGroupAddon',
   template: `<ng-content />`,
   host: {
+    'attr.data-slot': '"input-group-addon"',
     '[class]': 'computedClass()',
   },
   changeDetection: ChangeDetectionStrategy.OnPush,

package/src/app/lib/components/ui/input-group/input-group-input.component.ts

@@ -10,6 +10,7 @@ import { ChangeDetectionStrategy, Component, computed, input } from '@angular/co
   selector: 'InputGroupInput',
   template: ``,
   host: {
+    'attr.data-slot': '"input-group-input"',
     '[class]': 'computedClass()',
   },
   changeDetection: ChangeDetectionStrategy.OnPush,

package/src/app/lib/components/ui/input-group/input-group.component.ts

@@ -30,6 +30,7 @@ import { ChangeDetectionStrategy, Component, computed, input } from '@angular/co
   selector: 'InputGroup',
   template: `<ng-content />`,
   host: {
+    'attr.data-slot': '"input-group"',
     '[class]': 'computedClass()',
   },
   changeDetection: ChangeDetectionStrategy.OnPush,

package/src/app/lib/components/ui/menubar/menubar-content.component.ts

@@ -114,7 +114,7 @@ export class MenubarContent implements OnDestroy {
     if (content) {
       this.menuItems = Array.from(
         content.querySelectorAll(
-          '[role="menuitem"]:not([aria-disabled="true"]):not([data-disabled])',
+          '[role="menuitem"]:not([data-disabled=""]), [role="menuitemcheckbox"]:not([data-disabled=""]), [role="menuitemradio"]:not([data-disabled=""])',
         ),
       );
     }

package/src/app/lib/components/ui/navigation-menu/navigation-menu-content.component.ts

@@ -18,7 +18,13 @@ import { NAVIGATION_MENU_CONTEXT, NAVIGATION_MENU_ITEM_CONTEXT } from './navigat
   imports: [Presence],
   template: `
     <Presence [present]="itemContext.open()">
-      <div [class]="computedClass()" [attr.data-state]="itemContext.open() ? 'open' : 'closed'">
+      <div
+        [class]="computedClass()"
+        [attr.id]="itemContext.contentId"
+        [attr.data-state]="itemContext.open() ? 'open' : 'closed'"
+        [attr.aria-labelledby]="itemContext.triggerId"
+        role="region"
+      >
         <ng-content />
       </div>
     </Presence>

package/src/app/lib/components/ui/navigation-menu/navigation-menu-context.ts

@@ -22,6 +22,16 @@ export interface NavigationMenuContextValue {
   activeItem: WritableSignal<string | null>;
   /** Layout orientation of the menu */
   orientation: WritableSignal<NavigationMenuOrientation>;
+  /** Ordered list of registered trigger element IDs */
+  triggerIds: WritableSignal<string[]>;
+  /** Register a trigger ID (called by NavigationMenuTrigger on init) */
+  registerTrigger: (triggerId: string) => void;
+  /** Unregister a trigger ID (called by NavigationMenuTrigger on destroy) */
+  unregisterTrigger: (triggerId: string) => void;
+  /** Move DOM focus to the next trigger in document order */
+  focusNextTrigger: (currentTriggerId: string) => void;
+  /** Move DOM focus to the previous trigger in document order */
+  focusPreviousTrigger: (currentTriggerId: string) => void;
 }
 
 export const NAVIGATION_MENU_CONTEXT = new InjectionToken<NavigationMenuContextValue>(
@@ -38,6 +48,10 @@ export const NAVIGATION_MENU_CONTEXT = new InjectionToken<NavigationMenuContextV
 export interface NavigationMenuItemContextValue {
   /** Unique identifier for this item */
   itemId: string;
+  /** DOM id for the trigger element (used for aria-controls / aria-labelledby) */
+  triggerId: string;
+  /** DOM id for the content element (used for aria-controls) */
+  contentId: string;
   /** Whether this item's content is open */
   open: WritableSignal<boolean>;
 }

package/src/app/lib/components/ui/navigation-menu/navigation-menu-item.component.ts

@@ -17,10 +17,15 @@ let itemIdCounter = 0;
   providers: [
     {
       provide: NAVIGATION_MENU_ITEM_CONTEXT,
-      useFactory: (): NavigationMenuItemContextValue => ({
-        itemId: `nav-item-${itemIdCounter++}`,
-        open: signal(false),
-      }),
+      useFactory: (): NavigationMenuItemContextValue => {
+        const id = itemIdCounter++;
+        return {
+          itemId: `nav-item-${id}`,
+          triggerId: `nav-trigger-${id}`,
+          contentId: `nav-content-${id}`,
+          open: signal(false),
+        };
+      },
     },
   ],
   host: {

package/src/app/lib/components/ui/navigation-menu/navigation-menu-trigger.component.ts

@@ -1,5 +1,13 @@
 import { cn } from '@/lib/utils';
-import { ChangeDetectionStrategy, Component, computed, inject, input } from '@angular/core';
+import {
+  ChangeDetectionStrategy,
+  Component,
+  computed,
+  inject,
+  input,
+  OnDestroy,
+  OnInit,
+} from '@angular/core';
 import { ChevronDown, LucideAngularModule } from 'lucide-angular';
 import { NAVIGATION_MENU_CONTEXT, NAVIGATION_MENU_ITEM_CONTEXT } from './navigation-menu-context';
 import { navigationMenuTriggerStyle } from './navigation-menu-trigger-style';
@@ -22,13 +30,19 @@ import { navigationMenuTriggerStyle } from './navigation-menu-trigger-style';
   host: {
     'attr.data-slot': '"navigation-menu-trigger"',
     '[class]': 'computedClass()',
+    '[attr.id]': 'itemContext.triggerId',
     '[attr.data-state]': 'itemContext.open() ? "open" : "closed"',
+    '[attr.role]': '"button"',
+    '[attr.aria-expanded]': 'itemContext.open()',
+    '[attr.aria-haspopup]': '"menu"',
+    '[attr.aria-controls]': 'itemContext.contentId',
     '(click)': 'toggle()',
     '(mouseenter)': 'onMouseEnter()',
+    '(keydown)': 'onKeyDown($event)',
   },
   changeDetection: ChangeDetectionStrategy.OnPush,
 })
-export class NavigationMenuTrigger {
+export class NavigationMenuTrigger implements OnInit, OnDestroy {
   /** Additional CSS classes */
   readonly class = input<string>('');
 
@@ -41,6 +55,14 @@ export class NavigationMenuTrigger {
 
   protected readonly ChevronDownIcon = ChevronDown;
 
+  ngOnInit(): void {
+    this.context.registerTrigger(this.itemContext.triggerId);
+  }
+
+  ngOnDestroy(): void {
+    this.context.unregisterTrigger(this.itemContext.triggerId);
+  }
+
   protected toggle(): void {
     this.itemContext.open.update((v) => !v);
     if (this.itemContext.open()) {
@@ -49,6 +71,7 @@ export class NavigationMenuTrigger {
       this.context.activeItem.set(null);
     }
   }
+
   protected onMouseEnter(): void {
     const activeItem = this.context.activeItem();
     if (activeItem && activeItem !== this.itemContext.itemId) {
@@ -56,4 +79,48 @@ export class NavigationMenuTrigger {
       this.itemContext.open.set(true);
     }
   }
+
+  protected onKeyDown(event: KeyboardEvent): void {
+    switch (event.key) {
+      case 'Enter':
+      case ' ':
+        event.preventDefault();
+        this.toggle();
+        if (this.itemContext.open()) {
+          this.focusFirstContentItem();
+        }
+        break;
+      case 'ArrowDown':
+        event.preventDefault();
+        if (!this.itemContext.open()) {
+          this.itemContext.open.set(true);
+          this.context.activeItem.set(this.itemContext.itemId);
+        }
+        this.focusFirstContentItem();
+        break;
+      case 'ArrowRight':
+        event.preventDefault();
+        this.context.focusNextTrigger(this.itemContext.triggerId);
+        break;
+      case 'ArrowLeft':
+        event.preventDefault();
+        this.context.focusPreviousTrigger(this.itemContext.triggerId);
+        break;
+      case 'Escape':
+        if (this.itemContext.open()) {
+          this.itemContext.open.set(false);
+          this.context.activeItem.set(null);
+          document.getElementById(this.itemContext.triggerId)?.focus();
+        }
+        break;
+    }
+  }
+
+  private focusFirstContentItem(): void {
+    setTimeout(() => {
+      const content = document.getElementById(this.itemContext.contentId);
+      const focusable = content?.querySelector<HTMLElement>('a, button, [tabindex]');
+      focusable?.focus();
+    }, 10);
+  }
 }

package/src/app/lib/components/ui/navigation-menu/navigation-menu.component.ts

@@ -7,6 +7,37 @@ import {
 } from './navigation-menu-context';
 import { NavigationMenuViewport } from './navigation-menu-viewport.component';
 
+function createNavigationMenuContext(): NavigationMenuContextValue {
+  const triggerIds = signal<string[]>([]);
+  return {
+    activeItem: signal(null),
+    orientation: signal('horizontal'),
+    triggerIds,
+    registerTrigger: (triggerId: string) => {
+      triggerIds.update((ids) => [...ids, triggerId]);
+    },
+    unregisterTrigger: (triggerId: string) => {
+      triggerIds.update((ids) => ids.filter((id) => id !== triggerId));
+    },
+    focusNextTrigger: (currentTriggerId: string) => {
+      const ids = triggerIds();
+      const idx = ids.indexOf(currentTriggerId);
+      const nextId = idx < ids.length - 1 ? ids[idx + 1] : ids[0];
+      if (nextId) {
+        document.getElementById(nextId)?.focus();
+      }
+    },
+    focusPreviousTrigger: (currentTriggerId: string) => {
+      const ids = triggerIds();
+      const idx = ids.indexOf(currentTriggerId);
+      const prevId = idx > 0 ? ids[idx - 1] : ids[ids.length - 1];
+      if (prevId) {
+        document.getElementById(prevId)?.focus();
+      }
+    },
+  };
+}
+
 /**
  * Props for the NavigationMenu component
  */
@@ -121,10 +152,7 @@ export interface NavigationMenuProps {
   providers: [
     {
       provide: NAVIGATION_MENU_CONTEXT,
-      useFactory: (): NavigationMenuContextValue => ({
-        activeItem: signal(null),
-        orientation: signal('horizontal'),
-      }),
+      useFactory: createNavigationMenuContext,
     },
   ],
   changeDetection: ChangeDetectionStrategy.OnPush,

package/src/app/lib/components/ui/pagination/pagination.component.ts

@@ -29,12 +29,14 @@ import { ChangeDetectionStrategy, Component, computed, input } from '@angular/co
   host: {
     'attr.data-slot': '"pagination"',
     role: 'navigation',
-    '[attr.aria-label]': '"pagination"',
+    '[attr.aria-label]': 'ariaLabel()',
     '[class]': 'computedClass()',
   },
   changeDetection: ChangeDetectionStrategy.OnPush,
 })
 export class Pagination {
+  /** Accessible label for the navigation landmark */
+  readonly ariaLabel = input<string>('Pagination');
   /** Additional CSS classes */
   readonly class = input<string>('');
 

package/src/app/lib/components/ui/popover/popover-content.component.ts

@@ -100,6 +100,7 @@ export interface PopoverContentProps {
         [attr.data-align]="computedAlign()"
         [style]="mergedStyles()"
         role="dialog"
+        tabindex="-1"
         [attr.aria-modal]="context.modal() || null"
       >
         <ng-content />
@@ -277,5 +278,15 @@ export class PopoverContent {
       '--radix-popover-content-transform-origin': transformOrigin,
     });
     this.isPositioned.set(true);
+
+    // Move focus into the popover for keyboard accessibility
+    setTimeout(() => {
+      const dialog = this._elementRef.nativeElement.querySelector('[role="dialog"]') as HTMLElement;
+      if (!dialog) return;
+      const firstFocusable = dialog.querySelector<HTMLElement>(
+        'button:not([disabled]):not([data-disabled=""]), [href], input:not([disabled]), select:not([disabled]), textarea:not([disabled]), [tabindex]:not([tabindex="-1"])',
+      );
+      (firstFocusable ?? dialog).focus({ preventScroll: true });
+    }, 0);
   }
 }

package/src/app/lib/components/ui/popover/popover-context.ts

@@ -16,6 +16,8 @@ export interface PopoverContextValue {
   triggerRef?: Signal<HTMLElement | null>;
   /** Set the trigger element reference */
   setTriggerRef?: (element: HTMLElement | null) => void;
+  /** Unique ID for aria-controls relationship */
+  contentId: string;
 }
 
 export const POPOVER_CONTEXT = new InjectionToken<PopoverContextValue>('POPOVER_CONTEXT');

package/src/app/lib/components/ui/popover/popover.component.ts

@@ -10,6 +10,8 @@ import { POPOVER_CONTEXT, type PopoverContextValue } from './popover-context';
 
 export type PopoverState = 'open' | 'closed';
 
+let idCounter = 0;
+
 /**
  * Props for the Popover component
  */
@@ -128,6 +130,8 @@ export class Popover implements PopoverContextValue {
   readonly controlledOpen = input<boolean | undefined>(undefined, { alias: 'open' });
 
   readonly open = signal(false);
+  /** Unique ID for aria-controls relationship */
+  readonly contentId = `popover-content-${++idCounter}`;
   /** Reference to the trigger element for positioning */
   readonly triggerRef = signal<HTMLElement | null>(null);
 

package/src/app/lib/components/ui/progress/progress.component.ts

@@ -102,9 +102,8 @@ export type ProgressProps = {
     '[attr.aria-label]': 'ariaLabel()',
     '[attr.aria-valuemin]': '0',
     '[attr.aria-valuemax]': 'max()',
-    '[attr.aria-valuenow]': 'value()',
+    '[attr.aria-valuenow]': 'value() !== null ? value() : null',
     '[attr.aria-valuetext]': 'computedValueText()',
-    '[attr.aria-live]': '"polite"',
     '[attr.data-state]': 'state()',
     '[attr.data-value]': 'value()',
     '[attr.data-max]': 'max()',