@nfq/eslint-config 2.2.9 → 2.3.0

package/CHANGELOG.md

@@ -2,6 +2,33 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [2.3.0](https://github.com/nfqde/eslint-config-nfq/compare/v2.2.11...v2.3.0) (2023-04-21)
+
+
+### Features
+
+* **Curly, NoMagic:** Update rules to be a bit more lax ([#37](https://github.com/nfqde/eslint-config-nfq/issues/37)) ([a211764](https://github.com/nfqde/eslint-config-nfq/commit/a21176478f62fe8fdae46566290a0a0eff6c593b))
+
+### [2.2.11](https://github.com/nfqde/eslint-config-nfq/compare/v2.2.10...v2.2.11) (2023-03-04)
+
+
+### Bug Fixes
+
+* **Rules:** fix some rules ([#36](https://github.com/nfqde/eslint-config-nfq/issues/36)) ([5c0a5f1](https://github.com/nfqde/eslint-config-nfq/commit/5c0a5f1a76ae7020d02abb50ef7862af42fb22e8))
+
+### [2.2.10](https://github.com/nfqde/eslint-config-nfq/compare/v2.2.9...v2.2.10) (2023-03-02)
+
+
+### Bug Fixes
+
+* **es6:** Remove depricated rule: prefer-reflect ([#31](https://github.com/nfqde/eslint-config-nfq/issues/31)) ([d582b4f](https://github.com/nfqde/eslint-config-nfq/commit/d582b4fb104e4921df9c3e8c98858aba7b43926d))
+* **jsdoc:** Remove depricated jsdoc rules ([#29](https://github.com/nfqde/eslint-config-nfq/issues/29)) ([1d4ee15](https://github.com/nfqde/eslint-config-nfq/commit/1d4ee15abc882654a60055821483cac386462100))
+* **React:** Repalace depricated rule with sort-default-props ([#35](https://github.com/nfqde/eslint-config-nfq/issues/35)) ([1348de8](https://github.com/nfqde/eslint-config-nfq/commit/1348de8a19e40a7a7cf5e05da5dac2097754c4b3))
+* **Style:** Remove depricated and already replaced no-spaced-func ([#33](https://github.com/nfqde/eslint-config-nfq/issues/33)) ([266b936](https://github.com/nfqde/eslint-config-nfq/commit/266b9364416c138a60451d7021e95104eef6ae69))
+* **Style:** Replace depricated line between rules ([#34](https://github.com/nfqde/eslint-config-nfq/issues/34)) ([581a48d](https://github.com/nfqde/eslint-config-nfq/commit/581a48d8582dd7fc8a9c40f9466424213377047a))
+* **Style:** Replace depricated rule id-blacklist with id-denylist ([#32](https://github.com/nfqde/eslint-config-nfq/issues/32)) ([b804fe6](https://github.com/nfqde/eslint-config-nfq/commit/b804fe6c5d5ce6d28a916329dc516fbf4519353c))
+* **Variables:** Remove depricated rule: no-catch-shadow ([#30](https://github.com/nfqde/eslint-config-nfq/issues/30)) ([ed9ac8c](https://github.com/nfqde/eslint-config-nfq/commit/ed9ac8c74ceeba62adb32dea18b60e8a40f23c0e))
+
 ### [2.2.9](https://github.com/nfqde/eslint-config-nfq/compare/v2.2.8...v2.2.9) (2022-11-15)
 
 

package/config/globals.js

@@ -11,6 +11,7 @@ module.exports = {
     describe: false,
     expect: false,
     it: false,
+    JQuery: false,
     JSX: false,
     NodeJs: false
 };

package/index.js

@@ -16,7 +16,7 @@ module.exports = {
         {
             files: ['**/*.{ts,cts,mts,tsx}'],
             parser: '@typescript-eslint/parser',
-            parserOptions: {project: './tsconfig.json'},
+            parserOptions: {project: '**/tsconfig*.json'},
             plugins: ['@typescript-eslint'],
             rules: typescript.rules
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nfq/eslint-config",
-  "version": "2.2.9",
+  "version": "2.3.0",
   "engines": {
     "node": ">= 12.0.0"
   },
@@ -17,6 +17,7 @@
     "config"
   ],
   "peerDependencies": {
+    "@babel/core": ">= 7",
     "@babel/eslint-parser": ">= 7",
     "@nfq/eslint-plugin": ">= 0.6.0",
     "@typescript-eslint/eslint-plugin": ">= 5",
@@ -26,12 +27,12 @@
     "eslint-plugin-array-func": ">= 3",
     "eslint-plugin-better-styled-components": ">= 1",
     "eslint-plugin-import": ">= 2",
-    "eslint-plugin-jsdoc": ">= 39",
+    "eslint-plugin-jsdoc": ">= 40",
     "eslint-plugin-jsx-a11y": ">= 6",
-    "eslint-plugin-no-unsanitized": ">= 3",
+    "eslint-plugin-no-unsanitized": ">= 4",
     "eslint-plugin-node": ">= 11",
     "eslint-plugin-perf-standard": ">= 1",
-    "eslint-plugin-promise": ">= 5",
+    "eslint-plugin-promise": ">= 6",
     "eslint-plugin-react": ">= 7",
     "eslint-plugin-react-hooks": ">= 4",
     "eslint-plugin-react-hooks-ssr": ">= 0.1.5",
@@ -43,28 +44,28 @@
     "confusing-browser-globals": "^1.0.11"
   },
   "devDependencies": {
-    "@babel/core": "^7.18.9",
-    "@babel/eslint-parser": "^7.18.9",
+    "@babel/core": "^7.21.4",
+    "@babel/eslint-parser": "^7.21.3",
     "@nfq/eslint-plugin": "^0.6.0",
-    "@typescript-eslint/eslint-plugin": "^5.30.7",
-    "@typescript-eslint/parser": "^5.30.7",
-    "eslint": "^8.20.0",
+    "@typescript-eslint/eslint-plugin": "^5.59.0",
+    "@typescript-eslint/parser": "^5.59.0",
+    "eslint": "^8.38.0",
     "eslint-import-resolver-alias": "^1.1.2",
-    "eslint-plugin-array-func": "^3.1.7",
+    "eslint-plugin-array-func": "^3.1.8",
     "eslint-plugin-better-styled-components": "^1.1.2",
-    "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-jsdoc": "^39.3.3",
-    "eslint-plugin-jsx-a11y": "^6.6.0",
-    "eslint-plugin-no-unsanitized": "^4.0.1",
+    "eslint-plugin-import": "^2.27.5",
+    "eslint-plugin-jsdoc": "^41.1.2",
+    "eslint-plugin-jsx-a11y": "^6.7.1",
+    "eslint-plugin-no-unsanitized": "^4.0.2",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-perf-standard": "^1.0.3",
-    "eslint-plugin-promise": "^6.0.0",
-    "eslint-plugin-react": "^7.30.1",
+    "eslint-plugin-promise": "^6.1.1",
+    "eslint-plugin-react": "^7.32.2",
     "eslint-plugin-react-hooks": "^4.6.0",
     "eslint-plugin-react-hooks-ssr": "^0.1.5",
-    "eslint-plugin-redos": "^4.4.1",
-    "eslint-plugin-security": "^1.5.0",
-    "eslint-plugin-sort-destructure-keys": "^1.4.0"
+    "eslint-plugin-redos": "4.4.5",
+    "eslint-plugin-security": "^1.7.1",
+    "eslint-plugin-sort-destructure-keys": "^1.5.0"
   },
   "author": ".NFQ | Christoph Kruppe",
   "license": "ISC"

package/rules/best-practices.js

@@ -10,7 +10,7 @@ module.exports = {
                 ignore: [0, 1],
                 ignoreArrayIndexes: true,
                 ignoreArrays: true,
-                ignoreFunctions: ['setTimeout', 'setInterval']
+                ignoreFunctions: ['setTimeout', 'setInterval', 'spacing']
             }
         ], // disallow magic numbers http://eslint.org/docs/rules/no-magic-numbers
         'accessor-pairs': [
@@ -25,7 +25,7 @@ module.exports = {
         'class-methods-use-this': ['off', {exceptMethods: []}], // enforce that class methods use "this" http://eslint.org/docs/rules/class-methods-use-this
         complexity: ['warn', {max: 20}], // specify the maximum cyclomatic complexity allowed in a program https://eslint.org/docs/rules/complexity
         'consistent-return': 'error', // require return statements to either always or never specify values https://eslint.org/docs/rules/consistent-return
-        curly: 'error', // specify curly brace conventions for all control statements https://eslint.org/docs/rules/curly#top
+        curly: ['error', 'multi-line', 'consistent'], // specify curly brace conventions for all control statements https://eslint.org/docs/rules/curly#top
         'default-case': ['warn', {commentPattern: '^no default$'}], // require default case in switch statements https://eslint.org/docs/rules/default-case
         'default-param-last': 'error', // Checks if default params are last https://eslint.org/docs/rules/default-param-last
         'dot-location': ['error', 'property'], // enforces consistent newlines before or after dots http://eslint.org/docs/rules/dot-location

package/rules/errors.js

@@ -49,7 +49,6 @@ module.exports = {
         'no-unsafe-negation': 'error', // disallow negating the left operand of relational operators https://eslint.org/docs/rules/no-unsafe-negation
         'require-atomic-updates': 'off', // Disallow assignments that can lead to race conditions due to usage of await or yield https://eslint.org/docs/rules/require-atomic-updates
         'use-isnan': 'error', // disallow comparisons with the value NaN https://eslint.org/docs/rules/use-isnan
-        'valid-jsdoc': 'off', // ensure JSDoc comments are valid https://eslint.org/docs/rules/valid-jsdoc
         'valid-typeof': ['error', {requireStringLiterals: true}] // ensure that the results of typeof are compared against a valid string https://eslint.org/docs/rules/valid-typeof
     }
 };

package/rules/es6.js

@@ -81,7 +81,6 @@ module.exports = {
             {enforceForRenamedProperties: false}
         ], // Prefer destructuring from arrays and objects https://eslint.org/docs/rules/prefer-destructuring
         'prefer-numeric-literals': 'error', // disallow parseInt() in favor of binary, octal, and hexadecimal literals https://eslint.org/docs/rules/prefer-numeric-literals
-        'prefer-reflect': 'off', // suggest using Reflect methods where applicable https://eslint.org/docs/rules/prefer-reflect
         'prefer-rest-params': 'error', // use rest parameters instead of arguments https://eslint.org/docs/rules/prefer-rest-params
         'prefer-spread': 'error', // suggest using the spread operator instead of .apply() https://eslint.org/docs/rules/prefer-spread
         'prefer-template': 'error', // suggest using template literals instead of string concatenation https://eslint.org/docs/rules/prefer-template

package/rules/react.js

@@ -169,7 +169,6 @@ module.exports = {
                 html: 'enforce'
             }
         ], // Disallow JSX props spreading https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-props-no-spreading.md
-        'react/jsx-sort-default-props': ['error', {ignoreCase: true}], // Enforce defaultProps declarations alphabetical sorting https://github.com/yannickcr/eslint-plugin-react/blob/843d71a432baf0f01f598d7cf1eea75ad6896e4b/docs/rules/jsx-sort-default-props.md
         'react/jsx-sort-props': [
             'error',
             {
@@ -302,6 +301,7 @@ module.exports = {
                 ]
             }
         ], // Enforce component methods order https://github.com/yannickcr/eslint-plugin-react/blob/843d71a432baf0f01f598d7cf1eea75ad6896e4b/docs/rules/sort-comp.md
+        'react/sort-default-props': ['error', {ignoreCase: true}], // Enforce defaultProps declarations alphabetical sorting https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/sort-default-props.md
         'react/sort-prop-types': [
             'error',
             {

package/rules/style.js

@@ -80,7 +80,7 @@ module.exports = {
         'func-style': ['off', 'expression'], // enforces use of function declarations or expressions https://eslint.org/docs/rules/func-style
         'function-call-argument-newline': ['error', 'consistent'], // https://eslint.org/docs/rules/function-call-argument-newline
         'function-paren-newline': ['error', 'consistent'], // enforce consistent line breaks inside function parentheses https://eslint.org/docs/rules/function-paren-newline
-        'id-blacklist': 'off', // Blacklist certain identifiers to prevent them being used https://eslint.org/docs/rules/id-blacklist
+        'id-denylist': 'off', // Blacklist certain identifiers to prevent them being used https://eslint.org/docs/rules/id-denylist
         'id-length': 'off', // this option enforces minimum and maximum identifier lengths (variable names, property names etc.) https://eslint.org/docs/rules/id-length
         'id-match': 'off', // require identifiers to match the provided regular expression https://eslint.org/docs/rules/id-match
         'implicit-arrow-linebreak': ['error', 'beside'], // Enforce the location of arrow function bodies with implicit returns https://eslint.org/docs/rules/implicit-arrow-linebreak
@@ -126,7 +126,7 @@ module.exports = {
                 VariableDeclarator: 'first'
             }
         ], // this option sets a specific tab width for your code https://eslint.org/docs/rules/indent
-        'jsx-quotes': ['off', 'prefer-double'], // specify whether double or single quotes should be used in JSX attributes https://eslint.org/docs/rules/jsx-quotes
+        'jsx-quotes': ['error', 'prefer-double'], // specify whether double or single quotes should be used in JSX attributes https://eslint.org/docs/rules/jsx-quotes
         'key-spacing': [
             'error',
             {
@@ -152,13 +152,6 @@ module.exports = {
         ], // enforce position of line comments https://eslint.org/docs/rules/line-comment-position
         'linebreak-style': ['error', 'unix'], // disallow mixed 'LF' and 'CRLF' as linebreaks https://eslint.org/docs/rules/linebreak-style
         'lines-around-comment': 'off', // enforces empty lines around comments https://eslint.org/docs/rules/lines-around-comment
-        'lines-around-directive': [
-            'error',
-            {
-                after: 'always',
-                before: 'always'
-            }
-        ], // require or disallow newlines around directives https://eslint.org/docs/rules/lines-around-directive
         'lines-between-class-members': [
             'error',
             'always',
@@ -208,8 +201,6 @@ module.exports = {
             }
         ], // require a capital letter for constructors https://eslint.org/docs/rules/new-cap
         'new-parens': ['error', 'always'], // disallow the omission of parentheses when invoking a constructor with no arguments https://eslint.org/docs/rules/new-parens
-        'newline-after-var': 'off', // allow/disallow an empty newline after var statement https://eslint.org/docs/rules/newline-after-var
-        'newline-before-return': 'error', // https://eslint.org/docs/rules/newline-before-return
         'newline-per-chained-call': [
             'error',
             {ignoreChainWithDepth: 4}
@@ -261,7 +252,6 @@ module.exports = {
                 selector: 'WithStatement'
             }
         ], // disallow certain syntax forms https://eslint.org/docs/rules/no-restricted-syntax
-        'no-spaced-func': 'error', // disallow space between function identifier and application https://eslint.org/docs/rules/no-spaced-func
         'no-tabs': 'error', // disallow tab characters entirely https://eslint.org/docs/rules/no-tabs
         'no-ternary': 'off', // disallow the use of ternary operators https://eslint.org/docs/rules/no-ternary
         'no-trailing-spaces': 'error', // disallow trailing whitespace at the end of lines https://eslint.org/docs/rules/no-trailing-spaces
@@ -309,6 +299,21 @@ module.exports = {
                 blankLine: 'any',
                 next: ['const', 'let', 'var'],
                 prev: ['const', 'let', 'var']
+            },
+            {
+                blankLine: "always",
+                prev: "directive",
+                next: "*"
+            },
+            {
+                blankLine: "any",
+                prev: "directive",
+                next: "directive"
+            },
+            {
+                blankLine: "always",
+                prev: "*",
+                next: "return"
             }
         ], // Require or disallow padding lines between statements https://eslint.org/docs/rules/padding-line-between-statements
         'prefer-exponentiation-operator': 'error', // Disallow the use of Math.pow in favor of the ** operator https://eslint.org/docs/rules/prefer-exponentiation-operator
@@ -327,7 +332,6 @@ module.exports = {
             'single',
             {avoidEscape: true}
         ], // specify whether double or single quotes should be used
-        'require-jsdoc': 'off', // do not require jsdoc https://eslint.org/docs/rules/require-jsdoc
         semi: ['error', 'always'], // require or disallow use of semicolons instead of ASI https://eslint.org/docs/rules/semi
         'semi-spacing': [
             'error',

package/rules/typescript.js

@@ -92,7 +92,13 @@ module.exports = {
         '@typescript-eslint/no-loss-of-precision': 'error',
         '@typescript-eslint/no-misused-new': 'error',
         '@typescript-eslint/no-misused-promises': ['error', {checksVoidReturn: false}],
-        '@typescript-eslint/no-namespace': 'error',
+        '@typescript-eslint/no-namespace': [
+            'error',
+            {
+                allowDeclarations: true,
+                allowDefinitionFiles: true
+            }
+        ],
         '@typescript-eslint/no-non-null-asserted-nullish-coalescing': 'error',
         '@typescript-eslint/no-non-null-asserted-optional-chain': 'error',
         '@typescript-eslint/no-non-null-assertion': 'off',

package/rules/variables.js

@@ -4,7 +4,6 @@ const confusingBrowserGlobals = require('confusing-browser-globals');
 module.exports = {
     rules: {
         'init-declarations': 'off', // enforce or disallow variable initializations at definition https://eslint.org/docs/rules/init-declarations
-        'no-catch-shadow': 'error', // disallow the catch clause parameter name being the same as a variable in the outer scope https://eslint.org/docs/rules/no-catch-shadow
         'no-delete-var': 'error', // disallow deletion of variables https://eslint.org/docs/rules/no-delete-var
         'no-label-var': 'error', // disallow labels that share a name with a variable https://eslint.org/docs/rules/no-label-var
         'no-restricted-globals': ['error', 'isFinite', 'isNaN'].concat(confusingBrowserGlobals), // disallow specific globals https://eslint.org/docs/rules/no-restricted-globals