@nforma.ai/nforma 0.2.1 → 0.28.0

package/hooks/dist/{qgsd-circuit-breaker.js → nf-circuit-breaker.js}

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-// hooks/qgsd-circuit-breaker.js
+// hooks/nf-circuit-breaker.js
 // PreToolUse hook — oscillation detection, state persistence, and notification for circuit breaker.
 //
 // Reads JSON from stdin (Claude Code PreToolUse event payload), checks for oscillation
@@ -94,30 +94,38 @@ function getCommitDiff(gitRoot, olderHash, newerHash, files) {
 
 // Second-pass reversion check: given the hashes (newest-first) belonging to
 // run-groups for an oscillating file set key, and the files in that set,
-// determines whether the pattern is true oscillation or TDD progression.
+// determines whether the pattern is true oscillation or TDD/workflow progression.
+//
+// Algorithm: sum net change (additions - deletions) across all consecutive pairs,
+// AND track whether at least one pair has negative net change (content removal).
 //
-// Algorithm: sum net change (additions - deletions) across all consecutive pairs.
 // - Positive total net change → file grew overall → TDD progression (not oscillation).
-// - Zero or negative total net change → file didn't grow → true oscillation.
+// - Zero or negative total net change WITH at least one pair showing net deletions
+//   → true oscillation (content was added then removed).
+// - Zero or negative total net change with NO pair showing net deletions
+//   (all pairs are zero-net substitutions) → NOT oscillation. This is monotonic
+//   workflow progression (e.g., template → linter substitution → population).
 //
 // This correctly handles TDD patterns where a line like `module.exports` is modified
 // (1 deletion, 1 addition per commit) alongside net-new lines — the net change remains
 // positive because new functions are added each time.
 //
-// For true oscillation (same content toggled back and forth), each pair is symmetric
-// (same number added as removed) so the total net change is zero.
+// For true oscillation (same content toggled back and forth), at least one pair
+// will show a net-negative change (lines removed that were added in a prior pair).
 //
 // hashes: all commit hashes (newest-first) in the oscillating run-groups
 // files: file paths in the oscillating set
 // gitRoot: git repository root
 //
-// Returns true if real oscillation (net change <= 0), false if TDD progression (net change > 0).
+// Returns true if real oscillation (net change <= 0 AND at least one negative pair).
+// Returns false if all pairs are zero-net substitutions (monotonic workflow progression).
 // Returns true also if ALL pairs errored out (git unavailable → fall back to original behavior).
 function hasReversionInHashes(gitRoot, hashes, files) {
   // hashes are newest-first; consecutive pairs: (hashes[i], hashes[i-1]) where
   // hashes[i] is older (higher index = earlier in time), hashes[i-1] is newer.
   // We diff older → newer: git diff <hashes[i]> <hashes[i-1]>
   let totalNetChange = 0;
+  let hasNegativePair = false;
   let errorsOnly = true;
 
   for (let i = hashes.length - 1; i >= 1; i--) {
@@ -142,15 +150,18 @@ function hasReversionInHashes(gitRoot, hashes, files) {
       else if (line.startsWith('-')) deletions++;
     }
 
-    totalNetChange += (additions - deletions);
+    const pairNet = additions - deletions;
+    totalNetChange += pairNet;
+    if (pairNet < 0) hasNegativePair = true;
   }
 
   // If all pairs errored out → fall back to original behavior (treat as oscillation)
   if (errorsOnly) return true;
 
   // Positive net change → file grew overall → TDD progression, not oscillation
-  // Zero or negative net change → file didn't grow → real oscillation
-  return totalNetChange <= 0;
+  // Zero or negative net change WITH at least one negative pair → real oscillation
+  // Zero or negative net change with NO negative pair → monotonic substitution workflow, not oscillation
+  return totalNetChange <= 0 && hasNegativePair;
 }
 
 // Detects true oscillation: returns { detected: bool, fileSet: string[] }
@@ -301,7 +312,7 @@ function writeState(statePath, fileSet, snapshot) {
     };
     fs.writeFileSync(statePath, JSON.stringify(state, null, 2), 'utf8');
   } catch (e) {
-    process.stderr.write(`[qgsd] WARNING: Could not write circuit breaker state: ${e.message}\n`);
+    process.stderr.write(`[nf] WARNING: Could not write circuit breaker state: ${e.message}\n`);
     // Fail-open: do not block execution
   }
 }
@@ -329,7 +340,7 @@ function appendFalseNegative(statePath, fileSet) {
     });
     fs.writeFileSync(fnLogPath, JSON.stringify(existing, null, 2), 'utf8');
   } catch (e) {
-    process.stderr.write(`[qgsd] WARNING: Could not write false-negative log: ${e.message}\n`);
+    process.stderr.write(`[nf] WARNING: Could not write false-negative log: ${e.message}\n`);
     // Fail-open: do not block execution
   }
 }
@@ -352,7 +363,7 @@ function writeOscillationLog(logPath, log) {
     fs.mkdirSync(path.dirname(logPath), { recursive: true });
     fs.writeFileSync(logPath, JSON.stringify(log, null, 2), 'utf8');
   } catch (e) {
-    process.stderr.write(`[qgsd] WARNING: Could not write oscillation log: ${e.message}\n`);
+    process.stderr.write(`[nf] WARNING: Could not write oscillation log: ${e.message}\n`);
   }
 }
 
@@ -387,7 +398,7 @@ function appendConformanceEvent(event) {
     const logPath = pp.resolve(process.cwd(), 'conformance-events');
     fs.appendFileSync(logPath, JSON.stringify(event) + '\n', 'utf8');
   } catch (err) {
-    process.stderr.write('[qgsd] conformance log write failed: ' + err.message + '\n');
+    process.stderr.write('[nf] conformance log write failed: ' + err.message + '\n');
   }
 }
 
@@ -416,12 +427,12 @@ function buildBlockReason(state) {
     lines.push('');
   }
   lines.push(
-    'Invoke Oscillation Resolution Mode per R5 in CLAUDE.md — see qgsd-core/workflows/oscillation-resolution-mode.md for the full procedure.',
+    'Invoke Oscillation Resolution Mode per R5 in CLAUDE.md — see core/workflows/oscillation-resolution-mode.md for the full procedure.',
     '',
     'Read-only operations are still allowed (e.g. git log --oneline to review the commit history).',
     'You must manually commit a root-cause fix before write operations are unblocked.',
     '',
-    "After committing the fix, run 'npx qgsd --reset-breaker' to clear the circuit breaker state.",
+    "After committing the fix, run 'npx nforma --reset-breaker' to clear the circuit breaker state.",
   );
   return lines.join('\n');
 }
@@ -453,11 +464,11 @@ function buildWarningNotice(state) {
   }
 
   lines.push(
-    'Invoke Oscillation Resolution Mode per R5 in CLAUDE.md — see qgsd-core/workflows/oscillation-resolution-mode.md for the full procedure.',
+    'Invoke Oscillation Resolution Mode per R5 in CLAUDE.md — see core/workflows/oscillation-resolution-mode.md for the full procedure.',
     '',
-    'After committing the fix, run \'npx qgsd --reset-breaker\' to clear the circuit breaker state.',
-    'To temporarily disable the circuit breaker for deliberate iterative work, run \'npx qgsd --disable-breaker\'.',
-    'Re-enable with \'npx qgsd --enable-breaker\' when done.'
+    'After committing the fix, run \'npx nforma --reset-breaker\' to clear the circuit breaker state.',
+    'To temporarily disable the circuit breaker for deliberate iterative work, run \'npx nforma --disable-breaker\'.',
+    'Re-enable with \'npx nforma --enable-breaker\' when done.'
   );
 
   return lines.join('\n');
@@ -568,10 +579,10 @@ req.end();
             // Clear state file so PreToolUse stops warning
             const statePath = path.join(gitRoot, '.claude', 'circuit-breaker-state.json');
             try { if (fs.existsSync(statePath)) fs.rmSync(statePath); } catch {}
-            process.stderr.write(`[qgsd] INFO: Oscillation resolved by Haiku — circuit breaker cleared.\n`);
+            process.stderr.write(`[nf] INFO: Oscillation resolved by Haiku — circuit breaker cleared.\n`);
           }
         } catch (e) {
-          process.stderr.write(`[qgsd] WARNING: PostToolUse Haiku check failed: ${e.message}\n`);
+          process.stderr.write(`[nf] WARNING: PostToolUse Haiku check failed: ${e.message}\n`);
         }
         process.exit(0);
       }
@@ -627,7 +638,7 @@ req.end();
         if (verdict === 'REFINEMENT') {
           // Haiku confirmed this is iterative refinement, not a bug loop — do not notify.
           // Log false-negative for auditability (stderr + persistent file).
-          process.stderr.write(`[qgsd] INFO: circuit breaker false-negative — Haiku classified oscillation as REFINEMENT (files: ${result.fileSet.join(', ')}). Allowing tool call to proceed.\n`);
+          process.stderr.write(`[nf] INFO: circuit breaker false-negative — Haiku classified oscillation as REFINEMENT (files: ${result.fileSet.join(', ')}). Allowing tool call to proceed.\n`);
           appendFalseNegative(statePath, result.fileSet);
           process.exit(0);
         }
@@ -656,7 +667,7 @@ req.end();
       };
       writeOscillationLog(logPath, oscLog);
 
-      // Write state so qgsd-prompt.js picks it up on next user message
+      // Write state so nf-prompt.js picks it up on next user message
       writeState(statePath, result.fileSet, fileSets);
 
       appendConformanceEvent({