@nfcard/validation 0.4.0 → 0.6.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nfcard/validation",
-  "version": "0.4.0",
+  "version": "0.6.0",
   "description": "Shared Zod validation schemas for the NFCard product family.",
   "type": "module",
   "main": "./dist/index.js",
@@ -17,7 +17,7 @@
   ],
   "dependencies": {
     "zod": "^3.24.0",
-    "@nfcard/types": "0.4.0"
+    "@nfcard/types": "0.5.0"
   },
   "devDependencies": {
     "tsup": "^8.0.0"

package/src/index.test.ts

@@ -1,5 +1,6 @@
 import { describe, expect, it } from 'vitest';
 import {
+  cardDesignSchema,
   cardElementsSchema,
   comboIdSchema,
   configurationCreateSchema,
@@ -482,12 +483,21 @@ describe('profileCreateSchema', () => {
     expect(r.success).toBe(false);
   });
 
-  it('rejects missing label', () => {
+  it('accepts a missing label (NFCARD-128 — blank profile, label set later in the editor)', () => {
     const r = profileCreateSchema.safeParse({
       userData: { ...validUserData, email: '' },
       digitalConfig: validDigitalConfig,
     });
-    expect(r.success).toBe(false);
+    expect(r.success).toBe(true);
+  });
+
+  it('accepts an empty label', () => {
+    const r = profileCreateSchema.safeParse({
+      label: '',
+      userData: { ...validUserData, email: '' },
+      digitalConfig: validDigitalConfig,
+    });
+    expect(r.success).toBe(true);
   });
 });
 
@@ -676,3 +686,92 @@ describe('hubConfigSchema', () => {
     expect(hubConfigSchema.safeParse({ avatarUrl: '' }).success).toBe(true);
   });
 });
+
+// ── cardDesign (cardgen interop, FOXHOLE-810) ───────────────────
+
+const validCardDesign = {
+  material: '3dprint_standard' as const,
+  designType: 'custom' as const,
+  thicknessMm: 1.8,
+  pattern: {
+    family: 'spiral' as const,
+    variant: 'pulse' as const,
+    density: 0.55,
+    holeMinMm: 0.6,
+    holeMaxMm: 2.0,
+    intensity: 0.5,
+    cellShape: 0 as const,
+    cellRotationDeg: 0,
+    chipShape: 0 as const,
+    chipRotationDeg: 0,
+  },
+  layout: { chipAnchor: { col: 0 as const, row: 1 as const } },
+  filaments: { background: '#F2F1ED', text: '#1A1A1A', accent: '#3FA34D' },
+};
+
+const valid3dPhysicalConfig = {
+  material: '3dprint_standard' as const,
+  colour: '#F2F1ED',
+  comboId: 'A1' as const,
+  frontElements: validCardElements,
+  backElements: validCardElements,
+};
+
+describe('cardDesignSchema', () => {
+  it('accepts a valid 3D card design', () => {
+    expect(cardDesignSchema.safeParse(validCardDesign).success).toBe(true);
+  });
+
+  it('accepts a solid card (pattern: null)', () => {
+    expect(
+      cardDesignSchema.safeParse({ ...validCardDesign, pattern: null }).success,
+    ).toBe(true);
+  });
+
+  it('rejects plastic (cardgen has no FDM mesh for PVC)', () => {
+    expect(
+      cardDesignSchema.safeParse({ ...validCardDesign, material: 'plastic' }).success,
+    ).toBe(false);
+  });
+
+  it('rejects holeMin > holeMax', () => {
+    const bad = { ...validCardDesign, pattern: { ...validCardDesign.pattern, holeMinMm: 3, holeMaxMm: 1 } };
+    expect(cardDesignSchema.safeParse(bad).success).toBe(false);
+  });
+
+  it('rejects an unknown pattern family', () => {
+    const bad = { ...validCardDesign, pattern: { ...validCardDesign.pattern, family: 'mosaic' } };
+    expect(cardDesignSchema.safeParse(bad).success).toBe(false);
+  });
+
+  it('rejects a chip anchor outside 0..2', () => {
+    const bad = { ...validCardDesign, layout: { chipAnchor: { col: 3, row: 1 } } };
+    expect(cardDesignSchema.safeParse(bad).success).toBe(false);
+  });
+
+  it('rejects a non-hex filament', () => {
+    const bad = { ...validCardDesign, filaments: { ...validCardDesign.filaments, accent: 'green' } };
+    expect(cardDesignSchema.safeParse(bad).success).toBe(false);
+  });
+});
+
+describe('physicalConfig.cardDesign (nested, not stripped)', () => {
+  it('accepts a 3D physicalConfig carrying a matching cardDesign', () => {
+    const res = physicalConfigSchema.safeParse({ ...valid3dPhysicalConfig, cardDesign: validCardDesign });
+    expect(res.success).toBe(true);
+    // and it survives (not stripped):
+    if (res.success) expect(res.data.cardDesign?.material).toBe('3dprint_standard');
+  });
+
+  it('rejects a cardDesign whose material disagrees with the card', () => {
+    const res = physicalConfigSchema.safeParse({
+      ...valid3dPhysicalConfig,
+      cardDesign: { ...validCardDesign, material: 'metal' },
+    });
+    expect(res.success).toBe(false);
+  });
+
+  it('still accepts a legacy physicalConfig with no cardDesign', () => {
+    expect(physicalConfigSchema.safeParse(validPhysicalConfig).success).toBe(true);
+  });
+});