@nfcard/validation 0.16.0 → 0.17.0

package/package.json

@@ -1,39 +1,45 @@
-{
-  "name": "@nfcard/validation",
-  "version": "0.16.0",
-  "description": "Shared Zod validation schemas for the NFCard product family.",
-  "type": "module",
-  "main": "./dist/index.js",
-  "types": "./dist/index.d.ts",
-  "exports": {
-    ".": {
-      "import": "./dist/index.js",
-      "types": "./dist/index.d.ts"
-    }
-  },
-  "files": [
-    "dist",
-    "src"
-  ],
-  "dependencies": {
-    "zod": "^3.24.0",
-    "@nfcard/types": "0.13.0"
-  },
-  "devDependencies": {
-    "tsup": "^8.0.0"
-  },
-  "publishConfig": {
-    "access": "public",
-    "registry": "https://registry.npmjs.org/"
-  },
-  "repository": {
-    "type": "git",
-    "url": "https://bitbucket.org/fox-hole/nfcard-shared.git",
-    "directory": "validation"
-  },
-  "scripts": {
-    "test": "vitest run",
-    "test:watch": "vitest",
-    "build": "tsup src/index.ts --format esm --dts --clean"
-  }
-}
+{
+  "name": "@nfcard/validation",
+  "version": "0.17.0",
+  "description": "Shared Zod validation schemas for the NFCard product family.",
+  "type": "module",
+  "main": "./src/index.ts",
+  "types": "./src/index.ts",
+  "exports": {
+    ".": "./src/index.ts"
+  },
+  "files": [
+    "dist",
+    "src"
+  ],
+  "scripts": {
+    "test": "vitest run",
+    "test:watch": "vitest",
+    "build": "tsup src/index.ts --format esm --dts --clean",
+    "prepublishOnly": "pnpm build"
+  },
+  "dependencies": {
+    "zod": "^3.24.0",
+    "@nfcard/types": "workspace:*"
+  },
+  "devDependencies": {
+    "tsup": "^8.0.0"
+  },
+  "publishConfig": {
+    "access": "public",
+    "registry": "https://registry.npmjs.org/",
+    "main": "./dist/index.js",
+    "types": "./dist/index.d.ts",
+    "exports": {
+      ".": {
+        "import": "./dist/index.js",
+        "types": "./dist/index.d.ts"
+      }
+    }
+  },
+  "repository": {
+    "type": "git",
+    "url": "https://bitbucket.org/fox-hole/nfcard-shared.git",
+    "directory": "validation"
+  }
+}

package/src/elements.test.ts

@@ -81,6 +81,22 @@ describe('cardDesignSchema — free-transform element layer (NFCARD-197/198)', (
     expect(res.success).toBe(true)
   })
 
+  it('NFCARD-480: accepts a HIDDEN chip (shape -1) — the order gate must not 400 it', () => {
+    const res = cardDesignSchema.safeParse(withElements([chipEl({ shape: -1 }), textEl(), qrEl()]))
+    expect(res.success).toBe(true)
+  })
+
+  it('NFCARD-480: a CELL never takes the hidden sentinel (cellShape -1 still rejected)', () => {
+    const validPattern = {
+      family: 'spiral', variant: 'pulse', density: 0.3, holeMinMm: 0.5, holeMaxMm: 1.8,
+      intensity: 0.5, cellShape: 0, cellRotationDeg: 0, chipShape: 0, chipRotationDeg: 0,
+    }
+    expect(cardDesignSchema.safeParse(withElements([chipEl()], { pattern: validPattern })).success).toBe(true)
+    const res = cardDesignSchema.safeParse(withElements([chipEl()], { pattern: { ...validPattern, cellShape: -1 } }))
+    expect(res.success).toBe(false)
+    expect(codes(res)).toContain('cellSidesRange')
+  })
+
   it('rejects a QR below the scannable size floor', () => {
     const res = cardDesignSchema.safeParse(withElements([chipEl(), qrEl({ sizeMm: 12 })]))
     expect(res.success).toBe(false)

package/src/index.test.ts

@@ -974,104 +974,104 @@ describe('physicalConfig.cardDesign (nested, not stripped)', () => {
     expect(physicalConfigSchema.safeParse(validPhysicalConfig).success).toBe(true);
   });
 });
-
-// -- entrySourceSchema (NFCARD-392) --------------------------------
-
-describe('entrySourceSchema on configurationCreateSchema', () => {
-  const base = {
-    sessionId: '550e8400-e29b-41d4-a716-446655440000',
-    userData: validUserData,
-    physicalConfig: validPhysicalConfig,
-    digitalConfig: validDigitalConfig,
-  };
-
-  it('accepts a full entry-attribution blob', () => {
-    const r = configurationCreateSchema.safeParse({
-      ...base,
-      entrySource: {
-        output: 'with-card',
-        entryFlow: 'order',
-        ref: 'PROMO24',
-        path: '/configurator',
-        referrer: 'google.com',
-        utm: { utm_source: 'ads', utm_campaign: 'launch' },
-      },
-    });
-    expect(r.success).toBe(true);
-    if (r.success) expect(r.data.entrySource?.output).toBe('with-card');
-  });
-
-  it('is optional — older clients omit it entirely', () => {
-    const r = configurationCreateSchema.safeParse(base);
-    expect(r.success).toBe(true);
-    if (r.success) expect(r.data.entrySource).toBeUndefined();
-  });
-
-  it('rejects unknown keys (strict) and out-of-enum values', () => {
-    expect(
-      configurationCreateSchema.safeParse({
-        ...base,
-        entrySource: { output: 'with-card', evil: 'payload' },
-      }).success,
-    ).toBe(false);
-    expect(
-      configurationCreateSchema.safeParse({
-        ...base,
-        entrySource: { output: 'both-please' },
-      }).success,
-    ).toBe(false);
-  });
-
-  it('bounds the utm map (max 10 entries, capped value length)', () => {
-    const utm: Record<string, string> = {};
-    for (let i = 0; i < 11; i++) utm['k' + i] = 'v';
-    expect(
-      configurationCreateSchema.safeParse({ ...base, entrySource: { utm } }).success,
-    ).toBe(false);
-    expect(
-      configurationCreateSchema.safeParse({
-        ...base,
-        entrySource: { referrer: 'x'.repeat(300) },
-      }).success,
-    ).toBe(false);
-  });
-
-  it('is create-only: the update schema strips/ignores it', () => {
-    const r = configurationUpdateSchema.safeParse({
-      entrySource: { output: 'with-card' },
-    });
-    // z.object strips unknown keys by default - the field must not survive.
-    expect(r.success).toBe(true);
-    if (r.success) expect((r.data as Record<string, unknown>).entrySource).toBeUndefined();
-  });
-});
-
-describe('entrySourceSchema material/template preselects (NFCARD-393)', () => {
-  const base = {
-    sessionId: '550e8400-e29b-41d4-a716-446655440000',
-    userData: validUserData,
-    physicalConfig: validPhysicalConfig,
-    digitalConfig: validDigitalConfig,
-  };
-
-  it('accepts the deep-link preselects', () => {
-    const r = configurationCreateSchema.safeParse({
-      ...base,
-      entrySource: { output: 'with-card', material: '3dprint_standard', template: 'tpl-pvc-white' },
-    });
-    expect(r.success).toBe(true);
-    if (r.success) {
-      expect(r.data.entrySource?.material).toBe('3dprint_standard');
-      expect(r.data.entrySource?.template).toBe('tpl-pvc-white');
-    }
-  });
-
-  it('rejects a non-enum material', () => {
-    expect(
-      configurationCreateSchema.safeParse({
-        ...base,
-        entrySource: { material: 'carbon-fiber' },
-      }).success,
-    ).toBe(false);
-  });
-});
+
+// -- entrySourceSchema (NFCARD-392) --------------------------------
+
+describe('entrySourceSchema on configurationCreateSchema', () => {
+  const base = {
+    sessionId: '550e8400-e29b-41d4-a716-446655440000',
+    userData: validUserData,
+    physicalConfig: validPhysicalConfig,
+    digitalConfig: validDigitalConfig,
+  };
+
+  it('accepts a full entry-attribution blob', () => {
+    const r = configurationCreateSchema.safeParse({
+      ...base,
+      entrySource: {
+        output: 'with-card',
+        entryFlow: 'order',
+        ref: 'PROMO24',
+        path: '/configurator',
+        referrer: 'google.com',
+        utm: { utm_source: 'ads', utm_campaign: 'launch' },
+      },
+    });
+    expect(r.success).toBe(true);
+    if (r.success) expect(r.data.entrySource?.output).toBe('with-card');
+  });
+
+  it('is optional — older clients omit it entirely', () => {
+    const r = configurationCreateSchema.safeParse(base);
+    expect(r.success).toBe(true);
+    if (r.success) expect(r.data.entrySource).toBeUndefined();
+  });
+
+  it('rejects unknown keys (strict) and out-of-enum values', () => {
+    expect(
+      configurationCreateSchema.safeParse({
+        ...base,
+        entrySource: { output: 'with-card', evil: 'payload' },
+      }).success,
+    ).toBe(false);
+    expect(
+      configurationCreateSchema.safeParse({
+        ...base,
+        entrySource: { output: 'both-please' },
+      }).success,
+    ).toBe(false);
+  });
+
+  it('bounds the utm map (max 10 entries, capped value length)', () => {
+    const utm: Record<string, string> = {};
+    for (let i = 0; i < 11; i++) utm['k' + i] = 'v';
+    expect(
+      configurationCreateSchema.safeParse({ ...base, entrySource: { utm } }).success,
+    ).toBe(false);
+    expect(
+      configurationCreateSchema.safeParse({
+        ...base,
+        entrySource: { referrer: 'x'.repeat(300) },
+      }).success,
+    ).toBe(false);
+  });
+
+  it('is create-only: the update schema strips/ignores it', () => {
+    const r = configurationUpdateSchema.safeParse({
+      entrySource: { output: 'with-card' },
+    });
+    // z.object strips unknown keys by default - the field must not survive.
+    expect(r.success).toBe(true);
+    if (r.success) expect((r.data as Record<string, unknown>).entrySource).toBeUndefined();
+  });
+});
+
+describe('entrySourceSchema material/template preselects (NFCARD-393)', () => {
+  const base = {
+    sessionId: '550e8400-e29b-41d4-a716-446655440000',
+    userData: validUserData,
+    physicalConfig: validPhysicalConfig,
+    digitalConfig: validDigitalConfig,
+  };
+
+  it('accepts the deep-link preselects', () => {
+    const r = configurationCreateSchema.safeParse({
+      ...base,
+      entrySource: { output: 'with-card', material: '3dprint_standard', template: 'tpl-pvc-white' },
+    });
+    expect(r.success).toBe(true);
+    if (r.success) {
+      expect(r.data.entrySource?.material).toBe('3dprint_standard');
+      expect(r.data.entrySource?.template).toBe('tpl-pvc-white');
+    }
+  });
+
+  it('rejects a non-enum material', () => {
+    expect(
+      configurationCreateSchema.safeParse({
+        ...base,
+        entrySource: { material: 'carbon-fiber' },
+      }).success,
+    ).toBe(false);
+  });
+});