@nextlyhq/adapter-mysql 0.0.2-alpha.73 → 0.0.2-alpha.74

package/dist/index.mjs

@@ -1,5 +1,5 @@
 import { DrizzleAdapter } from "@nextlyhq/adapter-drizzle";
-import { createDatabaseError, isApplicationError, isDatabaseError, poolWaitTimeoutError } from "@nextlyhq/adapter-drizzle/types";
+import { createDatabaseError, isDatabaseError, poolWaitTimeoutError } from "@nextlyhq/adapter-drizzle/types";
 import { acceptsForShare, checkDialectVersion } from "@nextlyhq/adapter-drizzle/version-check";
 import { and, eq, getColumns } from "drizzle-orm";
 import { getTableConfig } from "drizzle-orm/mysql-core";
@@ -145,6 +145,16 @@ async function returnTransactionConnection(connection, rollbackFailed, restore)
 	else connection.destroy();
 }
 /**
+* mysql2 accepts only `local`, `Z` and `±HH:MM` spellings for its driver
+* zone, and the ones that resolve to UTC are exactly these. `local` resolves
+* to the Node process's own zone, so it agrees with a UTC session only on a
+* UTC host.
+*/
+function isUtcDriverZone(zone) {
+	if (zone === "local") return (/* @__PURE__ */ new Date()).getTimezoneOffset() === 0;
+	return zone === "Z" || zone === "+00:00" || zone === "-00:00";
+}
+/**
 * Package version
 */
 const VERSION = "0.1.0";
@@ -191,11 +201,19 @@ const MYSQL_ERROR_CODES = {
 	1146: "query",
 	1054: "query"
 };
+/** ER_LOCK_DEADLOCK: the transaction lost a race, and running it again may succeed. */
+const DEADLOCK = 1213;
 /**
-* Delay helper for retry logic.
+* The MySQL error number an error carries: its own, or that of the driver
+* error it wraps, as a classified or a Drizzle query error does.
 */
-function delay(ms) {
-	return new Promise((resolve) => setTimeout(resolve, ms));
+function errnoOf(error) {
+	for (let at = error, hops = 0; hops < 4; hops++) {
+		if (typeof at !== "object" || at === null) return void 0;
+		const errno = Reflect.get(at, "errno");
+		if (typeof errno === "number") return errno;
+		at = Reflect.get(at, "cause");
+	}
 }
 /**
 * MySQL database adapter for Nextly.
@@ -271,8 +289,14 @@ var MySqlAdapter = class extends DrizzleAdapter {
 	async connect() {
 		if (this.connected && this.pool) return;
 		try {
+			this.warnOnDriverZoneDisagreement();
 			const poolConfig = this.buildPoolConfig();
 			const pool = mysql.createPool(poolConfig);
+			pool.pool.on("connection", (connection) => {
+				connection.query("SET SESSION time_zone = '+00:00'", (error) => {
+					if (error) connection.destroy();
+				});
+			});
 			boundPoolWait(pool.pool, poolConfig.connectTimeout ?? 0);
 			this.pool = pool;
 			const connection = await this.pool.getConnection();
@@ -391,9 +415,29 @@ var MySqlAdapter = class extends DrizzleAdapter {
 	*
 	* Note: Savepoints are disabled in this adapter for safety due to
 	* MySQL's quirks with nested transactions.
+	*
+	* A call made inside another transaction's work therefore joins it flat,
+	* on its connection: its statements are the outer's. Its failure cannot be
+	* undone alone, so it fails the whole transaction, even when the outer
+	* catches it: the outer's COMMIT is refused, it rolls back, and it rejects
+	* with the error that failed the joined call; any later joined call fails
+	* with that error at once. A joined call keeps the outer's options and is
+	* never retried itself. `retryWhen` is asked first, of every error that
+	* ends an attempt, application ones included.
 	*/
-	async transaction(work, options) {
-		return this.runInFlowTransaction(() => this.runTransactionAttempts(work, options));
+	transaction(work, options) {
+		return this.openOrJoin(work, options, {
+			run: (_attempt, openedAt) => this.runAttempt(work, options, openedAt),
+			retryable: (error) => errnoOf(error) === DEADLOCK,
+			describe: (error) => {
+				const errno = errnoOf(error);
+				return {
+					label: errno === DEADLOCK ? "deadlock" : "a retryable error",
+					detail: { errno }
+				};
+			},
+			logger: this.config.logger
+		});
 	}
 	/**
 	* Runs `work` on a connection of its own, opened for it with the pool's
@@ -435,6 +479,7 @@ var MySqlAdapter = class extends DrizzleAdapter {
 		try {
 			try {
 				await connection.query("SET SESSION autocommit = 1");
+				await connection.query("SET SESSION time_zone = '+00:00'");
 				if (options?.strictSqlMode) await this.enterStrictMode(connection, {});
 			} catch (error) {
 				throw this.classifyError(error);
@@ -453,50 +498,48 @@ var MySqlAdapter = class extends DrizzleAdapter {
 			connection.destroy();
 		}
 	}
-	/** The attempts `transaction` makes, each on a connection of its own. */
-	async runTransactionAttempts(work, options) {
+	/** One attempt at an outermost transaction, on a connection of its own. */
+	async runAttempt(work, options, openedAt) {
 		const pool = this.ensurePool();
-		const maxAttempts = (options?.retryCount ?? 0) + 1;
-		const retryDelayMs = options?.retryDelayMs ?? 100;
-		let lastError;
-		for (let attempt = 1; attempt <= maxAttempts; attempt++) {
-			const connection = await this.connectFlowTransaction(() => pool.getConnection());
-			const startTime = Date.now();
-			let rollbackFailed = false;
-			const restore = {};
-			try {
-				await this.beginTransaction(connection, options, restore);
-				const result = await work(this.createTransactionContext(connection));
+		this.notePoolAccess();
+		const connection = await pool.getConnection();
+		let rollbackFailed = false;
+		const restore = {};
+		const settled = await this.settleOutermost({
+			context: this.createTransactionContext(connection),
+			join: this.joinSteps(connection),
+			openedAt,
+			begin: () => this.beginTransaction(connection, options, restore),
+			commit: async () => {
 				await connection.query("COMMIT");
-				if (this.config.logger?.debug) {
-					const durationMs = Date.now() - startTime;
-					this.config.logger.debug("Transaction committed", {
-						attempt,
-						durationMs
-					});
-				}
-				return result;
-			} catch (error) {
-				await connection.query("ROLLBACK").catch(() => {
+			},
+			rollback: async () => {
+				await connection.query("ROLLBACK").catch((rollbackError) => {
 					rollbackFailed = true;
+					throw rollbackError;
 				});
-				lastError = error;
-				if (isApplicationError(error)) throw error;
-				const mysqlError = error;
-				if (mysqlError.errno === 1213 && attempt < maxAttempts) {
-					if (this.config.logger?.warn) this.config.logger.warn(`Transaction failed with deadlock, retrying (${attempt}/${maxAttempts})`, {
-						errno: mysqlError.errno,
-						attempt
-					});
-					await delay(retryDelayMs * attempt);
-					continue;
-				}
-				throw this.classifyError(error);
-			} finally {
-				await returnTransactionConnection(connection, rollbackFailed, restore);
 			}
-		}
-		throw this.classifyError(lastError);
+		}, work, options);
+		await returnTransactionConnection(connection, rollbackFailed, restore);
+		return settled;
+	}
+	/**
+	* How a call made inside a transaction on `connection` joins it: flat, on
+	* the same connection, with nothing to send. Any failure inside it fails
+	* the whole transaction, since no savepoint can undo the part alone.
+	*/
+	joinSteps(connection) {
+		const callbackConnection = connection.connection;
+		return this.joinStepsOn(() => this.createTransactionContext(connection), (relations) => relations ? drizzle({
+			client: callbackConnection,
+			relations
+		}) : drizzle({ client: callbackConnection }), (context) => ({
+			context,
+			begin() {},
+			commit() {},
+			rollback() {},
+			dooms: () => true
+		}));
 	}
 	/**
 	* Get MySQL database capabilities.
@@ -607,17 +650,36 @@ var MySqlAdapter = class extends DrizzleAdapter {
 			"execute",
 			"getConnection"
 		]);
-		return this.trackFlowTransactions(this.pinDrizzleTransactions(onClient(callbackPool), async () => {
-			const connection = await this.connectFlowTransaction(() => pool.getConnection());
+		return this.joiningHandle(onClient(callbackPool), async () => {
+			const connection = await pool.getConnection();
 			return {
 				drizzle: onClient(connection.connection),
 				rollback: () => connection.query("ROLLBACK"),
 				release: (dirty) => {
 					if (dirty) connection.destroy();
 					else connection.release();
-				}
+				},
+				join: this.joinSteps(connection)
 			};
-		}));
+		}, relations);
+	}
+	/**
+	* Warns when a caller's configured driver zone does not agree with the
+	* pinned UTC session.
+	*
+	* mysql2's driver-level `timezone` decides how it parses the date strings
+	* the pinned session answers with and how it binds raw Date parameters, so
+	* a non-UTC spelling there would shift values a round-trip fails to
+	* cancel. The configuration is aligned to the pin (`buildConnectionConfig`
+	* sets UTC unconditionally, for pooled and standalone connections alike),
+	* never rewritten silently: the caller configured a reading, and this is
+	* where that reading is named as lost. Runs from `connect`, once per pool
+	* build — the configuration cannot change between calls.
+	*/
+	warnOnDriverZoneDisagreement() {
+		const requestedZone = this.config.timezone ?? "local";
+		if (isUtcDriverZone(requestedZone)) return;
+		this.config.logger?.warn?.(`Driver timezone "${requestedZone}" is not UTC; it is aligned to the pinned UTC session and no longer shifts reads or writes.`);
 	}
 	/**
 	* Builds mysql2 Pool configuration from adapter config.
@@ -638,7 +700,7 @@ var MySqlAdapter = class extends DrizzleAdapter {
 		const config = this.buildAddressConfig();
 		config.connectTimeout = this.config.pool?.connectionTimeoutMs ?? DEFAULT_POOL_CONFIG.connectionTimeoutMs;
 		if (this.config.ssl) config.ssl = this.buildSslConfig(this.config.ssl);
-		if (this.config.timezone) config.timezone = this.config.timezone;
+		config.timezone = "Z";
 		if (this.config.charset) config.charset = this.config.charset;
 		config.multipleStatements = false;
 		config.dateStrings = false;
@@ -901,7 +963,8 @@ var MySqlAdapter = class extends DrizzleAdapter {
 				await connection.query(`SELECT ${idColumn} FROM ${this.escapeIdentifier(table)} WHERE ${idColumn} = ? FOR UPDATE`, [id]);
 			},
 			insert: async (table, data, options) => {
-				const mapped = this.mapRowToRawSql(this.getTableObject(table), data);
+				const insertTableObj = this.resolvedTableObject(table);
+				const mapped = this.mapRowToRawSql(insertTableObj, data);
 				const columns = Object.keys(mapped);
 				const values = Object.values(mapped);
 				const placeholders = this.buildPlaceholders(values.length, 0);
@@ -909,7 +972,6 @@ var MySqlAdapter = class extends DrizzleAdapter {
 				const [result] = await connection.query(sql, values);
 				const ret = options?.returning;
 				if (Array.isArray(ret) && ret.length === 0) return;
-				const insertTableObj = this.getTableObject(table);
 				const aliases = this.dateWallClockAliases(insertTableObj, ret ?? "*");
 				const spelled = aliases.map((a) => `DATE_FORMAT(${this.escapeIdentifier(a.sqlName)}, '%Y-%m-%dT%H:%i:%s.%f') AS ${this.escapeIdentifier(a.alias)}`).join(", ");
 				const projected = !ret || ret === "*" ? "*" : this.mapColumnNamesToSql(insertTableObj, ret).map((c) => this.escapeIdentifier(c)).join(", ");
@@ -927,7 +989,7 @@ var MySqlAdapter = class extends DrizzleAdapter {
 				if (data.length === 0) return [];
 				const retMany = options?.returning;
 				const skipReread = Array.isArray(retMany) && retMany.length === 0;
-				const tableObj = this.getTableObject(table);
+				const tableObj = this.resolvedTableObject(table);
 				const mappedRecords = data.map((r) => this.mapRowToRawSql(tableObj, r));
 				const columns = Object.keys(mappedRecords[0]);
 				const allValues = [];