@nextcommerce/campaigns-os 1.43.2 → 1.47.0

package/src/commercial-parity.mjs

@@ -652,8 +652,8 @@ function recurrenceEquivalent(claim, truth) {
   if (moneyToCents(claim.amount) !== moneyToCents(truth.amount)) return false;
   if (claim.interval_count === truth.interval_count && claim.interval === truth.interval) return true;
 
-  // Uzzle's accepted monthly disclosure is the one narrow proven equivalence:
-  // its API cadence is expressed as 30 days. Do not generalize rate math.
+  // One merchant's accepted monthly disclosure is the one narrow proven
+  // equivalence: its API cadence is expressed as 30 days. Do not generalize rate math.
   return (claim.interval_count === 1 && claim.interval === "month"
       && truth.interval_count === 30 && truth.interval === "day")
     || (truth.interval_count === 1 && truth.interval === "month"
@@ -872,6 +872,52 @@ export function serializeCommercialFindings(findingsValue, options = {}) {
   return { assertions, omittedFindingCount };
 }
 
+export const RECURRING_CLAIM_ABSENT_CODE = "commercial_parity.recurring_claim_absent";
+
+/**
+ * A subscription package a page renders with no recurring claim extracted for
+ * it (#533). The diff above is silent when there is nothing to compare, which
+ * is exactly how a page whose rebill copy could not be read used to pass. This
+ * is incomplete evidence, not a mismatch: it names the package, never a price.
+ * `subscriptionRefsByPage` maps a page id to the refs the spec says recur;
+ * a capture carries the package refs its page renders as
+ * `rendered_package_refs`. A capture that failed extraction is skipped — that
+ * failure is already its own issue — and so is one with no page id: there is
+ * no page to hold its subscriptions against, and it is never keyed as "null".
+ */
+export function recurringClaimAbsences(capturesValue, subscriptionRefsByPage) {
+  const absences = [];
+  const seen = new Set();
+  partitionCaptures(capturesValue).valid.forEach((capture) => {
+    if (!present(capture.page_id)) return;
+    const pageId = String(capture.page_id);
+    const subscriptions = subscriptionRefsByPage?.get?.(pageId);
+    if (!subscriptions?.size) return;
+    const claimed = new Set(capture.recurrence_claims.map((claim) => String(claim.package_id)));
+    array(capture.rendered_package_refs).map(String).forEach((ref) => {
+      const key = `${pageId}\u0000${ref}`;
+      if (!subscriptions.has(ref) || claimed.has(ref) || seen.has(key)) return;
+      seen.add(key);
+      absences.push({ type: "recurring-claim-absent", page_id: pageId, ...(present(capture.url) ? { url: String(capture.url) } : {}), package_id: ref });
+    });
+  });
+  return absences;
+}
+
+export function recurringClaimAbsentAssertions(absences, { maxAssertions = Number.POSITIVE_INFINITY } = {}) {
+  return array(absences).slice(0, Math.max(0, maxAssertions)).map((absence) => ({
+    id: `${RECURRING_CLAIM_ABSENT_CODE}:${component(absence.page_id)}:package-${component(absence.package_id)}`,
+    family: "pricing",
+    page: absence.page_id || "campaign",
+    ...(absence.url ? { url: absence.url } : {}),
+    status: "warn",
+    severity: "warn",
+    expected: `a readable recurring (rebill) claim for subscription package ${absence.package_id}`,
+    actual: `no recurring claim extracted for package ${absence.package_id}`,
+    evidence: { type: absence.type, code: RECURRING_CLAIM_ABSENT_CODE, package_id: absence.package_id },
+  }));
+}
+
 /**
  * Build the runner-facing commercial evidence section and flat QA assertions.
  * `countsOnly` retains matched array lengths without walking claim elements.

package/src/deviation.mjs

@@ -17,6 +17,17 @@ export const DEVIATION_JOURNAL_REL_PATH = ".campaign-runtime/agent-deviations.js
 // (doctor, next, findings, telemetry, run, validate-*) never deviate.
 export const TRACKED_STAGE_COMMANDS = Object.freeze(new Set(["start", "prepare-build", "theme", "polish", "qa", "run-record"]));
 
+// Setup and metadata subcommands of a tracked command. They produce no stage
+// output, so running one outside the recommendation is not a detour:
+//   qa install-browser — installs the package-owned QA browser binary;
+//   qa policy set      — edits the packet's QA policy fields (and the
+//                        assembly report's mirror of them);
+//   qa resolve         — read-only diagnostic: prints the derived QA targets
+//                        and, unless --no-probe, probes their reachability.
+// Every other subcommand of a tracked command (`qa run`, `polish capture`,
+// `theme generate`, ...) is still compared against the recommendation.
+export const UNTRACKED_SUBCOMMANDS = Object.freeze(new Set(["qa install-browser", "qa policy", "qa resolve"]));
+
 // Commands every recommendation implicitly allows for its stage. Stage work is
 // agent/skill work, so the expected command set is small and explicit.
 const EXPECTED_COMMANDS_BY_STAGE = Object.freeze({
@@ -65,8 +76,9 @@ export function buildRecommendation({ stage, status, expectedCommands, now = new
  * Compare a pipeline-advancing command against the session's last
  * recommendation. Returns a deviation entry or null.
  */
-export function detectDeviation({ lastRecommendation, command, argvShape = [], runId = null, deviationReason = null, now = new Date() }) {
+export function detectDeviation({ lastRecommendation, command, subcommand = null, argvShape = [], runId = null, deviationReason = null, now = new Date() }) {
   if (!TRACKED_STAGE_COMMANDS.has(command)) return null;
+  if (subcommand && UNTRACKED_SUBCOMMANDS.has(`${command} ${subcommand}`)) return null;
   if (!lastRecommendation || !Array.isArray(lastRecommendation.expected_commands)) return null;
   if (lastRecommendation.expected_commands.includes(command)) return null;
   return {

package/src/diagnostic.mjs

@@ -20,7 +20,11 @@ const REASONS = new Set([
   "built_output.upsell_selector_scope", "built_output.sdk_markup.swap_with_add_to_cart",
   "built_output.sdk_markup.checkout_not_form", "built_output.sdk_markup.wrong_field_name",
   "built_output.sdk_markup.missing_selector_id_match", "built_output.script_syntax.parse_failure",
-  "built_output.script_syntax.missing_script",
+  "built_output.script_syntax.missing_script", "built_output.script_syntax.unclosed_script",
+  "built_output.script_syntax.symlink_outside_site", "source_html.producer_provenance",
+  "source_html.producer_provenance.source_type", "source_html.producer_provenance.screenshot_fallback_used",
+  "source_html.producer_provenance.semantic_section_count", "source_html.producer_provenance.material_fingerprint",
+  "source_html.producer_provenance.section_exports", "source_html.producer_provenance.waiver_inert",
 ]);
 const ACTIONS = new Set([
   "repair_target", "align_store_profile", "align_sdk_version", "repair_waiver", "waive_checkpoint",
@@ -31,7 +35,7 @@ const ACTIONS = new Set([
 ]);
 
 const RECOVERY = Object.freeze({
-  skills: { owner: "operator", action_id: "install-skills", input_needed: "Selected agent profile", instruction: "Refresh the bundled skills for that profile and restart the agent." },
+  skills: { owner: "operator", action_id: "install-skills", input_needed: "Selected agent profile", instruction: "Refresh the bundled skills for that profile, then read the SKILL.md files install-skills lists under Read now in the running session; restart the agent only if it cannot read them." },
   pin: { owner: "operator", action_id: "tooling.status", input_needed: "Reviewed toolkit version and lockfile", instruction: "Compare the installed package with the reviewed version; registry currency is not checked." },
   update: { owner: "operator", action_id: "tooling.status", input_needed: "Reviewed upstream revision", instruction: "Review and update the toolkit checkout using the existing worktree workflow." },
   doctor: { owner: "workflow_owner", action_id: "doctor", input_needed: "Local packet inputs and detailed doctor findings", instruction: "Inspect doctor locally and follow its existing owner, required inputs, and recovery actions." },