@nextcommerce/campaigns-os 1.43.1 → 1.46.0

package/src/commercial-parity.mjs

@@ -652,8 +652,8 @@ function recurrenceEquivalent(claim, truth) {
   if (moneyToCents(claim.amount) !== moneyToCents(truth.amount)) return false;
   if (claim.interval_count === truth.interval_count && claim.interval === truth.interval) return true;
 
-  // Uzzle's accepted monthly disclosure is the one narrow proven equivalence:
-  // its API cadence is expressed as 30 days. Do not generalize rate math.
+  // One merchant's accepted monthly disclosure is the one narrow proven
+  // equivalence: its API cadence is expressed as 30 days. Do not generalize rate math.
   return (claim.interval_count === 1 && claim.interval === "month"
       && truth.interval_count === 30 && truth.interval === "day")
     || (truth.interval_count === 1 && truth.interval === "month"
@@ -872,6 +872,52 @@ export function serializeCommercialFindings(findingsValue, options = {}) {
   return { assertions, omittedFindingCount };
 }
 
+export const RECURRING_CLAIM_ABSENT_CODE = "commercial_parity.recurring_claim_absent";
+
+/**
+ * A subscription package a page renders with no recurring claim extracted for
+ * it (#533). The diff above is silent when there is nothing to compare, which
+ * is exactly how a page whose rebill copy could not be read used to pass. This
+ * is incomplete evidence, not a mismatch: it names the package, never a price.
+ * `subscriptionRefsByPage` maps a page id to the refs the spec says recur;
+ * a capture carries the package refs its page renders as
+ * `rendered_package_refs`. A capture that failed extraction is skipped — that
+ * failure is already its own issue — and so is one with no page id: there is
+ * no page to hold its subscriptions against, and it is never keyed as "null".
+ */
+export function recurringClaimAbsences(capturesValue, subscriptionRefsByPage) {
+  const absences = [];
+  const seen = new Set();
+  partitionCaptures(capturesValue).valid.forEach((capture) => {
+    if (!present(capture.page_id)) return;
+    const pageId = String(capture.page_id);
+    const subscriptions = subscriptionRefsByPage?.get?.(pageId);
+    if (!subscriptions?.size) return;
+    const claimed = new Set(capture.recurrence_claims.map((claim) => String(claim.package_id)));
+    array(capture.rendered_package_refs).map(String).forEach((ref) => {
+      const key = `${pageId}\u0000${ref}`;
+      if (!subscriptions.has(ref) || claimed.has(ref) || seen.has(key)) return;
+      seen.add(key);
+      absences.push({ type: "recurring-claim-absent", page_id: pageId, ...(present(capture.url) ? { url: String(capture.url) } : {}), package_id: ref });
+    });
+  });
+  return absences;
+}
+
+export function recurringClaimAbsentAssertions(absences, { maxAssertions = Number.POSITIVE_INFINITY } = {}) {
+  return array(absences).slice(0, Math.max(0, maxAssertions)).map((absence) => ({
+    id: `${RECURRING_CLAIM_ABSENT_CODE}:${component(absence.page_id)}:package-${component(absence.package_id)}`,
+    family: "pricing",
+    page: absence.page_id || "campaign",
+    ...(absence.url ? { url: absence.url } : {}),
+    status: "warn",
+    severity: "warn",
+    expected: `a readable recurring (rebill) claim for subscription package ${absence.package_id}`,
+    actual: `no recurring claim extracted for package ${absence.package_id}`,
+    evidence: { type: absence.type, code: RECURRING_CLAIM_ABSENT_CODE, package_id: absence.package_id },
+  }));
+}
+
 /**
  * Build the runner-facing commercial evidence section and flat QA assertions.
  * `countsOnly` retains matched array lengths without walking claim elements.

package/src/design-source-package.mjs

@@ -612,7 +612,7 @@ export function synthesizeHtmlFunnelDesignSourcePackage({
         kind: "coverage_absence",
         scope: "primary_design_coverage",
         applies_to: [surface.id],
-        reason: `Page surface "${surface.id}" is template stock from the ${template.family} family: it has no design source of its own, and the build stage materialises it from that family's stock page.`,
+        reason: `Page surface "${surface.id}" is template stock from the ${template.family} family: it has no design source of its own; keep it unbuilt unless the operator opts in to materialising that family's stock page.`,
         status: "accepted",
         attributed_by: "prepare-build",
         attributed_at: null,