@nextcloud/eslint-config 9.0.0-rc.3 → 9.0.0-rc.5

package/CHANGELOG.md

@@ -25,6 +25,7 @@ Please refer to the README on how to adjust your configuration for flat config.
 * feat(no-deprecated-props): extend existing rules to support other components [\#1069](https://github.com/nextcloud-libraries/eslint-config/pull/1069) \([Antreesy](https://github.com/Antreesy)\)
 * feat(imports): add custom plugin to suggest file extensions [\#1110](https://github.com/nextcloud-libraries/eslint-config/pull/1110) \([susnux](https://github.com/susnux)\)
 * feat(filesystem): ignore all files within the `.gitignore` [\#1108](https://github.com/nextcloud-libraries/eslint-config/pull/1108) \([susnux](https://github.com/susnux)\)
+* feat(l10n-plugin): also handle vue templates [\#1113](https://github.com/nextcloud-libraries/eslint-config/pull/1113) \([susnux](https://github.com/susnux)\)
 
 ### Fixed
 * fix(codestyle): do not require splitting chains [\#951](https://github.com/nextcloud-libraries/eslint-config/pull/951)
@@ -53,6 +54,10 @@ Please refer to the README on how to adjust your configuration for flat config.
 * fix(vue): also ignore the global router link component [\#1097](https://github.com/nextcloud-libraries/eslint-config/pull/1097) \([susnux](https://github.com/susnux)\)
 * fix(no-deprecated-props): respect nextcloud/vue library version for the rule [\#1084](https://github.com/nextcloud-libraries/eslint-config/pull/1084) \([Antreesy](https://github.com/Antreesy)\)
 * fix(codestyle): replace deprecated config in `@stylistic/quotes` rule [\#1109](https://github.com/nextcloud-libraries/eslint-config/pull/1109) \([susnux](https://github.com/susnux)\)
+* fix(l10n-plugin): also check translation strings in `n` method [\#1112](https://github.com/nextcloud-libraries/eslint-config/pull/1112) \([susnux](https://github.com/susnux)\)
+* fix(filesystem): relax ignored files [\#1114](https://github.com/nextcloud-libraries/eslint-config/pull/1114) \([susnux](https://github.com/susnux)\)
+* fix(globs): adjust globs for test related files [\#1128](https://github.com/nextcloud-libraries/eslint-config/pull/1128) \([susnux](https://github.com/susnux)\)
+* fix(vue): use vue variant of `no-irregular-whitespace` [\#1129](https://github.com/nextcloud-libraries/eslint-config/pull/1129) \([susnux](https://github.com/susnux)\)
 
 ### Changed
 * Add SPDX header [#802](https://github.com/nextcloud-libraries/eslint-config/pull/802)
@@ -69,6 +74,7 @@ Please refer to the README on how to adjust your configuration for flat config.
 * ci: update workflows from organization [#1047](https://github.com/nextcloud-libraries/eslint-config/pull/1047) ([susnux](https://github.com/susnux))
 * chore: add active node version (24) to supported engines [#1066](https://github.com/nextcloud-libraries/eslint-config/pull/1066) ([susnux](https://github.com/susnux))
 * build: add common changelog formatting and documentation for it [#1067](https://github.com/nextcloud-libraries/eslint-config/pull/1067) ([susnux](https://github.com/susnux))
+* chore: lint this project as a library [\#1130](https://github.com/nextcloud-libraries/eslint-config/pull/1130) \([susnux](https://github.com/susnux)\)
 * Updated `@eslint/json` to 0.12.0
 * Updated `@stylistic/eslint-plugin` 4.2.0
 * Updated `eslint-plugin-jsdoc` to 50.6.11

package/dist/configs/filesystem.js

@@ -14,13 +14,11 @@ export const filesystem = [
     {
         name: 'nextcloud/filesystem/ignores',
         ignores: [
-            '**/coverage',
-            '**/dist',
-            '**/js',
-            '**/l10n',
-            '**/playwright-report',
-            '**/vendor',
-            '**/vendor-bin',
+            'dist/',
+            'js/',
+            'l10n/',
+            'vendor/',
+            'vendor-bin/',
             '**/package-lock.json',
         ],
     },

package/dist/configs/vue.js

@@ -35,6 +35,7 @@ export function vue(options) {
             : []),
         {
             files: GLOB_FILES_VUE,
+            name: 'nextcloud/vue/rules',
             rules: {
                 // PascalCase components names for vuejs
                 'vue/component-name-in-template-casing': [
@@ -98,14 +99,20 @@ export function vue(options) {
                 'vue/no-unused-refs': 'warn',
                 // Warn on unused props
                 'vue/no-unused-properties': 'warn',
+                // This rule does not work in vue files, we must use the vue one
+                'no-irregular-whitespace': 'off',
+                'vue/no-irregular-whitespace': 'error',
             },
-            name: 'nextcloud/vue/rules',
         },
         {
             files: GLOB_FILES_VUE,
+            name: 'nextcloud/vue/stylistic-rules',
             rules: {
                 // same as the stylistic rules but for the <template> in Vue files
                 ...Object.fromEntries(vueStylisticRules),
+                // same as in the codeStyle config but for the <template> in Vue files
+                '@nextcloud-l10n/non-breaking-space-vue': 'error',
+                '@nextcloud-l10n/enforce-ellipsis-vue': 'error',
                 // Also enforce tabs for template
                 'vue/html-indent': [
                     'error',
@@ -131,7 +138,6 @@ export function vue(options) {
                     },
                 ],
             },
-            name: 'nextcloud/vue/stylistic-rules',
         },
         {
             files: [

package/dist/globs.js

@@ -7,8 +7,10 @@ export const GLOB_FILES_TESTING = [
     '**/*.test.*',
     '**/*.spec.*',
     '**/*.cy.*',
-    '**/test',
-    '**/tests',
+    '**/test/**',
+    '**/tests/**',
+    '**/__tests__/**',
+    '**/__mocks__/**',
 ];
 /** Glob pattern for Typescript files */
 export const GLOB_FILES_TYPESCRIPT = [

package/dist/plugins/l10n/index.js

@@ -1,6 +1,9 @@
+/*!
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
 import { packageVersion } from "../../version.js";
-import RuleEllipsis from "./rules/enforce-ellipsis.js";
-import RuleNonBreakingSpace from "./rules/non-breaking-space.js";
+import { rules } from "./rules/index.js";
 /**
  * ESLint plugin to enforce consistent translations
  */
@@ -9,9 +12,6 @@ const Plugin = {
         name: '@nextcloud/l10n-plugin',
         version: packageVersion,
     },
-    rules: {
-        'non-breaking-space': RuleNonBreakingSpace,
-        'enforce-ellipsis': RuleEllipsis,
-    },
+    rules,
 };
 export default Plugin;

package/dist/plugins/l10n/rules/enforce-ellipsis-vue.d.ts

@@ -0,0 +1,7 @@
+/*!
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+import type { Rule } from 'eslint';
+declare const _default: Rule.RuleModule;
+export default _default;

package/dist/plugins/l10n/rules/enforce-ellipsis-vue.js

@@ -0,0 +1,13 @@
+/*!
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+import * as vueUtils from 'eslint-plugin-vue/lib/utils/index.js';
+import enforceEllipsis from "./enforce-ellipsis.js";
+const defineRule = (r) => r;
+export default defineRule({
+    ...enforceEllipsis,
+    create(context) {
+        return vueUtils.defineTemplateBodyVisitor(context, enforceEllipsis.create(context));
+    },
+});

package/dist/plugins/l10n/rules/enforce-ellipsis.js

@@ -7,24 +7,30 @@ export default defineRule({
         docs: {
             description: 'Enforce consistent usageof ellipsis instead of tripple dots',
         },
+        messages: {
+            shoudUseEllipsis: 'Translated strings should use ellipsis character instead of triple dots',
+        },
     },
     create(context) {
         return {
-            Literal(node) {
-                if (typeof node.value !== 'string'
-                    || node.parent.type !== 'CallExpression'
-                    || node.parent.callee.type !== 'Identifier'
-                    || node.parent.callee.name !== 't') {
+            CallExpression(node) {
+                if (node.callee.type !== 'Identifier'
+                    || (node.callee.name !== 't' && node.callee.name !== 'n')) {
                     return;
                 }
-                if (node.raw?.match(/(?<=[^.])\.\.\.(?!\.)/)) {
-                    context.report({
-                        node,
-                        message: 'Strings should ellipsis instead of triple dots',
-                        fix(fixer) {
-                            return fixer.replaceText(node, node.raw.replaceAll(/(?<=[^.])\.\.\.(?!\.)/g, '…'));
-                        },
-                    });
+                for (const argument of node.arguments) {
+                    if (argument.type !== 'Literal') {
+                        continue;
+                    }
+                    if (argument.raw?.match(/(?<=[^.])\.\.\.(?!\.)/)) {
+                        context.report({
+                            node,
+                            messageId: 'shoudUseEllipsis',
+                            fix(fixer) {
+                                return fixer.replaceText(argument, argument.raw.replaceAll(/(?<=[^.])\.\.\.(?!\.)/g, '…'));
+                            },
+                        });
+                    }
                 }
             },
         };

package/dist/plugins/l10n/rules/index.d.ts

@@ -0,0 +1,10 @@
+/*!
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+export declare const rules: {
+    'enforce-ellipsis': import("eslint").Rule.RuleModule;
+    'enforce-ellipsis-vue': import("eslint").Rule.RuleModule;
+    'non-breaking-space': import("eslint").Rule.RuleModule;
+    'non-breaking-space-vue': import("eslint").Rule.RuleModule;
+};

package/dist/plugins/l10n/rules/index.js

@@ -0,0 +1,14 @@
+/*!
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+import enforceEllipsisVue from "./enforce-ellipsis-vue.js";
+import enforceEllipsis from "./enforce-ellipsis.js";
+import nonBreakingSpaceVue from "./non-breaking-space-vue.js";
+import nonBreakingSpace from "./non-breaking-space.js";
+export const rules = {
+    'enforce-ellipsis': enforceEllipsis,
+    'enforce-ellipsis-vue': enforceEllipsisVue,
+    'non-breaking-space': nonBreakingSpace,
+    'non-breaking-space-vue': nonBreakingSpaceVue,
+};

package/dist/plugins/l10n/rules/non-breaking-space-vue.d.ts

@@ -0,0 +1,7 @@
+/*!
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+import type { Rule } from 'eslint';
+declare const _default: Rule.RuleModule;
+export default _default;

package/dist/plugins/l10n/rules/non-breaking-space-vue.js

@@ -0,0 +1,13 @@
+/*!
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+import * as vueUtils from 'eslint-plugin-vue/lib/utils/index.js';
+import nonBreakingSpace from "./non-breaking-space.js";
+const defineRule = (r) => r;
+export default defineRule({
+    ...nonBreakingSpace,
+    create(context) {
+        return vueUtils.defineTemplateBodyVisitor(context, nonBreakingSpace.create(context));
+    },
+});

package/dist/plugins/l10n/rules/non-breaking-space.js

@@ -7,6 +7,9 @@ export default defineRule({
         docs: {
             description: 'Enforce non-breaking spaces before ellipsis',
         },
+        messages: {
+            precedeWithNonbreakingSpace: 'Ellipsis must be preceded by non-breaking spaces',
+        },
     },
     create(context) {
         return {
@@ -18,7 +21,7 @@ export default defineRule({
                 if (matches && matches[1] !== ' ') {
                     context.report({
                         node,
-                        message: 'Ellipsis must be preceded by non-breaking spaces',
+                        messageId: 'precedeWithNonbreakingSpace',
                         fix(fixer) {
                             return fixer.replaceText(node, node.raw.replaceAll(/\s+…/g, ' …'));
                         },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nextcloud/eslint-config",
-  "version": "9.0.0-rc.3",
+  "version": "9.0.0-rc.5",
   "description": "Eslint shared config for nextcloud apps and libraries",
   "keywords": [
     "eslint",
@@ -44,23 +44,23 @@
   },
   "dependencies": {
     "@eslint/json": "^0.13.1",
-    "@stylistic/eslint-plugin": "^5.2.2",
+    "@stylistic/eslint-plugin": "^5.2.3",
     "eslint-config-flat-gitignore": "^2.1.0",
     "eslint-plugin-antfu": "^3.1.1",
-    "eslint-plugin-jsdoc": "^51.2.3",
+    "eslint-plugin-jsdoc": "^53.0.1",
     "eslint-plugin-perfectionist": "^4.15.0",
-    "eslint-plugin-vue": "^10.3.0",
+    "eslint-plugin-vue": "^10.4.0",
     "fast-xml-parser": "^5.2.5",
     "globals": "^16.3.0",
     "semver": "^7.7.2",
     "sort-package-json": "^3.4.0",
-    "typescript-eslint": "^8.38.0"
+    "typescript-eslint": "^8.39.0"
   },
   "devDependencies": {
-    "@types/node": "^24.1.0",
+    "@types/node": "^24.2.1",
     "@types/semver": "^7.7.0",
-    "eslint": "^9.32.0",
-    "memfs": "^4.24.0",
+    "eslint": "^9.33.0",
+    "memfs": "^4.36.0",
     "vitest": "^3.2.4"
   },
   "peerDependencies": {