@nextclaw/x-harness 0.2.50 → 0.2.52

package/SOURCE.md

@@ -1,8 +1,8 @@
 # Corresponding source
 
-Version 0.2.50, commit 574f6379381dcf0bab9269f063474771df0067ee.
+Version 0.2.52, commit b3e3310d4977db067f05ee409f58ae619f042c9a.
 
-Complete source, build scripts and dependencies: https://github.com/Peiiii/x-harness/tree/574f6379381dcf0bab9269f063474771df0067ee
+Complete source, build scripts and dependencies: https://github.com/Peiiii/x-harness/tree/b3e3310d4977db067f05ee409f58ae619f042c9a
 
 Clone this revision, run npm ci, npm run bootstrap and npm run release:build.
 

package/dist/browser-dom-capabilities.js

@@ -26,6 +26,7 @@ export class DOMCapabilities {
                 base.push(...missingMethods(this.#tab.playwright.locator("div"), [
                     "filter",
                     "count",
+                    "nth",
                     "click",
                     "innerText",
                 ]));

package/dist/browser-dom-navigation.js

@@ -30,16 +30,23 @@ export class DOMNavigation {
             posts?.length !== 1 ||
             posts[0].quoteCards?.length !== 1 ||
             posts[0].quoteCards[0].text !== command.cardText)
-            throw Error("unique-observed-quote-required");
+            throw Error(`unique-observed-quote-required:snapshot:${posts?.length ?? 0}:${posts?.[0]?.quoteCards?.length ?? 0}`);
         const article = this.#tab.playwright.getByRole("article").filter({
             has: this.#tab.playwright.locator(`a[href=${JSON.stringify(posts[0].primary)}]`),
         });
-        const card = article
+        const cards = article
             .locator('[role="link"][tabindex="0"]')
-            .filter({ visible: true, hasText: command.cardText });
-        if ((await card.count()) !== 1 ||
-            (await card.innerText()) !== command.cardText)
-            throw Error("unique-observed-quote-required");
+            .filter({ visible: true });
+        const count = await cards.count();
+        const matches = [];
+        for (let i = 0; i < count; i++) {
+            const candidate = cards.nth(i);
+            if ((await candidate.innerText()) === command.cardText)
+                matches.push(candidate);
+        }
+        if (matches.length !== 1)
+            throw Error(`unique-observed-quote-required:controls:${count}:matches:${matches.length}`);
+        const card = matches[0];
         this.#session.current = null;
         await this.#tab.playwright.expectNavigation(() => card.click(), {
             waitUntil: "commit",
@@ -64,6 +71,12 @@ export class DOMNavigation {
         return;
     }
     async handleWaitForFolder(command) {
+        if (command.selected) {
+            await this.#tab.playwright
+                .getByRole("heading", { name: command.folder, exact: true })
+                .waitFor({ state: "visible", timeoutMs: 5000 });
+            return;
+        }
         if (command.folderDiscovery) {
             // "All bookmarks" renders before the asynchronously loaded named cards.
             // Wait for any named card inside that specific menu, never an unrelated

package/dist/browser.js

@@ -138,7 +138,7 @@ export function readXSurface({ view, posts = [], targetId, replyTargetId, } = {}
                                 .querySelector?.("time")
                                 ?.getAttribute("datetime"),
                         }))
-                            .filter((card) => card.text?.trim() && card.datetime)
+                            .filter((card) => card.text?.trim())
                         : [],
                 };
             }),

package/dist/platform-collections.d.ts

@@ -9,6 +9,7 @@ export declare class PlatformCollections {
     private handleCollectSources;
     private handleReadCreator;
     private handleReadBookmarks;
+    private confirmBookmarkFolder;
     private bookmarkDiscovery;
     private waitForBookmarkLabel;
     private handleSearchSources;

package/dist/platform-collections.js

@@ -294,15 +294,9 @@ export class PlatformCollections {
                 folder,
                 controls: nav.controls,
             };
-        const selected = await this.#ready({ view: "navigation" });
-        if (selected.page === nav.page && !selected.headings?.includes(folder))
-            return {
-                status: "needsDecision",
-                complete: false,
-                missing: ["folder-selection-unconfirmed"],
-                folder,
-                page: selected.page,
-            };
+        const selected = await this.confirmBookmarkFolder(folder);
+        if (selected.status)
+            return selected;
         const value = await this.handleCollectSources(window);
         return {
             ...value,
@@ -314,6 +308,35 @@ export class PlatformCollections {
             },
         };
     }
+    async confirmBookmarkFolder(folder) {
+        let selected = await this.#ready({ view: "navigation" });
+        if (!selected.headings?.includes(folder)) {
+            try {
+                await this.#browser.act({
+                    operation: "waitForFolder",
+                    folder,
+                    selected: true,
+                });
+            }
+            catch (error) {
+                if (!/timed out|timeout/i.test(error.message))
+                    throw error;
+            }
+            selected = await this.#ready({ view: "navigation" });
+        }
+        if (!selected.headings?.includes(folder) ||
+            !/\/i\/(?:history\/)?bookmarks\//.test(selected.page ?? "") ||
+            selected.needsStateCheck ||
+            selected.alerts?.length)
+            return {
+                status: "needsDecision",
+                complete: false,
+                missing: ["folder-selection-unconfirmed"],
+                folder,
+                page: selected.page,
+            };
+        return selected;
+    }
     bookmarkDiscovery(nav) {
         const folders = nav.bookmarkFolders ?? [];
         return {

package/generated/observation.mjs

@@ -640,7 +640,7 @@ export const readXObservation = (query) => {
                                 .querySelector?.("time")
                                 ?.getAttribute("datetime"),
                         }))
-                            .filter((card) => card.text?.trim() && card.datetime)
+                            .filter((card) => card.text?.trim())
                         : [],
                 };
             }),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nextclaw/x-harness",
-  "version": "0.2.50",
+  "version": "0.2.52",
   "type": "module",
   "description": "Typed X task harness with compact business results and explicit diagnostics.",
   "main": "./dist/index.js",
@@ -42,5 +42,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "574f6379381dcf0bab9269f063474771df0067ee"
+  "gitHead": "b3e3310d4977db067f05ee409f58ae619f042c9a"
 }