@nextclaw/x-harness 0.2.49 → 0.2.51

package/SOURCE.md

@@ -1,8 +1,8 @@
 # Corresponding source
 
-Version 0.2.49, commit d4a3b2e37cebcd8bb86fd558faad4e3b2022e5ab.
+Version 0.2.51, commit 4fcb5b63209a99a05a176cc9a7242c1f7de614ea.
 
-Complete source, build scripts and dependencies: https://github.com/Peiiii/x-harness/tree/d4a3b2e37cebcd8bb86fd558faad4e3b2022e5ab
+Complete source, build scripts and dependencies: https://github.com/Peiiii/x-harness/tree/4fcb5b63209a99a05a176cc9a7242c1f7de614ea
 
 Clone this revision, run npm ci, npm run bootstrap and npm run release:build.
 

package/dist/browser-dom-capabilities.js

@@ -26,6 +26,7 @@ export class DOMCapabilities {
                 base.push(...missingMethods(this.#tab.playwright.locator("div"), [
                     "filter",
                     "count",
+                    "nth",
                     "click",
                     "innerText",
                 ]));

package/dist/browser-dom-navigation.js

@@ -30,16 +30,23 @@ export class DOMNavigation {
             posts?.length !== 1 ||
             posts[0].quoteCards?.length !== 1 ||
             posts[0].quoteCards[0].text !== command.cardText)
-            throw Error("unique-observed-quote-required");
+            throw Error(`unique-observed-quote-required:snapshot:${posts?.length ?? 0}:${posts?.[0]?.quoteCards?.length ?? 0}`);
         const article = this.#tab.playwright.getByRole("article").filter({
             has: this.#tab.playwright.locator(`a[href=${JSON.stringify(posts[0].primary)}]`),
         });
-        const card = article
+        const cards = article
             .locator('[role="link"][tabindex="0"]')
             .filter({ visible: true });
-        if ((await card.count()) !== 1 ||
-            (await card.innerText()) !== command.cardText)
-            throw Error("unique-observed-quote-required");
+        const count = await cards.count();
+        const matches = [];
+        for (let i = 0; i < count; i++) {
+            const candidate = cards.nth(i);
+            if ((await candidate.innerText()) === command.cardText)
+                matches.push(candidate);
+        }
+        if (matches.length !== 1)
+            throw Error(`unique-observed-quote-required:controls:${count}:matches:${matches.length}`);
+        const card = matches[0];
         this.#session.current = null;
         await this.#tab.playwright.expectNavigation(() => card.click(), {
             waitUntil: "commit",

package/dist/browser.js

@@ -132,10 +132,13 @@ export function readXSurface({ view, posts = [], targetId, replyTargetId, } = {}
                             .filter(visible)
                             .map((card) => ({
                             text: card.innerText,
+                            body: card.querySelector?.('[data-testid="tweetText"]')
+                                ?.innerText,
                             datetime: card
                                 .querySelector?.("time")
                                 ?.getAttribute("datetime"),
                         }))
+                            .filter((card) => card.text?.trim())
                         : [],
                 };
             }),

package/dist/platform-quote.js

@@ -1,11 +1,18 @@
 import { xURL } from "./platform-rules.js";
 export async function resolveQuotedSource(target, initial, { browser, ready, open }) {
+    const incomplete = (value) => ({
+        ...value,
+        complete: false,
+        missing: [
+            ...new Set([...(value.missing ?? []), "quoted-source-unconfirmed"]),
+        ],
+    });
     const parent = initial.posts?.find((p) => p.id === target.postId);
     if (initial.needsStateCheck ||
         initial.alerts?.length ||
         !parent ||
         parent.quoteCards?.length !== 1)
-        return initial;
+        return parent?.quoteCards?.length ? incomplete(initial) : initial;
     const card = parent.quoteCards[0];
     const destination = await browser.act({
         operation: "openQuote",
@@ -13,15 +20,29 @@ export async function resolveQuotedSource(target, initial, { browser, ready, ope
         cardText: card.text,
     });
     const id = xURL(destination.url).pathname.match(/\/status\/(\d+)$/)?.[1];
-    const source = await ready({ view: "posts", targetId: id });
-    const quoted = source.posts?.find((p) => p.id === id);
+    let source = await ready({ view: "posts", targetId: id });
+    let quoted = source.posts?.find((p) => p.id === id);
+    if (!source.needsStateCheck &&
+        !source.alerts?.length &&
+        quoted?.needsExpansion) {
+        await browser.act({ operation: "expandPost", postId: id });
+        source = await ready({ view: "posts", targetId: id });
+        quoted = source.posts?.find((p) => p.id === id);
+    }
+    const normalize = (text) => text.replace(/\s/g, "");
+    const excerpt = typeof card.body === "string" && /(?:…|\.\.\.)\s*$/.test(card.body)
+        ? normalize(card.body.replace(/(?:…|\.\.\.)\s*$/, ""))
+        : "";
+    const bodyBound = quoted?.body &&
+        (card.text.endsWith(quoted.body) ||
+            (excerpt.length >= 32 && normalize(quoted.body).startsWith(excerpt)));
     const confirmed = !source.needsStateCheck &&
         !source.alerts?.length &&
         quoted?.body &&
         !quoted.needsExpansion &&
         quoted.datetime === card.datetime &&
         card.text.includes(`@${quoted.author}`) &&
-        card.text.endsWith(quoted.body);
+        bodyBound;
     const back = await open({
         url: target.url,
         evidenceRef: {
@@ -43,5 +64,5 @@ export async function resolveQuotedSource(target, initial, { browser, ready, ope
             parentId: target.postId,
             cardText: card.text,
         };
-    return back;
+    return fresh?.quoteSource ? back : incomplete(back);
 }

package/dist/results.js

@@ -47,7 +47,7 @@ export function source(value, page) {
         }
     }
     if (raw.quoteCards)
-        out.quoteCards = list(raw.quoteCards).map((v) => pick(v, ["text", "datetime"]));
+        out.quoteCards = list(raw.quoteCards).map((v) => pick(v, ["text", "datetime", "body"]));
     if (raw.quoteSource)
         out.quoteSource = pick(raw.quoteSource, [
             "id",

package/dist/types.d.ts

@@ -44,6 +44,7 @@ export interface PostEvidence {
     quoteCards?: Array<{
         text: string;
         datetime: string;
+        body?: string;
     }>;
     quoteSource?: {
         id: string;

package/generated/observation.mjs

@@ -634,10 +634,13 @@ export const readXObservation = (query) => {
                             .filter(visible)
                             .map((card) => ({
                             text: card.innerText,
+                            body: card.querySelector?.('[data-testid="tweetText"]')
+                                ?.innerText,
                             datetime: card
                                 .querySelector?.("time")
                                 ?.getAttribute("datetime"),
                         }))
+                            .filter((card) => card.text?.trim())
                         : [],
                 };
             }),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nextclaw/x-harness",
-  "version": "0.2.49",
+  "version": "0.2.51",
   "type": "module",
   "description": "Typed X task harness with compact business results and explicit diagnostics.",
   "main": "./dist/index.js",
@@ -42,5 +42,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "d4a3b2e37cebcd8bb86fd558faad4e3b2022e5ab"
+  "gitHead": "4fcb5b63209a99a05a176cc9a7242c1f7de614ea"
 }