@nextclaw/ui 0.25.4 → 0.26.1

package/src/features/right-panel-resources/hooks/use-page-resource-actions.ts

@@ -0,0 +1,190 @@
+import { resolveAlternateWorkspaceFileViewer } from "@/features/chat";
+import { readWorkspaceFilePanelView } from "@/features/chat";
+import { useLocation, useNavigate } from "react-router-dom";
+import {
+  usePanelApps,
+  useUpdatePanelAppPreferences,
+} from "@/features/panel-apps";
+import { useAppPresenter } from "@/app/components/app-presenter-provider";
+import { viewportLayoutManager } from "@/app/managers/viewport-layout.manager";
+import { usePageNavigationStore } from "@/features/right-panel-resources/stores/page-navigation.store";
+import {
+  readPanelAppIdFromTab,
+  createChatUiResourceReferenceFromTab,
+} from "@/features/right-panel-resources/utils/right-panel-resource-uri.utils";
+import { pageResourceTab } from "@/features/right-panel-resources/managers/page-resource.manager";
+import type { PageResource } from "@/features/right-panel-resources/types/page-resource.types";
+import type {
+  ContextMenuGroup,
+  ContextMenuItem,
+} from "@/shared/components/ui/context-menu/context-menu";
+import { t } from "@/shared/lib/i18n";
+import { toast } from "sonner";
+import { createElement } from "react";
+import {
+  LayoutPanelLeft,
+  Link,
+  MessageSquarePlus,
+  PanelLeft,
+  PanelsTopLeft,
+  Pin,
+} from "lucide-react";
+
+export function usePageResourceActions() {
+  const app = useAppPresenter();
+  const navigate = useNavigate();
+  const { pathname, search } = useLocation();
+  const pins = usePageNavigationStore((state) => state.pinned);
+  const apps = usePanelApps();
+  const updatePreferences = useUpdatePanelAppPreferences();
+  return (
+    page: PageResource,
+    origin?: "main" | "global" | "workspace",
+  ): ContextMenuGroup[] => {
+    const tab = pageResourceTab(page);
+    const file = readWorkspaceFilePanelView(tab)?.file;
+    const viewer =
+      file?.viewMode === "preview"
+        ? resolveAlternateWorkspaceFileViewer(file.path, file.previewViewer)
+        : null;
+    const appId = readPanelAppIdFromTab(tab);
+    const entry = apps.data?.entries.find(
+      (candidate) => candidate.appId === appId,
+    );
+    const pinned = entry
+      ? entry.mainSidebar
+      : pins.some((item) => item.uri === page.uri);
+    const open = (location: "main" | "sidebar" | "floating") =>
+      app.pageResourceManager.open(page, location, navigate);
+    const items = [
+      {
+        key: "open-main",
+        icon: createElement(PanelsTopLeft, { className: "h-4 w-4" }),
+        label: t(
+          page.target.kind === "workspace"
+            ? "workbenchMaximize"
+            : "workbenchOpenMain",
+        ),
+        onSelect: () => open("main"),
+      },
+      ...(page.target.kind === "route"
+        ? []
+        : [
+            {
+              key: "open-sidebar",
+              icon: createElement(PanelLeft, { className: "h-4 w-4" }),
+              label: t("workbenchDock"),
+              onSelect: () => open("sidebar"),
+            },
+            {
+              key: "open-floating",
+              icon: createElement(PanelsTopLeft, { className: "h-4 w-4" }),
+              label: t("workbenchFloatView"),
+              onSelect: () => open("floating"),
+            },
+          ]),
+      {
+        key: "pin-left",
+        icon: createElement(Pin, { className: "h-4 w-4" }),
+        pressed: pinned,
+        label: t(pinned ? "pageUnpinLeft" : "pagePinLeft"),
+        disabled: Boolean(entry && updatePreferences.isPending),
+        onSelect: () => {
+          if (entry)
+            updatePreferences.mutate({
+              id: entry.id,
+              preferences: { mainSidebar: !pinned },
+            });
+          else if (pinned) app.pageResourceManager.unpin(page.uri);
+          else app.pageResourceManager.pin(page);
+          if (!pinned)
+            viewportLayoutManager.setMainSidebarAppGroupCollapsed(false);
+        },
+      },
+      ...(createChatUiResourceReferenceFromTab(tab)
+        ? [
+            {
+              key: "add-to-chat",
+              icon: createElement(MessageSquarePlus, { className: "h-4 w-4" }),
+              label: t("docBrowserAddToChat"),
+              restoreFocus: false,
+              onSelect: () =>
+                app.pageResourceManager.addToChat(page, pathname, navigate),
+            },
+          ]
+        : []),
+      {
+        key: "copy-uri",
+        icon: createElement(Link, { className: "h-4 w-4" }),
+        label: t("pageCopyUri"),
+        onSelect: () => {
+          void navigator.clipboard
+            .writeText(page.uri)
+            .catch(() => toast.error(t("pageCopyFailed")));
+        },
+      },
+    ];
+    return [
+      ...(viewer
+        ? [
+            {
+              key: "file-view",
+              items: [
+                {
+                  key: `viewer:${viewer}`,
+                  label: t(
+                    viewer === "rendered"
+                      ? "chatWorkspaceOpenPreview"
+                      : "chatWorkspaceOpenSource",
+                  ),
+                  onSelect: () =>
+                    app.pageResourceManager.openFileViewer(
+                      page,
+                      viewer,
+                      origin ??
+                        (pathname === "/resource" &&
+                        new URLSearchParams(search).get("uri") === page.uri
+                          ? "main"
+                          : undefined),
+                      navigate,
+                    ),
+                },
+              ],
+            },
+          ]
+        : []),
+      ...groupPageResourceActions(items),
+    ];
+  };
+}
+
+function groupPageResourceActions(
+  items: ContextMenuItem[],
+): ContextMenuGroup[] {
+  return [
+    {
+      key: "page-reference",
+      items: items.filter(
+        (item) => item.key === "add-to-chat" || item.key === "copy-uri",
+      ),
+    },
+    {
+      key: "page-layout",
+      items: [
+        {
+          key: "layout",
+          label: t("pageLayoutActions"),
+          icon: createElement(LayoutPanelLeft, { className: "h-4 w-4" }),
+          children: [
+            {
+              key: "placement",
+              items: items.filter(
+                (item) => item.key !== "add-to-chat" && item.key !== "copy-uri",
+              ),
+            },
+          ],
+        },
+      ],
+    },
+  ];
+}

package/src/features/right-panel-resources/index.ts

@@ -1,12 +1,5 @@
-export { RightPanelResourceHomePage } from '@/features/right-panel-resources/components/right-panel-resource-home-page';
-export { RightPanelResourceRouteResolver } from '@/features/right-panel-resources/utils/right-panel-resource-route-resolver.utils';
-export type {
-  RightPanelResourceHomeNavigationItem,
-  RightPanelResourceKind,
-  RightPanelResourceNavigationTarget,
-  RightPanelResourceTarget,
-} from '@/features/right-panel-resources/types/right-panel-resource.types';
 export {
+  createChatUiResourceReferenceFromTab,
   createPanelAppContentPath,
   createPanelAppResourceUri,
   createPanelAppRightPanelResourceTarget,
@@ -20,3 +13,23 @@ export {
   RIGHT_PANEL_PANEL_APPS_URL,
   RIGHT_PANEL_SERVICE_APPS_URL,
 } from '@/features/right-panel-resources/utils/right-panel-resource-uri.utils';
+export { RightPanelResourceHomePage } from '@/features/right-panel-resources/components/right-panel-resource-home-page';
+export { RightPanelResourceRouteResolver } from '@/features/right-panel-resources/utils/right-panel-resource-route-resolver.utils';
+export type {
+  RightPanelResourceHomeNavigationItem,
+  RightPanelResourceKind,
+  RightPanelResourceNavigationTarget,
+  RightPanelResourceTarget,
+} from '@/features/right-panel-resources/types/right-panel-resource.types';
+
+
+
+export { PageResourceIcon } from './components/page-resource-icon';
+export { PageResourceActionsMenu, PageResourceActionItems } from './components/page-resource-actions-menu';
+export { PageResourceSidebarNav } from './components/page-resource-sidebar-nav';
+export { SYSTEM_OBJECT_RESOURCE_RENDERERS } from './components/system-object-resource';
+export { WORKSPACE_FILE_PANEL_RENDERERS } from './components/workspace-file-resource';
+export { ResourcePage } from './pages/resource-page';
+export { usePageResourceActions } from './hooks/use-page-resource-actions';
+export { PageResourceManager, pageResourceTab } from './managers/page-resource.manager';
+export { pageResourceFromTarget, pageResourceFromTab, pageResourceMainPath, pageResourceFromSystemObject } from './utils/page-resource-identity.utils';

package/src/features/right-panel-resources/managers/__tests__/page-resource.manager.test.ts

@@ -0,0 +1,149 @@
+import type { ChatThreadManager } from "@/features/chat";
+import { useChatThreadStore } from "@/features/chat";
+import { nextclawClient } from "@/shared/lib/api";
+import { beforeEach, describe, expect, it, vi } from "vitest";
+import type { AppPresenter } from "@/app/presenters/app.presenter";
+import { PageResourceManager } from "@/features/right-panel-resources/managers/page-resource.manager";
+import { RightPanelResourceRouteResolver } from "@/features/right-panel-resources/utils/right-panel-resource-route-resolver.utils";
+import { usePageNavigationStore } from "@/features/right-panel-resources/stores/page-navigation.store";
+import { useDocBrowserStore } from "@/shared/components/doc-browser/stores/doc-browser.store";
+import { createDefaultDocBrowserState } from "@/shared/components/doc-browser/utils/doc-browser-state.utils";
+import { pageResourceTab } from "@/features/right-panel-resources/managers/page-resource.manager";
+import {
+  buildSessionPanelUrl,
+  buildSessionPath,
+} from "@/features/chat";
+
+function setup() {
+  const app = {
+    rightPanelResourceRouteResolver: new RightPanelResourceRouteResolver(),
+    docBrowserManager: { openTarget: vi.fn() },
+    workbenchSurfaceManager: {
+      restore: vi.fn(),
+      toggleMaximize: vi.fn(),
+      place: vi.fn(),
+      isVisible: vi.fn(() => false),
+    },
+    chatComposerIntentManager: {
+      requestUiResourceReference: vi.fn(),
+      requestFileReference: vi.fn(),
+      requestSystemObjectReference: vi.fn(),
+    },
+  };
+  return {
+    app,
+    manager: new PageResourceManager(app as unknown as AppPresenter),
+    navigate: vi.fn(),
+  };
+}
+
+describe("shared resource opening policy", () => {
+  beforeEach(() => {
+    usePageNavigationStore.setState({ pinned: [] });
+    useDocBrowserStore.setState({ snapshot: createDefaultDocBrowserState() });
+  });
+  it("opens contextual workspace pages through their owner and maximizes instead of pretending to render a separate main page", () => {
+    const { manager, app, navigate } = setup();
+    const openWorkspacePage = vi.fn(() => useChatThreadStore.getState().setSnapshot({ workspacePanelParentKey: "parent" }));
+    manager.bindWorkspace({ openWorkspacePage } as unknown as ChatThreadManager);
+    const page = manager.resolve("nextclaw://workspace?page=overview&session=parent")!;
+    manager.open(page, "main", navigate);
+    expect(openWorkspacePage).toHaveBeenCalledWith("parent", "overview");
+    expect(app.workbenchSurfaceManager.place).toHaveBeenCalledWith("session-workspace:parent", "docked");
+    expect(app.workbenchSurfaceManager.toggleMaximize).toHaveBeenCalledWith("session-workspace:parent");
+    expect(navigate).toHaveBeenCalledWith(buildSessionPath("parent"));
+  });
+  it("opens an ordinary Panel App URI in the global sidebar by default, preserving explicit main navigation", () => {
+    const { manager, app, navigate } = setup();
+    const page = manager.resolve("nextclaw://panel-app/example-notes")!;
+    expect(page.target.kind).toBe("panel-app");
+    manager.open(page, "default", navigate);
+    expect(navigate).not.toHaveBeenCalled();
+    expect(app.docBrowserManager.openTarget).toHaveBeenCalledWith(page.target, { newTab: true, placement: "docked" });
+    manager.open(page, "main", navigate);
+    expect(navigate).toHaveBeenCalledWith("/apps/panel/example-notes");
+  });
+  it("reuses an already open resource before default main navigation, while an explicit choice overrides it", () => {
+    const { manager, app, navigate } = setup();
+    const page = manager.resolve("nextclaw://panel-app/example-notes")!;
+    useDocBrowserStore.setState({
+      snapshot: {
+        ...createDefaultDocBrowserState(),
+        isOpen: true,
+        tabs: [pageResourceTab(page)],
+      },
+    });
+    manager.open(page, "default", navigate);
+    expect(app.docBrowserManager.openTarget).toHaveBeenCalledWith(page.target, {
+      newTab: true,
+    });
+    expect(navigate).not.toHaveBeenCalled();
+    manager.open(page, "main", navigate);
+    expect(navigate).toHaveBeenCalledWith("/apps/panel/example-notes");
+  });
+  it("reconstructs conversations and pins generic pages without a Panel App identity", () => {
+    const { manager, navigate } = setup();
+    const conversation = manager.resolve(
+      buildSessionPanelUrl("example-session"),
+    )!;
+    manager.open(conversation, "main", navigate);
+    expect(navigate).toHaveBeenCalledWith(buildSessionPath("example-session"));
+    const page = manager.resolve("nextclaw://page?path=%2Fskills")!;
+    manager.pin(page);
+    expect(usePageNavigationStore.getState().pinned[0].uri).toBe(page.uri);
+    manager.unpin(page.uri);
+    expect(usePageNavigationStore.getState().pinned).toEqual([]);
+  });
+  it("uses the same chat reference from resource menus and preserves current conversation context", () => {
+    const { manager, app, navigate } = setup();
+    const page = manager.resolve("nextclaw://panel-app/example-notes")!;
+    manager.addToChat(page, buildSessionPath("example-session"), navigate);
+    expect(
+      app.chatComposerIntentManager.requestUiResourceReference,
+    ).toHaveBeenCalledWith({
+      targetSessionKey: "example-session",
+      reference: expect.objectContaining({ uri: page.uri }),
+    });
+    expect(navigate).not.toHaveBeenCalled();
+  });
+  it("adds resolved object snapshots to chat without sending or substituting a generic UI reference", async () => {
+    const { manager, app, navigate } = setup();
+    const page = manager.resolve("nextclaw://objects/cron-job/existing")!;
+    const reference = {
+      uri: page.uri,
+      objectType: "cron-job",
+      objectId: "existing",
+      assetUri: "ncp://assets/exact-snapshot",
+    };
+    const resolve = vi
+      .spyOn(nextclawClient.systemObjectReferences, "resolve")
+      .mockResolvedValue(reference as never);
+    try {
+      manager.addToChat(page, "/cron", navigate);
+      await Promise.resolve();
+      await Promise.resolve();
+      expect(resolve).toHaveBeenCalledWith(page.uri);
+      expect(
+        app.chatComposerIntentManager.requestSystemObjectReference,
+      ).toHaveBeenCalledWith({ targetSessionKey: null, reference });
+      expect(
+        app.chatComposerIntentManager.requestUiResourceReference,
+      ).not.toHaveBeenCalled();
+      expect(navigate).toHaveBeenCalledWith("/chat");
+    } finally {
+      resolve.mockRestore();
+    }
+  });
+  it("rejects unsafe schemes, unknown internal resources and off-origin route escapes", () => {
+    const { manager } = setup();
+    for (const uri of [
+      "javascript:alert(1)",
+      "data:text/html,x",
+      "nextclaw://missing",
+      "nextclaw://page?path=%2F%2Fevil.test",
+      "nextclaw://page?path=%2Fresource",
+    ]) {
+      expect(manager.resolve(uri)).toBeNull();
+    }
+  });
+});