@nextclaw/ui 0.12.4 → 0.12.5

package/src/components/chat/ChatConversationPanel.test.tsx

@@ -1,10 +1,10 @@
-import { render, screen } from '@testing-library/react';
-import userEvent from '@testing-library/user-event';
-import { beforeEach, describe, expect, it, vi } from 'vitest';
-import { ChatChildSessionPanel } from '@/components/chat/chat-child-session-panel';
-import { ChatConversationPanel } from '@/components/chat/ChatConversationPanel';
-import { useChatInputStore } from '@/components/chat/stores/chat-input.store';
-import { useChatThreadStore } from '@/components/chat/stores/chat-thread.store';
+import { render, screen } from "@testing-library/react";
+import userEvent from "@testing-library/user-event";
+import { beforeEach, describe, expect, it, vi } from "vitest";
+import { ChatChildSessionPanel } from "@/components/chat/chat-child-session-panel";
+import { ChatConversationPanel } from "@/components/chat/ChatConversationPanel";
+import { useChatInputStore } from "@/components/chat/stores/chat-input.store";
+import { useChatThreadStore } from "@/components/chat/stores/chat-thread.store";
 
 const mocks = vi.hoisted(() => ({
   deleteSession: vi.fn(),
@@ -12,41 +12,44 @@ const mocks = vi.hoisted(() => ({
   createSession: vi.fn(),
   setSelectedAgentId: vi.fn(),
   setPendingSessionType: vi.fn(),
+  stickyBottomScroll: vi.fn(() => ({
+    onScroll: vi.fn(),
+  })),
   resolvedChildTabs: [
     {
-      sessionKey: 'child-session-1',
-      parentSessionKey: 'parent-session-1',
-      title: '北京天气',
-      agentId: 'weather',
-      agentDisplayName: 'Weather',
-      agentAvatarUrl: null,
+      sessionKey: "child-session-1",
+      parentSessionKey: "parent-session-1",
+      title: "北京天气",
+      agentId: "weather",
+      sessionTypeLabel: "Codex",
+      preferredModel: "openai/gpt-5.3-codex",
+      projectName: "project-alpha",
+      projectRoot: "/Users/demo/project-alpha",
     },
   ],
 }));
 
-vi.mock('@nextclaw/agent-chat-ui', async (importOriginal) => {
+vi.mock("@nextclaw/agent-chat-ui", async (importOriginal) => {
   const actual = await importOriginal();
   return {
     ...(actual as object),
-    useStickyBottomScroll: () => ({
-      onScroll: vi.fn()
-    })
+    useStickyBottomScroll: mocks.stickyBottomScroll,
   };
 });
 
-vi.mock('@/components/chat/nextclaw', () => ({
+vi.mock("@/components/chat/nextclaw", () => ({
   ChatInputBarContainer: () => <div data-testid="chat-input-bar" />,
-  ChatMessageListContainer: () => <div data-testid="chat-message-list" />
+  ChatMessageListContainer: () => <div data-testid="chat-message-list" />,
 }));
 
-vi.mock('@/components/chat/containers/chat-message-list.container', () => ({
+vi.mock("@/components/chat/containers/chat-message-list.container", () => ({
   ChatMessageListContainer: () => <div data-testid="child-chat-message-list" />,
 }));
 
-vi.mock('@/components/chat/ChatWelcome', () => ({
+vi.mock("@/components/chat/ChatWelcome", () => ({
   ChatWelcome: ({
     onCreateSession,
-    onSelectAgent
+    onSelectAgent,
   }: {
     onCreateSession: () => void;
     onSelectAgent: (agentId: string) => void;
@@ -55,87 +58,102 @@ vi.mock('@/components/chat/ChatWelcome', () => ({
       <button type="button" onClick={onCreateSession}>
         create draft session
       </button>
-      <button type="button" onClick={() => onSelectAgent('engineer')}>
+      <button type="button" onClick={() => onSelectAgent("engineer")}>
         switch draft agent
       </button>
     </div>
-  )
+  ),
 }));
 
-vi.mock('@/components/chat/presenter/chat-presenter-context', () => ({
-      usePresenter: () => ({
-        chatThreadManager: {
-          deleteSession: mocks.deleteSession,
-          goToProviders: mocks.goToProviders,
-          openSessionFromToolAction: vi.fn(),
-          selectChildSessionDetail: vi.fn(),
-          closeChildSessionDetail: vi.fn(),
-          goToParentSession: vi.fn(),
-        },
+vi.mock("@/components/chat/presenter/chat-presenter-context", () => ({
+  usePresenter: () => ({
+    chatThreadManager: {
+      deleteSession: mocks.deleteSession,
+      goToProviders: mocks.goToProviders,
+      openSessionFromToolAction: vi.fn(),
+      selectChildSessionDetail: vi.fn(),
+      closeChildSessionDetail: vi.fn(),
+      goToParentSession: vi.fn(),
+    },
     chatSessionListManager: {
       selectSession: vi.fn(),
       createSession: mocks.createSession,
-      setSelectedAgentId: mocks.setSelectedAgentId
+      setSelectedAgentId: mocks.setSelectedAgentId,
     },
     chatInputManager: {
-      setPendingSessionType: mocks.setPendingSessionType
-    }
-  })
-}));
-
-vi.mock('@/components/chat/session-header/chat-session-header-actions', () => ({
-  ChatSessionHeaderActions: () => <button aria-label="More actions" />
+      setPendingSessionType: mocks.setPendingSessionType,
+    },
+  }),
 }));
 
-vi.mock('@/components/chat/session-header/chat-session-project-badge', () => ({
-  ChatSessionProjectBadge: ({ projectName }: { projectName: string }) => <button>{projectName}</button>
+vi.mock("@/components/chat/session-header/chat-session-header-actions", () => ({
+  ChatSessionHeaderActions: () => <button aria-label="More actions" />,
 }));
 
-vi.mock('@/components/chat/ncp/session-conversation/use-ncp-child-session-tabs-view', () => ({
-  useNcpChildSessionTabsView: () => mocks.resolvedChildTabs,
+vi.mock("@/components/chat/session-header/chat-session-project-badge", () => ({
+  ChatSessionProjectBadge: ({ projectName }: { projectName: string }) => (
+    <button>{projectName}</button>
+  ),
 }));
 
-vi.mock('@/components/chat/ncp/session-conversation/use-ncp-session-conversation', () => ({
-  useNcpSessionConversation: () => ({
-    visibleMessages: [],
-    isHydrating: false,
-    hydrateError: null,
-    isRunning: false,
+vi.mock(
+  "@/components/chat/ncp/session-conversation/use-ncp-child-session-tabs-view",
+  () => ({
+    useNcpChildSessionTabsView: () => mocks.resolvedChildTabs,
   }),
-}));
+);
+
+vi.mock(
+  "@/components/chat/ncp/session-conversation/use-ncp-session-conversation",
+  () => ({
+    useNcpSessionConversation: () => ({
+      visibleMessages: [],
+      isHydrating: false,
+      hydrateError: null,
+      isRunning: false,
+    }),
+  }),
+);
 
-vi.mock('@/components/common/AgentAvatar', () => ({
+vi.mock("@/components/common/AgentAvatar", () => ({
   AgentAvatar: ({ agentId }: { agentId: string }) => (
     <div data-testid="agent-avatar">{agentId}</div>
   ),
 }));
 
-vi.mock('@/components/common/agent-identity', () => ({
+vi.mock("@/components/common/agent-identity", () => ({
   AgentIdentityAvatar: ({ agentId }: { agentId: string }) => (
     <div data-testid="agent-identity-avatar">{agentId}</div>
   ),
 }));
 
-describe('ChatConversationPanel', () => {
+describe("ChatConversationPanel", () => {
   beforeEach(() => {
     mocks.deleteSession.mockReset();
     mocks.goToProviders.mockReset();
     mocks.createSession.mockReset();
     mocks.setSelectedAgentId.mockReset();
     mocks.setPendingSessionType.mockReset();
+    mocks.stickyBottomScroll.mockClear();
     useChatInputStore.setState({
       snapshot: {
         ...useChatInputStore.getState().snapshot,
-        defaultSessionType: 'native'
-      }
+        defaultSessionType: "native",
+      },
     });
     useChatThreadStore.setState({
       snapshot: {
         ...useChatThreadStore.getState().snapshot,
         isProviderStateResolved: true,
-        modelOptions: [{ value: 'openai/gpt-5.1', modelLabel: 'gpt-5.1', providerLabel: 'OpenAI' } as never],
-        sessionTypeLabel: 'Codex',
-        sessionKey: 'draft-session-1',
+        modelOptions: [
+          {
+            value: "openai/gpt-5.1",
+            modelLabel: "gpt-5.1",
+            providerLabel: "OpenAI",
+          } as never,
+        ],
+        sessionTypeLabel: "Codex",
+        sessionKey: "draft-session-1",
         sessionDisplayName: undefined,
         agentId: null,
         agentDisplayName: null,
@@ -150,121 +168,127 @@ describe('ChatConversationPanel', () => {
         parentSessionKey: null,
         parentSessionLabel: null,
         availableAgents: [
-          { id: 'main', displayName: 'Main', runtime: 'native' },
-          { id: 'engineer', displayName: 'Engineer', runtime: 'codex' }
+          { id: "main", displayName: "Main", runtime: "native" },
+          { id: "engineer", displayName: "Engineer", runtime: "codex" },
         ],
         childSessionTabs: [],
         activeChildSessionKey: null,
-      }
+      },
     });
   });
 
-  it('shows the draft session type in the conversation header', () => {
+  it("shows the draft session type in the conversation header", () => {
     render(<ChatConversationPanel />);
 
-    expect(screen.getByText('New Task')).toBeTruthy();
-    expect(screen.getByText('Codex')).toBeTruthy();
-    expect(screen.getByLabelText('More actions')).toBeTruthy();
+    expect(screen.getByText("New Task")).toBeTruthy();
+    expect(screen.getByText("Codex")).toBeTruthy();
+    expect(screen.getByLabelText("More actions")).toBeTruthy();
   });
 
-  it('shows the selected session project badge and more actions trigger', () => {
+  it("shows the selected session project badge and more actions trigger", () => {
     useChatThreadStore.setState({
       snapshot: {
         ...useChatThreadStore.getState().snapshot,
-        sessionKey: 'session-1',
-        sessionDisplayName: 'Project Thread',
-        sessionProjectRoot: '/Users/demo/workspace/project-alpha',
-        sessionProjectName: 'project-alpha',
+        sessionKey: "session-1",
+        sessionDisplayName: "Project Thread",
+        sessionProjectRoot: "/Users/demo/workspace/project-alpha",
+        sessionProjectName: "project-alpha",
         canDeleteSession: true,
-      }
+      },
     });
 
     render(<ChatConversationPanel />);
 
-    expect(screen.getByText('Project Thread')).toBeTruthy();
-    expect(screen.getByText('project-alpha')).toBeTruthy();
-    expect(screen.getByLabelText('More actions')).toBeTruthy();
+    expect(screen.getByText("Project Thread")).toBeTruthy();
+    expect(screen.getByText("project-alpha")).toBeTruthy();
+    expect(screen.getByLabelText("More actions")).toBeTruthy();
   });
 
-  it('does not show a header agent marker for the main agent', () => {
+  it("does not show a header agent marker for the main agent", () => {
     useChatThreadStore.setState({
       snapshot: {
         ...useChatThreadStore.getState().snapshot,
-        agentId: 'main',
-        agentDisplayName: 'Main',
-      }
+        agentId: "main",
+        agentDisplayName: "Main",
+      },
     });
 
     render(<ChatConversationPanel />);
 
-    expect(screen.queryByTestId('agent-avatar')).toBeNull();
+    expect(screen.queryByTestId("agent-avatar")).toBeNull();
   });
 
-  it('shows only a lightweight avatar marker for a specialist agent', () => {
+  it("shows only a lightweight avatar marker for a specialist agent", () => {
     useChatThreadStore.setState({
       snapshot: {
         ...useChatThreadStore.getState().snapshot,
-        agentId: 'engineer',
-        agentDisplayName: 'Engineer',
-      }
+        agentId: "engineer",
+        agentDisplayName: "Engineer",
+      },
     });
 
     render(<ChatConversationPanel />);
 
-    expect(screen.getByTestId('agent-avatar').textContent).toBe('engineer');
-    expect(screen.queryByText('Engineer')).toBeNull();
+    expect(screen.getByTestId("agent-avatar").textContent).toBe("engineer");
+    expect(screen.queryByText("Engineer")).toBeNull();
   });
 
-  it('creates a draft session with the selected draft agent runtime', async () => {
+  it("creates a draft session with the selected draft agent runtime", async () => {
     const user = userEvent.setup();
 
     useChatThreadStore.setState({
       snapshot: {
         ...useChatThreadStore.getState().snapshot,
-        agentId: 'engineer',
-        agentDisplayName: 'Engineer'
-      }
+        agentId: "engineer",
+        agentDisplayName: "Engineer",
+      },
     });
 
     render(<ChatConversationPanel />);
 
-    await user.click(screen.getByRole('button', { name: 'create draft session' }));
+    await user.click(
+      screen.getByRole("button", { name: "create draft session" }),
+    );
 
-    expect(mocks.createSession).toHaveBeenCalledWith('codex');
+    expect(mocks.createSession).toHaveBeenCalledWith("codex");
   });
 
-  it('syncs the pending session type when switching the draft agent', async () => {
+  it("syncs the pending session type when switching the draft agent", async () => {
     const user = userEvent.setup();
 
     render(<ChatConversationPanel />);
 
-    await user.click(screen.getByRole('button', { name: 'switch draft agent' }));
+    await user.click(
+      screen.getByRole("button", { name: "switch draft agent" }),
+    );
 
-    expect(mocks.setSelectedAgentId).toHaveBeenCalledWith('engineer');
-    expect(mocks.setPendingSessionType).toHaveBeenCalledWith('codex');
+    expect(mocks.setSelectedAgentId).toHaveBeenCalledWith("engineer");
+    expect(mocks.setPendingSessionType).toHaveBeenCalledWith("codex");
   });
 });
 
-describe('ChatChildSessionPanel', () => {
-  it('keeps the header compact for a single child session', () => {
+describe("ChatChildSessionPanel", () => {
+  it("keeps the header compact for a single child session", () => {
     mocks.resolvedChildTabs = [
       {
-        sessionKey: 'child-session-1',
-        parentSessionKey: 'parent-session-1',
-        title: '北京天气',
-        agentId: 'weather',
-        agentDisplayName: 'Weather',
-        agentAvatarUrl: null,
+        sessionKey: "child-session-1",
+        parentSessionKey: "parent-session-1",
+        title: "北京天气",
+        agentId: "weather",
+        sessionTypeLabel: "Codex",
+        preferredModel: "openai/gpt-5.3-codex",
+        projectName: "project-alpha",
+        projectRoot: "/Users/demo/project-alpha",
       },
     ];
     render(
       <ChatChildSessionPanel
         tabs={[
           {
-            sessionKey: 'child-session-1',
-            parentSessionKey: 'parent-session-1',
-            label: '北京天气',
-            agentId: 'weather',
+            sessionKey: "child-session-1",
+            parentSessionKey: "parent-session-1",
+            label: "北京天气",
+            agentId: "weather",
           },
         ]}
         activeSessionKey="child-session-1"
@@ -274,28 +298,42 @@ describe('ChatChildSessionPanel', () => {
       />,
     );
 
-    expect(screen.getByText('北京天气')).toBeTruthy();
-    expect(screen.queryByText('Child Sessions')).toBeNull();
-    expect(screen.queryByText('child-session-1')).toBeNull();
+    expect(screen.getByText("北京天气")).toBeTruthy();
+    expect(screen.getByText("Codex")).toBeTruthy();
+    expect(screen.getByText("openai/gpt-5.3-codex")).toBeTruthy();
+    expect(screen.getByText("project-alpha")).toBeTruthy();
+    expect(screen.getByText("/Users/demo/project-alpha")).toBeTruthy();
+    expect(screen.queryByText("Child Sessions")).toBeNull();
+    expect(screen.queryByText("child-session-1")).toBeNull();
+    expect(mocks.stickyBottomScroll).toHaveBeenCalledWith(
+      expect.objectContaining({
+        resetKey: "child-session-1",
+        stickyThresholdPx: 20,
+      }),
+    );
   });
 
-  it('uses tabs as the only title layer when multiple child sessions are open', () => {
+  it("uses tabs as the only title layer when multiple child sessions are open", () => {
     mocks.resolvedChildTabs = [
       {
-        sessionKey: 'child-session-1',
-        parentSessionKey: 'parent-session-1',
-        title: '北京天气',
-        agentId: 'weather',
-        agentDisplayName: 'Weather',
-        agentAvatarUrl: null,
+        sessionKey: "child-session-1",
+        parentSessionKey: "parent-session-1",
+        title: "北京天气",
+        agentId: "weather",
+        sessionTypeLabel: "Codex",
+        preferredModel: "openai/gpt-5.3-codex",
+        projectName: "project-alpha",
+        projectRoot: "/Users/demo/project-alpha",
       },
       {
-        sessionKey: 'child-session-2',
-        parentSessionKey: 'parent-session-1',
-        title: '上海天气',
-        agentId: 'weather',
-        agentDisplayName: 'Weather',
-        agentAvatarUrl: null,
+        sessionKey: "child-session-2",
+        parentSessionKey: "parent-session-1",
+        title: "上海天气",
+        agentId: "weather",
+        sessionTypeLabel: "Claude Code",
+        preferredModel: "anthropic/claude-sonnet-4",
+        projectName: "project-beta",
+        projectRoot: "/Users/demo/project-beta",
       },
     ];
 
@@ -303,16 +341,16 @@ describe('ChatChildSessionPanel', () => {
       <ChatChildSessionPanel
         tabs={[
           {
-            sessionKey: 'child-session-1',
-            parentSessionKey: 'parent-session-1',
-            label: '北京天气',
-            agentId: 'weather',
+            sessionKey: "child-session-1",
+            parentSessionKey: "parent-session-1",
+            label: "北京天气",
+            agentId: "weather",
           },
           {
-            sessionKey: 'child-session-2',
-            parentSessionKey: 'parent-session-1',
-            label: '上海天气',
-            agentId: 'weather',
+            sessionKey: "child-session-2",
+            parentSessionKey: "parent-session-1",
+            label: "上海天气",
+            agentId: "weather",
           },
         ]}
         activeSessionKey="child-session-1"
@@ -322,13 +360,17 @@ describe('ChatChildSessionPanel', () => {
       />,
     );
 
-    expect(screen.getAllByText('北京天气')).toHaveLength(1);
-    expect(screen.getByText('上海天气')).toBeTruthy();
-    const tabButtons = screen.getAllByRole('button').filter((element) =>
-      element.getAttribute('aria-pressed') !== null,
-    );
+    expect(screen.getAllByText("北京天气")).toHaveLength(1);
+    expect(screen.getByText("上海天气")).toBeTruthy();
+    expect(screen.getByText("Codex")).toBeTruthy();
+    expect(screen.getByText("openai/gpt-5.3-codex")).toBeTruthy();
+    expect(screen.getByText("project-alpha")).toBeTruthy();
+    expect(screen.getByText("/Users/demo/project-alpha")).toBeTruthy();
+    const tabButtons = screen
+      .getAllByRole("button")
+      .filter((element) => element.getAttribute("aria-pressed") !== null);
     expect(tabButtons).toHaveLength(2);
-    expect(tabButtons[0]?.getAttribute('aria-pressed')).toBe('true');
-    expect(tabButtons[1]?.getAttribute('aria-pressed')).toBe('false');
+    expect(tabButtons[0]?.getAttribute("aria-pressed")).toBe("true");
+    expect(tabButtons[1]?.getAttribute("aria-pressed")).toBe("false");
   });
 });

package/src/components/chat/adapters/chat-message-tool-agent-id.test.ts

@@ -33,19 +33,19 @@ function adapt(uiMessages: ChatMessageSource[]) {
   });
 }
 
-it("exposes agentId on spawn call cards when the invocation args include it", () => {
+it("exposes agentId on sessions_spawn call cards when the invocation args include it", () => {
   const adapted = adapt([
     {
-      id: "assistant-spawn-call",
+      id: "assistant-sessions-spawn-call",
       role: "assistant",
       parts: [
         {
           type: "tool-invocation",
           toolInvocation: {
             status: ToolInvocationStatus.PARTIAL_CALL,
-            toolCallId: "spawn-call-args-1",
-            toolName: "spawn",
-            args: '{"agentId":"planner-agent","label":"Planner","task":"Plan the rollout"}',
+            toolCallId: "sessions-spawn-call-args-1",
+            toolName: "sessions_spawn",
+            args: '{"agentId":"planner-agent","scope":"child","title":"Planner","task":"Plan the rollout","request":{"notify":"final_reply"}}',
             result: {
               kind: "nextclaw.session_request",
               requestId: "request-3",
@@ -64,7 +64,7 @@ it("exposes agentId on spawn call cards when the invocation args include it", ()
   expect(adapted[0]?.parts[0]).toMatchObject({
     type: "tool-card",
     card: {
-      toolName: "spawn",
+      toolName: "sessions_spawn",
       agentId: "planner-agent",
       statusTone: "running",
     },
@@ -74,16 +74,16 @@ it("exposes agentId on spawn call cards when the invocation args include it", ()
 it("exposes agentId on running tool call cards even before a session-request result exists", () => {
   const adapted = adapt([
     {
-      id: "assistant-spawn-call-running",
+      id: "assistant-sessions-spawn-call-running",
       role: "assistant",
       parts: [
         {
           type: "tool-invocation",
           toolInvocation: {
             status: ToolInvocationStatus.PARTIAL_CALL,
-            toolCallId: "spawn-call-running-1",
-            toolName: "spawn",
-            args: '{"agentId":"planner-agent","task":"Plan the rollout"}',
+            toolCallId: "sessions-spawn-call-running-1",
+            toolName: "sessions_spawn",
+            args: '{"agentId":"planner-agent","scope":"child","task":"Plan the rollout"}',
           },
         },
       ],
@@ -93,7 +93,7 @@ it("exposes agentId on running tool call cards even before a session-request res
   expect(adapted[0]?.parts[0]).toMatchObject({
     type: "tool-card",
     card: {
-      toolName: "spawn",
+      toolName: "sessions_spawn",
       agentId: "planner-agent",
       statusTone: "running",
       titleLabel: "Tool Call",