@nextclaw/ui 0.12.24 → 0.12.26

package/src/features/chat/components/conversation/chat-conversation-panel.test.tsx

@@ -4,6 +4,7 @@ import { beforeEach, describe, expect, it, vi } from "vitest";
 import { ChatConversationPanel } from "@/features/chat/components/conversation/chat-conversation-panel";
 import { ChatSessionWorkspacePanel } from "@/features/chat";
 import type { ResolvedChildSessionTab } from "@/features/chat/hooks/use-ncp-child-session-tabs-view";
+import type { CronJobView } from "@/shared/lib/api";
 import { useChatInputStore } from "@/features/chat/stores/chat-input.store";
 import { useChatSessionListStore } from "@/features/chat/stores/chat-session-list.store";
 import { useChatThreadStore } from "@/features/chat/stores/chat-thread.store";
@@ -12,7 +13,11 @@ const mocks = vi.hoisted(() => ({
   deleteSession: vi.fn(),
   goToProviders: vi.fn(),
   createSession: vi.fn(() => "draft-session-2"),
+  goToChatRoot: vi.fn(),
   goToSession: vi.fn(),
+  openSessionCronPanel: vi.fn(),
+  deleteCronJob: vi.fn(),
+  cronJobs: [] as CronJobView[],
   setSelectedAgentId: vi.fn(),
   setPendingSessionType: vi.fn(),
   stickyBottomScroll: vi.fn(() => ({
@@ -43,21 +48,40 @@ vi.mock("@nextclaw/agent-chat-ui", async (importOriginal) => {
   };
 });
 
-vi.mock("@/features/chat/components/conversation/chat-input-bar.container", () => ({
-  ChatInputBarContainer: () => <div data-testid="chat-input-bar" />,
-}));
+vi.mock(
+  "@/features/chat/components/conversation/chat-input-bar.container",
+  () => ({
+    ChatInputBarContainer: () => <div data-testid="chat-input-bar" />,
+  }),
+);
 
-vi.mock("@/features/chat/components/conversation/chat-message-list.container", () => ({
-  ChatMessageListContainer: () => <div data-testid="chat-message-list" />,
-}));
+vi.mock(
+  "@/features/chat/components/conversation/chat-message-list.container",
+  () => ({
+    ChatMessageListContainer: ({
+      isSending,
+      messages,
+    }: {
+      isSending: boolean;
+      messages: readonly unknown[];
+    }) => (
+      <div
+        data-testid="chat-message-list"
+        data-message-count={String(messages.length)}
+        data-sending={String(isSending)}
+      />
+    ),
+  }),
+);
 
-vi.mock("@/features/chat/components/chat-session-workspace-file-preview", () => ({
-  ChatSessionWorkspaceFilePreview: ({
-    file,
-  }: {
-    file: { path: string };
-  }) => <div data-testid="workspace-file-preview">{file.path}</div>,
-}));
+vi.mock(
+  "@/features/chat/components/chat-session-workspace-file-preview",
+  () => ({
+    ChatSessionWorkspaceFilePreview: ({ file }: { file: { path: string } }) => (
+      <div data-testid="workspace-file-preview">{file.path}</div>
+    ),
+  }),
+);
 
 vi.mock("@/features/chat/components/chat-welcome", () => ({
   ChatWelcome: ({
@@ -81,12 +105,14 @@ vi.mock("@/features/chat/components/chat-welcome", () => ({
 vi.mock("@/features/chat/components/providers/chat-presenter.provider", () => ({
   usePresenter: () => ({
     chatUiManager: {
+      goToChatRoot: mocks.goToChatRoot,
       goToSession: mocks.goToSession,
     },
     chatThreadManager: {
       deleteSession: mocks.deleteSession,
       goToProviders: mocks.goToProviders,
       openChildSessionPanel: vi.fn(),
+      openSessionCronPanel: mocks.openSessionCronPanel,
       openFilePreview: vi.fn(),
       openSessionFromToolAction: vi.fn(),
       selectChildSessionDetail: vi.fn(),
@@ -104,10 +130,9 @@ vi.mock("@/features/chat/components/providers/chat-presenter.provider", () => ({
         readAt: string | null | undefined,
       ) =>
         sessionKey
-          ? useChatSessionListStore.getState().markSessionRead(
-              sessionKey,
-              readAt,
-            )
+          ? useChatSessionListStore
+              .getState()
+              .markSessionRead(sessionKey, readAt)
           : undefined,
     },
     chatInputManager: {
@@ -116,35 +141,45 @@ vi.mock("@/features/chat/components/providers/chat-presenter.provider", () => ({
   }),
 }));
 
-vi.mock("@/features/chat/components/conversation/session-header/chat-session-header-actions", () => ({
-  ChatSessionHeaderActions: () => <button aria-label="More actions" />,
-}));
-
-vi.mock("@/features/chat/components/conversation/session-header/chat-session-project-badge", () => ({
-  ChatSessionProjectBadge: ({ projectName }: { projectName: string }) => (
-    <button>{projectName}</button>
-  ),
+vi.mock("@/shared/hooks/use-config", () => ({
+  useCronJobs: () => ({
+    data: { jobs: mocks.cronJobs, total: mocks.cronJobs.length },
+  }),
+  useDeleteCronJob: () => ({
+    mutate: mocks.deleteCronJob,
+    isPending: false,
+  }),
 }));
 
 vi.mock(
-  "@/features/chat/hooks/use-ncp-child-session-tabs-view",
+  "@/features/chat/components/conversation/session-header/chat-session-header-actions",
   () => ({
-    useNcpChildSessionTabsView: () => mocks.resolvedChildTabs,
+    ChatSessionHeaderActions: () => <button aria-label="More actions" />,
   }),
 );
 
 vi.mock(
-  "@/features/chat/hooks/use-ncp-session-conversation",
+  "@/features/chat/components/conversation/session-header/chat-session-project-badge",
   () => ({
-    useNcpSessionConversation: () => ({
-      visibleMessages: [],
-      isHydrating: false,
-      hydrateError: null,
-      isRunning: false,
-    }),
+    ChatSessionProjectBadge: ({ projectName }: { projectName: string }) => (
+      <button>{projectName}</button>
+    ),
   }),
 );
 
+vi.mock("@/features/chat/hooks/use-ncp-child-session-tabs-view", () => ({
+  useNcpChildSessionTabsView: () => mocks.resolvedChildTabs,
+}));
+
+vi.mock("@/features/chat/hooks/use-ncp-session-conversation", () => ({
+  useNcpSessionConversation: () => ({
+    visibleMessages: [],
+    isHydrating: false,
+    hydrateError: null,
+    isRunning: false,
+  }),
+}));
+
 vi.mock("@/shared/components/common/agent-avatar", () => ({
   AgentAvatar: ({ agentId }: { agentId: string }) => (
     <div data-testid="agent-avatar">{agentId}</div>
@@ -157,66 +192,73 @@ vi.mock("@/shared/components/common/agent-identity", () => ({
   ),
 }));
 
-describe("ChatConversationPanel", () => {
-  beforeEach(() => {
-    mocks.deleteSession.mockReset();
-    mocks.goToProviders.mockReset();
-    mocks.createSession.mockReset();
-    mocks.createSession.mockReturnValue("draft-session-2");
-    mocks.goToSession.mockReset();
-    mocks.setSelectedAgentId.mockReset();
-    mocks.setPendingSessionType.mockReset();
-    mocks.stickyBottomScroll.mockClear();
-    useChatInputStore.setState({
-      snapshot: {
-        ...useChatInputStore.getState().snapshot,
-        defaultSessionType: "native",
-      },
-    });
-    useChatThreadStore.setState({
-      snapshot: {
-        ...useChatThreadStore.getState().snapshot,
-        isProviderStateResolved: true,
-        modelOptions: [
-          {
-            value: "openai/gpt-5.1",
-            modelLabel: "gpt-5.1",
-            providerLabel: "OpenAI",
-          } as never,
-        ],
-        sessionTypeLabel: "Codex",
-        sessionKey: "draft-session-1",
-        sessionDisplayName: undefined,
-        agentId: null,
-        agentDisplayName: null,
-        sessionProjectRoot: null,
-        sessionProjectName: null,
-        canDeleteSession: false,
-        isDeletePending: false,
-        isHistoryLoading: false,
-        messages: [],
-        isSending: false,
-        isAwaitingAssistantOutput: false,
-        parentSessionKey: null,
-        parentSessionLabel: null,
-        workspacePanelParentKey: null,
-        availableAgents: [
-          { id: "main", displayName: "Main", runtime: "native" },
-          { id: "engineer", displayName: "Engineer", runtime: "codex" },
-        ],
-        childSessionTabs: [],
-        activeChildSessionKey: null,
-        workspaceFileTabs: [],
-        activeWorkspaceFileKey: null,
-      },
-    });
-    useChatSessionListStore.setState({
-      optimisticReadAtBySessionKey: {},
-      snapshot: {
-        ...useChatSessionListStore.getState().snapshot,
-      },
-    });
+function resetChatConversationPanelTestState() {
+  mocks.deleteSession.mockReset();
+  mocks.goToProviders.mockReset();
+  mocks.createSession.mockReset();
+  mocks.createSession.mockReturnValue("draft-session-2");
+  mocks.goToChatRoot.mockReset();
+  mocks.goToSession.mockReset();
+  mocks.openSessionCronPanel.mockReset();
+  mocks.deleteCronJob.mockReset();
+  mocks.cronJobs = [];
+  mocks.setSelectedAgentId.mockReset();
+  mocks.setPendingSessionType.mockReset();
+  mocks.stickyBottomScroll.mockClear();
+  useChatInputStore.setState({
+    snapshot: {
+      ...useChatInputStore.getState().snapshot,
+      defaultSessionType: "native",
+    },
+  });
+  useChatThreadStore.setState({
+    snapshot: {
+      ...useChatThreadStore.getState().snapshot,
+      isProviderStateResolved: true,
+      modelOptions: [
+        {
+          value: "openai/gpt-5.1",
+          modelLabel: "gpt-5.1",
+          providerLabel: "OpenAI",
+        } as never,
+      ],
+      sessionTypeLabel: "Codex",
+      sessionKey: "draft-session-1",
+      sessionDisplayName: undefined,
+      agentId: null,
+      agentDisplayName: null,
+      sessionProjectRoot: null,
+      sessionProjectName: null,
+      canDeleteSession: false,
+      isDeletePending: false,
+      isHistoryLoading: false,
+      messages: [],
+      isSending: false,
+      isAwaitingAssistantOutput: false,
+      hasSubmittedDraftMessage: false,
+      parentSessionKey: null,
+      parentSessionLabel: null,
+      workspacePanelParentKey: null,
+      availableAgents: [
+        { id: "main", displayName: "Main", runtime: "native" },
+        { id: "engineer", displayName: "Engineer", runtime: "codex" },
+      ],
+      childSessionTabs: [],
+      activeChildSessionKey: null,
+      workspaceFileTabs: [],
+      activeWorkspaceFileKey: null,
+    },
   });
+  useChatSessionListStore.setState({
+    optimisticReadAtBySessionKey: {},
+    snapshot: {
+      ...useChatSessionListStore.getState().snapshot,
+    },
+  });
+}
+
+describe("ChatConversationPanel", () => {
+  beforeEach(resetChatConversationPanelTestState);
 
   it("shows the draft session type in the conversation header", () => {
     render(<ChatConversationPanel />);
@@ -244,10 +286,12 @@ describe("ChatConversationPanel", () => {
 
     render(<ChatConversationPanel layoutMode="mobile" />);
 
-    await user.click(screen.getByRole("button", { name: "create draft session" }));
+    await user.click(
+      screen.getByRole("button", { name: "create draft session" }),
+    );
 
     expect(mocks.createSession).toHaveBeenCalledWith("native");
-    expect(mocks.goToSession).toHaveBeenCalledWith("draft-session-2");
+    expect(mocks.goToChatRoot).toHaveBeenCalledTimes(1);
   });
 
   it("shows the selected session project badge and more actions trigger", () => {
@@ -331,7 +375,79 @@ describe("ChatConversationPanel", () => {
     expect(
       screen.queryByRole("status", { name: "Loading session history..." }),
     ).toBeNull();
-    expect(screen.queryByText("No messages yet. Send one to start.")).toBeNull();
+    expect(
+      screen.queryByText("No messages yet. Send one to start."),
+    ).toBeNull();
+  });
+
+  it("keeps the message list mounted while waiting for the first assistant token", () => {
+    useChatThreadStore.setState({
+      snapshot: {
+        ...useChatThreadStore.getState().snapshot,
+        sessionKey: "session-1",
+        messages: [
+          {
+            id: "user-1",
+            sessionId: "session-1",
+            role: "user",
+            status: "final",
+            parts: [{ type: "text", text: "hello" }],
+            timestamp: "2026-05-19T00:00:00.000Z",
+          } as never,
+        ],
+        isSending: true,
+        isAwaitingAssistantOutput: true,
+      },
+    });
+
+    render(<ChatConversationPanel />);
+
+    expect(screen.getByTestId("chat-message-list").dataset).toMatchObject({
+      messageCount: "1",
+      sending: "true",
+    });
+    expect(
+      screen.queryByText("No messages yet. Send one to start."),
+    ).toBeNull();
+  });
+
+  it("does not show assistant waiting copy before the first message is visible", () => {
+    useChatThreadStore.setState({
+      snapshot: {
+        ...useChatThreadStore.getState().snapshot,
+        sessionKey: "session-1",
+        messages: [],
+        isSending: true,
+        isAwaitingAssistantOutput: true,
+      },
+    });
+
+    render(<ChatConversationPanel />);
+
+    expect(screen.queryByTestId("chat-message-list")).toBeNull();
+    expect(
+      screen.queryByText("No messages yet. Send one to start."),
+    ).toBeNull();
+  });
+
+  it("does not reopen the welcome panel after a root draft send fails", () => {
+    useChatThreadStore.setState({
+      snapshot: {
+        ...useChatThreadStore.getState().snapshot,
+        sessionKey: null,
+        messages: [],
+        isSending: false,
+        isAwaitingAssistantOutput: false,
+        hasSubmittedDraftMessage: true,
+      },
+    });
+
+    render(<ChatConversationPanel />);
+
+    expect(screen.queryByTestId("chat-welcome")).toBeNull();
+    expect(
+      screen.queryByText("No messages yet. Send one to start."),
+    ).toBeNull();
   });
 
   it("does not render runtime lifecycle copy in the conversation alert strip", () => {
@@ -423,6 +539,7 @@ describe("ChatSessionWorkspacePanel", () => {
 
     render(
       <ChatSessionWorkspacePanel
+        sessionKey="parent-session-1"
         childSessionTabs={[
           {
             sessionKey: "child-session-1",
@@ -435,12 +552,6 @@ describe("ChatSessionWorkspacePanel", () => {
         workspaceFileTabs={[]}
         activeWorkspaceFileKey={null}
         sessionProjectRoot="/Users/demo/project-alpha"
-        onSelectSession={vi.fn()}
-        onSelectFile={vi.fn()}
-        onCloseFile={vi.fn()}
-        onClose={vi.fn()}
-        onBackToParent={vi.fn()}
-        onFileOpen={vi.fn()}
       />,
     );
 
@@ -491,6 +602,7 @@ describe("ChatSessionWorkspacePanel", () => {
 
     render(
       <ChatSessionWorkspacePanel
+        sessionKey="parent-session-1"
         childSessionTabs={[
           {
             sessionKey: "child-session-1",
@@ -509,12 +621,6 @@ describe("ChatSessionWorkspacePanel", () => {
         workspaceFileTabs={[]}
         activeWorkspaceFileKey={null}
         sessionProjectRoot="/Users/demo/project-alpha"
-        onSelectSession={vi.fn()}
-        onSelectFile={vi.fn()}
-        onCloseFile={vi.fn()}
-        onClose={vi.fn()}
-        onBackToParent={vi.fn()}
-        onFileOpen={vi.fn()}
       />,
     );
 
@@ -524,6 +630,7 @@ describe("ChatSessionWorkspacePanel", () => {
   it("shows opened files as top tabs and renders the file preview pane", () => {
     render(
       <ChatSessionWorkspacePanel
+        sessionKey="parent-session-1"
         childSessionTabs={[]}
         activeChildSessionKey={null}
         workspaceFileTabs={[
@@ -537,12 +644,6 @@ describe("ChatSessionWorkspacePanel", () => {
         ]}
         activeWorkspaceFileKey="parent-session-1::preview::README.md"
         sessionProjectRoot="/Users/demo/project-alpha"
-        onSelectSession={vi.fn()}
-        onSelectFile={vi.fn()}
-        onCloseFile={vi.fn()}
-        onClose={vi.fn()}
-        onBackToParent={vi.fn()}
-        onFileOpen={vi.fn()}
       />,
     );
 
@@ -555,4 +656,51 @@ describe("ChatSessionWorkspacePanel", () => {
       "workspace-horizontal-scrollbar",
     );
   });
+
+  it("renders session cron jobs in the workspace sidebar and deletes with a neutral confirmation", async () => {
+    const user = userEvent.setup();
+    const job: CronJobView = {
+      id: "job-1",
+      name: "Follow up",
+      enabled: true,
+      schedule: { kind: "every", everyMs: 3600000 },
+      payload: {
+        kind: "agent_turn",
+        message: "Continue this session later",
+        sessionId: "parent-session-1",
+      },
+      state: {
+        nextRunAt: "2026-05-15T10:00:00.000Z",
+        lastRunAt: null,
+        lastStatus: null,
+        lastError: null,
+      },
+      createdAt: "2026-05-15T09:00:00.000Z",
+      updatedAt: "2026-05-15T09:00:00.000Z",
+      deleteAfterRun: false,
+    };
+
+    render(
+      <ChatSessionWorkspacePanel
+        sessionKey="parent-session-1"
+        childSessionTabs={[]}
+        activeChildSessionKey={null}
+        workspaceFileTabs={[]}
+        activeWorkspaceFileKey={null}
+        activePanelKind="cron"
+        sessionCronJobs={[job]}
+        sessionProjectRoot="/Users/demo/project-alpha"
+      />,
+    );
+
+    expect(screen.getAllByText("Session cron jobs").length).toBeGreaterThan(0);
+    expect(screen.getByText("Follow up")).toBeTruthy();
+    expect(screen.getByText("Continue this session later")).toBeTruthy();
+
+    await user.click(screen.getByRole("button", { name: "Delete" }));
+    expect(screen.getByText("Delete cron job?")).toBeTruthy();
+    await user.click(screen.getAllByRole("button", { name: "Delete" }).at(-1)!);
+
+    expect(mocks.deleteCronJob).toHaveBeenCalledWith({ id: "job-1" });
+  });
 });