@nextclaw/channel-plugin-feishu 0.2.12 → 0.2.14

package/src/bot.card-action.test.ts

@@ -0,0 +1,63 @@
+import { describe, it, expect, vi } from "vitest";
+import { handleFeishuCardAction, type FeishuCardActionEvent } from "./card-action.js";
+
+// Mock resolveFeishuAccount
+vi.mock("./accounts.js", () => ({
+  resolveFeishuAccount: vi.fn().mockReturnValue({ accountId: "mock-account" }),
+}));
+
+// Mock bot.js to verify handleFeishuMessage call
+vi.mock("./bot.js", () => ({
+  handleFeishuMessage: vi.fn(),
+}));
+
+import { handleFeishuMessage } from "./bot.js";
+
+describe("Feishu Card Action Handler", () => {
+  const cfg = {} as any; // Minimal mock
+  const runtime = { log: vi.fn(), error: vi.fn() } as any;
+
+  it("handles card action with text payload", async () => {
+    const event: FeishuCardActionEvent = {
+      operator: { open_id: "u123", user_id: "uid1", union_id: "un1" },
+      token: "tok1",
+      action: { value: { text: "/ping" }, tag: "button" },
+      context: { open_id: "u123", user_id: "uid1", chat_id: "chat1" },
+    };
+
+    await handleFeishuCardAction({ cfg, event, runtime });
+
+    expect(handleFeishuMessage).toHaveBeenCalledWith(
+      expect.objectContaining({
+        event: expect.objectContaining({
+          message: expect.objectContaining({
+            content: '{"text":"/ping"}',
+            chat_id: "chat1",
+          }),
+        }),
+      }),
+    );
+  });
+
+  it("handles card action with JSON object payload", async () => {
+    const event: FeishuCardActionEvent = {
+      operator: { open_id: "u123", user_id: "uid1", union_id: "un1" },
+      token: "tok2",
+      action: { value: { key: "val" }, tag: "button" },
+      context: { open_id: "u123", user_id: "uid1", chat_id: "" },
+    };
+
+    await handleFeishuCardAction({ cfg, event, runtime });
+
+    expect(handleFeishuMessage).toHaveBeenCalledWith(
+      expect.objectContaining({
+        event: expect.objectContaining({
+          message: expect.objectContaining({
+            content: '{"text":"{\\"key\\":\\"val\\"}"}',
+            chat_id: "u123", // Fallback to open_id
+          }),
+        }),
+      }),
+    );
+  });
+});

package/src/bot.checkBotMentioned.test.ts

@@ -0,0 +1,193 @@
+import { describe, it, expect } from "vitest";
+import { parseFeishuMessageEvent } from "./bot.js";
+
+// Helper to build a minimal FeishuMessageEvent for testing
+function makeEvent(
+  chatType: "p2p" | "group" | "private",
+  mentions?: Array<{ key: string; name: string; id: { open_id?: string } }>,
+  text = "hello",
+) {
+  return {
+    sender: {
+      sender_id: { user_id: "u1", open_id: "ou_sender" },
+    },
+    message: {
+      message_id: "msg_1",
+      chat_id: "oc_chat1",
+      chat_type: chatType,
+      message_type: "text",
+      content: JSON.stringify({ text }),
+      mentions,
+    },
+  };
+}
+
+function makePostEvent(content: unknown) {
+  return {
+    sender: { sender_id: { user_id: "u1", open_id: "ou_sender" } },
+    message: {
+      message_id: "msg_1",
+      chat_id: "oc_chat1",
+      chat_type: "group",
+      message_type: "post",
+      content: JSON.stringify(content),
+      mentions: [],
+    },
+  };
+}
+
+function makeShareChatEvent(content: unknown) {
+  return {
+    sender: { sender_id: { user_id: "u1", open_id: "ou_sender" } },
+    message: {
+      message_id: "msg_1",
+      chat_id: "oc_chat1",
+      chat_type: "group",
+      message_type: "share_chat",
+      content: JSON.stringify(content),
+      mentions: [],
+    },
+  };
+}
+
+describe("parseFeishuMessageEvent – mentionedBot", () => {
+  const BOT_OPEN_ID = "ou_bot_123";
+
+  it("returns mentionedBot=false when there are no mentions", () => {
+    const event = makeEvent("group", []);
+    const ctx = parseFeishuMessageEvent(event as any, BOT_OPEN_ID);
+    expect(ctx.mentionedBot).toBe(false);
+  });
+
+  it("falls back to sender user_id when open_id is missing", () => {
+    const event = makeEvent("p2p", []);
+    (event as any).sender.sender_id = { user_id: "u_mobile_only" };
+
+    const ctx = parseFeishuMessageEvent(event as any, BOT_OPEN_ID);
+    expect(ctx.senderOpenId).toBe("u_mobile_only");
+    expect(ctx.senderId).toBe("u_mobile_only");
+  });
+
+  it("returns mentionedBot=true when bot is mentioned", () => {
+    const event = makeEvent("group", [
+      { key: "@_user_1", name: "Bot", id: { open_id: BOT_OPEN_ID } },
+    ]);
+    const ctx = parseFeishuMessageEvent(event as any, BOT_OPEN_ID);
+    expect(ctx.mentionedBot).toBe(true);
+  });
+
+  it("returns mentionedBot=true when bot mention name differs from configured botName", () => {
+    const event = makeEvent("group", [
+      { key: "@_user_1", name: "OpenClaw Bot (Alias)", id: { open_id: BOT_OPEN_ID } },
+    ]);
+    const ctx = parseFeishuMessageEvent(event as any, BOT_OPEN_ID, "OpenClaw Bot");
+    expect(ctx.mentionedBot).toBe(true);
+  });
+
+  it("returns mentionedBot=false when only other users are mentioned", () => {
+    const event = makeEvent("group", [
+      { key: "@_user_1", name: "Alice", id: { open_id: "ou_alice" } },
+    ]);
+    const ctx = parseFeishuMessageEvent(event as any, BOT_OPEN_ID);
+    expect(ctx.mentionedBot).toBe(false);
+  });
+
+  it("returns mentionedBot=false when botOpenId is undefined (unknown bot)", () => {
+    const event = makeEvent("group", [
+      { key: "@_user_1", name: "Alice", id: { open_id: "ou_alice" } },
+    ]);
+    const ctx = parseFeishuMessageEvent(event as any, undefined);
+    expect(ctx.mentionedBot).toBe(false);
+  });
+
+  it("returns mentionedBot=false when botOpenId is empty string (probe failed)", () => {
+    const event = makeEvent("group", [
+      { key: "@_user_1", name: "Alice", id: { open_id: "ou_alice" } },
+    ]);
+    const ctx = parseFeishuMessageEvent(event as any, "");
+    expect(ctx.mentionedBot).toBe(false);
+  });
+
+  it("treats mention.name regex metacharacters as literals when stripping", () => {
+    const event = makeEvent(
+      "group",
+      [{ key: "@_bot_1", name: ".*", id: { open_id: BOT_OPEN_ID } }],
+      "@NotBot hello",
+    );
+    const ctx = parseFeishuMessageEvent(event as any, BOT_OPEN_ID);
+    expect(ctx.content).toBe("@NotBot hello");
+  });
+
+  it("treats mention.key regex metacharacters as literals when stripping", () => {
+    const event = makeEvent(
+      "group",
+      [{ key: ".*", name: "Bot", id: { open_id: BOT_OPEN_ID } }],
+      "hello world",
+    );
+    const ctx = parseFeishuMessageEvent(event as any, BOT_OPEN_ID);
+    expect(ctx.content).toBe("hello world");
+  });
+
+  it("returns mentionedBot=true for post message with at (no top-level mentions)", () => {
+    const BOT_OPEN_ID = "ou_bot_123";
+    const event = makePostEvent({
+      content: [
+        [{ tag: "at", user_id: BOT_OPEN_ID, user_name: "claw" }],
+        [{ tag: "text", text: "What does this document say" }],
+      ],
+    });
+    const ctx = parseFeishuMessageEvent(event as any, BOT_OPEN_ID);
+    expect(ctx.mentionedBot).toBe(true);
+  });
+
+  it("returns mentionedBot=false for post message with no at", () => {
+    const event = makePostEvent({
+      content: [[{ tag: "text", text: "hello" }]],
+    });
+    const ctx = parseFeishuMessageEvent(event as any, "ou_bot_123");
+    expect(ctx.mentionedBot).toBe(false);
+  });
+
+  it("returns mentionedBot=false for post message with at for another user", () => {
+    const event = makePostEvent({
+      content: [
+        [{ tag: "at", user_id: "ou_other", user_name: "other" }],
+        [{ tag: "text", text: "hello" }],
+      ],
+    });
+    const ctx = parseFeishuMessageEvent(event as any, "ou_bot_123");
+    expect(ctx.mentionedBot).toBe(false);
+  });
+
+  it("preserves post code and code_block content", () => {
+    const event = makePostEvent({
+      content: [
+        [
+          { tag: "text", text: "before " },
+          { tag: "code", text: "inline()" },
+        ],
+        [{ tag: "code_block", language: "ts", text: "const x = 1;" }],
+      ],
+    });
+    const ctx = parseFeishuMessageEvent(event as any, "ou_bot_123");
+    expect(ctx.content).toContain("before `inline()`");
+    expect(ctx.content).toContain("```ts\nconst x = 1;\n```");
+  });
+
+  it("uses share_chat body when available", () => {
+    const event = makeShareChatEvent({
+      body: "Merged and Forwarded Message",
+      share_chat_id: "sc_abc123",
+    });
+    const ctx = parseFeishuMessageEvent(event as any, "ou_bot_123");
+    expect(ctx.content).toBe("Merged and Forwarded Message");
+  });
+
+  it("falls back to share_chat identifier when body is unavailable", () => {
+    const event = makeShareChatEvent({
+      share_chat_id: "sc_abc123",
+    });
+    const ctx = parseFeishuMessageEvent(event as any, "ou_bot_123");
+    expect(ctx.content).toBe("[Forwarded message: sc_abc123]");
+  });
+});

package/src/bot.stripBotMention.test.ts

@@ -0,0 +1,134 @@
+import { describe, expect, it } from "vitest";
+import { parseFeishuMessageEvent } from "./bot.js";
+
+function makeEvent(
+  text: string,
+  mentions?: Array<{ key: string; name: string; id: { open_id?: string; user_id?: string } }>,
+  chatType: "p2p" | "group" = "p2p",
+) {
+  return {
+    sender: { sender_id: { user_id: "u1", open_id: "ou_sender" } },
+    message: {
+      message_id: "msg_1",
+      chat_id: "oc_chat1",
+      chat_type: chatType,
+      message_type: "text",
+      content: JSON.stringify({ text }),
+      mentions,
+    },
+  };
+}
+
+const BOT_OPEN_ID = "ou_bot";
+
+describe("normalizeMentions (via parseFeishuMessageEvent)", () => {
+  it("returns original text when mentions are missing", () => {
+    const ctx = parseFeishuMessageEvent(makeEvent("hello world", undefined) as any, BOT_OPEN_ID);
+    expect(ctx.content).toBe("hello world");
+  });
+
+  it("strips bot mention in p2p (addressing prefix, not semantic content)", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent("@_bot_1 hello", [
+        { key: "@_bot_1", name: "Bot", id: { open_id: "ou_bot" } },
+      ]) as any,
+      BOT_OPEN_ID,
+    );
+    expect(ctx.content).toBe("hello");
+  });
+
+  it("strips bot mention in group so slash commands work (#35994)", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent(
+        "@_bot_1 hello",
+        [{ key: "@_bot_1", name: "Bot", id: { open_id: "ou_bot" } }],
+        "group",
+      ) as any,
+      BOT_OPEN_ID,
+    );
+    expect(ctx.content).toBe("hello");
+  });
+
+  it("strips bot mention in group preserving slash command prefix (#35994)", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent(
+        "@_bot_1 /model",
+        [{ key: "@_bot_1", name: "Bot", id: { open_id: "ou_bot" } }],
+        "group",
+      ) as any,
+      BOT_OPEN_ID,
+    );
+    expect(ctx.content).toBe("/model");
+  });
+
+  it("strips bot mention but normalizes other mentions in p2p (mention-forward)", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent("@_bot_1 @_user_alice hello", [
+        { key: "@_bot_1", name: "Bot", id: { open_id: "ou_bot" } },
+        { key: "@_user_alice", name: "Alice", id: { open_id: "ou_alice" } },
+      ]) as any,
+      BOT_OPEN_ID,
+    );
+    expect(ctx.content).toBe('<at user_id="ou_alice">Alice</at> hello');
+  });
+
+  it("falls back to @name when open_id is absent", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent("@_user_1 hi", [
+        { key: "@_user_1", name: "Alice", id: { user_id: "uid_alice" } },
+      ]) as any,
+      BOT_OPEN_ID,
+    );
+    expect(ctx.content).toBe("@Alice hi");
+  });
+
+  it("falls back to plain @name when no id is present", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent("@_unknown hey", [{ key: "@_unknown", name: "Nobody", id: {} }]) as any,
+      BOT_OPEN_ID,
+    );
+    expect(ctx.content).toBe("@Nobody hey");
+  });
+
+  it("treats mention key regex metacharacters as literal text", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent("hello world", [{ key: ".*", name: "Bot", id: { open_id: "ou_bot" } }]) as any,
+      BOT_OPEN_ID,
+    );
+    expect(ctx.content).toBe("hello world");
+  });
+
+  it("normalizes multiple mentions in one pass", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent("@_bot_1 hi @_user_2", [
+        { key: "@_bot_1", name: "Bot One", id: { open_id: "ou_bot_1" } },
+        { key: "@_user_2", name: "User Two", id: { open_id: "ou_user_2" } },
+      ]) as any,
+      BOT_OPEN_ID,
+    );
+    expect(ctx.content).toBe(
+      '<at user_id="ou_bot_1">Bot One</at> hi <at user_id="ou_user_2">User Two</at>',
+    );
+  });
+
+  it("treats $ in display name as literal (no replacement-pattern interpolation)", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent("@_user_1 hi", [
+        { key: "@_user_1", name: "$& the user", id: { open_id: "ou_x" } },
+      ]) as any,
+      BOT_OPEN_ID,
+    );
+    // $ is preserved literally (no $& pattern substitution); & is not escaped in tag body
+    expect(ctx.content).toBe('<at user_id="ou_x">$& the user</at> hi');
+  });
+
+  it("escapes < and > in mention name to protect tag structure", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent("@_user_1 test", [
+        { key: "@_user_1", name: "<script>", id: { open_id: "ou_x" } },
+      ]) as any,
+      BOT_OPEN_ID,
+    );
+    expect(ctx.content).toBe('<at user_id="ou_x">&lt;script&gt;</at> test');
+  });
+});