@nextage/nx-frame-be 1.0.44 → 1.0.45

package/build/common/base/__test__/before-get-contract.test.d.ts

@@ -0,0 +1,16 @@
+/*********************************************************************************************
+ *                                                                                           *
+ * BEFOREGET CONTRACT                                                                        *
+ *                                                                                           *
+ * `beforeGet` is declared `Promise<FilterParams>`, so the filter it returns is part of the  *
+ * contract. `get` used to await it and throw the result away, handing `findOne` the object  *
+ * it had built itself - which worked only because every override in existence MUTATES its   *
+ * argument.                                                                                 *
+ *                                                                                           *
+ * That difference is invisible at compile time and silent at run time, and it is the whole  *
+ * point of this file: an override written in pure style - `return { ...filter, tenantId }`, *
+ * the shape the signature invites - compiled, passed review, and read across every tenant.  *
+ * These tests state that BOTH styles scope the read.                                        *
+ *                                                                                           *
+ *********************************************************************************************/
+export {};

package/build/common/base/__test__/before-get-contract.test.js

@@ -0,0 +1,90 @@
+"use strict";
+/*********************************************************************************************
+ *                                                                                           *
+ * BEFOREGET CONTRACT                                                                        *
+ *                                                                                           *
+ * `beforeGet` is declared `Promise<FilterParams>`, so the filter it returns is part of the  *
+ * contract. `get` used to await it and throw the result away, handing `findOne` the object  *
+ * it had built itself - which worked only because every override in existence MUTATES its   *
+ * argument.                                                                                 *
+ *                                                                                           *
+ * That difference is invisible at compile time and silent at run time, and it is the whole  *
+ * point of this file: an override written in pure style - `return { ...filter, tenantId }`, *
+ * the shape the signature invites - compiled, passed review, and read across every tenant.  *
+ * These tests state that BOTH styles scope the read.                                        *
+ *                                                                                           *
+ *********************************************************************************************/
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+const base_model_1 = require("../base.model");
+const mongo_utils_1 = require("../mongo-utils");
+/** Scopes the read the way every override in the wild does today: by MUTATING the filter. */
+class MutatingModel extends base_model_1.BaseModel {
+    beforeGet() {
+        return __awaiter(this, arguments, void 0, function* (filter = {}, context = {}) {
+            filter.tenantId = context.tenantId;
+            return filter;
+        });
+    }
+}
+/** Scopes the read in pure style - the shape the `Promise<FilterParams>` signature invites. */
+class PureModel extends base_model_1.BaseModel {
+    beforeGet() {
+        return __awaiter(this, arguments, void 0, function* (filter = {}, context = {}) {
+            return Object.assign(Object.assign({}, filter), { tenantId: context.tenantId });
+        });
+    }
+}
+const schema = {
+    code: { type: String, required: true },
+    tenantId: { type: String, required: true },
+};
+const mutating = (0, mongo_utils_1.createModel)({
+    name: 'BeforeGetMutating',
+    modelName: 'BeforeGetMutating',
+    collection: 'beforeGetMutating',
+    classDef: MutatingModel,
+    modelParams: {},
+    schema
+}, true);
+const pure = (0, mongo_utils_1.createModel)({
+    name: 'BeforeGetPure',
+    modelName: 'BeforeGetPure',
+    collection: 'beforeGetPure',
+    classDef: PureModel,
+    modelParams: {},
+    schema
+}, true);
+describe('BaseModel.get honours the filter beforeGet returns', () => {
+    const owner = { tenantId: 'tenant-a' };
+    const outsider = { tenantId: 'tenant-b' };
+    let mutatingId;
+    let pureId;
+    // Inserted per test: the shared setup empties every collection before each one.
+    beforeEach(() => __awaiter(void 0, void 0, void 0, function* () {
+        const a = yield mutating.mgModel.collection.insertOne({ code: 'A', tenantId: owner.tenantId });
+        const b = yield pure.mgModel.collection.insertOne({ code: 'B', tenantId: owner.tenantId });
+        mutatingId = a.insertedId.toString();
+        pureId = b.insertedId.toString();
+    }));
+    it('denies a foreign read when the override MUTATES the filter', () => __awaiter(void 0, void 0, void 0, function* () {
+        expect(yield mutating.get(mutatingId, outsider)).toBeNull();
+    }));
+    // The one that used to pass in silence: the filter handed to `findOne` was the untouched
+    // `{ _id }`, so another tenant's document came back in full.
+    it('denies a foreign read when the override RETURNS a new filter', () => __awaiter(void 0, void 0, void 0, function* () {
+        expect(yield pure.get(pureId, outsider)).toBeNull();
+    }));
+    it('still finds the document for its own tenant, in both styles', () => __awaiter(void 0, void 0, void 0, function* () {
+        expect(yield mutating.get(mutatingId, owner)).not.toBeNull();
+        expect(yield pure.get(pureId, owner)).not.toBeNull();
+    }));
+});

package/build/common/base/base.model.js

@@ -213,8 +213,11 @@ class BaseModel extends events_1.EventEmitter {
         return __awaiter(this, arguments, void 0, function* (id, context = {}) {
             if (!id)
                 return null;
-            const filter = { _id: (0, mongo_utils_1.toObjectId)(id) };
-            yield this.beforeGet(filter, context);
+            // The RETURNED filter is the one that counts. This used to discard it and query with
+            // the object built here, which worked only because every override mutates its argument:
+            // one written in pure style - `return { ...filter, tenantId }`, the shape this very
+            // signature invites - compiled, read across every tenant, and said nothing.
+            const filter = yield this.beforeGet({ _id: (0, mongo_utils_1.toObjectId)(id) }, context);
             return this.mgModel.findOne(filter, null, { session: context === null || context === void 0 ? void 0 : context.session });
         });
     }

package/build/common/crypto/index.d.ts

@@ -1,4 +1,5 @@
 export * from './crypto.interfaces';
+export * from './crypto.constants';
 export * from './crypto.classes';
 export * from './crypto.utils';
 export * from './crypto-legacy';

package/build/common/crypto/index.js

@@ -15,6 +15,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 __exportStar(require("./crypto.interfaces"), exports);
+__exportStar(require("./crypto.constants"), exports);
 __exportStar(require("./crypto.classes"), exports);
 __exportStar(require("./crypto.utils"), exports);
 __exportStar(require("./crypto-legacy"), exports);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nextage/nx-frame-be",
-  "version": "1.0.44",
+  "version": "1.0.45",
   "description": "",
   "main": "./build/index.js",
   "types": "./build/index.d.ts",