@next/playwright 16.2.0-canary.94 → 16.2.0-canary.95

package/dist/index.d.ts

@@ -12,8 +12,14 @@ interface PlaywrightBrowserContext {
         domain?: string;
         path?: string;
     }>): Promise<void>;
+    cookies(): Promise<Array<{
+        name: string;
+        value: string;
+    }>>;
     clearCookies(options?: {
         name?: string;
+        domain?: string;
+        path?: string;
     }): Promise<void>;
 }
 interface PlaywrightPage {

package/dist/index.js

@@ -25,6 +25,14 @@ const INSTANT_COOKIE = 'next-instant-navigation-testing';
  * as labeled steps in the Playwright UI.
  */
 async function instant(page, fn, options) {
+    // Check for nested instant() calls. The cookie is scoped to the browser
+    // context, so we can detect nesting by checking if it's already set.
+    const existingCookies = await page.context().cookies();
+    if (existingCookies.some((c) => c.name === INSTANT_COOKIE)) {
+        throw new Error('An instant() scope is already active. Nesting instant() ' +
+            'calls is not supported. Did you forget to await the ' +
+            'previous instant() call?');
+    }
     // Acquire the lock by setting the cookie via the browser context. This
     // ensures the cookie is present even on the very first navigation.
     // The cookie triggers the CookieStore change event in
@@ -33,16 +41,16 @@ async function instant(page, fn, options) {
     await (0, step_1.step)('Acquire Instant Lock', () => page
         .context()
         .addCookies([
-        { name: INSTANT_COOKIE, value: '1', domain: hostname, path: '/' },
+        { name: INSTANT_COOKIE, value: '[0]', domain: hostname, path: '/' },
     ]));
     try {
         return await fn();
     }
     finally {
-        // Release the lock by clearing the cookie. For SPA navigations, this
-        // triggers the CookieStore change event which resolves the in-memory
-        // lock. For MPA navigations (reload, plain anchor), the listener in
-        // app-bootstrap.ts triggers a page reload to fetch dynamic data.
+        // Release the lock by clearing the cookie. Next.js may have updated the
+        // cookie value (e.g. from [0] to [1,null]) during the lock scope. We
+        // clear by name to remove the cookie regardless of its current value or
+        // which domain variant it was stored under.
         await (0, step_1.step)('Release Instant Lock', () => page.context().clearCookies({ name: INSTANT_COOKIE }));
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@next/playwright",
-  "version": "16.2.0-canary.94",
+  "version": "16.2.0-canary.95",
   "repository": {
     "url": "vercel/next.js",
     "directory": "packages/next-playwright"