@next/eslint-plugin-next 16.3.0-canary.70 → 16.3.0-canary.71

package/dist/rules/no-location-assign-relative-destination.js

@@ -9,28 +9,8 @@ Object.defineProperty(exports, "default", {
     }
 });
 var _definerule = require("../utils/define-rule");
+var _eslintutils = require("@eslint-community/eslint-utils");
 var url = 'https://nextjs.org/docs/messages/no-location-assign-relative-destination';
-var LOCATION_GLOBALS = new Set([
-    'window',
-    'globalThis'
-]);
-function isLocationObject(node) {
-    // `location`
-    if (node.type === 'Identifier' && node.name === 'location') {
-        return true;
-    }
-    // `window.location` / `globalThis.location` (dot or bracket notation)
-    if (node.type === 'MemberExpression' && node.object.type === 'Identifier' && LOCATION_GLOBALS.has(node.object.name) && isPropertyNamed(node, 'location')) {
-        return true;
-    }
-    return false;
-}
-function isPropertyNamed(memberNode, name) {
-    return memberNode.computed === false && memberNode.property.type === 'Identifier' && memberNode.property.name === name || memberNode.computed === true && memberNode.property.type === 'Literal' && memberNode.property.value === name;
-}
-/** Returns true when the node is a string literal containing "://" (absolute URL). */ function isAbsoluteUrlLiteral(node) {
-    return node != null && node.type === 'Literal' && typeof node.value === 'string' && node.value.includes('://');
-}
 var _default = (0, _definerule.defineRule)({
     meta: {
         docs: {
@@ -46,43 +26,48 @@ var _default = (0, _definerule.defineRule)({
     },
     create: function create(context) {
         var sourceCode = context.sourceCode;
+        var scopeManager = sourceCode.scopeManager;
+        if (!scopeManager) return {};
         return {
             // location.assign(...) / location['assign'](...)
             // window.location.assign(...) / window.location['assign'](...)
             // globalThis.location.assign(...) / globalThis.location['assign'](...)
             CallExpression: function CallExpression(node) {
-                var callee = node.callee;
-                if (callee.type === 'MemberExpression' && isPropertyNamed(callee, 'assign') && isLocationObject(callee.object)) {
-                    // Allow calls where the first argument is an absolute URL string literal
-                    if (isAbsoluteUrlLiteral(node.arguments[0])) {
-                        return;
-                    }
-                    var expression = sourceCode.getText(callee);
+                var callee = node.callee, args = node.arguments;
+                if (!isMemberExprWithNamedProperty(callee, 'assign')) return;
+                var rootIdentifier = getLocationRootIdentifier(callee.object);
+                if (!rootIdentifier) return;
+                if (!isGlobalReference(sourceCode, rootIdentifier)) return;
+                if (args.length < 1) return;
+                var firstArg = args[0];
+                if (firstArg.type === 'SpreadElement') return;
+                var value = getStaticStringPrefix(firstArg, sourceCode);
+                if (value !== null && isRelativeUrl(value)) {
                     context.report({
                         node: node,
                         messageId: 'noLocationAssign',
                         data: {
-                            expression: expression + '()'
+                            expression: sourceCode.getText(callee) + '()'
                         }
                     });
                 }
             },
-            // location.href = ... / location['href'] = ...
-            // window.location.href = ... / window.location['href'] = ...
-            // globalThis.location.href = ... / globalThis.location['href'] = ...
+            // location.href = '/path'
+            // window.location.href = '/path'
+            // globalThis.location.href = '/path'
             AssignmentExpression: function AssignmentExpression(node) {
-                var left = node.left;
-                if (left.type === 'MemberExpression' && isPropertyNamed(left, 'href') && isLocationObject(left.object)) {
-                    // Allow assignments where the right-hand side is an absolute URL string literal
-                    if (isAbsoluteUrlLiteral(node.right)) {
-                        return;
-                    }
-                    var expression = sourceCode.getText(left);
+                var left = node.left, right = node.right;
+                if (!isMemberExprWithNamedProperty(left, 'href')) return;
+                var rootIdentifier = getLocationRootIdentifier(left.object);
+                if (!rootIdentifier) return;
+                if (!isGlobalReference(sourceCode, rootIdentifier)) return;
+                var value = getStaticStringPrefix(right, sourceCode);
+                if (value !== null && isRelativeUrl(value)) {
                     context.report({
                         node: node,
                         messageId: 'noLocationAssign',
                         data: {
-                            expression: expression
+                            expression: sourceCode.getText(left)
                         }
                     });
                 }
@@ -90,3 +75,84 @@ var _default = (0, _definerule.defineRule)({
         };
     }
 });
+var ABSOLUTE_URL_RE = /^(?:[a-z][\d+.a-z-]*:|\/\/)/i;
+var GLOBAL_PREFIXES = new Set([
+    'window',
+    'globalThis',
+    'document',
+    'self'
+]);
+function isMemberExprWithNamedProperty(expr, name) {
+    if (expr.type !== 'MemberExpression') return false;
+    return expr.computed ? expr.property.type === 'Literal' && expr.property.value === name : expr.property.type === 'Identifier' && expr.property.name === name;
+}
+function isRelativeUrl(value) {
+    return !ABSOLUTE_URL_RE.test(value);
+}
+function getLocationRootIdentifier(node) {
+    if (node.type === 'Identifier' && node.name === 'location') {
+        return node;
+    }
+    if (node.type === 'MemberExpression' && node.object.type === 'Identifier' && GLOBAL_PREFIXES.has(node.object.name) && isMemberExprWithNamedProperty(node, 'location')) {
+        return node.object;
+    }
+    return null;
+}
+function isGlobalReference(sourceCode, node) {
+    if (!node) return false;
+    if (node.type !== 'Identifier') return false;
+    var variable = sourceCode.scopeManager.scopes[0].set.get(node.name);
+    if (!variable || variable.defs.length > 0) return false;
+    return variable.references.some(function(param) {
+        var identifier = param.identifier;
+        return identifier === node;
+    });
+}
+function getStaticStringPrefix(node, sourceCode) {
+    var constantValue = (0, _eslintutils.getStringIfConstant)(node, sourceCode.getScope(node));
+    if (constantValue !== null) {
+        return constantValue;
+    }
+    if (node.type === 'TemplateLiteral' && node.quasis.length > 0) {
+        var _node_quasis__value_cooked;
+        return (_node_quasis__value_cooked = node.quasis[0].value.cooked) !== null && _node_quasis__value_cooked !== void 0 ? _node_quasis__value_cooked : node.quasis[0].value.raw;
+    }
+    if (node.type === 'BinaryExpression' && node.operator === '+') {
+        return getStaticStringPrefix(node.left, sourceCode);
+    }
+    if (node.type === 'Identifier') {
+        var variable = (0, _eslintutils.findVariable)(sourceCode.getScope(node), node);
+        if (!variable || variable.defs.length < 1) return null;
+        var def = variable.defs[variable.defs.length - 1];
+        if (def.type !== 'Variable') return null;
+        var readPos = node.range[0];
+        var _def_node_init;
+        var lastWriteExpr = (_def_node_init = def.node.init) !== null && _def_node_init !== void 0 ? _def_node_init : null;
+        var _iteratorNormalCompletion = true, _didIteratorError = false, _iteratorError = undefined;
+        try {
+            for(var _iterator = variable.references[Symbol.iterator](), _step; !(_iteratorNormalCompletion = (_step = _iterator.next()).done); _iteratorNormalCompletion = true){
+                var ref = _step.value;
+                if (ref.identifier.range[0] >= readPos) break;
+                if (ref.isWrite() && ref.writeExpr && ref.writeExpr !== def.node.init) {
+                    lastWriteExpr = ref.writeExpr;
+                }
+            }
+        } catch (err) {
+            _didIteratorError = true;
+            _iteratorError = err;
+        } finally{
+            try {
+                if (!_iteratorNormalCompletion && _iterator.return != null) {
+                    _iterator.return();
+                }
+            } finally{
+                if (_didIteratorError) {
+                    throw _iteratorError;
+                }
+            }
+        }
+        if (!lastWriteExpr) return null;
+        return getStaticStringPrefix(lastWriteExpr, sourceCode);
+    }
+    return null;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@next/eslint-plugin-next",
-  "version": "16.3.0-canary.70",
+  "version": "16.3.0-canary.71",
   "description": "ESLint plugin for Next.js.",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -13,10 +13,12 @@
     "dist"
   ],
   "dependencies": {
+    "@eslint-community/eslint-utils": "4.9.1",
     "fast-glob": "3.3.1"
   },
   "devDependencies": {
     "@types/eslint": "9.6.1",
+    "@types/estree": "1.0.8",
     "eslint": "9.37.0"
   },
   "scripts": {