@next/eslint-plugin-next 16.3.0-canary.1 → 16.3.0-canary.100

package/dist/index.d.ts

@@ -18,6 +18,7 @@ declare const plugin: {
         'no-head-import-in-document': Rule.RuleModule;
         'no-html-link-for-pages': Rule.RuleModule;
         'no-img-element': Rule.RuleModule;
+        'no-location-assign-relative-destination': Rule.RuleModule;
         'no-page-custom-font': Rule.RuleModule;
         'no-script-component-in-head': Rule.RuleModule;
         'no-styled-jsx-in-document': Rule.RuleModule;
@@ -50,6 +51,7 @@ export declare const rules: {
     'no-head-import-in-document': Rule.RuleModule;
     'no-html-link-for-pages': Rule.RuleModule;
     'no-img-element': Rule.RuleModule;
+    'no-location-assign-relative-destination': Rule.RuleModule;
     'no-page-custom-font': Rule.RuleModule;
     'no-script-component-in-head': Rule.RuleModule;
     'no-styled-jsx-in-document': Rule.RuleModule;

package/dist/index.js

@@ -33,6 +33,7 @@ var _noheadelement = /*#__PURE__*/ _interop_require_default(require("./rules/no-
 var _noheadimportindocument = /*#__PURE__*/ _interop_require_default(require("./rules/no-head-import-in-document"));
 var _nohtmllinkforpages = /*#__PURE__*/ _interop_require_default(require("./rules/no-html-link-for-pages"));
 var _noimgelement = /*#__PURE__*/ _interop_require_default(require("./rules/no-img-element"));
+var _nolocationassignrelativedestination = /*#__PURE__*/ _interop_require_default(require("./rules/no-location-assign-relative-destination"));
 var _nopagecustomfont = /*#__PURE__*/ _interop_require_default(require("./rules/no-page-custom-font"));
 var _noscriptcomponentinhead = /*#__PURE__*/ _interop_require_default(require("./rules/no-script-component-in-head"));
 var _nostyledjsxindocument = /*#__PURE__*/ _interop_require_default(require("./rules/no-styled-jsx-in-document"));
@@ -84,6 +85,7 @@ var recommendedRules = {
     '@next/next/no-head-element': 'warn',
     '@next/next/no-html-link-for-pages': 'warn',
     '@next/next/no-img-element': 'warn',
+    '@next/next/no-location-assign-relative-destination': 'warn',
     '@next/next/no-page-custom-font': 'warn',
     '@next/next/no-styled-jsx-in-document': 'warn',
     '@next/next/no-sync-scripts': 'warn',
@@ -121,6 +123,7 @@ var plugin = {
         'no-head-import-in-document': _noheadimportindocument.default,
         'no-html-link-for-pages': _nohtmllinkforpages.default,
         'no-img-element': _noimgelement.default,
+        'no-location-assign-relative-destination': _nolocationassignrelativedestination.default,
         'no-page-custom-font': _nopagecustomfont.default,
         'no-script-component-in-head': _noscriptcomponentinhead.default,
         'no-styled-jsx-in-document': _nostyledjsxindocument.default,

package/dist/rules/no-location-assign-relative-destination.d.ts

@@ -0,0 +1,2 @@
+declare const _default: import("eslint").Rule.RuleModule;
+export default _default;

package/dist/rules/no-location-assign-relative-destination.js

@@ -0,0 +1,158 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", {
+    value: true
+});
+Object.defineProperty(exports, "default", {
+    enumerable: true,
+    get: function() {
+        return _default;
+    }
+});
+var _definerule = require("../utils/define-rule");
+var _eslintutils = require("@eslint-community/eslint-utils");
+var url = 'https://nextjs.org/docs/messages/no-location-assign-relative-destination';
+var _default = (0, _definerule.defineRule)({
+    meta: {
+        docs: {
+            description: 'Prevent usage of `location.assign` or `location.href` assignment to navigate to internal Next.js pages.',
+            recommended: true,
+            url: url
+        },
+        type: 'problem',
+        schema: [],
+        messages: {
+            noLocationAssign: "Do not use `{{expression}}` to navigate to internal Next.js pages. Use `redirect()` in the render phase, or `useRouter().push()` in Client Components' event handlers instead. See: " + url
+        }
+    },
+    create: function create(context) {
+        var sourceCode = context.sourceCode;
+        var scopeManager = sourceCode.scopeManager;
+        if (!scopeManager) return {};
+        return {
+            // location.assign(...) / location['assign'](...)
+            // window.location.assign(...) / window.location['assign'](...)
+            // globalThis.location.assign(...) / globalThis.location['assign'](...)
+            CallExpression: function CallExpression(node) {
+                var callee = node.callee, args = node.arguments;
+                if (!isMemberExprWithNamedProperty(callee, 'assign')) return;
+                var rootIdentifier = getLocationRootIdentifier(callee.object);
+                if (!rootIdentifier) return;
+                if (!isGlobalReference(sourceCode, rootIdentifier)) return;
+                if (args.length < 1) return;
+                var firstArg = args[0];
+                if (firstArg.type === 'SpreadElement') return;
+                var value = getStaticStringPrefix(firstArg, sourceCode);
+                if (value !== null && isRelativeUrl(value)) {
+                    context.report({
+                        node: node,
+                        messageId: 'noLocationAssign',
+                        data: {
+                            expression: sourceCode.getText(callee) + '()'
+                        }
+                    });
+                }
+            },
+            // location.href = '/path'
+            // window.location.href = '/path'
+            // globalThis.location.href = '/path'
+            AssignmentExpression: function AssignmentExpression(node) {
+                var left = node.left, right = node.right;
+                if (!isMemberExprWithNamedProperty(left, 'href')) return;
+                var rootIdentifier = getLocationRootIdentifier(left.object);
+                if (!rootIdentifier) return;
+                if (!isGlobalReference(sourceCode, rootIdentifier)) return;
+                var value = getStaticStringPrefix(right, sourceCode);
+                if (value !== null && isRelativeUrl(value)) {
+                    context.report({
+                        node: node,
+                        messageId: 'noLocationAssign',
+                        data: {
+                            expression: sourceCode.getText(left)
+                        }
+                    });
+                }
+            }
+        };
+    }
+});
+var ABSOLUTE_URL_RE = /^(?:[a-z][\d+.a-z-]*:|\/\/)/i;
+var GLOBAL_PREFIXES = new Set([
+    'window',
+    'globalThis',
+    'document',
+    'self'
+]);
+function isMemberExprWithNamedProperty(expr, name) {
+    if (expr.type !== 'MemberExpression') return false;
+    return expr.computed ? expr.property.type === 'Literal' && expr.property.value === name : expr.property.type === 'Identifier' && expr.property.name === name;
+}
+function isRelativeUrl(value) {
+    return !ABSOLUTE_URL_RE.test(value);
+}
+function getLocationRootIdentifier(node) {
+    if (node.type === 'Identifier' && node.name === 'location') {
+        return node;
+    }
+    if (node.type === 'MemberExpression' && node.object.type === 'Identifier' && GLOBAL_PREFIXES.has(node.object.name) && isMemberExprWithNamedProperty(node, 'location')) {
+        return node.object;
+    }
+    return null;
+}
+function isGlobalReference(sourceCode, node) {
+    if (!node) return false;
+    if (node.type !== 'Identifier') return false;
+    var variable = sourceCode.scopeManager.scopes[0].set.get(node.name);
+    if (!variable || variable.defs.length > 0) return false;
+    return variable.references.some(function(param) {
+        var identifier = param.identifier;
+        return identifier === node;
+    });
+}
+function getStaticStringPrefix(node, sourceCode) {
+    var constantValue = (0, _eslintutils.getStringIfConstant)(node, sourceCode.getScope(node));
+    if (constantValue !== null) {
+        return constantValue;
+    }
+    if (node.type === 'TemplateLiteral' && node.quasis.length > 0) {
+        var _node_quasis__value_cooked;
+        return (_node_quasis__value_cooked = node.quasis[0].value.cooked) !== null && _node_quasis__value_cooked !== void 0 ? _node_quasis__value_cooked : node.quasis[0].value.raw;
+    }
+    if (node.type === 'BinaryExpression' && node.operator === '+') {
+        return getStaticStringPrefix(node.left, sourceCode);
+    }
+    if (node.type === 'Identifier') {
+        var variable = (0, _eslintutils.findVariable)(sourceCode.getScope(node), node);
+        if (!variable || variable.defs.length < 1) return null;
+        var def = variable.defs[variable.defs.length - 1];
+        if (def.type !== 'Variable') return null;
+        var readPos = node.range[0];
+        var _def_node_init;
+        var lastWriteExpr = (_def_node_init = def.node.init) !== null && _def_node_init !== void 0 ? _def_node_init : null;
+        var _iteratorNormalCompletion = true, _didIteratorError = false, _iteratorError = undefined;
+        try {
+            for(var _iterator = variable.references[Symbol.iterator](), _step; !(_iteratorNormalCompletion = (_step = _iterator.next()).done); _iteratorNormalCompletion = true){
+                var ref = _step.value;
+                if (ref.identifier.range[0] >= readPos) break;
+                if (ref.isWrite() && ref.writeExpr && ref.writeExpr !== def.node.init) {
+                    lastWriteExpr = ref.writeExpr;
+                }
+            }
+        } catch (err) {
+            _didIteratorError = true;
+            _iteratorError = err;
+        } finally{
+            try {
+                if (!_iteratorNormalCompletion && _iterator.return != null) {
+                    _iterator.return();
+                }
+            } finally{
+                if (_didIteratorError) {
+                    throw _iteratorError;
+                }
+            }
+        }
+        if (!lastWriteExpr) return null;
+        return getStaticStringPrefix(lastWriteExpr, sourceCode);
+    }
+    return null;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@next/eslint-plugin-next",
-  "version": "16.3.0-canary.1",
+  "version": "16.3.0-canary.100",
   "description": "ESLint plugin for Next.js.",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -13,16 +13,17 @@
     "dist"
   ],
   "dependencies": {
+    "@eslint-community/eslint-utils": "4.9.1",
     "fast-glob": "3.3.1"
   },
   "devDependencies": {
     "@types/eslint": "9.6.1",
+    "@types/estree": "1.0.8",
     "eslint": "9.37.0"
   },
   "scripts": {
     "dev": "pnpm build",
     "build": "swc -d dist src && pnpm types",
-    "types": "tsc --project tsconfig.json --skipLibCheck --declaration --emitDeclarationOnly --esModuleInterop --declarationDir dist",
-    "prepublishOnly": "cd ../../ && turbo run build"
+    "types": "tsc --project tsconfig.json --skipLibCheck --declaration --emitDeclarationOnly --esModuleInterop --declarationDir dist"
   }
-}
+}