@next/codemod 16.0.2-canary.3 → 16.0.2-canary.31

package/bin/next-codemod.js

@@ -39,6 +39,8 @@ const program = new commander_1.Command(packageJson.name)
 program
     .command('upgrade')
     .description('Upgrade Next.js apps to desired versions with a single command.')
+    // The CLI interface must be backwards compatible at all times so that older
+    // versions of Next.js can still run the codemod successfully.
     .argument('[revision]', 'Specify the target Next.js version using an NPM dist tag (e.g. "latest", "canary", "rc", "beta") or an exact version number (e.g. "15.0.0").', packageJson.version.includes('-canary.')
     ? 'canary'
     : packageJson.version.includes('-rc.')

package/lib/handle-package.js

@@ -99,6 +99,13 @@ function runInstallation(packageManager, options) {
     try {
         execa_1.default.sync(packageManager, ['install'], {
             cwd: options.cwd,
+            env: {
+                ...process.env,
+                // In case NODE_ENV=production is set, we still want dev dependencies to
+                // be installed. Otherwise we won't be able to check for peer dependencies.
+                // --production=false is not implemented by every package manager.
+                NODE_ENV: 'development',
+            },
             stdio: 'inherit',
             shell: true,
         });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@next/codemod",
-  "version": "16.0.2-canary.3",
+  "version": "16.0.2-canary.31",
   "license": "MIT",
   "repository": {
     "type": "git",

package/transforms/next-lint-to-eslint-cli.js

@@ -113,6 +113,7 @@ function replaceFlatCompatInConfig(configPath) {
     const j = (0, parser_1.createParserFromPath)(configPath);
     const root = j(configContent);
     // Track if we need to add imports and preserve other configs
+    let needsNext = false;
     let needsNextVitals = false;
     let needsNextTs = false;
     let otherConfigs = [];
@@ -128,7 +129,10 @@ function replaceFlatCompatInConfig(configPath) {
             // Check arguments for all configs
             node.arguments.forEach((arg) => {
                 if (arg.type === 'Literal' || arg.type === 'StringLiteral') {
-                    if (arg.value === 'next/core-web-vitals') {
+                    if (arg.value === 'next') {
+                        needsNext = true;
+                    }
+                    else if (arg.value === 'next/core-web-vitals') {
                         needsNextVitals = true;
                     }
                     else if (arg.value === 'next/typescript') {
@@ -159,7 +163,10 @@ function replaceFlatCompatInConfig(configPath) {
                             prop.value.elements?.forEach((element) => {
                                 if (element.type === 'Literal' ||
                                     element.type === 'StringLiteral') {
-                                    if (element.value === 'next/core-web-vitals') {
+                                    if (element.value === 'next') {
+                                        needsNext = true;
+                                    }
+                                    else if (element.value === 'next/core-web-vitals') {
                                         needsNextVitals = true;
                                     }
                                     else if (element.value === 'next/typescript') {
@@ -177,11 +184,14 @@ function replaceFlatCompatInConfig(configPath) {
             });
         }
     });
-    if (!needsNextVitals && !needsNextTs && otherConfigs.length === 0) {
+    if (!needsNext &&
+        !needsNextVitals &&
+        !needsNextTs &&
+        otherConfigs.length === 0) {
         console.warn(exports.prefixes.warn, '   No ESLint configs found in FlatCompat usage');
         return false;
     }
-    if (!needsNextVitals && !needsNextTs) {
+    if (!needsNext && !needsNextVitals && !needsNextTs) {
         console.log('   No Next.js configs found, but preserving other configs');
     }
     // Only remove FlatCompat setup if no other configs need it
@@ -223,7 +233,10 @@ function replaceFlatCompatInConfig(configPath) {
     }
     // Add new imports after the eslint/config import
     const imports = [];
-    // Add imports in correct order: core-web-vitals first, then typescript
+    // Add imports in correct order: next first, then core-web-vitals, then typescript
+    if (needsNext) {
+        imports.push(j.importDeclaration([j.importDefaultSpecifier(j.identifier('next'))], j.literal('eslint-config-next')));
+    }
     if (needsNextVitals) {
         imports.push(j.importDeclaration([j.importDefaultSpecifier(j.identifier('nextCoreWebVitals'))], j.literal('eslint-config-next/core-web-vitals')));
     }
@@ -265,7 +278,10 @@ function replaceFlatCompatInConfig(configPath) {
             const replacements = [];
             node.argument.arguments.forEach((arg) => {
                 if (arg.type === 'Literal' || arg.type === 'StringLiteral') {
-                    if (arg.value === 'next/core-web-vitals') {
+                    if (arg.value === 'next') {
+                        replacements.push(j.spreadElement(j.identifier('next')));
+                    }
+                    else if (arg.value === 'next/core-web-vitals') {
                         replacements.push(j.spreadElement(j.identifier('nextCoreWebVitals')));
                     }
                     else if (arg.value === 'next/typescript') {
@@ -311,7 +327,10 @@ function replaceFlatCompatInConfig(configPath) {
                             prop.value.elements?.forEach((element) => {
                                 if (element.type === 'Literal' ||
                                     element.type === 'StringLiteral') {
-                                    if (element.value === 'next/core-web-vitals') {
+                                    if (element.value === 'next') {
+                                        replacements.push(j.spreadElement(j.identifier('next')));
+                                    }
+                                    else if (element.value === 'next/core-web-vitals') {
                                         replacements.push(j.spreadElement(j.identifier('nextCoreWebVitals')));
                                     }
                                     else if (element.value === 'next/typescript') {
@@ -370,7 +389,10 @@ function replaceFlatCompatInConfig(configPath) {
                 const replacements = [];
                 prop.value.arguments.forEach((arg) => {
                     if (arg.type === 'Literal' || arg.type === 'StringLiteral') {
-                        if (arg.value === 'next/core-web-vitals') {
+                        if (arg.value === 'next') {
+                            replacements.push(j.spreadElement(j.identifier('next')));
+                        }
+                        else if (arg.value === 'next/core-web-vitals') {
                             replacements.push(j.spreadElement(j.identifier('nextCoreWebVitals')));
                         }
                         else if (arg.value === 'next/typescript') {
@@ -451,6 +473,7 @@ function updateExistingFlatConfig(configPath, isTypeScript = false) {
         return false;
     }
     // Check if Next.js configs are already imported directly
+    const hasNext = configContent.includes('eslint-config-next');
     const hasNextVitals = configContent.includes('eslint-config-next/core-web-vitals');
     const hasNextTs = configContent.includes('eslint-config-next/typescript');
     const hasNextConfigs = hasNextVitals || hasNextTs;
@@ -510,6 +533,9 @@ function updateExistingFlatConfig(configPath, isTypeScript = false) {
     // Add Next.js imports if not present
     const program = root.find(j.Program);
     const imports = [];
+    if (!hasNext) {
+        imports.push(j.importDeclaration([j.importDefaultSpecifier(j.identifier('next'))], j.literal('eslint-config-next')));
+    }
     if (!hasNextVitals) {
         imports.push(j.importDeclaration([j.importDefaultSpecifier(j.identifier('nextCoreWebVitals'))], j.literal('eslint-config-next/core-web-vitals')));
     }
@@ -525,6 +551,9 @@ function updateExistingFlatConfig(configPath, isTypeScript = false) {
         exportedArray.value.elements = [];
     }
     const spreadsToAdd = [];
+    if (!hasNext) {
+        spreadsToAdd.push(j.spreadElement(j.identifier('next')));
+    }
     if (!hasNextVitals) {
         spreadsToAdd.push(j.spreadElement(j.identifier('nextCoreWebVitals')));
     }