@next/codemod 15.5.2 → 15.6.0-canary.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@next/codemod",
-  "version": "15.5.2",
+  "version": "15.6.0-canary.0",
   "license": "MIT",
   "repository": {
     "type": "git",

package/transforms/metadata-to-viewport-export.js

@@ -17,19 +17,21 @@ function transformer(file, _api) {
         },
     });
     if (metadataExport.size() !== 1) {
-        return;
+        return file.source;
     }
     const metadataObject = metadataExport.find(j.ObjectExpression).get(0).node;
     if (!metadataObject) {
         console.error('Could not find metadata object');
-        return;
+        return file.source;
     }
     let metadataProperties = metadataObject.properties;
     let viewportProperties;
+    let hasChanges = false;
     const viewport = metadataProperties.find((prop) => prop.key.name === 'viewport');
     if (viewport) {
         viewportProperties = viewport.value.properties;
         metadataProperties = metadataProperties.filter((prop) => prop.key.name !== 'viewport');
+        hasChanges = true;
     }
     else {
         viewportProperties = [];
@@ -38,11 +40,17 @@ function transformer(file, _api) {
     if (colorScheme) {
         viewportProperties.push(colorScheme);
         metadataProperties = metadataProperties.filter((prop) => prop.key.name !== 'colorScheme');
+        hasChanges = true;
     }
     const themeColor = metadataProperties.find((prop) => prop.key.name === 'themeColor');
     if (themeColor) {
         viewportProperties.push(themeColor);
         metadataProperties = metadataProperties.filter((prop) => prop.key.name !== 'themeColor');
+        hasChanges = true;
+    }
+    // Only apply changes if there were actual modifications
+    if (!hasChanges) {
+        return file.source;
     }
     // Update the metadata export
     metadataExport

package/transforms/new-link.js

@@ -1,15 +1,15 @@
 "use strict";
-// It might insert extra parnes for JSX components
+// It might insert extra parens for JSX components
 // x-ref: https://github.com/facebook/jscodeshift/issues/534
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.default = transformer;
 const parser_1 = require("../lib/parser");
+const utils_1 = require("./lib/async-request-api/utils");
 function transformer(file, _api) {
     const j = (0, parser_1.createParserFromPath)(file.path);
     const $j = j(file.source);
-    return $j
-        .find(j.ImportDeclaration, { source: { value: 'next/link' } })
-        .forEach((path) => {
+    let hasChanges = false;
+    $j.find(j.ImportDeclaration, { source: { value: 'next/link' } }).forEach((path) => {
         const defaultImport = j(path).find(j.ImportDefaultSpecifier);
         if (defaultImport.size() === 0) {
             return;
@@ -22,29 +22,21 @@ function transformer(file, _api) {
             return;
         }
         const linkElements = $j.findJSXElements(variableName);
-        const hasStylesJSX = $j.findJSXElements('style').some((stylePath) => {
-            const $style = j(stylePath);
-            const hasJSXProp = $style.find(j.JSXAttribute, { name: { name: 'jsx' } }).size() !== 0;
-            return hasJSXProp;
-        });
         linkElements.forEach((linkPath) => {
-            const $link = j(linkPath).filter((childPath) => {
-                // Exclude links with `legacybehavior` prop from modification
-                return (j(childPath)
-                    .find(j.JSXAttribute, { name: { name: 'legacyBehavior' } })
-                    .size() === 0);
-            });
+            const $link = j(linkPath);
             if ($link.size() === 0) {
                 return;
             }
-            // If file has <style jsx> enable legacyBehavior
-            // and keep <a> to stay on the safe side
-            if (hasStylesJSX) {
-                $link
-                    .get('attributes')
-                    .push(j.jsxAttribute(j.jsxIdentifier('legacyBehavior')));
-                return;
-            }
+            const $legacyBehaviorProps = $link.find(j.JSXAttribute, {
+                name: { type: 'JSXIdentifier', name: 'legacyBehavior' },
+            });
+            $legacyBehaviorProps.remove();
+            hasChanges ||= $legacyBehaviorProps.size() > 0;
+            const $passHrefProps = $link.find(j.JSXAttribute, {
+                name: { type: 'JSXIdentifier', name: 'passHref' },
+            });
+            $passHrefProps.remove();
+            hasChanges ||= $passHrefProps.size() > 0;
             const linkChildrenNodes = $link.get('children');
             // Text-only link children are already correct with the new behavior
             // `next/link` would previously auto-wrap typeof 'string' children already
@@ -59,34 +51,48 @@ function transformer(file, _api) {
                 return (j(childPath).find(j.JSXOpeningElement).get('name').get('name')
                     .value === 'a');
             });
-            // No <a> as child to <Link> so the old behavior is used
-            if ($childrenWithA.size() !== 1) {
-                $link
-                    .get('attributes')
-                    .push(j.jsxAttribute(j.jsxIdentifier('legacyBehavior')));
-                return;
+            if ($childrenWithA.length === 0) {
+                if ($legacyBehaviorProps.length > 0) {
+                    linkPath.node.children.unshift(j.jsxText('\n'), j.jsxExpressionContainer.from({
+                        expression: j.jsxEmptyExpression.from({
+                            comments: [
+                                j.commentBlock.from({
+                                    value: ` ${utils_1.NEXT_CODEMOD_ERROR_PREFIX} This Link previously used the now removed \`legacyBehavior\` prop, and has a child that might not be an anchor. The codemod bailed out of lifting the child props to the Link. Check that the child component does not render an anchor, and potentially move the props manually to Link. `,
+                                }),
+                            ],
+                        }),
+                    }));
+                    hasChanges = true;
+                }
             }
-            const props = $childrenWithA.get('attributes').value;
-            const hasProps = props.length > 0;
-            if (hasProps) {
-                // Add only unique props to <Link> (skip duplicate props)
-                const linkPropNames = $link
-                    .get('attributes')
-                    .value.map((linkProp) => linkProp?.name?.name);
-                const uniqueProps = [];
-                props.forEach((anchorProp) => {
-                    if (!linkPropNames.includes(anchorProp?.name?.name)) {
-                        uniqueProps.push(anchorProp);
-                    }
-                });
-                $link.get('attributes').value.push(...uniqueProps);
-                // Remove props from <a>
-                props.length = 0;
+            else {
+                const props = $childrenWithA.get('attributes').value;
+                const hasProps = props.length > 0;
+                if (hasProps) {
+                    // Add only unique props to <Link> (skip duplicate props)
+                    const linkPropNames = $link
+                        .get('attributes')
+                        .value.map((linkProp) => linkProp?.name?.name);
+                    const uniqueProps = [];
+                    props.forEach((anchorProp) => {
+                        if (!linkPropNames.includes(anchorProp?.name?.name)) {
+                            uniqueProps.push(anchorProp);
+                        }
+                    });
+                    $link.get('attributes').value.push(...uniqueProps);
+                    // Remove props from <a>
+                    props.length = 0;
+                    hasChanges = true;
+                }
+                const childrenProps = $childrenWithA.get('children');
+                $childrenWithA.replaceWith(childrenProps.value);
+                hasChanges = true;
             }
-            const childrenProps = $childrenWithA.get('children');
-            $childrenWithA.replaceWith(childrenProps.value);
         });
-    })
-        .toSource();
+    });
+    if (hasChanges) {
+        return $j.toSource();
+    }
+    return file.source;
 }
 //# sourceMappingURL=new-link.js.map