@next-friday/create-app 5.0.3 → 6.0.1

package/dist/main.mjs

@@ -81,12 +81,15 @@ async function writeEnvironmentFile(directory) {
 */
 function initGit(directory) {
 	if (existsSync(path.join(directory, ".git"))) return "existing";
+	const environment = projectGitEnvironment();
 	if (spawnSync("git", ["rev-parse", "--is-inside-work-tree"], {
 		cwd: directory,
+		env: environment,
 		stdio: "ignore"
 	}).status === 0) return "parent";
 	return spawnSync("git", ["init", "--initial-branch=main"], {
 		cwd: directory,
+		env: environment,
 		stdio: "ignore"
 	}).status === 0 ? "initialized" : "failed";
 }
@@ -99,9 +102,22 @@ function didInstallDependencies(directory) {
 	return spawnSync("pnpm install", {
 		cwd: directory,
 		stdio: "inherit",
-		shell: true
+		shell: true,
+		env: projectGitEnvironment()
 	}).status === 0;
 }
+/**
+* The environment without the repository variables that `git rev-parse --local-env-vars` lists.
+* An inherited `GIT_DIR`, as Git sets for its hooks, would point Git, and the install's Git hook
+* setup, at another repository. `git -c` options stay, as Git keeps them for another repository.
+* @returns Environment for commands that run Git in the project directory.
+*/
+function projectGitEnvironment() {
+	const localVariables = new Set(spawnSync("git", ["rev-parse", "--local-env-vars"], { encoding: "utf8" }).stdout?.split("\n"));
+	localVariables.delete("GIT_CONFIG_PARAMETERS");
+	localVariables.delete("GIT_CONFIG_COUNT");
+	return Object.fromEntries(Object.entries(process.env).filter(([name]) => !localVariables.has(name)));
+}
 // src/project-name.ts
 const packageNamePattern = /^[a-z0-9][a-z0-9._-]*$/;
 const maxPackageNameLength = 214;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@next-friday/create-app",
-  "version": "5.0.3",
+  "version": "6.0.1",
   "description": "Create a Next Friday project from a template.",
   "keywords": [
     "create",
@@ -8,13 +8,13 @@
     "template",
     "next-friday"
   ],
-  "homepage": "https://github.com/next-friday/create-next-friday-app#readme",
+  "homepage": "https://github.com/next-friday/next-friday-create-app#readme",
   "bugs": {
-    "url": "https://github.com/next-friday/create-next-friday-app/issues"
+    "url": "https://github.com/next-friday/next-friday-create-app/issues"
   },
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/next-friday/create-next-friday-app.git"
+    "url": "git+https://github.com/next-friday/next-friday-create-app.git"
   },
   "license": "MIT",
   "author": "Next Friday",
@@ -24,7 +24,7 @@
     "./package.json": "./package.json"
   },
   "bin": {
-    "create-friday-app": "./dist/main.mjs"
+    "next-friday-create-app": "./dist/main.mjs"
   },
   "files": [
     "dist",

package/templates/base/.agents/hooks/agent-production-gate.sh

@@ -1,10 +1,48 @@
-#!/bin/bash
-# Production deploys require a named release authorization
-cmd=$(jq -r '.tool_input.command // .command' < /dev/stdin)
-if [[ "$cmd" == *"deploy"* && "$cmd" == *"production"* ]]; then
-  if [ -z "$RELEASE_APPROVAL" ]; then
-    echo "Production deploys need a release authorization." >&2
-    exit 2 # exit 2 blocks the action; the message goes to Claude
-  fi
+#!/usr/bin/env bash
+set -uo pipefail
+
+allow() {
+  printf '%s\n' '{"permission":"allow"}'
+  exit 0
+}
+
+block() {
+  jq -n --arg message "$1" '{permission:"deny",user_message:$message,agent_message:$message}'
+  printf 'agent-production-gate: %s\n' "$1" >&2
+  exit 2
+}
+
+trap 'block ".agents/hooks/agent-production-gate.sh failed. Stop and report this error to the user; agents may not edit the gate."' ERR
+command -v jq > /dev/null || block "jq is required to read the hook input. Install it: https://jqlang.org/download/"
+command=$(jq -r '.command // .tool_input.command // empty')
+[[ -n $command && -z ${RELEASE_APPROVAL:-} ]] || allow
+
+release_gate="A release manager runs prod deploys, commands against prod, and release tag pushes. Do not run this; report what is ready to promote, such as the commit SHA. If a gated command appears only inside a message, write the text to a file and pass it with git commit -F <file> or gh pr create --body-file <file>."
+
+# The gate reads the command line as text, joining continued lines and dropping quotes,
+# backslashes, and fd redirections, so wrappers such as bash -c, eval, or npx and split words such
+# as pr''od do not hide the common forms. A dispatch input or Railway environment the gate cannot
+# read (a variable, a command substitution, a file, or stdin) counts as prod. It is a convenience,
+# not a security boundary: the prod environment's required reviewers and Railway credentials are.
+text=${command//'\\'/}
+text=${text//$'\\\n'/}
+text=$(sed -E 's/([0-9]*[<>]&[0-9-]*|&>>?)//g' <<< "${text//[\"\'\\]/}")
+simple=$'[^;&|\n]*'
+prod="(prod([^[:alnum:]_-]|$)|[\$\`@])"
+dispatch="(workflow[[:space:]]+run|/dispatches)"
+environment_field="environment[]]*[=:][[:space:]]*$prod"
+unreadable_inputs="--(json|input)([[:space:]=]|$)"
+railway="(^|[^[:alnum:]_.-])(railway|@railway/cli(@[^[:space:]]*)?)([[:space:]]$simple)?"
+git_push="(^|[^[:alnum:]_.-])git([[:space:]]+(-[Cc][[:space:]]+[^[:space:]]+|--(git-dir|work-tree|namespace|config-env)[[:space:]]+[^[:space:]]+|--?[^[:space:]]+))*[[:space:]]+push([[:space:]]$simple)?"
+tag_ref="([[:space:]:+]((refs/)?tags/|v[0-9])|[[:space:]]--((follow-)?tags|mirror)([[:space:]=]|$))"
+
+if [[ $text =~ $dispatch$simple($environment_field|$unreadable_inputs) || $text =~ $environment_field$simple$dispatch ]]; then
+  block "$release_gate"
 fi
-exit 0
+if [[ $text =~ $railway[[:space:]](-[[:alpha:]]*e([[:space:]]+|=)?|--environment([[:space:]]+|=))$prod || $text =~ $railway[[:space:]](env|environment)([[:space:]]+[[:alpha:]]+)?[[:space:]]+$prod ]]; then
+  block "$release_gate"
+fi
+if [[ $text =~ $git_push$tag_ref || $(tr '[:upper:]' '[:lower:]' <<< "$text") == *push.followtags* ]]; then
+  block "$release_gate"
+fi
+allow

package/templates/base/.claude/settings.json

@@ -76,7 +76,8 @@
           {
             "type": "command",
             "command": "\"$CLAUDE_PROJECT_DIR\"/.agents/hooks/agent-production-gate.sh",
-            "timeout": 10
+            "timeout": 10,
+            "onFailure": "block"
           }
         ]
       },

package/templates/base/.cursor/hooks.json

@@ -29,7 +29,8 @@
       },
       {
         "command": ".agents/hooks/agent-production-gate.sh",
-        "timeout": 10
+        "timeout": 10,
+        "failClosed": true
       }
     ],
     "beforeMCPExecution": [

package/templates/base/scripts/check-agent-gates.ts

@@ -6,12 +6,14 @@ type GateCase = {
   gate: string;
   input: Record<string, unknown>;
   name: string;
+  releaseApproval?: string;
 };
 
 const shellGate = ".agents/hooks/agent-shell-gate.sh";
 const suppressionGate = ".agents/hooks/agent-suppression-gate.sh";
 const constitutionGate = ".cursor/hooks/agent-constitution-gate.sh";
 const mcpGate = ".agents/hooks/agent-mcp-gate.sh";
+const productionGate = ".agents/hooks/agent-production-gate.sh";
 const sourceFile = "src/example.ts";
 
 const blockedCommands = [
@@ -189,6 +191,101 @@ const allowedCommands = [
   'gh api repos/next-friday/example/issues/1/comments -f body="APPROVED by QA"',
 ];
 
+const productionCommands = [
+  "gh workflow run deploy.yml -f environment=prod -f commit_sha=abc",
+  "gh workflow run Deploy --field 'environment=prod'",
+  "gh workflow run deploy.yml -fenvironment=prod",
+  "gh workflow run deploy.yml --field=environment=prod",
+  'gh workflow run deploy.yml -f "environment=prod"',
+  "gh workflow run deploy.yml -F environment=@environment.txt",
+  "gh workflow run deploy.yml --json",
+  "gh workflow run deploy.yml --json=true",
+  "for e in uat prod; do gh workflow run deploy.yml -f environment=$e -f commit_sha=abc; done",
+  "env=prod; gh workflow run deploy.yml -f environment=$env",
+  "gh workflow run deploy.yml -f environment=$(echo prod)",
+  'gh workflow run deploy.yml -f "environment=$TARGET"',
+  "gh api -X POST repos/o/r/actions/workflows/deploy.yml/dispatches -f ref=main -f 'inputs[environment]=prod'",
+  "gh api repos/o/r/actions/workflows/deploy.yml/dispatches/ -f inputs[environment]=prod",
+  "gh api -f 'inputs[environment]=prod' repos/o/r/actions/workflows/deploy.yml/dispatches",
+  "gh api repos/o/r/actions/workflows/1/dispatches --input body.json",
+  "gh api repos/o/r/actions/workflows/1/dispatches -f inputs[environment]=$E",
+  "bash -c 'gh workflow run deploy.yml -f environment=prod'",
+  "railway up --ci --environment prod",
+  "railway up -e prod",
+  "railway up -e=prod",
+  "railway up -eprod",
+  "railway up -ce prod",
+  "railway up -ceprod",
+  "railway redeploy -ye prod",
+  "railway up -s api -e prod",
+  "railway up --environment=prod",
+  'railway up -e "$ENV"',
+  "for e in uat prod; do railway up -e $e; done",
+  "railway env prod",
+  "railway env link prod",
+  "railway environment prod",
+  "railway environment delete prod --yes",
+  "railway link -e prod",
+  "railway logs -e prod",
+  "railway variables --set A=b -e prod",
+  "npx @railway/cli up -e prod",
+  "pnpm dlx @railway/cli up -e prod",
+  "/usr/local/bin/railway up -e prod",
+  "timeout 60 railway up -e prod",
+  "eval railway up -e prod",
+  "git push origin v1.0.0",
+  "git push origin HEAD:refs/tags/v1.0.0",
+  "git push --tags",
+  "git push --follow-tags origin main",
+  "git -C . push origin v2.3.4",
+  "npx @railway/cli@5.71.0 up -e prod",
+  "npx @railway/cli@latest up --environment prod",
+  "railway up -e pr''od",
+  "gh workflow run deploy.yml -f environment=pr''od",
+  "gh workflow run deploy.yml -f environment=p\\rod",
+  'gh workflow run deploy.yml -f "envi"ronment=prod',
+  "git push origin 'refs/tags/*'",
+  'git push origin "refs/tags/v*"',
+  "git push --mirror",
+  "git -c push.followTags=true push origin main",
+  "git config push.followTags true && git push",
+  "gh workflow run deploy.yml 2>&1 -f environment=prod",
+  "railway up 2>&1 -e prod",
+  "git push origin tags/v1.0.0",
+  "git --git-dir .git push origin v1.0.0",
+  "gh workflow run deploy.yml \\\n  -f environment=prod \\\n  -f commit_sha=abc",
+  "railway up \\\n  --environment prod",
+  "git push \\\n  origin v1.0.0",
+  "railway up &>/dev/null -e prod",
+  "git push &>/dev/null origin v1.0.0",
+  "cd a\\\\\ngit push origin v1.0.0",
+];
+
+const nonProductionCommands = [
+  "gh workflow run deploy.yml -f environment=uat -f commit_sha=abc",
+  "gh api repos/o/r/actions/workflows/deploy.yml/dispatches -f 'inputs[environment]=uat'",
+  "railway up -e uat",
+  "railway up -e prod-eu",
+  "railway environment uat",
+  "railway status",
+  "gh workflow list",
+  "gh run list --workflow deploy.yml",
+  "gh api repos/o/r/environments/prod",
+  "git push -u origin feature/v2-ui",
+  "git push origin main",
+  'git commit -m "release v1.0" && git push',
+  'git commit -m "docs(x): deploy to production"',
+  'gh pr create --title "ci(x): promote to prod" --body "run gh workflow run later"',
+  "echo railway",
+  "git tag v1.0.0",
+  'git stash push -m "wip v2"',
+  'git commit -m "fix(ci): push v2 images"',
+  'git commit -m "fix: railway env uat and prod split"',
+  "git push -u origin HEAD",
+  "git push origin feature/push-v2",
+  "pnpm verify 2>&1 | tail && git push",
+];
+
 const mcpTools = {
   blocked: [
     "mcp__github__merge_pull_request",
@@ -273,6 +370,47 @@ const cases: GateCase[] = [
     expectedPermission: "allow" as const,
     name: `shell: ${command}`,
   })),
+  ...productionCommands.flatMap(command => [
+    {
+      gate: productionGate,
+      input: {
+        command,
+      },
+      expectedExit: 2 as const,
+      name: `Cursor production: ${command}`,
+    },
+    {
+      gate: productionGate,
+      input: {
+        tool_input: {
+          command,
+        },
+      },
+      expectedExit: 2 as const,
+      name: `Claude production: ${command}`,
+    },
+  ]),
+  {
+    gate: productionGate,
+    releaseApproval: "CHG-1",
+    expectedPermission: "allow",
+    name: "production with RELEASE_APPROVAL: railway up -e prod",
+    expectedExit: 0,
+    input: {
+      tool_input: {
+        command: "railway up -e prod",
+      },
+    },
+  },
+  ...nonProductionCommands.map(command => ({
+    gate: productionGate,
+    input: {
+      command,
+    },
+    expectedExit: 0 as const,
+    expectedPermission: "allow" as const,
+    name: `production: ${command}`,
+  })),
   ...mcpTools.blocked.map(tool => ({
     gate: mcpGate,
     input: {
@@ -399,6 +537,7 @@ const failures = cases.filter(gateCase => {
       ...process.env,
       CLAUDE_PROJECT_DIR: process.cwd(),
       CURSOR_PROJECT_DIR: process.cwd(),
+      RELEASE_APPROVAL: gateCase.releaseApproval,
     },
     input: JSON.stringify(gateCase.input),
   });