@next-core/build-next-bricks 1.20.9 → 1.21.0

package/index.d.ts

@@ -1,4 +1,10 @@
-import type { Compiler, Configuration, RuleSetRule, container } from "webpack";
+import type {
+  Compiler,
+  Configuration,
+  ResolveOptions,
+  RuleSetRule,
+  container,
+} from "webpack";
 
 export declare function build(config: BuildNextBricksConfig): Compiler;
 export declare function getSvgrLoaders(options?: {
@@ -83,6 +89,7 @@ export interface BuildNextBricksConfig {
   imageAssetFilename?: string | ((pathData: any, assetInfo: any) => string);
   plugins?: Configuration["plugins"];
   moduleRules?: RuleSetRule[];
+  resolve?: ResolveOptions;
   exposes?: ConstructorParameters<
     typeof container.ModuleFederationPlugin
   >[0]["exposes"];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@next-core/build-next-bricks",
-  "version": "1.20.9",
+  "version": "1.21.0",
   "description": "Build next bricks",
   "homepage": "https://github.com/easyops-cn/next-core/tree/v3/packages/build-next-bricks",
   "license": "GPL-3.0",
@@ -56,5 +56,5 @@
   "devDependencies": {
     "@next-core/brick-manifest": "^0.7.0"
   },
-  "gitHead": "db50cd31e4f0e9ad071aae54d84e5f2c686749cc"
+  "gitHead": "dbaf7ff2c328eedfaeb636d2bb3dca1bd8cad1d3"
 }

package/src/build.js

@@ -201,7 +201,7 @@ async function getWebpackConfig(config) {
                       paths: [packageDir],
                     }
                   );
-                } catch (e) {
+                } catch {
                   console.warn(`Shared package not found: "${dep}"`);
                   return;
                 }
@@ -213,15 +213,23 @@ async function getWebpackConfig(config) {
                 if (typeof customized === "string") {
                   return;
                 }
+
+                const getRequiredVersion = (dep) =>
+                  packageJson.peerDependencies?.[dep] ??
+                  packageJson.devDependencies?.[dep] ??
+                  packageJson.dependencies?.[dep];
+
                 return [
                   dep,
                   {
                     singleton: sharedSingletonPackages.includes(dep),
                     version: depPackageJson.version,
                     requiredVersion:
-                      packageJson.peerDependencies?.[depPkgName] ??
-                      packageJson.devDependencies?.[depPkgName] ??
-                      packageJson.dependencies?.[depPkgName],
+                      getRequiredVersion(depPkgName) ??
+                      // Use react required version for react-dom if it is not specified
+                      (depPkgName === "react-dom"
+                        ? getRequiredVersion("react")
+                        : undefined),
                     ...customized,
                   },
                 ];
@@ -306,6 +314,7 @@ async function getWebpackConfig(config) {
       extensionAlias: {
         ".js": [".ts", ".tsx", ".js", ".jsx"],
       },
+      ...config.resolve,
     },
     module: {
       rules: [