@newsteam/eslint-config 1.2.16 → 1.2.17

package/dist/index.d.ts

@@ -1,5 +1,5 @@
 import type { Linter } from "eslint";
 declare const config: Linter.Config[];
 export default config;
-export { nextPlugin } from "./plugins/next.js";
+export { nextPluginConfig } from "./rules/next.js";
 //# sourceMappingURL=index.d.ts.map

package/dist/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAgDA,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AA6CrC,QAAA,MAAM,MAAM,EAAE,MAAM,CAAC,MAAM,EA4HzB,CAAC;AAGH,eAAe,MAAM,CAAC;AAGtB,OAAO,EAAE,UAAU,EAAE,MAAM,mBAAmB,CAAC"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAyBA,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AA6CrC,QAAA,MAAM,MAAM,EAAE,MAAM,CAAC,MAAM,EAoGzB,CAAC;AAGH,eAAe,MAAM,CAAC;AAGtB,OAAO,EAAE,gBAAgB,EAAE,MAAM,iBAAiB,CAAC"}

package/dist/index.js

@@ -15,30 +15,7 @@ import { createNodeResolver } from "eslint-plugin-import-x";
 import { defineConfig } from "eslint/config";
 import global from "globals";
 import tseslint from "typescript-eslint";
-import { arrayFuncPlugin } from "./plugins/array-function.js";
-import { cssModulesPlugin } from "./plugins/css-modules.js";
-import { destructuringPlugin } from "./plugins/destructuring.js";
-import { eslintCommentsPlugin } from "./plugins/eslint-comments.js";
-import { importNewlinesPlugin } from "./plugins/import-newlines.js";
-import { importXPlugin } from "./plugins/import-x.js";
-import { newlineDestructuringPlugin } from "./plugins/newline-destructuring.js";
-import { noUnsanitizedPlugin } from "./plugins/no-unsanitized.js";
-import { noUselessAssignPlugin } from "./plugins/no-useless-assign.js";
-import { nodePlugin } from "./plugins/node.js";
-import { perfectionistPlugin } from "./plugins/perfectionist.js";
-import { promisePlugin } from "./plugins/promise.js";
-import { react19UpgradePlugin } from "./plugins/react-19-upgrade.js";
-import { reactCompilerPlugin } from "./plugins/react-compiler.js";
-import { reactHooksPlugin } from "./plugins/react-hooks.js";
-import { reactPerfPlugin } from "./plugins/react-perf.js";
-import { reactRefreshPlugin } from "./plugins/react-refresh.js";
-import { reactPlugin } from "./plugins/react.js";
-import { securityPlugin } from "./plugins/security.js";
-import { sortReactDependenyArraysPlugin } from "./plugins/sort-react-dependency-arrays.js";
-import { stylisticPlugin } from "./plugins/stylistic.js";
-import { typescriptPlugin } from "./plugins/typescript.js";
-import { unicornPlugin } from "./plugins/unicorn.js";
-import { rules } from "./rules.js";
+import { rules } from "./rules/index.js";
 import { REACT_VERSION } from "./settings.js";
 const globals = {
     ...global.browser,
@@ -86,30 +63,6 @@ const config = defineConfig([
         settings,
     },
     ...rules,
-    // Always place plugins after rules in case there are overrides (e.g. in the typescriptPlugin)
-    ...arrayFuncPlugin,
-    ...cssModulesPlugin,
-    ...destructuringPlugin,
-    ...eslintCommentsPlugin,
-    ...importNewlinesPlugin,
-    ...importXPlugin,
-    ...newlineDestructuringPlugin,
-    ...noUnsanitizedPlugin,
-    ...noUselessAssignPlugin,
-    ...nodePlugin,
-    ...perfectionistPlugin,
-    ...promisePlugin,
-    ...react19UpgradePlugin,
-    ...reactCompilerPlugin,
-    ...reactHooksPlugin,
-    ...reactPerfPlugin,
-    ...reactPlugin,
-    ...reactRefreshPlugin,
-    ...securityPlugin,
-    ...sortReactDependenyArraysPlugin,
-    ...stylisticPlugin,
-    ...typescriptPlugin,
-    ...unicornPlugin,
     {
         files: [
             "**/*.d.ts",
@@ -198,4 +151,4 @@ const config = defineConfig([
     },
 ]);
 export default config;
-export { nextPlugin } from "./plugins/next.js";
+export { nextPluginConfig } from "./rules/next.js";

package/dist/plugins/sort-react-dependency-arrays.d.ts

@@ -1,3 +1,4 @@
-import type { Linter } from "eslint";
-export declare const sortReactDependenyArraysPlugin: Linter.Config[];
+import type { ESLint } from "eslint";
+declare const _default: ESLint.Plugin;
+export default _default;
 //# sourceMappingURL=sort-react-dependency-arrays.d.ts.map

package/dist/plugins/sort-react-dependency-arrays.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"sort-react-dependency-arrays.d.ts","sourceRoot":"","sources":["../../src/plugins/sort-react-dependency-arrays.ts"],"names":[],"mappings":"AAIA,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAQrC,eAAO,MAAM,8BAA8B,EAAE,MAAM,CAAC,MAAM,EAgBzD,CAAC"}
+{"version":3,"file":"sort-react-dependency-arrays.d.ts","sourceRoot":"","sources":["../../src/plugins/sort-react-dependency-arrays.ts"],"names":[],"mappings":"AAeA,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;wBAoJZ,MAAM,CAAC,MAAM;AAAtC,wBAAuC"}

package/dist/plugins/sort-react-dependency-arrays.js

@@ -1,21 +1,98 @@
-import sortReactDependenyArrays from "eslint-plugin-sort-react-dependency-arrays";
 /*
- * Validate that your components can safely be updated with fast refresh.
- *
- * https://github.com/ArnaudBarre/eslint-plugin-react-refresh
- */
-export const sortReactDependenyArraysPlugin = [
-    {
-        plugins: {
-            "sort-react-dependency-arrays": sortReactDependenyArrays,
-        },
-        rules: {
-            /*
-             * Validate that your components can safely be updated with fast refresh.
-             *
-             * https://github.com/ArnaudBarre/eslint-plugin-react-refresh#usage
-             */
-            "sort-react-dependency-arrays/sort": "warn",
+
+    This is a port of eslint-plugin-sort-react-dependency-arrays because it looked simple and
+    I couldn't be asked to fork it or contribute to open source. Forgive me.
+
+*/
+import { AST_NODE_TYPES } from "@typescript-eslint/utils";
+const HOOKS = [
+    "useCallback",
+    "useEffect",
+    "useLayoutEffect",
+    "useMemo",
+];
+const isDependencyArrayHook = (node) => node.type === AST_NODE_TYPES.Identifier && HOOKS.includes(node.name);
+const plugin = {
+    meta: {
+        name: "eslint-plugin-sort-react-dependency-arrays",
+        version: "1.0.0",
+    },
+    rules: {
+        sort: {
+            create(context) {
+                const { sourceCode } = context;
+                const getSortableNameFromNode = (node) => {
+                    if (!node) {
+                        return "";
+                    }
+                    // eslint-disable-next-line @typescript-eslint/switch-exhaustiveness-check -- it's ok in this case, default is taking care of it
+                    switch (node.type) {
+                        case AST_NODE_TYPES.Identifier: {
+                            return node.name;
+                        }
+                        case AST_NODE_TYPES.Literal: {
+                            return String(node.value);
+                        }
+                        case AST_NODE_TYPES.MemberExpression: {
+                            return `${getSortableNameFromNode(node.object)}.${getSortableNameFromNode(node.property)}`;
+                        }
+                        default: {
+                            return sourceCode.getText(node);
+                        }
+                    }
+                };
+                return {
+                    CallExpression(node) {
+                        if (isDependencyArrayHook(node.callee)) {
+                            const [, dependencies] = node.arguments;
+                            if (dependencies?.type === AST_NODE_TYPES.ArrayExpression
+                                && dependencies.elements.length > 1) {
+                                // 1. Map elements to their sortable names AND their raw source text
+                                const elementsWithMetadata = dependencies.elements
+                                    .map((element) => {
+                                    if (!element) {
+                                        return undefined;
+                                    }
+                                    return {
+                                        name: getSortableNameFromNode(element),
+                                        originalNode: element,
+                                        // sourceCode.getText(el) gets the exact text of that element
+                                        source: sourceCode.getText(element),
+                                    };
+                                })
+                                    .filter((item) => item !== undefined);
+                                const currentNames = elementsWithMetadata.map((element) => element.name);
+                                // 2. Create the sorted version
+                                // eslint-disable-next-line unicorn/no-array-sort -- nah this causes down stream issues
+                                const sortedMetadata = [...elementsWithMetadata].sort((itemA, itemB) => itemA.name.toLowerCase().localeCompare(itemB.name.toLowerCase()));
+                                const sortedNames = sortedMetadata.map((element) => element.name);
+                                // 3. Check if sorting changed anything
+                                if (JSON.stringify(currentNames) !== JSON.stringify(sortedNames)) {
+                                    context.report({
+                                        fix: (fixer) => elementsWithMetadata.map((original, index) => fixer.replaceText(original.originalNode, sortedMetadata[index].source)),
+                                        messageId: "sortDependencies",
+                                        node: dependencies,
+                                    });
+                                }
+                            }
+                        }
+                    },
+                };
+            },
+            meta: {
+                docs: {
+                    description: "Sort React dependency arrays alphabetically",
+                    url: "https://newsteam.io/this-was-petes-idea",
+                },
+                fixable: "code",
+                messages: {
+                    sortDependencies: "React hook dependencies should be sorted alphabetically.",
+                },
+                schema: [],
+                type: "suggestion",
+            },
         },
     },
-];
+};
+// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- im pretty sure it's safe
+export default plugin;

package/dist/rules/array-function.d.ts

@@ -0,0 +1,3 @@
+import type { Linter } from "eslint";
+export declare const arrayFuncPluginConfig: Linter.Config;
+//# sourceMappingURL=array-function.d.ts.map

package/dist/rules/array-function.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"array-function.d.ts","sourceRoot":"","sources":["../../src/rules/array-function.ts"],"names":[],"mappings":"AAIA,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAQrC,eAAO,MAAM,qBAAqB,EAAE,MAAM,CAAC,MAwD1C,CAAC"}

package/dist/rules/array-function.js

@@ -0,0 +1,56 @@
+import arrayFunc from "eslint-plugin-array-func";
+/*
+ * Rules for Array functions and methods.
+ *
+ * https://www.npmjs.com/package/eslint-plugin-array-func
+ */
+export const arrayFuncPluginConfig = {
+    plugins: {
+        "array-func": arrayFunc,
+    },
+    rules: {
+        /*
+         * Avoid reversing the array and running a method on it if there is an
+         * equivalent of the method operating on the array from the other end.
+         *
+         * https://www.npmjs.com/package/eslint-plugin-array-func#avoid-reverse
+         */
+        "array-func/avoid-reverse": "warn",
+        /*
+         * Prefer using the mapFn callback of Array.from over an immediate
+         * .map() call on the Array.from result.
+         *
+         * https://www.npmjs.com/package/eslint-plugin-array-func#from-map
+         */
+        "array-func/from-map": "warn",
+        /*
+         * Avoid the this parameter when providing arrow function as callback
+         * in array functions.
+         *
+         * https://www.npmjs.com/package/eslint-plugin-array-func#no-unnecessary-this-arg
+         */
+        "array-func/no-unnecessary-this-arg": "warn",
+        /*
+         * Use Array.from instead of [...iterable] for performance benefits.
+         *
+         * Off for now, performance benefits probably don't warrant the irritation
+         *
+         * https://www.npmjs.com/package/eslint-plugin-array-func#prefer-array-from
+         */
+        "array-func/prefer-array-from": "off",
+        /*
+         * Use .flat() to flatten an array of arrays. This rule currently
+         * recognizes two patterns and can replace them with a .flat() call.
+         *
+         * https://www.npmjs.com/package/eslint-plugin-array-func#prefer-flat
+         */
+        "array-func/prefer-flat": "warn",
+        /*
+         * Use .flatMap() to flatten an array and map the values instead of
+         * using .flat().map().
+         *
+         * https://www.npmjs.com/package/eslint-plugin-array-func#prefer-flat-map
+         */
+        "array-func/prefer-flat-map": "warn",
+    },
+};

package/dist/rules/css-modules.d.ts

@@ -0,0 +1,3 @@
+import type { Linter } from "eslint";
+export declare const cssModulesPluginConfig: Linter.Config;
+//# sourceMappingURL=css-modules.d.ts.map

package/dist/rules/css-modules.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"css-modules.d.ts","sourceRoot":"","sources":["../../src/rules/css-modules.ts"],"names":[],"mappings":"AAIA,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAUrC,eAAO,MAAM,sBAAsB,EAAE,MAAM,CAAC,MAqB3C,CAAC"}

package/dist/rules/css-modules.js

@@ -0,0 +1,27 @@
+import cssModules from "@bhollis/eslint-plugin-css-modules";
+/*
+ * This plugin intends to help you in tracking down problems when you are using css-modules.
+ * It tells if you are using a non-existent css/scss/less class in js or if you forgot to
+ * use some classes which you declared in css/scss/less.
+ *
+ * https://www.npmjs.com/package/eslint-plugin-css-modules
+ */
+export const cssModulesPluginConfig = {
+    plugins: {
+        "css-modules": cssModules,
+    },
+    rules: {
+        /*
+         * Broken in eslint 10
+         *
+         * https://www.npmjs.com/package/eslint-plugin-css-modules
+         */
+        "css-modules/no-undef-class": ["off"],
+        /*
+         * Broken in eslint 10
+         *
+         * https://www.npmjs.com/package/eslint-plugin-css-modules
+         */
+        "css-modules/no-unused-class": ["off"],
+    },
+};

package/dist/rules/destructuring.d.ts

@@ -0,0 +1,3 @@
+import type { Linter } from "eslint";
+export declare const destructuringPluginConfig: Linter.Config;
+//# sourceMappingURL=destructuring.d.ts.map

package/dist/rules/destructuring.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"destructuring.d.ts","sourceRoot":"","sources":["../../src/rules/destructuring.ts"],"names":[],"mappings":"AAIA,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAQrC,eAAO,MAAM,yBAAyB,EAAE,MAAM,CAAC,MAwC9C,CAAC"}

package/dist/rules/destructuring.js

@@ -0,0 +1,39 @@
+import destructuring from "eslint-plugin-destructuring";
+/*
+ * Destructuring-specific linting rules for ESLint.
+ *
+ * https://www.npmjs.com/package/eslint-plugin-destructuring
+ */
+export const destructuringPluginConfig = {
+    plugins: {
+        destructuring,
+    },
+    rules: {
+        /*
+         * Destructuring within params of a method can be messy, unreadable and moreover you loose an
+         * opportunity of giving a name to the param. This rule allows you to ban destructuring of
+         * params in method declarations.
+         *
+         * https://github.com/lukeapage/eslint-plugin-destructuring/blob/HEAD/docs/rules/in-methods-params.md
+         */
+        "destructuring/in-methods-params": "warn",
+        /*
+         * Destructuring within params can be messy, particularly if you have more than one parameter.
+         * This rule allows you to configure the maximum parameters allowed when one or more is destructuring.
+         *
+         * https://github.com/lukeapage/eslint-plugin-destructuring/blob/HEAD/docs/rules/in-params.md
+         */
+        "destructuring/in-params": ["warn", { "max-params": 0 }],
+        /*
+         * When destructuring an object, you can provide the variable name in order to have
+         * the variable name differ from the object property. This can produce confusing code
+         * that is harder to read than ES5 code, therefore this rule prevents it unless the
+         *  object property is an invalid identifier (ie. a string literal).
+         *
+         * Off because we like renaming when destructuring
+         *
+         * https://github.com/lukeapage/eslint-plugin-destructuring/blob/HEAD/docs/rules/no-rename.md
+         */
+        "destructuring/no-rename": "off",
+    },
+};

package/dist/rules/eslint-comments.d.ts

@@ -0,0 +1,3 @@
+import type { Linter } from "eslint";
+export declare const eslintCommentsPluginConfig: Linter.Config;
+//# sourceMappingURL=eslint-comments.d.ts.map

package/dist/rules/eslint-comments.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"eslint-comments.d.ts","sourceRoot":"","sources":["../../src/rules/eslint-comments.ts"],"names":[],"mappings":"AAIA,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AASrC,eAAO,MAAM,0BAA0B,EAAE,MAAM,CAAC,MA+E/C,CAAC"}

package/dist/rules/eslint-comments.js

@@ -0,0 +1,77 @@
+import eslintComments from "@eslint-community/eslint-plugin-eslint-comments";
+/*
+ * Additional ESLint rules for ESLint directive comments
+ * (e.g. //eslint-disable-line).
+ *
+ * https://eslint-community.github.io/eslint-plugin-eslint-comments/rules/
+ */
+export const eslintCommentsPluginConfig = {
+    plugins: {
+        "eslint-comments": eslintComments,
+    },
+    rules: {
+        /*
+         * Require a eslint-enable comment for every eslint-disable comment
+         *
+         * https://eslint-community.github.io/eslint-plugin-eslint-comments/rules/disable-enable-pair.html
+         */
+        "eslint-comments/disable-enable-pair": "warn",
+        /*
+         * Disallow a eslint-enable comment for multiple eslint-disable comments
+         *
+         * https://eslint-community.github.io/eslint-plugin-eslint-comments/rules/no-aggregating-enable.html
+         */
+        "eslint-comments/no-aggregating-enable": "warn",
+        /*
+         * Disallow duplicate eslint-disable comments
+         *
+         * https://eslint-community.github.io/eslint-plugin-eslint-comments/rules/no-duplicate-disable.html
+         */
+        "eslint-comments/no-duplicate-disable": "warn",
+        /*
+         * Disallow eslint-disable comments without rule names
+         *
+         * https://eslint-community.github.io/eslint-plugin-eslint-comments/rules/no-restricted-disable.html
+         */
+        "eslint-comments/no-restricted-disable": "warn",
+        /*
+         * Disallow eslint-disable comments about specific rules
+         *
+         * https://eslint-community.github.io/eslint-plugin-eslint-comments/rules/no-unlimited-disable.html
+         */
+        "eslint-comments/no-unlimited-disable": "warn",
+        /*
+         * Disallow unused eslint-disable comments
+         *
+         * https://eslint-community.github.io/eslint-plugin-eslint-comments/rules/no-unused-disable.html
+         */
+        "eslint-comments/no-unused-disable": "warn",
+        /*
+         * Disallow unused eslint-enable comments
+         *
+         * https://eslint-community.github.io/eslint-plugin-eslint-comments/rules/no-unused-enable.html
+         */
+        "eslint-comments/no-unused-enable": "warn",
+        /*
+         * Disallow ESLint directive-comments
+         *
+         * Off for now because sometimes we have a good reason to use these
+         *
+         * https://eslint-community.github.io/eslint-plugin-eslint-comments/rules/no-use.html
+         */
+        "eslint-comments/no-use": "off",
+        /*
+         * This rule warns directive comments without description.
+         *
+         * https://eslint-community.github.io/eslint-plugin-eslint-comments/rules/require-description.html
+         */
+        "eslint-comments/require-description": [
+            "warn",
+            {
+                ignore: [
+                    "eslint-enable",
+                ],
+            },
+        ],
+    },
+};

package/dist/rules/import-newlines.d.ts

@@ -0,0 +1,3 @@
+import type { Linter } from "eslint";
+export declare const importNewlinesPluginConfig: Linter.Config;
+//# sourceMappingURL=import-newlines.d.ts.map

package/dist/rules/import-newlines.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"import-newlines.d.ts","sourceRoot":"","sources":["../../src/rules/import-newlines.ts"],"names":[],"mappings":"AAIA,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAQrC,eAAO,MAAM,0BAA0B,EAAE,MAAM,CAAC,MAqB/C,CAAC"}

package/dist/rules/import-newlines.js

@@ -0,0 +1,26 @@
+import importNewlines from "eslint-plugin-import-newlines";
+/*
+ * ESLint plugin for enforcing newlines in ES6 import statements past a certain number of items.
+ *
+ * https://www.npmjs.com/package/eslint-plugin-import-newlines
+ */
+export const importNewlinesPluginConfig = {
+    plugins: {
+        "import-newlines": importNewlines,
+    },
+    rules: {
+        /*
+         * ESLint plugin for enforcing newlines in ES6 import statements past a certain number of items.
+         *
+         * https://www.npmjs.com/package/eslint-plugin-import-newlines
+         */
+        "import-newlines/enforce": [
+            "warn",
+            {
+                items: 1,
+                "max-len": Number.POSITIVE_INFINITY,
+                semi: true,
+            },
+        ],
+    },
+};

package/dist/rules/import-x.d.ts

@@ -0,0 +1,3 @@
+import type { Linter } from "eslint";
+export declare const importXPluginConfig: Linter.Config;
+//# sourceMappingURL=import-x.d.ts.map

package/dist/rules/import-x.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"import-x.d.ts","sourceRoot":"","sources":["../../src/rules/import-x.ts"],"names":[],"mappings":"AAIA,OAAO,KAAK,EAER,MAAM,EACT,MAAM,QAAQ,CAAC;AAGhB,eAAO,MAAM,mBAAmB,EAAE,MAAM,CAAC,MA6fxC,CAAC"}