@newskit-render/core 4.23.29 → 4.24.0-alpha.1

package/CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [4.23.29](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@4.23.29-alpha.2...@newskit-render/core@4.23.29) (2024-04-17)
+
+**Note:** Version bump only for package @newskit-render/core
+
+
+
+
+
 ## [4.23.28](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@4.23.28-alpha.0...@newskit-render/core@4.23.28) (2024-04-15)
 
 **Note:** Version bump only for package @newskit-render/core

package/helpers/mocks/index.ts

@@ -1,9 +1,7 @@
 import getRadioPosts from './getRadioPostsMock'
 import getRadioPost from './getRadioPostMock'
 import getPage from './getPageMock'
-import getUniversalArticle from './getUniversalArticleMock'
 
 export const getRadioPostsMock = getRadioPosts
 export const getRadioPostMock = getRadioPost
 export const getPageMock = getPage
-export const getUniversalArticleMock = getUniversalArticle

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@newskit-render/core",
-  "version": "4.23.29",
+  "version": "4.24.0-alpha.1",
   "description": "Newskit Render - Core package",
   "author": "",
   "license": "UNLICENSED",
@@ -47,7 +47,7 @@
     "@newskit-render/checkout": "^3.9.19",
     "@newskit-render/feature-flags": "^1.7.0",
     "@newskit-render/feed": "^1.8.5",
-    "@newskit-render/my-account": "^7.41.0",
+    "@newskit-render/my-account": "^7.41.1-alpha.0",
     "@newskit-render/shared-components": "^4.22.0",
     "@newskit-render/standalone-components": "^3.20.12",
     "@newskit-render/validation": "^1.14.0",

package/queries/index.ts

@@ -1,4 +1,3 @@
 export * from './getRadioPost'
 export * from './getRadioPosts'
 export * from './getPage'
-export * from './getUniversalArticle'

package/__tests__/pages/[articleSlug].test.tsx

@@ -1,185 +0,0 @@
-import useSWR from 'swr'
-import { act } from '@testing-library/react'
-import { recomendationsMock } from '../../helpers/mocks/getRecommendationsMock'
-import Article, {
-  ArticleSlug,
-  getServerSideProps,
-} from '../../pages/[section]/[articleId]/[articleSlug]'
-import { renderWithTheme } from '../../helpers/test-utils'
-import { URL, Slug } from '../../helpers/global-types'
-
-const props: ArticleSlug = {
-  universalArticle: {
-    id: 'demo-1',
-    url: 'https://mock-site-url/some-location' as URL,
-    label: 'Mock label',
-    slug: 'some-location' as Slug,
-    publisher: 'DEMO',
-    headline:
-      'Mock Article: Lorem ipsum dolor sit amet consectetur adipiscing elit',
-    kicker: '',
-    authors: undefined,
-    flags: [],
-    topics: [
-      {
-        name: 'Some topic one',
-        slug: 'some-topic-one',
-        link: undefined,
-      },
-      {
-        name: 'Some topic one',
-        slug: 'some-topic-one',
-        link: undefined,
-      },
-    ],
-    template: undefined,
-    bylines: [
-      {
-        type: 'author',
-        slug: 'mock-author',
-        name: 'Mock Author',
-      },
-      {
-        value: 'Chief Mock Author',
-        type: 'inline',
-      },
-    ],
-    publishedDateTime: '2019-02-14T00:00:00.000Z',
-    updatedDateTime: '2019-02-14T00:37:17.000Z',
-    summary: {
-      children: [
-        {
-          text: 'Lorem ipsum',
-        },
-      ],
-    },
-  },
-  articleURL: 'https://hostname/section/test-1/slugche' as URL,
-  twitterUsername: 'D_Trump',
-  siteHost: 'https://hostname',
-  gscId: '4320982',
-  articleId: 'test-1',
-}
-
-const user = {
-  paymentFailure: {
-    active: false,
-    startDate: null,
-  },
-  subscriptions: [{ endDate: null }],
-}
-
-jest.mock('swr')
-let swrMock
-
-jest.mock('next/router', () => {
-  return {
-    useRouter: () => ({ asPath: '' }),
-  }
-})
-
-jest.mock('../../config', () => ({
-  twitterUsername: 'D_Trump',
-  gscId: '4320982',
-}))
-
-jest.mock('cross-fetch', () =>
-  jest.fn().mockImplementation(() =>
-    Promise.resolve({
-      json: () => Promise.resolve(user),
-    })
-  )
-)
-
-jest.mock('newrelic', () => {
-  return {
-    setTransactionName: jest.fn(),
-  }
-})
-
-/* start cra-effected */
-jest.mock('@newskit-render/feature-flags', () => ({
-  initAndGetFeatureFlag: jest
-    .fn()
-    .mockImplementation(() => Promise.resolve({ test: 'test' })),
-}))
-/* end cra-effected */
-
-jest.mock('@newskit-render/api', () => ({
-  ClientTypes: { nkapi: 'nkapi' },
-  createApolloClient: jest.fn().mockImplementation(() => {
-    return Promise.resolve({
-      query: jest.fn().mockResolvedValueOnce({
-        data: {
-          universalArticle: props.universalArticle,
-        },
-      }),
-    })
-  }),
-  getAcsCookie: jest.fn().mockReturnValue({ Cookie: 'something' }),
-  Publisher: {
-    SUN_UK: 'SUN_UK',
-  },
-}))
-
-jest.mock('@newskit-render/my-account', () => {
-  return {
-    PastDueBannerExternal: 'PastDueBannerExternal',
-  }
-})
-
-describe('Article', () => {
-  describe('getServerSideProps', () => {
-    it('should return props', async () => {
-      const setHeaderMock = jest.fn()
-
-      const response = await getServerSideProps({
-        params: {
-          articleId: 'test-1',
-          section: 'section',
-          articleSlug: 'slugche',
-        },
-        req: { headers: { cookie: 'some-cookie', host: 'hostname' } },
-        res: { setHeader: setHeaderMock },
-      })
-      expect(response).toMatchObject({
-        props: {
-          ...props,
-          showAds: true,
-          user,
-          featureFlags: { test: 'test' } /* cra-effected */,
-        },
-      })
-      expect(setHeaderMock).toHaveBeenCalledWith(
-        'Cache-Control',
-        'public, s-maxage=10, stale-while-revalidate=59'
-      )
-    })
-  })
-})
-
-describe('Recommendation', () => {
-  beforeEach(() => {
-    swrMock = useSWR as jest.Mock
-  })
-  afterEach(() => {
-    jest.resetAllMocks()
-  })
-  it('render related article page when data is null page', async () => {
-    let result
-    await act(async () => {
-      swrMock.mockReturnValueOnce({ data: null })
-      result = renderWithTheme(Article, props)
-    })
-    expect(result.asFragment()).toMatchSnapshot()
-  })
-  it('render related article page', async () => {
-    let result
-    await act(async () => {
-      swrMock.mockReturnValueOnce({ data: recomendationsMock })
-      result = renderWithTheme(Article, props)
-    })
-    expect(result.findByTestId('article-recommendation-small')).toBeDefined()
-    expect(result.findByTestId('articleRec-1')).toBeDefined()
-  })
-})