@newskit-render/core 4.13.0-alpha.1 → 4.13.0-alpha.3

package/README.md

@@ -258,14 +258,14 @@ export { AppContextProvider, AppContext }
 You may see some lines of code that have comments next to them:
 
 ```
-code here /* cra-effected */
+code here. /* cra-effected */
 ```
 
 Or around them:
 
 ```
 /* start cra-effected */
-code here
+code here.
 /* end cra-effected */
 ```
 

package/cypress/e2e/account/account-page.cy.js

@@ -105,63 +105,6 @@ describe('My account personal details', () => {
   //   cy.contains('21/03/1988')
   // })
 
-  it('Should go to edit page and change display name ', () => {
-    cy.get('a[href="/account/edit/displayName"]')
-      .should('be.visible')
-      .click({ force: true })
-    cy.get('[name="displayName"]').clear().type('NKDN')
-    cy.get('[data-testid="primary-button"]').scrollIntoView().click()
-    cy.contains(
-      '[data-testid="toast-container"]',
-      'Updating your display name...'
-    )
-    // Redirects to Personal details page
-    cy.contains(
-      '[data-testid="toast-container"]',
-      'Your display name has been updated.'
-    )
-  })
-
-  it('Should show error toast when updating display name', () => {
-    cy.intercept('POST', '/api/account/mutate', { statusCode: 500 })
-    cy.get('a[href="/account/edit/displayName"]')
-      .should('be.visible')
-      .click({ force: true })
-    cy.get('[name="displayName"]').clear().type('Rock')
-    cy.get('[data-testid="primary-button"]')
-      .scrollIntoView()
-      .click({ force: true })
-    cy.contains(
-      '[data-testid="toast-container"]',
-      'Updating your display name...'
-    )
-    cy.contains(
-      '[data-testid="toast-container"]',
-      "Sorry, we're unable to save your display name right now. Please try again or come back later."
-    )
-  })
-
-  it('Should show error message when display name is empty', () => {
-    cy.get('a[href="/account/edit/displayName"]')
-      .should('be.visible')
-      .click({ force: true })
-    cy.get('[name="displayName"]').clear()
-    cy.get('[data-testid="primary-button"]').scrollIntoView().click()
-    cy.contains('Please enter your Display Name')
-  })
-
-  it('Should go back to Personal Details on clicking cancel button', () => {
-    cy.get('a[href="/account/edit/displayName"]')
-      .should('be.visible')
-      .click({ force: true })
-    cy.get('[data-testid="secondary-button"]')
-      .should('be.visible')
-      .click({ force: true })
-    cy.location().should((loc) => {
-      expect(loc.pathname).to.eq('/account')
-    })
-  })
-
   // it('Should go to edit page and change email', () => {
   //   const currentEmail = 'render.e2e.default@yopmail.com'
   //   const newEmail = 'render.e2e.default2@yopmail.com'
@@ -368,3 +311,67 @@ describe('My account personal details', () => {
     cy.url().should('eq', 'http://localhost:3000/account')
   })
 })
+
+describe('My account personal details - Display name', () => {
+  beforeEach(() => {
+    cy.GetTnlAcsSession('tnl')
+    cy.mockConsentAndVisit('/account')
+  })
+
+  it('Should go to edit page and change display name ', () => {
+    cy.get('a[href="/account/edit/displayName"]')
+      .should('be.visible')
+      .click({ force: true })
+    cy.get('[name="displayName"]').clear().type('NKDN')
+    cy.get('[data-testid="primary-button"]').scrollIntoView().click()
+    cy.contains(
+      '[data-testid="toast-container"]',
+      'Updating your display name...'
+    )
+    // Redirects to Personal details page
+    cy.contains(
+      '[data-testid="toast-container"]',
+      'Your display name has been updated.'
+    )
+  })
+
+  it('Should show error toast when updating display name', () => {
+    cy.intercept('POST', '/api/account/mutate', { statusCode: 500 })
+    cy.get('a[href="/account/edit/displayName"]')
+      .should('be.visible')
+      .click({ force: true })
+    cy.get('[name="displayName"]').clear().type('Rock')
+    cy.get('[data-testid="primary-button"]')
+      .scrollIntoView()
+      .click({ force: true })
+    cy.contains(
+      '[data-testid="toast-container"]',
+      'Updating your display name...'
+    )
+    cy.contains(
+      '[data-testid="toast-container"]',
+      "Sorry, we're unable to save your display name right now. Please try again or come back later."
+    )
+  })
+
+  it('Should show error message when display name is empty', () => {
+    cy.get('a[href="/account/edit/displayName"]')
+      .should('be.visible')
+      .click({ force: true })
+    cy.get('[name="displayName"]').clear()
+    cy.get('[data-testid="primary-button"]').scrollIntoView().click()
+    cy.contains('Please enter your Display Name')
+  })
+
+  it('Should go back to Personal Details on clicking cancel button', () => {
+    cy.get('a[href="/account/edit/displayName"]')
+      .should('be.visible')
+      .click({ force: true })
+    cy.get('[data-testid="secondary-button"]')
+      .should('be.visible')
+      .click({ force: true })
+    cy.location().should((loc) => {
+      expect(loc.pathname).to.eq('/account')
+    })
+  })
+})

package/cypress/e2e/account/account-subscription.cy.js

@@ -260,6 +260,7 @@ describe('Account Subscription & Cancellation', () => {
     cy.contains(
       'Please note that if you choose a delivery location that is not secure we cannot be liable for lost or stolen newspapers.'
     )
+    cy.get('textarea[name="other"]').clear()
     cy.get('[data-testid="primary-button"]').scrollIntoView().click()
     cy.contains('Please enter your delivery instructions.')
     cy.get('textarea[name="other"]')

package/cypress/e2e/account/commenting-notifications.cy.js

@@ -1,6 +1,6 @@
 describe('My account commenting notifications', () => {
   beforeEach(() => {
-    cy.GetAcsSession()
+    cy.GetTnlAcsSession('tnl')
     cy.mockConsentAndVisit('/account/edit/commenting-notifications')
   })
 

package/infrastructure/.circleci/config.yml

@@ -254,6 +254,7 @@ commands:
             echo 'export HELM_OPT_SET="$HELM_OPT_SET --set envs.TEALIUM_ACCOUNT_ID=${TEALIUM_ACCOUNT_ID}"' >> $BASH_ENV
             echo 'export HELM_OPT_SET="$HELM_OPT_SET --set envs.TEALIUM_PROFILE_ID=${TEALIUM_PROFILE_ID}"' >> $BASH_ENV
             echo 'export HELM_OPT_SET="$HELM_OPT_SET --set envs.TEALIUM_ENV=${TEALIUM_ENV}"' >> $BASH_ENV
+            echo 'export HELM_OPT_SET="$HELM_OPT_SET --set secret.items.COMMENTING_ADMIN_SERVICE_URL=${COMMENTING_ADMIN_SERVICE_URL}"' >> $BASH_ENV
             echo 'export HELM_OPT_SET="$HELM_OPT_SET --set secret.items.NEW_RELIC_LICENSE_KEY=${NEW_RELIC_LICENSE_KEY}"' >> $BASH_ENV
             echo 'export HELM_OPT_SET="$HELM_OPT_SET --set secret.items.ACCOUNT_PROVIDER_GRAPHQL_URL=${ACCOUNT_PROVIDER_GRAPHQL_URL}"' >> $BASH_ENV
             echo 'export HELM_OPT_SET="$HELM_OPT_SET --set secret.items.ACCOUNT_PROVIDER_INTERNAL_AUTH0_DOMAIN=${ACCOUNT_PROVIDER_INTERNAL_AUTH0_DOMAIN}"' >> $BASH_ENV

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@newskit-render/core",
-  "version": "4.13.0-alpha.1",
+  "version": "4.13.0-alpha.3",
   "description": "Newskit Render - Core package",
   "author": "",
   "license": "UNLICENSED",
@@ -40,14 +40,14 @@
     "@emotion-icons/material-outlined": "3.14.0",
     "@emotion/react": "11.9.3",
     "@emotion/styled": "11.9.3",
-    "@newskit-render/api": "^1.8.0-alpha.1",
+    "@newskit-render/api": "^1.8.0-alpha.2",
     "@newskit-render/auth": "^1.6.0-alpha.1",
-    "@newskit-render/checkout": "^3.6.0-alpha.1",
+    "@newskit-render/checkout": "^3.6.0-alpha.2",
     "@newskit-render/feature-flags": "^1.6.0-alpha.1",
-    "@newskit-render/feed": "^1.7.0-alpha.1",
-    "@newskit-render/my-account": "^6.18.0-alpha.1",
+    "@newskit-render/feed": "^1.7.0-alpha.2",
+    "@newskit-render/my-account": "^6.18.0-alpha.2",
     "@newskit-render/shared-components": "^3.20.0-alpha.1",
-    "@newskit-render/standalone-components": "^3.15.0-alpha.1",
+    "@newskit-render/standalone-components": "^3.15.0-alpha.2",
     "@newskit-render/validation": "^1.11.0-alpha.1",
     "cross-fetch": "3.1.5",
     "graphql": "16.6.0",