@newskit-render/core 2.24.0 → 2.24.1

package/CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [2.24.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@2.24.0-alpha.0...@newskit-render/core@2.24.0) (2022-11-28)
+
+**Note:** Version bump only for package @newskit-render/core
+
+
+
+
+
 # [2.23.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@2.23.0-alpha.0...@newskit-render/core@2.23.0) (2022-11-24)
 
 **Note:** Version bump only for package @newskit-render/core

package/cypress/e2e/account/accessibility.spec.js

@@ -35,7 +35,11 @@ const pages = [
   },
   {
     url: '/account/edit/delivery-instructions',
-    name: 'delivery instructions form',
+    name: 'Delivery Instructions form',
+  },
+  {
+    url: '/account/holiday-stop',
+    name: 'Holiday Stops',
   },
 ]
 

package/cypress/e2e/account/account-edit-page.spec.js

@@ -26,9 +26,6 @@ describe('Address outside delivery area', () => {
       '[data-testid="toast-container"]',
       'As your new address is outside of our delivery area it has not been updated.'
     )
-    cy.url().should(
-      'eq',
-      'http://localhost:3000/account/subscription-and-billing'
-    )
+    cy.url().should('eq', 'http://localhost:3000/account')
   })
 })

package/cypress/e2e/account/holiday-stop.spec.js

@@ -1,12 +1,12 @@
-describe('Book a holiday stop', () => {
+describe('Book a Holiday Stop', () => {
   beforeEach(() => {
     cy.GetTnlAcsSession('tnl')
     cy.mockConsentAndVisit('/account/holiday-stop')
   })
 
-  it('should display book a holiday stop page', () => {
+  it('should display book a Holiday Stop page', () => {
     cy.get('a[href="/account/subscription-and-billing"]').should('be.visible')
-    cy.contains('[data-testid="introduction-title"]', 'Book a holiday stop')
+    cy.contains('[data-testid="introduction-title"]', 'Book a Holiday Stop')
     cy.contains('Add a Holiday Stop')
     cy.get('a[href="/account/holiday-stop/upcoming-holiday-stops"]').should(
       'exist'
@@ -14,13 +14,13 @@ describe('Book a holiday stop', () => {
   })
 })
 
-describe('Upcoming holiday stops', () => {
+describe('Upcoming Holiday Stops', () => {
   beforeEach(() => {
     cy.GetTnlAcsSession('tnl')
     cy.mockConsentAndVisit('/account/holiday-stop')
   })
 
-  it('should navigate to the Upcoming holiday stops and display the list of upcoming holiday stops', () => {
+  it('should navigate to the Upcoming Holiday Stops and display the list of upcoming Holiday Stops', () => {
     cy.get('a[href="/account/holiday-stop/upcoming-holiday-stops"]').should(
       'exist'
     )
@@ -31,13 +31,13 @@ describe('Upcoming holiday stops', () => {
   })
 })
 
-describe('Cancel holiday stop', () => {
+describe('Cancel Holiday Stop', () => {
   beforeEach(() => {
     cy.GetTnlAcsSession('tnl')
     cy.mockConsentAndVisit('/account/holiday-stop')
   })
 
-  it('should show popup and cancel holiday stop', () => {
+  it('should show popup and cancel Holiday Stop', () => {
     cy.intercept('POST', '/api/account/mutate', {
       statusCode: 200,
       body: { data: { deleteUserHolidayStop: { success: true } } },
@@ -49,22 +49,72 @@ describe('Cancel holiday stop', () => {
     cy.get('[data-testid="primary-button"]').click()
     cy.contains(
       '[data-testid="toast-container"]',
-      'Your holiday stop was successfully cancelled'
+      'Your Holiday Stop was successfully cancelled'
     )
   })
 })
 
+describe('Edit button Holiday Stop', () => {
+  beforeEach(() => {
+    cy.GetTnlAcsSession('tnl')
+    cy.mockConsentAndVisit('/account/holiday-stop')
+  })
+
+  it('should show redirect to edit page and show corrensponding data', () => {
+    cy.intercept('POST', '/api/account/mutate', {
+      statusCode: 200,
+      body: { data: { updateUserHolidayStop: { success: true } } },
+    })
+
+    cy.get('[data-testid="content-list"] > ul > li')
+      .eq(1)
+      .contains('Edit')
+      .click()
+
+    cy.url().should('match', /\/account\/edit\/holiday-stop?/)
+
+    cy.get('[name="startDate"]').invoke('val').should('equal', '18/10/2023')
+    cy.get('[name="endDate"]').invoke('val').should('equal', '20/10/2023')
+
+    const dateFormatOptions = {
+      year: 'numeric',
+      month: 'numeric',
+      day: 'numeric',
+    }
+    cy.get('[id="startDate"]').should('be.visible').click({ force: true })
+
+    cy.get('input[name="startDate"]')
+      .clear()
+      .type(
+        new Date('10/18/2023').toLocaleDateString('en-GB', dateFormatOptions)
+      )
+    cy.get('input[name="endDate"]')
+      .clear()
+      .type(
+        new Date('10/20/2023').toLocaleDateString('en-GB', dateFormatOptions)
+      )
+
+    cy.get('body').click({ force: true })
+    cy.contains('[data-testid="primary-button"]', 'Save').click()
+    cy.contains('[data-testid="modal"]', 'Holiday Stop updated')
+    cy.contains('[data-testid="primary-button"]', 'OK').click()
+    cy.url().should('match', /account\/holiday-stop/)
+  })
+})
+
 describe('Add a Holiday Stop', () => {
   beforeEach(() => {
     cy.GetTnlAcsSession('tnl')
     cy.mockConsentAndVisit('/account/add/holiday-stop')
   })
-  it('should display add holiday stop page', () => {
+  it('should display add Holiday Stop page', () => {
     cy.get('[data-testid="introduction-title"]').contains('Add a Holiday Stop')
     cy.get('[data-testid="create-holiday-stop"]').should('exist')
     cy.get('[data-testid="description-block"]').contains('Choose your dates')
+
     cy.get('[id="startDate"]').should('exist')
     cy.get('[id="endDate"]').should('exist')
+
     cy.get('[data-testid="primary-button"]').should('exist')
     cy.get('[data-testid="secondary-button"]')
       .should('have.attr', 'href', '/account/holiday-stop')
@@ -120,7 +170,7 @@ describe('Edit Holiday Stops', () => {
       ]
     )
   })
-  it('should display edit holiday stop page', () => {
+  it('should display edit Holiday Stop page', () => {
     cy.get('[data-testid="introduction-title"]').contains('Edit a Holiday Stop')
     cy.get('[data-testid="update-holiday-stop"]').should('exist')
     cy.get('[name="startDate"]').invoke('val').should('equal', '12/10/2022')

package/cypress/visual/account/visual-regression.spec.js

@@ -22,6 +22,10 @@ const pages = [
     url: '/account/edit/delivery-instructions',
     pageName: 'delivery instructions form',
   },
+  {
+    url: '/account/holiday-stop',
+    pageName: 'Holiday Stops',
+  },
 ]
 
 describe('Visual regression', () => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@newskit-render/core",
-  "version": "2.24.0",
+  "version": "2.24.1",
   "description": "Newskit Render - Core package",
   "author": "",
   "license": "UNLICENSED",
@@ -40,12 +40,12 @@
     "@emotion/styled": "11.10.4",
     "@newskit-render/api": "^1.4.0",
     "@newskit-render/auth": "^1.2.0",
-    "@newskit-render/checkout": "^1.7.0",
+    "@newskit-render/checkout": "^1.7.1",
     "@newskit-render/feature-flags": "^1.3.0",
     "@newskit-render/feed": "^1.3.0",
-    "@newskit-render/my-account": "^3.19.0",
-    "@newskit-render/shared-components": "^1.19.0",
-    "@newskit-render/standalone-components": "^1.12.0",
+    "@newskit-render/my-account": "^3.19.1",
+    "@newskit-render/shared-components": "^1.19.1",
+    "@newskit-render/standalone-components": "^1.12.1",
     "@newskit-render/validation": "^1.4.0",
     "cross-fetch": "3.1.5",
     "graphql": "15.6.0",