@newskit-render/core 2.23.0 → 2.24.0

package/.eslintrc

@@ -1,6 +1,6 @@
 {
   "plugins": ["prettier", "@typescript-eslint", "cypress"],
-  "extends": ["airbnb-typescript", "react-app", "prettier", "plugin:cypress/recommended"],
+  "extends": ["airbnb-typescript", "react-app", "prettier", "plugin:cypress/recommended","plugin:@next/next/recommended"],
   "parser": "@typescript-eslint/parser",
   "parserOptions": {
     "project": "./tsconfig.json"

package/CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [2.23.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@2.23.0-alpha.0...@newskit-render/core@2.23.0) (2022-11-24)
+
+**Note:** Version bump only for package @newskit-render/core
+
+
+
+
+
 ## [2.22.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@2.22.1-alpha.0...@newskit-render/core@2.22.1) (2022-11-23)
 
 **Note:** Version bump only for package @newskit-render/core

package/__tests__/pages/__snapshots__/[articleSlug].test.tsx.snap

@@ -1402,4 +1402,4 @@ exports[`Recommendation render related article page when data is null page 1`] =
     </div>
   </div>
 </DocumentFragment>
-`;
+`

package/components/article/__tests__/__snapshots__/index.test.tsx.snap

@@ -1688,4 +1688,4 @@ exports[`Article should render tile and sub title 1`] = `
     </div>
   </div>
 </DocumentFragment>
-`;
+`

package/components/header/index.tsx

@@ -35,7 +35,7 @@ const Header: React.FC<{ user: UserData }> = ({ user }) => {
 
   const { theme, setTheme } = useContext(AppContext)
   const themeDropdownObject = createThemeDropdownObject(setTheme)
-  const { sharedTheme, ...restThemes } = themeDropdownObject.options
+  const { ...restThemes } = themeDropdownObject.options
 
   const themeDropdownObjectUpdated = {
     ...themeDropdownObject,

package/components/layout/MainGrid.tsx

@@ -9,11 +9,11 @@ import {
 } from 'newskit'
 import { LayoutProps } from './layoutTypes'
 
-type StyledGrid = GridProps & {
+type StyledGridProps = GridProps & {
   backgroundColor?: string
 }
 
-const StyledGrid = styled(Grid)<StyledGrid>`
+const StyledGrid = styled(Grid)<StyledGridProps>`
   ${({ backgroundColor, theme }) =>
     `${getColorCssFromTheme(
       'backgroundColor',

package/components/section/CollectionBlock.tsx

@@ -1,4 +1,3 @@
-import { Block } from 'newskit'
 import React from 'react'
 import {
   CollectionBlock as Collection,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@newskit-render/core",
-  "version": "2.23.0",
+  "version": "2.24.0",
   "description": "Newskit Render - Core package",
   "author": "",
   "license": "UNLICENSED",
@@ -38,15 +38,15 @@
     "@emotion-icons/material-outlined": "3.14.0",
     "@emotion/react": "11.10.4",
     "@emotion/styled": "11.10.4",
-    "@newskit-render/api": "^1.3.0",
-    "@newskit-render/auth": "^1.1.1",
-    "@newskit-render/checkout": "^1.6.5",
-    "@newskit-render/feature-flags": "^1.2.0",
-    "@newskit-render/feed": "^1.2.2",
-    "@newskit-render/my-account": "^3.18.3",
-    "@newskit-render/shared-components": "^1.18.1",
-    "@newskit-render/standalone-components": "^1.11.1",
-    "@newskit-render/validation": "^1.3.2",
+    "@newskit-render/api": "^1.4.0",
+    "@newskit-render/auth": "^1.2.0",
+    "@newskit-render/checkout": "^1.7.0",
+    "@newskit-render/feature-flags": "^1.3.0",
+    "@newskit-render/feed": "^1.3.0",
+    "@newskit-render/my-account": "^3.19.0",
+    "@newskit-render/shared-components": "^1.19.0",
+    "@newskit-render/standalone-components": "^1.12.0",
+    "@newskit-render/validation": "^1.4.0",
     "cross-fetch": "3.1.5",
     "graphql": "15.6.0",
     "lodash.get": "4.4.2",
@@ -63,6 +63,7 @@
     "@applitools/eyes-cypress": "3.23.2",
     "@emotion/jest": "11.3.0",
     "@next/bundle-analyzer": "12.0.8",
+    "@next/eslint-plugin-next": "13.0.5",
     "@pact-foundation/pact": "9.12.1",
     "@testing-library/jest-dom": "5.16.5",
     "@testing-library/react": "13.4.0",
@@ -70,26 +71,26 @@
     "@types/react": "18.0.19",
     "@types/react-dom": "18.0.6",
     "@types/react-helmet": "6.1.0",
-    "@typescript-eslint/eslint-plugin": "3.7.1",
-    "@typescript-eslint/parser": "3.7.1",
+    "@typescript-eslint/eslint-plugin": "5.44.0",
+    "@typescript-eslint/parser": "5.44.0",
     "axe-core": "4.3.4",
     "babel-jest": "26.3.0",
     "cypress": "9.0.0",
     "cypress-axe": "0.13.0",
-    "eslint": "6.6.0",
-    "eslint-config-airbnb": "18.2.0",
-    "eslint-config-airbnb-typescript": "9.0.0",
-    "eslint-config-prettier": "6.11.0",
-    "eslint-config-react-app": "5.2.1",
-    "eslint-import-resolver-typescript": "2.0.0",
+    "eslint": "8.27.0",
+    "eslint-config-airbnb": "19.0.4",
+    "eslint-config-airbnb-typescript": "17.0.0",
+    "eslint-config-prettier": "8.5.0",
+    "eslint-config-react-app": "7.0.1",
+    "eslint-import-resolver-typescript": "3.5.2",
     "eslint-loader": "4.0.2",
-    "eslint-plugin-cypress": "2.11.2",
-    "eslint-plugin-flowtype": "5.2.0",
-    "eslint-plugin-import": "2.22.1",
-    "eslint-plugin-jsx-a11y": "6.2.3",
-    "eslint-plugin-prettier": "3.1.4",
-    "eslint-plugin-react": "7.19.0",
-    "eslint-plugin-react-hooks": "1.6.1",
+    "eslint-plugin-cypress": "2.12.1",
+    "eslint-plugin-flowtype": "8.0.3",
+    "eslint-plugin-import": "2.26.0",
+    "eslint-plugin-jsx-a11y": "6.6.1",
+    "eslint-plugin-prettier": "4.2.1",
+    "eslint-plugin-react": "7.31.10",
+    "eslint-plugin-react-hooks": "4.6.0",
     "jest": "27.4.7",
     "jest-junit": "12.0.0",
     "jest-watch-typeahead": "0.6.3",

package/pages/[section]/[articleId]/[articleSlug].tsx

@@ -1,5 +1,4 @@
 import React from 'react'
-import useSWR from 'swr'
 import newrelic from 'newrelic'
 import {
   createApolloClient,
@@ -35,7 +34,7 @@ export type ArticleSlug = {
   config: Config
 }
 
-const Article: React.FC<ArticleSlug> = ({
+const ArticleSlugPage: React.FC<ArticleSlug> = ({
   universalArticle,
   articleURL,
   twitterUsername,
@@ -100,4 +99,4 @@ export async function getServerSideProps(context) {
   }
 }
 
-export default Article
+export default ArticleSlugPage

package/pages/_document.tsx

@@ -61,6 +61,7 @@ export default class MyDocument extends Document {
           <>
             {fontList.map((font) => generateFontLink(font))}
             <Script
+              id="browser-script"
               type="text/javascript"
               data-attribute="nr-browser"
               dangerouslySetInnerHTML={{

package/pages/api/account/mutate/index.ts

@@ -2,5 +2,7 @@ import { NextApiRequest, NextApiResponse } from 'next'
 import { mutateHandler } from '@newskit-render/my-account'
 import validation from '../../../../validation'
 
-export default (req: NextApiRequest, res: NextApiResponse) =>
+const handler = (req: NextApiRequest, res: NextApiResponse) =>
   mutateHandler(req, res, validation)
+
+export default handler

package/pages/api/account/query/index.ts

@@ -1,5 +1,6 @@
 import { NextApiRequest, NextApiResponse } from 'next'
 import { queryHandler } from '@newskit-render/my-account'
 
-export default (req: NextApiRequest, res: NextApiResponse) =>
+const handler = (req: NextApiRequest, res: NextApiResponse) =>
   queryHandler(req, res)
+export default handler

package/pages/api/auth/[...nextauth].ts

@@ -2,9 +2,10 @@ import createAuthRoute from '@newskit-render/auth/providers'
 import { NextApiRequest, NextApiResponse } from 'next'
 import { oktaClientId, oktaClientSecret, oktaDomain } from '../../../config'
 
-export default (req: NextApiRequest, res: NextApiResponse) =>
+const router = (req: NextApiRequest, res: NextApiResponse) =>
   createAuthRoute(req, res, {
     clientId: oktaClientId,
     clientSecret: oktaClientSecret,
     issuer: oktaDomain,
   })
+export default router

package/temp/_document.tsx

@@ -31,6 +31,7 @@ export default class MyDocument extends Document {
         <Head>
           <>
             <Script
+                id="browser-script"
                 type="text/javascript"
                 data-attribute="nr-browser"
                 dangerouslySetInnerHTML={{