@newskit-render/core 1.87.1 → 1.87.3-alpha.0

package/CHANGELOG.md

@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.87.2](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.87.2-alpha.0...@newskit-render/core@1.87.2) (2022-09-08)
+
+**Note:** Version bump only for package @newskit-render/core
+
+
+
+
+
+## [1.87.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.87.1-alpha.0...@newskit-render/core@1.87.1) (2022-09-08)
+
+**Note:** Version bump only for package @newskit-render/core
+
+
+
+
+
 # [1.87.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.87.0-alpha.0...@newskit-render/core@1.87.0) (2022-09-07)
 
 **Note:** Version bump only for package @newskit-render/core

package/__pacts__/spec/interactions/interactUniversalArticle.ts

@@ -0,0 +1,80 @@
+import { GraphQLInteraction, Matchers } from '@pact-foundation/pact'
+import { print } from 'graphql/language/printer'
+import { GET_UNIVERSAL_ARTICLE } from '../../../queries'
+
+const { like, eachLike } = Matchers
+
+const interactUniversalArticle = ({
+  id,
+  publisher,
+}: {
+  id: string
+  publisher: string
+}) => {
+  return new GraphQLInteraction()
+    .uponReceiving('Universal Article')
+    .withRequest({
+      path: '/',
+      method: 'POST',
+      headers: {
+        'content-type': 'application/json',
+      },
+    })
+    .withOperation('getUniversalArticle')
+    .withQuery(print(GET_UNIVERSAL_ARTICLE))
+    .withVariables({ id, publisher })
+    .willRespondWith({
+      status: 200,
+      body: {
+        data: {
+          universalArticle: {
+            id: like('17842504'),
+            url: like('https://mock-site-url/some-location'),
+            label: like(''),
+            slug: like('some-location'),
+            publisher: like('DEMO'),
+            headline: like(
+              "Drying your wet iPhone in rice 'is a MYTH' – how to save a soaked mobile"
+            ),
+            kicker: like('WAT-ER PUZZLE!'),
+            flags: eachLike(''),
+            topics: [
+              {
+                name: like('some name'),
+                slug: like('some name'),
+                link: like('some name'),
+              },
+            ],
+            template: like('theme-tech'),
+            bylines: [
+              {
+                type: like('inline'),
+                value: like('Sean Keach'),
+              },
+            ],
+            publishedDateTime: like('2022-03-04T11:35:13.000Z'),
+            updatedDateTime: like('2022-03-04T11:35:18.000Z'),
+            summary: {
+              children: [
+                {
+                  text: like(
+                    'There are more effective ways to dry out your iPhone – and using rice could even cause damage to your handset.'
+                  ),
+                },
+              ],
+            },
+            media: {
+              crops: eachLike({
+                url:
+                  'https://www.thesun.co.uk/wp-content/uploads/2022/03/iphone-in-rice.jpg?strip=all&w=620&h=413&crop=1',
+                alt: null,
+                aspectRatio: 'landscape',
+              }),
+            },
+          },
+        },
+      },
+    })
+}
+
+export default interactUniversalArticle

package/__pacts__/spec/newskitApi.consumer.pact.ts

@@ -1,82 +1,17 @@
-import { GraphQLInteraction, Matchers } from '@pact-foundation/pact'
-import { print } from 'graphql/language/printer'
 import provider from './newskitApi.mock.provider'
 import getUniversalArticle from '../client'
-import { GET_UNIVERSAL_ARTICLE } from '../../queries'
-
-const { like, eachLike } = Matchers
+import interactUniversalArticle from './interactions/interactUniversalArticle'
 
 describe('Test pact with Newskit Api', () => {
   describe('When a request to get Universal Article is made', () => {
     beforeAll(async () => {
-      await provider.setup().then(() => {
-        const id = '17842504'
-        const publisher = 'DEMO'
-        provider.addInteraction(
-          new GraphQLInteraction()
-            .uponReceiving('Universal Article')
-            .withRequest({
-              path: '/',
-              method: 'POST',
-              headers: {
-                'content-type': 'application/json',
-              },
-            })
-            .withOperation('getUniversalArticle')
-            .withQuery(print(GET_UNIVERSAL_ARTICLE))
-            .withVariables({ id, publisher })
-            .willRespondWith({
-              status: 200,
-              body: {
-                data: {
-                  universalArticle: {
-                    id: like('17842504'),
-                    url: like('https://mock-site-url/some-location'),
-                    // label: like(''),
-                    slug: like('some-location'),
-                    publisher: like('DEMO'),
-                    headline: like(
-                      "Drying your wet iPhone in rice 'is a MYTH' – how to save a soaked mobile"
-                    ),
-                    kicker: like('WAT-ER PUZZLE!'),
-                    flags: eachLike(''),
-                    bylines: [
-                      {
-                        type: like('inline'),
-                        value: like('Sean Keach'),
-                      },
-                    ],
-                    publishedDateTime: like('2022-03-04T11:35:13.000Z'),
-                    updatedDateTime: like('2022-03-04T11:35:18.000Z'),
-                    summary: {
-                      children: [
-                        {
-                          text: like(
-                            'There are more effective ways to dry out your iPhone – and using rice could even cause damage to your handset.'
-                          ),
-                        },
-                      ],
-                    },
-                    media: {
-                      crops: eachLike({
-                        url:
-                          'https://www.thesun.co.uk/wp-content/uploads/2022/03/iphone-in-rice.jpg?strip=all&w=620&h=413&crop=1',
-                        alt: null,
-                        aspectRatio: 'landscape',
-                      }),
-                    },
-                  },
-                },
-              },
-            })
-        )
-      })
+      await provider.setup()
     })
 
     test('should return the correct data', async () => {
-      await expect(
-        getUniversalArticle({ id: '17842504', publisher: 'DEMO' })
-      ).resolves.not.toThrowError()
+      const article = { id: '17842504', publisher: 'DEMO' }
+      await provider.addInteraction(interactUniversalArticle(article))
+      await expect(getUniversalArticle(article)).resolves.not.toThrowError()
     })
 
     afterEach(() => {

package/__pacts__/spec/newskitApi.mock.provider.ts

@@ -7,6 +7,6 @@ export default new Pact({
   dir: path.resolve(__dirname, '../pacts'),
   log: path.resolve(__dirname, '../logs', 'pact.log'),
   logLevel: 'debug',
-  port: +(process.env.PORT || '3000'),
+  port: +process.env.PORT,
   spec: 2,
 })

package/newrelic.js

@@ -37,6 +37,7 @@ exports.config = {
      * production applications.
      */
     level: 'trace',
+    filepath: '',
   },
   /**
    * When true, all request headers except for those listed in attributes.exclude

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@newskit-render/core",
-  "version": "1.87.1",
+  "version": "1.87.3-alpha.0",
   "description": "Newskit Render - Core package",
   "author": "",
   "license": "UNLICENSED",