@newskit-render/core 1.54.0 → 1.66.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (44) hide show
  1. package/CHANGELOG.md +291 -0
  2. package/__pacts__/spec/newskitApi.consumer.pact.ts +19 -32
  3. package/__tests__/pages/[articleSlug].test.tsx +6 -8
  4. package/__tests__/pages/__snapshots__/brightcove.test.tsx.snap +20 -0
  5. package/__tests__/pages/__snapshots__/home.test.tsx.snap +139 -139
  6. package/__tests__/pages/brightcove.test.tsx +34 -0
  7. package/__tests__/pages/home.test.tsx +22 -18
  8. package/__tests__/pages/mocks.ts +29 -0
  9. package/__tests__/pages/relatedArticles.test.tsx +76 -0
  10. package/components/article/RelatedArticles.tsx +48 -55
  11. package/components/article/__tests__/__snapshots__/index.test.tsx.snap +305 -308
  12. package/components/article/__tests__/index.test.tsx +46 -2
  13. package/components/article/index.tsx +28 -15
  14. package/components/footer/__snapshots__/index.test.tsx.snap +29 -29
  15. package/components/section/layouts/Rows.tsx +36 -17
  16. package/components/section/layouts/__tests__/Rows.test.tsx +12 -0
  17. package/components/section/layouts/__tests__/__snapshots__/Lead.test.tsx.snap +17 -17
  18. package/components/section/layouts/__tests__/__snapshots__/SectionTitle.test.tsx.snap +23 -23
  19. package/components/section/layouts/types.ts +3 -0
  20. package/config/index.ts +85 -0
  21. package/constants/index.ts +3 -1
  22. package/cypress/e2e/account/accessibility.spec.js +14 -17
  23. package/helpers/logger.ts +3 -1
  24. package/helpers/mocks/articleMock.ts +1 -1
  25. package/helpers/mocks/getUniversalArticleMock.ts +13 -0
  26. package/infrastructure/helm/values-dev.yaml +1 -1
  27. package/infrastructure/helm/values-pr.yaml +1 -1
  28. package/infrastructure/helm/values-prod.yaml +1 -1
  29. package/jest.config.js +1 -0
  30. package/package.json +11 -11
  31. package/pages/[section]/[articleId]/[articleSlug].tsx +9 -4
  32. package/pages/[section]/[articleId]/relatedArticles.tsx +85 -0
  33. package/pages/_app.tsx +5 -3
  34. package/pages/_document.tsx +17 -18
  35. package/pages/api/auth/[...nextauth].ts +2 -3
  36. package/pages/api/feed.ts +3 -5
  37. package/pages/api/news-sitemap.ts +4 -6
  38. package/pages/api/sitemap.ts +10 -7
  39. package/pages/index.tsx +1 -0
  40. package/pages/player/brightcove.tsx +19 -0
  41. package/pages/preview/[articleId]/version/[versionId]/index.tsx +9 -4
  42. package/queries/getRadioPosts.ts +1 -1
  43. package/queries/getUniversalArticle.ts +13 -0
  44. package/temp/header.tsx +7 -0
package/CHANGELOG.md CHANGED
@@ -3,6 +3,297 @@
3
3
  All notable changes to this project will be documented in this file.
4
4
  See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
5
5
 
6
+ # [1.66.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.66.0-alpha.0...@newskit-render/core@1.66.0) (2022-06-02)
7
+
8
+ **Note:** Version bump only for package @newskit-render/core
9
+
10
+
11
+
12
+
13
+
14
+ # [1.65.0-alpha.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.64.0...@newskit-render/core@1.65.0-alpha.0) (2022-06-01)
15
+
16
+
17
+ ### Features
18
+
19
+ * **PPDSR-XXX:** Update SSL certificate ([#737](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/737)) ([2b706e3](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/2b706e3fd9a6c935bfde15d7d1082a7f7937307e))
20
+
21
+
22
+
23
+
24
+
25
+ ## [1.64.1-alpha.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.64.0...@newskit-render/core@1.64.1-alpha.0) (2022-06-01)
26
+
27
+ **Note:** Version bump only for package @newskit-render/core
28
+
29
+
30
+
31
+
32
+
33
+ # [1.64.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.64.0-alpha.0...@newskit-render/core@1.64.0) (2022-05-31)
34
+
35
+ **Note:** Version bump only for package @newskit-render/core
36
+
37
+
38
+
39
+
40
+
41
+ ## [1.63.2](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.63.2-alpha.0...@newskit-render/core@1.63.2) (2022-05-31)
42
+
43
+ **Note:** Version bump only for package @newskit-render/core
44
+
45
+
46
+
47
+
48
+
49
+ ## [1.63.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.63.0...@newskit-render/core@1.63.1) (2022-05-31)
50
+
51
+ **Note:** Version bump only for package @newskit-render/core
52
+
53
+
54
+
55
+
56
+
57
+ # [1.63.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.63.0-alpha.0...@newskit-render/core@1.63.0) (2022-05-31)
58
+
59
+ **Note:** Version bump only for package @newskit-render/core
60
+
61
+
62
+
63
+
64
+
65
+ ## [1.62.2](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.62.2-alpha.0...@newskit-render/core@1.62.2) (2022-05-31)
66
+
67
+ **Note:** Version bump only for package @newskit-render/core
68
+
69
+
70
+
71
+
72
+
73
+ ## [1.62.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.62.1-alpha.0...@newskit-render/core@1.62.1) (2022-05-31)
74
+
75
+ **Note:** Version bump only for package @newskit-render/core
76
+
77
+
78
+
79
+
80
+
81
+ # [1.62.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.62.0-alpha.3...@newskit-render/core@1.62.0) (2022-05-31)
82
+
83
+ **Note:** Version bump only for package @newskit-render/core
84
+
85
+
86
+
87
+
88
+
89
+ # [1.62.0-alpha.2](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.62.0-alpha.1...@newskit-render/core@1.62.0-alpha.2) (2022-05-31)
90
+
91
+
92
+ ### Features
93
+
94
+ * **PPDSR-655:** update versions ([#741](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/741)) ([ace8042](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/ace80427b7f7ed35aa6f94461c87b5ec220d251b))
95
+
96
+
97
+
98
+
99
+
100
+ # [1.62.0-alpha.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.61.0-alpha.7...@newskit-render/core@1.62.0-alpha.1) (2022-05-31)
101
+
102
+
103
+ ### Features
104
+
105
+ * **PPDSR-655:** update versions ([#740](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/740)) ([c4c01b0](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/c4c01b0b34088aa2477f8fb981778a1e39db6c77))
106
+
107
+
108
+
109
+
110
+
111
+ # [1.61.0-alpha.7](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.61.0...@newskit-render/core@1.61.0-alpha.7) (2022-05-30)
112
+
113
+
114
+ ### Features
115
+
116
+ * **PPDSR-655:** add push version bump ([#739](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/739)) ([175ff0c](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/175ff0c045962999a7d567f369d136a6794f81ef))
117
+
118
+
119
+
120
+
121
+
122
+ # [1.61.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.61.0-alpha.6...@newskit-render/core@1.61.0) (2022-05-30)
123
+
124
+ **Note:** Version bump only for package @newskit-render/core
125
+
126
+
127
+
128
+
129
+
130
+ # [1.61.0-alpha.5](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.61.0-alpha.4...@newskit-render/core@1.61.0-alpha.5) (2022-05-30)
131
+
132
+ **Note:** Version bump only for package @newskit-render/core
133
+
134
+
135
+
136
+
137
+
138
+ # [1.61.0-alpha.4](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.61.0-alpha.3...@newskit-render/core@1.61.0-alpha.4) (2022-05-27)
139
+
140
+ **Note:** Version bump only for package @newskit-render/core
141
+
142
+
143
+
144
+
145
+
146
+ # [1.61.0-alpha.3](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.61.0-alpha.2...@newskit-render/core@1.61.0-alpha.3) (2022-05-27)
147
+
148
+ **Note:** Version bump only for package @newskit-render/core
149
+
150
+
151
+
152
+
153
+
154
+ # [1.61.0-alpha.2](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.61.0-alpha.1...@newskit-render/core@1.61.0-alpha.2) (2022-05-27)
155
+
156
+ **Note:** Version bump only for package @newskit-render/core
157
+
158
+
159
+
160
+
161
+
162
+ # [1.61.0-alpha.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.61.0-alpha.0...@newskit-render/core@1.61.0-alpha.1) (2022-05-27)
163
+
164
+ **Note:** Version bump only for package @newskit-render/core
165
+
166
+
167
+
168
+
169
+
170
+ # [1.61.0-alpha.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.60.0...@newskit-render/core@1.61.0-alpha.0) (2022-05-27)
171
+
172
+
173
+ ### Features
174
+
175
+ * **PPDSR-665:** update alpha build ([#719](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/719)) ([6d58e3a](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/6d58e3a8998319fb2f17b49fd79983149b5adbe4))
176
+
177
+
178
+
179
+
180
+
181
+ # [1.60.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.59.1...@newskit-render/core@1.60.0) (2022-05-26)
182
+
183
+
184
+ ### Features
185
+
186
+ * **PPDSR-XXX:** check can - deploy ([#727](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/727)) ([d7bdc9a](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/d7bdc9a2e69bf0b32626fbcc428481671f42a6ab))
187
+
188
+
189
+
190
+
191
+
192
+ ## [1.59.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.59.0...@newskit-render/core@1.59.1) (2022-05-25)
193
+
194
+ **Note:** Version bump only for package @newskit-render/core
195
+
196
+
197
+
198
+
199
+
200
+ # [1.59.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.57.1...@newskit-render/core@1.59.0) (2022-05-23)
201
+
202
+
203
+ ### Features
204
+
205
+ * **PPDSR-655:** Manual bump ([#724](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/724)) ([8faca40](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/8faca4071f156b93552851c8eb5f27fd697437c9))
206
+ * **PPDSR-721:** Cypress-axe tests ([#697](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/697)) ([77aae87](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/77aae87b512a489882b47ec37f3faafd40421a1d))
207
+
208
+
209
+
210
+
211
+
212
+ ## [1.57.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.57.0...@newskit-render/core@1.57.1) (2022-05-18)
213
+
214
+ **Note:** Version bump only for package @newskit-render/core
215
+
216
+
217
+
218
+
219
+
220
+ # [1.57.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.56.0...@newskit-render/core@1.57.0) (2022-05-16)
221
+
222
+
223
+ ### Features
224
+
225
+ * **PPDSR-692:** related-article-page ([#678](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/678)) ([66da5ee](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/66da5ee5a7c01c2d653ba2f686afb18415410913))
226
+
227
+
228
+
229
+
230
+
231
+ # [1.56.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.55.2...@newskit-render/core@1.56.0) (2022-05-16)
232
+
233
+
234
+ ### Features
235
+
236
+ * **PPDSR-792:** add styling to rec component ([#714](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/714)) ([a37c8c5](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/a37c8c5b0a485b3fcaefa1ed89001be839ab1ac9))
237
+
238
+
239
+
240
+
241
+
242
+ ## [1.55.2](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.55.1...@newskit-render/core@1.55.2) (2022-05-16)
243
+
244
+ **Note:** Version bump only for package @newskit-render/core
245
+
246
+
247
+
248
+
249
+
250
+ ## [1.55.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.55.0...@newskit-render/core@1.55.1) (2022-05-13)
251
+
252
+
253
+ ### Bug Fixes
254
+
255
+ * **PPDSR-763:** update the universal article query ([#715](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/715)) ([59e04bb](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/59e04bb04a52841a3d16641edead1e97b2e7af83))
256
+ * **TEST:** commentted out the failing e2e test ([#720](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/720)) ([814e09a](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/814e09a646ff951c0c3d64ea82bec2841816c452))
257
+
258
+
259
+
260
+
261
+
262
+ # [1.55.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.54.3...@newskit-render/core@1.55.0) (2022-05-10)
263
+
264
+
265
+ ### Features
266
+
267
+ * **PPDSR-763:** Integrate Brightcove video ([#706](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/706)) ([497131a](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/497131a83c6e74c2af19aa578e0249dd25fb835a))
268
+
269
+
270
+
271
+
272
+
273
+ ## [1.54.3](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.54.2...@newskit-render/core@1.54.3) (2022-05-10)
274
+
275
+ **Note:** Version bump only for package @newskit-render/core
276
+
277
+
278
+
279
+
280
+
281
+ ## [1.54.2](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.54.1...@newskit-render/core@1.54.2) (2022-05-05)
282
+
283
+ **Note:** Version bump only for package @newskit-render/core
284
+
285
+
286
+
287
+
288
+
289
+ ## [1.54.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.54.0...@newskit-render/core@1.54.1) (2022-05-05)
290
+
291
+ **Note:** Version bump only for package @newskit-render/core
292
+
293
+
294
+
295
+
296
+
6
297
  # [1.54.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.53.1...@newskit-render/core@1.54.0) (2022-05-04)
7
298
 
8
299
 
@@ -10,7 +10,7 @@ describe('Test pact with Newskit Api', () => {
10
10
  describe('When a request to get Universal Article is made', () => {
11
11
  beforeAll(async () => {
12
12
  await provider.setup().then(() => {
13
- const id = 'demo-9'
13
+ const id = '17842504'
14
14
  const publisher = 'DEMO'
15
15
  provider.addInteraction(
16
16
  new GraphQLInteraction()
@@ -30,54 +30,41 @@ describe('Test pact with Newskit Api', () => {
30
30
  body: {
31
31
  data: {
32
32
  universalArticle: {
33
- id: like('demo-9'),
33
+ id: like('17842504'),
34
34
  url: like('https://mock-site-url/some-location'),
35
- label: like('Mock label'),
35
+ // label: like(''),
36
36
  slug: like('some-location'),
37
37
  publisher: like('DEMO'),
38
38
  headline: like(
39
- 'Mock Article: Lorem ipsum dolor sit amet consectetur adipiscing elit'
39
+ "Drying your wet iPhone in rice 'is a MYTH' how to save a soaked mobile"
40
40
  ),
41
- kicker: like(''),
42
- flags: eachLike('UPDATED'),
41
+ kicker: like('WAT-ER PUZZLE!'),
42
+ flags: eachLike(''),
43
43
  bylines: [
44
44
  {
45
- type: like('author'),
46
- slug: like('mock-author'),
47
- name: like('Mock Author'),
48
- },
49
- {
50
- value: like('Chief Mock Author'),
51
45
  type: like('inline'),
46
+ value: like('Sean Keach'),
52
47
  },
53
48
  ],
54
- publishedDateTime: like('2019-02-14T00:00:00.000Z'),
55
- updatedDateTime: like('2019-02-14T00:37:17.000Z'),
49
+ publishedDateTime: like('2022-03-04T11:35:13.000Z'),
50
+ updatedDateTime: like('2022-03-04T11:35:18.000Z'),
56
51
  summary: {
57
52
  children: [
58
53
  {
59
54
  text: like(
60
- 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Duis eget lorem vel nunc feugiat malesuada ut ac nisi. Morbi odio ipsum, dignissim nec turpis vel, laoreet condimentum tortor. Duis laoreet tincidunt ullamcorper.'
61
- ),
62
- },
63
- {
64
- text: like(
65
- 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Duis eget lorem vel nunc feugiat malesuada ut ac nisi. Morbi odio ipsum, dignissim nec turpis vel, laoreet condimentum tortor. Duis laoreet tincidunt ullamcorper.'
66
- ),
67
- },
68
- {
69
- url: like('http://this-is-a-url/'),
70
- text: like(
71
- 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Duis eget lorem vel nunc feugiat malesuada ut ac nisi. Morbi odio ipsum, dignissim nec turpis vel, laoreet condimentum tortor. Duis laoreet tincidunt ullamcorper.'
72
- ),
73
- },
74
- {
75
- text: like(
76
- 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Duis eget lorem vel nunc feugiat malesuada ut ac nisi. Morbi odio ipsum, dignissim nec turpis vel, laoreet condimentum tortor. Duis laoreet tincidunt ullamcorper.'
55
+ 'There are more effective ways to dry out your iPhone and using rice could even cause damage to your handset.'
77
56
  ),
78
57
  },
79
58
  ],
80
59
  },
60
+ media: {
61
+ crops: eachLike({
62
+ url:
63
+ 'https://www.thesun.co.uk/wp-content/uploads/2022/03/iphone-in-rice.jpg?strip=all&w=620&h=413&crop=1',
64
+ alt: null,
65
+ aspectRatio: 'landscape',
66
+ }),
67
+ },
81
68
  },
82
69
  },
83
70
  },
@@ -88,7 +75,7 @@ describe('Test pact with Newskit Api', () => {
88
75
 
89
76
  test('should return the correct data', async () => {
90
77
  await expect(
91
- getUniversalArticle({ id: 'demo-9', publisher: 'DEMO' })
78
+ getUniversalArticle({ id: '17842504', publisher: 'DEMO' })
92
79
  ).resolves.not.toThrowError()
93
80
  })
94
81
 
@@ -89,6 +89,11 @@ const user = {
89
89
  subscriptions: [{ endDate: null }],
90
90
  }
91
91
 
92
+ jest.mock('../../config', () => ({
93
+ siteHost: 'hostname',
94
+ twitterUsername: 'D_Trump',
95
+ gscId: '4320982',
96
+ }))
92
97
  jest.mock('cross-fetch', () =>
93
98
  jest.fn().mockImplementation(() =>
94
99
  Promise.resolve({
@@ -125,6 +130,7 @@ jest.mock('@newskit-render/my-account', () => {
125
130
  PastDueBannerExternal: 'PastDueBannerExternal',
126
131
  }
127
132
  })
133
+
128
134
  jest.mock('@newskit-render/standalone-components', () => {
129
135
  return {
130
136
  recommendationsProvider: jest.fn().mockResolvedValueOnce([
@@ -157,14 +163,6 @@ jest.mock('@newskit-render/standalone-components', () => {
157
163
 
158
164
  describe('Article', () => {
159
165
  describe('getServerSideProps', () => {
160
- beforeAll(() => {
161
- process.env = Object.assign(process.env, {
162
- SITE_HOST: 'hostname',
163
- TWITTER_USERNAME: 'D_Trump',
164
- GSC_ID: '4320982',
165
- })
166
- })
167
-
168
166
  it('should return props', async () => {
169
167
  const setHeaderMock = jest.fn()
170
168
 
@@ -0,0 +1,20 @@
1
+ // Jest Snapshot v1, https://goo.gl/fbAQLP
2
+
3
+ exports[`Brightcove page tests render page 1`] = `
4
+ <DocumentFragment>
5
+ <div
6
+ class="css-1stiqca"
7
+ >
8
+ <video
9
+ class="video-js vjs-fluid"
10
+ controls=""
11
+ data-account="account_id_test"
12
+ data-embed="default"
13
+ data-player="player_id_test"
14
+ data-testid="bc-video-player"
15
+ data-video-id="video_id_test"
16
+ id="bc-video-video_id_test"
17
+ />
18
+ </div>
19
+ </DocumentFragment>
20
+ `;