@newskit-render/core 1.44.0 → 1.48.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (42) hide show
  1. package/CHANGELOG.md +122 -0
  2. package/__tests__/pages/[articleSlug].test.tsx +59 -18
  3. package/__tests__/pages/__snapshots__/home.test.tsx.snap +769 -1261
  4. package/components/article/Highlights.tsx +4 -33
  5. package/components/article/RelatedArticles.tsx +4 -53
  6. package/components/article/__tests__/__snapshots__/index.test.tsx.snap +53 -43
  7. package/components/section/ArticleSlice.tsx +17 -43
  8. package/components/section/CollectionBlock.tsx +38 -6
  9. package/components/section/__tests__/ArticleSlice.test.tsx +37 -51
  10. package/components/section/__tests__/CollectionBlock.test.tsx +63 -13
  11. package/components/section/__tests__/pageBlock.test.tsx +8 -4
  12. package/components/section/index.tsx +17 -12
  13. package/components/section/layouts/Lead.tsx +36 -15
  14. package/components/section/layouts/Rows.tsx +67 -0
  15. package/components/section/layouts/{SectionRow.tsx → SectionTitle.tsx} +24 -52
  16. package/components/section/layouts/__tests__/Lead.test.tsx +31 -6
  17. package/components/section/layouts/__tests__/Rows.test.tsx +28 -0
  18. package/components/section/layouts/__tests__/SectionTitle.test.tsx +36 -0
  19. package/components/section/layouts/__tests__/__snapshots__/Lead.test.tsx.snap +274 -315
  20. package/components/section/layouts/__tests__/__snapshots__/SectionTitle.test.tsx.snap +942 -0
  21. package/components/section/layouts/gridUtils.ts +12 -9
  22. package/components/section/layouts/index.tsx +2 -1
  23. package/components/section/layouts/types.ts +5 -1
  24. package/components/section/{pageBlock.ts → pageBlock.tsx} +5 -2
  25. package/components/teaser/index.tsx +7 -6
  26. package/components/teaser/teaserVariants.ts +2 -0
  27. package/components/teaser/variants/horizontal.ts +14 -0
  28. package/cypress/e2e/account/account-page.spec.js +27 -1
  29. package/cypress/e2e/account/main-api.spec.js +4 -4
  30. package/cypress/support/commands.js +2 -2
  31. package/helpers/mocks/getPageMock.ts +2 -59
  32. package/next.config.js +4 -0
  33. package/package.json +8 -7
  34. package/pages/[section]/[articleId]/[articleSlug].tsx +14 -3
  35. package/pages/api/feed.ts +19 -0
  36. package/pages/api/news-sitemap.ts +10 -2
  37. package/pages/api/sitemap.ts +10 -6
  38. package/temp/_app.tsx +209 -0
  39. package/temp/header.tsx +1 -1
  40. package/components/section/layouts/Row.tsx +0 -28
  41. package/components/section/layouts/__tests__/SectionRow.test.tsx +0 -56
  42. package/components/section/layouts/__tests__/__snapshots__/SectionRow.test.tsx.snap +0 -4542
package/CHANGELOG.md CHANGED
@@ -3,6 +3,128 @@
3
3
  All notable changes to this project will be documented in this file.
4
4
  See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
5
5
 
6
+ ## [1.48.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.48.0...@newskit-render/core@1.48.1) (2022-04-07)
7
+
8
+ **Note:** Version bump only for package @newskit-render/core
9
+
10
+
11
+
12
+
13
+
14
+ # [1.48.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.47.0...@newskit-render/core@1.48.0) (2022-04-05)
15
+
16
+
17
+ ### Features
18
+
19
+ * **PPDSR-733:** Automate package release ([#667](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/667)) ([8be457e](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/8be457e08c4b460a8de7a0614f6540418e804f40))
20
+
21
+
22
+
23
+
24
+
25
+ # [1.47.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.46.1...@newskit-render/core@1.47.0) (2022-04-05)
26
+
27
+
28
+ ### Features
29
+
30
+ * **PPDSR-734:** RSS feed: Create XML and add title specific attributes ([#665](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/665)) ([8c99ad5](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/8c99ad565eb92174bfe914bde7d87e5deefff5af))
31
+
32
+
33
+
34
+
35
+
36
+ ## [1.46.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.46.0...@newskit-render/core@1.46.1) (2022-04-04)
37
+
38
+ **Note:** Version bump only for package @newskit-render/core
39
+
40
+
41
+
42
+
43
+
44
+ # [1.46.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.45.1...@newskit-render/core@1.46.0) (2022-04-04)
45
+
46
+
47
+ ### Features
48
+
49
+ * **PPDSR-688:** update demosite ([#655](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/655)) ([0d08a23](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/0d08a23c98a3820d2375c378a22bc2970a5de987))
50
+
51
+
52
+
53
+
54
+
55
+ ## [1.45.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.45.0...@newskit-render/core@1.45.1) (2022-04-04)
56
+
57
+ **Note:** Version bump only for package @newskit-render/core
58
+
59
+
60
+
61
+
62
+
63
+ # [1.45.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.44.6...@newskit-render/core@1.45.0) (2022-04-01)
64
+
65
+
66
+ ### Features
67
+
68
+ * **PPDSR-694:** Ensure sitemap works on demo site ([#664](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/664)) ([ba3d10f](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/ba3d10f296f50ba40a9684041f10ce2f9c0b3424))
69
+
70
+
71
+
72
+
73
+
74
+ ## [1.44.6](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.44.5...@newskit-render/core@1.44.6) (2022-04-01)
75
+
76
+ **Note:** Version bump only for package @newskit-render/core
77
+
78
+
79
+
80
+
81
+
82
+ ## [1.44.5](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.44.4...@newskit-render/core@1.44.5) (2022-04-01)
83
+
84
+ **Note:** Version bump only for package @newskit-render/core
85
+
86
+
87
+
88
+
89
+
90
+ ## [1.44.4](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.44.3...@newskit-render/core@1.44.4) (2022-03-31)
91
+
92
+
93
+ ### Bug Fixes
94
+
95
+ * **PPDSR-747:** Add dob data to profile ([#660](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/660)) ([8ebd19b](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/8ebd19b7d5003074e4d25c457c0c0747c7796cc7))
96
+
97
+
98
+
99
+
100
+
101
+ ## [1.44.3](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.44.2...@newskit-render/core@1.44.3) (2022-03-31)
102
+
103
+ **Note:** Version bump only for package @newskit-render/core
104
+
105
+
106
+
107
+
108
+
109
+ ## [1.44.2](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.44.1...@newskit-render/core@1.44.2) (2022-03-30)
110
+
111
+ **Note:** Version bump only for package @newskit-render/core
112
+
113
+
114
+
115
+
116
+
117
+ ## [1.44.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.44.0...@newskit-render/core@1.44.1) (2022-03-30)
118
+
119
+
120
+ ### Bug Fixes
121
+
122
+ * **PPDSR-691:** missing styles in temp files ([#658](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/658)) ([2b01484](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/2b01484dba99814d0a9ddb0987e9ba0b48f6401f))
123
+
124
+
125
+
126
+
127
+
6
128
  # [1.44.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@1.43.1...@newskit-render/core@1.44.0) (2022-03-29)
7
129
 
8
130
 
@@ -1,10 +1,7 @@
1
- import { within } from '@testing-library/react'
2
- import Article, {
1
+ import {
3
2
  ArticleSlug,
4
3
  getServerSideProps,
5
4
  } from '../../pages/[section]/[articleId]/[articleSlug]'
6
- import { renderWithQuery } from '../../helpers/test-utils'
7
- import { getUniversalArticleMock } from '../../helpers/mocks'
8
5
  import { URL, Slug } from '../../helpers/global-types'
9
6
 
10
7
  const props: ArticleSlug = {
@@ -57,6 +54,31 @@ const props: ArticleSlug = {
57
54
  twitterUsername: 'D_Trump',
58
55
  siteHost: 'hostname',
59
56
  gscId: '4320982',
57
+ recommendations: [
58
+ {
59
+ href:
60
+ 'https://www.thesun.co.uk/wp-content/uploads/2022/03/image-656eaa885d.jpg?strip=all&w=600&h=338&crop=1',
61
+ tag: 'FOOT ON THE GAZ',
62
+ text:
63
+ 'Bale considering short deal with new club before RETIRING after World Cup',
64
+ title: 'FOOT ON THE GAZ',
65
+ },
66
+ {
67
+ href:
68
+ 'https://www.thesun.co.uk/wp-content/uploads/2022/03/image-a21f115694-1.jpg?strip=all&w=600&h=338&crop=1',
69
+ tag: 'TOUGH TIMES',
70
+ text:
71
+ 'I only made £5k last year - I sold £801k villa for cash, says Claire Sweeney',
72
+ title: 'TOUGH TIMES',
73
+ },
74
+ {
75
+ href: null,
76
+ tag: 'TOUGH TIMES',
77
+ text:
78
+ 'I only made £5k last year - I sold £801k villa for cash, says Claire Sweeney',
79
+ title: 'TOUGH TIMES',
80
+ },
81
+ ],
60
82
  }
61
83
 
62
84
  const user = {
@@ -87,6 +109,9 @@ jest.mock('@newskit-render/api', () => ({
87
109
  })
88
110
  }),
89
111
  getAcsCookie: jest.fn().mockReturnValue({ Cookie: 'something' }),
112
+ Publisher: {
113
+ SUN_UK: 'SUN_UK',
114
+ },
90
115
  }))
91
116
 
92
117
  jest.mock('@newskit-render/my-account', () => {
@@ -94,21 +119,37 @@ jest.mock('@newskit-render/my-account', () => {
94
119
  PastDueBannerExternal: 'PastDueBannerExternal',
95
120
  }
96
121
  })
122
+ jest.mock('@newskit-render/standalone-components', () => {
123
+ return {
124
+ recommendationsProvider: jest.fn().mockResolvedValueOnce([
125
+ {
126
+ href:
127
+ 'https://www.thesun.co.uk/wp-content/uploads/2022/03/image-656eaa885d.jpg?strip=all&w=600&h=338&crop=1',
128
+ tag: 'FOOT ON THE GAZ',
129
+ text:
130
+ 'Bale considering short deal with new club before RETIRING after World Cup',
131
+ title: 'FOOT ON THE GAZ',
132
+ },
133
+ {
134
+ href:
135
+ 'https://www.thesun.co.uk/wp-content/uploads/2022/03/image-a21f115694-1.jpg?strip=all&w=600&h=338&crop=1',
136
+ tag: 'TOUGH TIMES',
137
+ text:
138
+ 'I only made £5k last year - I sold £801k villa for cash, says Claire Sweeney',
139
+ title: 'TOUGH TIMES',
140
+ },
141
+ {
142
+ href: null,
143
+ tag: 'TOUGH TIMES',
144
+ text:
145
+ 'I only made £5k last year - I sold £801k villa for cash, says Claire Sweeney',
146
+ title: 'TOUGH TIMES',
147
+ },
148
+ ]),
149
+ }
150
+ })
97
151
 
98
152
  describe('Article', () => {
99
- test('should load ArticleDisplay component and pass it query data', async () => {
100
- const { getByTestId } = renderWithQuery(
101
- Article,
102
- getUniversalArticleMock,
103
- props
104
- )
105
-
106
- const headLine = within(getByTestId('HeadLine')).getByText(
107
- 'Mock Article: Lorem ipsum dolor sit amet consectetur adipiscing elit'
108
- )
109
- expect(headLine).toBeInTheDocument()
110
- })
111
-
112
153
  describe('getServerSideProps', () => {
113
154
  beforeAll(() => {
114
155
  process.env = Object.assign(process.env, {
@@ -118,7 +159,7 @@ describe('Article', () => {
118
159
  })
119
160
  })
120
161
 
121
- test('should return props', async () => {
162
+ it('should return props', async () => {
122
163
  const setHeaderMock = jest.fn()
123
164
 
124
165
  const response = await getServerSideProps({