@newskit-render/core 0.131.1 → 0.138.1

package/CHANGELOG.md

@@ -3,6 +3,175 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.138.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@0.138.0...@newskit-render/core@0.138.1) (2021-11-15)
+
+
+### Bug Fixes
+
+* **PPDSR-541:** revert CRA to commonjs ([#505](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/505)) ([4cb288f](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/4cb288fbccc43cd40de4f06d3543de5bd7ad8706))
+
+
+
+
+
+# [0.138.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@0.137.0...@newskit-render/core@0.138.0) (2021-11-10)
+
+
+### Features
+
+* **PPDSR-496:** add next link wrapper component ([#500](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/500)) ([a8ca436](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/a8ca436f6f8061d58e857eb83d7d3ee9cfb449a6))
+
+
+
+
+
+# [0.137.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@0.136.3...@newskit-render/core@0.137.0) (2021-11-10)
+
+
+### Features
+
+* **PPDSR-500:** Up next version and switch to es2015 ([#496](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/496)) ([1e41435](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/1e414351247e4c069a829a0a2210a8e6da0e0287))
+
+
+
+
+
+## [0.136.3](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@0.136.2...@newskit-render/core@0.136.3) (2021-11-09)
+
+**Note:** Version bump only for package @newskit-render/core
+
+
+
+
+
+## [0.136.2](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@0.136.1...@newskit-render/core@0.136.2) (2021-11-09)
+
+**Note:** Version bump only for package @newskit-render/core
+
+
+
+
+
+## [0.136.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@0.136.0...@newskit-render/core@0.136.1) (2021-11-08)
+
+**Note:** Version bump only for package @newskit-render/core
+
+
+
+
+
+# [0.136.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@0.135.0...@newskit-render/core@0.136.0) (2021-11-05)
+
+
+### Features
+
+* **PPDSR-403:** Create package for MAIN/NK API ([#483](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/483)) ([8e8d6f7](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/8e8d6f7540d193d37f1dec3b63877ea2f47c2444))
+
+
+### BREAKING CHANGES
+
+* **PPDSR-403:** core now uses @newskit-render/api for setting up apollo client
+
+* feat(PPDSR-403): enable name to be changed
+
+* feat(PPDSR-403): changes based on PR review
+
+
+
+
+
+# [0.135.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@0.134.3...@newskit-render/core@0.135.0) (2021-11-04)
+
+
+### Features
+
+* **PPDSR-475:** Add cache request headers ([#494](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/494)) ([245db06](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/245db063c89d6ab828f673a8bb2d0cbaa7a2c747))
+
+
+
+
+
+## [0.134.3](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@0.134.2...@newskit-render/core@0.134.3) (2021-11-04)
+
+**Note:** Version bump only for package @newskit-render/core
+
+
+
+
+
+## [0.134.2](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@0.134.1...@newskit-render/core@0.134.2) (2021-11-03)
+
+**Note:** Version bump only for package @newskit-render/core
+
+
+
+
+
+## [0.134.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@0.134.0...@newskit-render/core@0.134.1) (2021-11-02)
+
+**Note:** Version bump only for package @newskit-render/core
+
+
+
+
+
+# [0.134.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@0.133.2...@newskit-render/core@0.134.0) (2021-11-01)
+
+
+### Features
+
+* **PPDSR-492:** update Newskit ([#488](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/488)) ([66e683f](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/66e683fea46afeb50c1cf9573b7a3986649fd892))
+
+
+
+
+
+## [0.133.2](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@0.133.1...@newskit-render/core@0.133.2) (2021-11-01)
+
+**Note:** Version bump only for package @newskit-render/core
+
+
+
+
+
+## [0.133.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@0.133.0...@newskit-render/core@0.133.1) (2021-11-01)
+
+**Note:** Version bump only for package @newskit-render/core
+
+
+
+
+
+# [0.133.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@0.132.1...@newskit-render/core@0.133.0) (2021-10-28)
+
+
+### Features
+
+* **PPDSR-478:** Up release-documentation-cli version ([#481](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/481)) ([4a3a24b](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/4a3a24b5bf06855ecff7713e588b8a9379ed45b0))
+
+
+
+
+
+## [0.132.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@0.132.0...@newskit-render/core@0.132.1) (2021-10-28)
+
+**Note:** Version bump only for package @newskit-render/core
+
+
+
+
+
+# [0.132.0](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@0.131.1...@newskit-render/core@0.132.0) (2021-10-27)
+
+
+### Features
+
+* **PPDSRR-464:** Move react to peer & dev dependency ([#479](https://github.com/newscorp-ghfb/ncu-newskit-render/issues/479)) ([225b874](https://github.com/newscorp-ghfb/ncu-newskit-render/commit/225b8748faea09549efb2cdbf2d52a56d4f1ca63))
+
+
+
+
+
 ## [0.131.1](https://github.com/newscorp-ghfb/ncu-newskit-render/compare/@newskit-render/core@0.131.0...@newskit-render/core@0.131.1) (2021-10-26)
 
 **Note:** Version bump only for package @newskit-render/core

package/README.md

@@ -25,7 +25,7 @@ npm start
 
 ## Ads Library
 
-Reach out to the Commercial team to discuss the ad slots names and to get an `ads.min.js` file which should be placed in the public directory.
+Reach out to the Commercial team to discuss the ad slots names and to get a custom `ads.min.js` file which should be placed in the public directory / or ur to file on their CDN.
 More information on the names of the slots can be found here: `https://nidigitalsolutions.jira.com/wiki/spaces/COMM/pages/2370339149/Naming+convention+for+Ad+slots`
 
 The ad slots should be placed as an id propery of the component.

package/__pacts__/client.ts

@@ -1,11 +1,6 @@
-import createApolloClient from '../helpers/createApolloClient'
+import { createApolloClient } from '@newskit-render/api'
 import { GET_UNIVERSAL_ARTICLE } from '../queries'
 
-const apolloClient = createApolloClient({
-  initialState: {},
-  addTypename: false,
-})
-
 export default async function getUniversalArticle({
   id,
   publisher,
@@ -13,6 +8,15 @@ export default async function getUniversalArticle({
   id: string
   publisher: string
 }) {
+  const apolloClient = await createApolloClient({
+    initialState: {},
+    uri: process.env.NEWSKIT_API_ENV_URL,
+    headers: {
+      'x-api-key': process.env.NEWSKIT_API_X_API_KEY,
+    },
+    addTypename: false,
+  })
+
   return apolloClient
     .query({
       query: GET_UNIVERSAL_ARTICLE,

package/__tests__/pages/[articleSlug].test.tsx

@@ -82,20 +82,26 @@ jest.mock('cross-fetch', () =>
   )
 )
 
-jest.mock('../../helpers/createApolloClient', () => () => ({
-  query: jest.fn(() =>
-    Promise.resolve({
-      data: {
-        universalArticle: props.universalArticle,
-      },
+jest.mock('@newskit-render/api', () => ({
+  ClientTypes: { nkapi: 'nkapi' },
+  createApolloClient: jest.fn().mockImplementation(() => {
+    return Promise.resolve({
+      query: jest.fn().mockResolvedValueOnce({
+        data: {
+          universalArticle: props.universalArticle,
+        },
+      }),
     })
-  ),
+  }),
+  sessionParser: jest.fn(),
+  getMainSession: jest.fn(),
 }))
 
 jest.mock('@newskit-render/my-account', () => {
   return {
     PastDueBannerExternal: 'PastDueBannerExternal',
     sessionParser: jest.fn(),
+    getMainSession: jest.fn(),
   }
 })
 
@@ -123,6 +129,8 @@ describe('Article', () => {
     })
 
     test('should return props', async () => {
+      const setHeaderMock = jest.fn()
+
       const response = await getServerSideProps({
         params: {
           articleId: 'test-1',
@@ -130,8 +138,13 @@ describe('Article', () => {
           articleSlug: 'slugche',
         },
         req: { headers: { cookie: 'some-cookie' } },
+        res: { setHeader: setHeaderMock },
       })
       expect(response).toEqual({ props: { ...props, user: userMock } })
+      expect(setHeaderMock).toHaveBeenCalledWith(
+        'Cache-Control',
+        'public, s-maxage=10, stale-while-revalidate=59'
+      )
     })
   })
 })