@newrelic/browser-agent 1.291.0 → 1.291.1

package/CHANGELOG.md

@@ -3,6 +3,15 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.291.1](https://github.com/newrelic/newrelic-browser-agent/compare/v1.291.0...v1.291.1) (2025-06-06)
+
+
+### Bug Fixes
+
+* Add safeguards for addToTrace ([#1490](https://github.com/newrelic/newrelic-browser-agent/issues/1490)) ([e94a36e](https://github.com/newrelic/newrelic-browser-agent/commit/e94a36efaf37f69dfdb8134bc27ee0df0a734e83))
+* Clean BrowserPerformance entryName for resources ([#1493](https://github.com/newrelic/newrelic-browser-agent/issues/1493)) ([09ff0ad](https://github.com/newrelic/newrelic-browser-agent/commit/09ff0adb27c12e99c02c81462aeb921af8686ce8))
+* Prevent ST from holding onto Event refs in memory when aborted ([#1491](https://github.com/newrelic/newrelic-browser-agent/issues/1491)) ([a1d15cb](https://github.com/newrelic/newrelic-browser-agent/commit/a1d15cb9d972a2fa421a648b83e150489799d437))
+
 ## [1.291.0](https://github.com/newrelic/newrelic-browser-agent/compare/v1.290.1...v1.291.0) (2025-05-30)
 
 

package/dist/cjs/common/constants/env.cdn.js

@@ -17,7 +17,7 @@ exports.VERSION = exports.RRWEB_VERSION = exports.DIST_METHOD = exports.BUILD_EN
 /**
  * Exposes the version of the agent
  */
-const VERSION = exports.VERSION = "1.291.0";
+const VERSION = exports.VERSION = "1.291.1";
 
 /**
  * Exposes the build type of the agent

package/dist/cjs/common/constants/env.npm.js

@@ -17,7 +17,7 @@ exports.VERSION = exports.RRWEB_VERSION = exports.DIST_METHOD = exports.BUILD_EN
 /**
  * Exposes the version of the agent
  */
-const VERSION = exports.VERSION = "1.291.0";
+const VERSION = exports.VERSION = "1.291.1";
 
 /**
  * Exposes the build type of the agent

package/dist/cjs/features/generic_events/aggregate/index.js

@@ -148,7 +148,7 @@ class Aggregate extends _aggregateBase.AggregateBase {
                       ...detailObj,
                       eventType: 'BrowserPerformance',
                       timestamp: this.toEpoch(entry.startTime),
-                      entryName: (0, _cleanUrl.cleanURL)(entry.name),
+                      entryName: entry.name,
                       entryDuration: entry.duration,
                       entryType: type
                     });
@@ -214,7 +214,7 @@ class Aggregate extends _aggregateBase.AggregateBase {
               ...entryObject,
               eventType: 'BrowserPerformance',
               timestamp: Math.floor(agentRef.runtime.timeKeeper.correctRelativeTimestamp(entryObject.startTime)),
-              entryName: name,
+              entryName: (0, _cleanUrl.cleanURL)(name),
               entryDuration: duration,
               firstParty
             };

package/dist/cjs/features/session_trace/aggregate/index.js

@@ -86,7 +86,7 @@ class Aggregate extends _aggregateBase.AggregateBase {
     (0, _registerHandler.registerHandler)('bstResource', (...args) => this.events.storeResources(...args), this.featureName, this.ee);
     (0, _registerHandler.registerHandler)('bstHist', (...args) => this.events.storeHist(...args), this.featureName, this.ee);
     (0, _registerHandler.registerHandler)('bstXhrAgg', (...args) => this.events.storeXhrAgg(...args), this.featureName, this.ee);
-    (0, _registerHandler.registerHandler)('bstApi', (...args) => this.events.storeSTN(...args), this.featureName, this.ee);
+    (0, _registerHandler.registerHandler)('bstApi', (...args) => this.events.storeNode(...args), this.featureName, this.ee);
     (0, _registerHandler.registerHandler)('trace-jserror', (...args) => this.events.storeErrorAgg(...args), this.featureName, this.ee);
     (0, _registerHandler.registerHandler)('pvtAdded', (...args) => this.events.processPVT(...args), this.featureName, this.ee);
     if (this.mode !== _constants2.MODE.FULL) {

package/dist/cjs/features/session_trace/aggregate/trace/storage.js

@@ -53,16 +53,19 @@ class TraceStorage {
   constructor(parent) {
     this.parent = parent;
   }
-
-  /** Central function called by all the other store__ & addToTrace API to append a trace node. */
-  storeSTN(stn) {
-    if (this.parent.blocked) return;
+  #canStoreNewNode() {
+    if (this.parent.blocked) return false;
     if (this.nodeCount >= _constants2.MAX_NODES_PER_HARVEST) {
       // limit the amount of pending data awaiting next harvest
-      if (this.parent.mode !== _constants.MODE.ERROR) return;
+      if (this.parent.mode !== _constants.MODE.ERROR) return false;
       const openedSpace = this.trimSTNs(ERROR_MODE_SECONDS_WINDOW); // but maybe we could make some space by discarding irrelevant nodes if we're in sessioned Error mode
-      if (openedSpace === 0) return;
+      if (openedSpace === 0) return false;
     }
+    return true;
+  }
+
+  /** Central internal function called by all the other store__ & addToTrace API to append a trace node. They MUST all have checked #canStoreNewNode before calling this func!! */
+  #storeSTN(stn) {
     if (this.trace[stn.n]) this.trace[stn.n].push(stn);else this.trace[stn.n] = [stn];
     if (stn.s < this.earliestTimeStamp) this.earliestTimeStamp = stn.s;
     if (stn.s > this.latestTimeStamp) this.latestTimeStamp = stn.s;
@@ -142,6 +145,10 @@ class TraceStorage {
       return !!(node && typeof node.e === 'number' && typeof node.s === 'number' && node.e - node.s < limit);
     }
   }
+  storeNode(node) {
+    if (!this.#canStoreNewNode()) return;
+    this.#storeSTN(node);
+  }
   processPVT(name, value, attrs) {
     this.storeTiming({
       [name]: value
@@ -165,13 +172,16 @@ class TraceStorage {
       if (this.parent.timeKeeper && this.parent.timeKeeper.ready && isAbsoluteTimestamp) {
         val = this.parent.timeKeeper.convertAbsoluteTimestamp(Math.floor(this.parent.timeKeeper.correctAbsoluteTimestamp(val)));
       }
-      this.storeSTN(new _node.TraceNode(key, val, val, 'document', 'timing'));
+      if (!this.#canStoreNewNode()) return; // at any point when no new nodes can be stored, there's no point in processing the rest of the timing entries
+      this.#storeSTN(new _node.TraceNode(key, val, val, 'document', 'timing'));
     }
   }
 
   // Tracks the events and their listener's duration on objects wrapped by wrap-events.
   storeEvent(currentEvent, target, start, end) {
     if (this.shouldIgnoreEvent(currentEvent, target)) return;
+    if (!this.#canStoreNewNode()) return; // need to check if adding node will succeed BEFORE storing event ref below (*cli Jun'25 - addressing memory leak in aborted ST issue #NR-420780)
+
     if (this.prevStoredEvents.has(currentEvent)) return; // prevent multiple listeners of an event from creating duplicate trace nodes per occurrence. Cleared every harvest. near-zero chance for re-duplication after clearing per harvest since the timestamps of the event are considered for uniqueness.
     this.prevStoredEvents.add(currentEvent);
     const evt = new _node.TraceNode(this.evtName(currentEvent.type), start, end, undefined, 'event');
@@ -182,7 +192,7 @@ class TraceStorage {
     } catch (e) {
       evt.o = (0, _eventOrigin.eventOrigin)(null, target, this.parent.ee);
     }
-    this.storeSTN(evt);
+    this.#storeSTN(evt);
   }
   shouldIgnoreEvent(event, target) {
     if (event.type in ignoredEvents.global) return true;
@@ -218,14 +228,17 @@ class TraceStorage {
 
   // Tracks when the window history API specified by wrap-history is used.
   storeHist(path, old, time) {
-    this.storeSTN(new _node.TraceNode('history.pushState', time, time, path, old));
+    if (!this.#canStoreNewNode()) return;
+    this.#storeSTN(new _node.TraceNode('history.pushState', time, time, path, old));
   }
   #laststart = 0;
   // Processes all the PerformanceResourceTiming entries captured (by observer).
   storeResources(resources) {
     if (!resources || resources.length === 0) return;
-    resources.forEach(currentResource => {
-      if ((currentResource.fetchStart | 0) <= this.#laststart) return; // don't recollect already-seen resources
+    for (let i = 0; i < resources.length; i++) {
+      const currentResource = resources[i];
+      if ((currentResource.fetchStart | 0) <= this.#laststart) continue; // don't recollect already-seen resources
+      if (!this.#canStoreNewNode()) break; // stop processing if we can't store any more resource nodes anyways
 
       const {
         initiatorType,
@@ -240,21 +253,23 @@ class TraceStorage {
         pathname
       } = (0, _parseUrl.parseUrl)(currentResource.name);
       const res = new _node.TraceNode(initiatorType, fetchStart | 0, responseEnd | 0, "".concat(protocol, "://").concat(hostname, ":").concat(port).concat(pathname), entryType);
-      this.storeSTN(res);
-    });
+      this.#storeSTN(res);
+    }
     this.#laststart = resources[resources.length - 1].fetchStart | 0;
   }
 
   // JavascriptError (FEATURE) events pipes into ST here.
   storeErrorAgg(type, name, params, metrics) {
     if (type !== 'err') return; // internal errors are purposefully ignored
-    this.storeSTN(new _node.TraceNode('error', metrics.time, metrics.time, params.message, params.stackHash));
+    if (!this.#canStoreNewNode()) return;
+    this.#storeSTN(new _node.TraceNode('error', metrics.time, metrics.time, params.message, params.stackHash));
   }
 
   // Ajax (FEATURE) events--XML & fetches--pipes into ST here.
   storeXhrAgg(type, name, params, metrics) {
     if (type !== 'xhr') return;
-    this.storeSTN(new _node.TraceNode('Ajax', metrics.time, metrics.time + metrics.duration, "".concat(params.status, " ").concat(params.method, ": ").concat(params.host).concat(params.pathname), 'ajax'));
+    if (!this.#canStoreNewNode()) return;
+    this.#storeSTN(new _node.TraceNode('Ajax', metrics.time, metrics.time + metrics.duration, "".concat(params.status, " ").concat(params.method, ": ").concat(params.host).concat(params.pathname), 'ajax'));
   }
 
   /* Below are the interface expected & required of whatever storage is used across all features on an individual basis. This allows a common `.events` property on Trace shared with AggregateBase.
@@ -279,7 +294,12 @@ class TraceStorage {
     this.latestTimeStamp = 0;
   }
   reloadSave() {
-    Object.values(this.#backupTrace).forEach(stnsArray => stnsArray.forEach(stn => this.storeSTN(stn)));
+    for (const stnsArray of Object.values(this.#backupTrace)) {
+      for (const stn of stnsArray) {
+        if (!this.#canStoreNewNode()) return; // stop attempting to re-store nodes
+        this.#storeSTN(stn);
+      }
+    }
   }
   clearSave() {
     this.#backupTrace = undefined;

package/dist/cjs/loaders/api/addToTrace.js

@@ -6,6 +6,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.setupAddToTraceAPI = setupAddToTraceAPI;
 var _runtime = require("../../common/constants/runtime");
 var _handle = require("../../common/event-emitter/handle");
+var _console = require("../../common/util/console");
 var _features = require("../features/features");
 var _constants = require("./constants");
 var _sharedHandlers = require("./sharedHandlers");
@@ -24,6 +25,13 @@ function setupAddToTraceAPI(agent) {
       o: evt.origin || '',
       t: 'api'
     };
+    if (report.s < 0 || report.e < 0 || report.e < report.s) {
+      (0, _console.warn)(61, {
+        start: report.s,
+        end: report.e
+      });
+      return;
+    }
     (0, _handle.handle)('bstApi', [report], undefined, _features.FEATURE_NAMES.sessionTrace, agent.ee);
   }, agent);
 }

package/dist/esm/common/constants/env.cdn.js

@@ -11,7 +11,7 @@
 /**
  * Exposes the version of the agent
  */
-export const VERSION = "1.291.0";
+export const VERSION = "1.291.1";
 
 /**
  * Exposes the build type of the agent

package/dist/esm/common/constants/env.npm.js

@@ -11,7 +11,7 @@
 /**
  * Exposes the version of the agent
  */
-export const VERSION = "1.291.0";
+export const VERSION = "1.291.1";
 
 /**
  * Exposes the build type of the agent

package/dist/esm/features/generic_events/aggregate/index.js

@@ -141,7 +141,7 @@ export class Aggregate extends AggregateBase {
                       ...detailObj,
                       eventType: 'BrowserPerformance',
                       timestamp: this.toEpoch(entry.startTime),
-                      entryName: cleanURL(entry.name),
+                      entryName: entry.name,
                       entryDuration: entry.duration,
                       entryType: type
                     });
@@ -207,7 +207,7 @@ export class Aggregate extends AggregateBase {
               ...entryObject,
               eventType: 'BrowserPerformance',
               timestamp: Math.floor(agentRef.runtime.timeKeeper.correctRelativeTimestamp(entryObject.startTime)),
-              entryName: name,
+              entryName: cleanURL(name),
               entryDuration: duration,
               firstParty
             };

package/dist/esm/features/session_trace/aggregate/index.js

@@ -79,7 +79,7 @@ export class Aggregate extends AggregateBase {
     registerHandler('bstResource', (...args) => this.events.storeResources(...args), this.featureName, this.ee);
     registerHandler('bstHist', (...args) => this.events.storeHist(...args), this.featureName, this.ee);
     registerHandler('bstXhrAgg', (...args) => this.events.storeXhrAgg(...args), this.featureName, this.ee);
-    registerHandler('bstApi', (...args) => this.events.storeSTN(...args), this.featureName, this.ee);
+    registerHandler('bstApi', (...args) => this.events.storeNode(...args), this.featureName, this.ee);
     registerHandler('trace-jserror', (...args) => this.events.storeErrorAgg(...args), this.featureName, this.ee);
     registerHandler('pvtAdded', (...args) => this.events.processPVT(...args), this.featureName, this.ee);
     if (this.mode !== MODE.FULL) {

package/dist/esm/features/session_trace/aggregate/trace/storage.js

@@ -46,16 +46,19 @@ export class TraceStorage {
   constructor(parent) {
     this.parent = parent;
   }
-
-  /** Central function called by all the other store__ & addToTrace API to append a trace node. */
-  storeSTN(stn) {
-    if (this.parent.blocked) return;
+  #canStoreNewNode() {
+    if (this.parent.blocked) return false;
     if (this.nodeCount >= MAX_NODES_PER_HARVEST) {
       // limit the amount of pending data awaiting next harvest
-      if (this.parent.mode !== MODE.ERROR) return;
+      if (this.parent.mode !== MODE.ERROR) return false;
       const openedSpace = this.trimSTNs(ERROR_MODE_SECONDS_WINDOW); // but maybe we could make some space by discarding irrelevant nodes if we're in sessioned Error mode
-      if (openedSpace === 0) return;
+      if (openedSpace === 0) return false;
     }
+    return true;
+  }
+
+  /** Central internal function called by all the other store__ & addToTrace API to append a trace node. They MUST all have checked #canStoreNewNode before calling this func!! */
+  #storeSTN(stn) {
     if (this.trace[stn.n]) this.trace[stn.n].push(stn);else this.trace[stn.n] = [stn];
     if (stn.s < this.earliestTimeStamp) this.earliestTimeStamp = stn.s;
     if (stn.s > this.latestTimeStamp) this.latestTimeStamp = stn.s;
@@ -135,6 +138,10 @@ export class TraceStorage {
       return !!(node && typeof node.e === 'number' && typeof node.s === 'number' && node.e - node.s < limit);
     }
   }
+  storeNode(node) {
+    if (!this.#canStoreNewNode()) return;
+    this.#storeSTN(node);
+  }
   processPVT(name, value, attrs) {
     this.storeTiming({
       [name]: value
@@ -158,13 +165,16 @@ export class TraceStorage {
       if (this.parent.timeKeeper && this.parent.timeKeeper.ready && isAbsoluteTimestamp) {
         val = this.parent.timeKeeper.convertAbsoluteTimestamp(Math.floor(this.parent.timeKeeper.correctAbsoluteTimestamp(val)));
       }
-      this.storeSTN(new TraceNode(key, val, val, 'document', 'timing'));
+      if (!this.#canStoreNewNode()) return; // at any point when no new nodes can be stored, there's no point in processing the rest of the timing entries
+      this.#storeSTN(new TraceNode(key, val, val, 'document', 'timing'));
     }
   }
 
   // Tracks the events and their listener's duration on objects wrapped by wrap-events.
   storeEvent(currentEvent, target, start, end) {
     if (this.shouldIgnoreEvent(currentEvent, target)) return;
+    if (!this.#canStoreNewNode()) return; // need to check if adding node will succeed BEFORE storing event ref below (*cli Jun'25 - addressing memory leak in aborted ST issue #NR-420780)
+
     if (this.prevStoredEvents.has(currentEvent)) return; // prevent multiple listeners of an event from creating duplicate trace nodes per occurrence. Cleared every harvest. near-zero chance for re-duplication after clearing per harvest since the timestamps of the event are considered for uniqueness.
     this.prevStoredEvents.add(currentEvent);
     const evt = new TraceNode(this.evtName(currentEvent.type), start, end, undefined, 'event');
@@ -175,7 +185,7 @@ export class TraceStorage {
     } catch (e) {
       evt.o = eventOrigin(null, target, this.parent.ee);
     }
-    this.storeSTN(evt);
+    this.#storeSTN(evt);
   }
   shouldIgnoreEvent(event, target) {
     if (event.type in ignoredEvents.global) return true;
@@ -211,14 +221,17 @@ export class TraceStorage {
 
   // Tracks when the window history API specified by wrap-history is used.
   storeHist(path, old, time) {
-    this.storeSTN(new TraceNode('history.pushState', time, time, path, old));
+    if (!this.#canStoreNewNode()) return;
+    this.#storeSTN(new TraceNode('history.pushState', time, time, path, old));
   }
   #laststart = 0;
   // Processes all the PerformanceResourceTiming entries captured (by observer).
   storeResources(resources) {
     if (!resources || resources.length === 0) return;
-    resources.forEach(currentResource => {
-      if ((currentResource.fetchStart | 0) <= this.#laststart) return; // don't recollect already-seen resources
+    for (let i = 0; i < resources.length; i++) {
+      const currentResource = resources[i];
+      if ((currentResource.fetchStart | 0) <= this.#laststart) continue; // don't recollect already-seen resources
+      if (!this.#canStoreNewNode()) break; // stop processing if we can't store any more resource nodes anyways
 
       const {
         initiatorType,
@@ -233,21 +246,23 @@ export class TraceStorage {
         pathname
       } = parseUrl(currentResource.name);
       const res = new TraceNode(initiatorType, fetchStart | 0, responseEnd | 0, "".concat(protocol, "://").concat(hostname, ":").concat(port).concat(pathname), entryType);
-      this.storeSTN(res);
-    });
+      this.#storeSTN(res);
+    }
     this.#laststart = resources[resources.length - 1].fetchStart | 0;
   }
 
   // JavascriptError (FEATURE) events pipes into ST here.
   storeErrorAgg(type, name, params, metrics) {
     if (type !== 'err') return; // internal errors are purposefully ignored
-    this.storeSTN(new TraceNode('error', metrics.time, metrics.time, params.message, params.stackHash));
+    if (!this.#canStoreNewNode()) return;
+    this.#storeSTN(new TraceNode('error', metrics.time, metrics.time, params.message, params.stackHash));
   }
 
   // Ajax (FEATURE) events--XML & fetches--pipes into ST here.
   storeXhrAgg(type, name, params, metrics) {
     if (type !== 'xhr') return;
-    this.storeSTN(new TraceNode('Ajax', metrics.time, metrics.time + metrics.duration, "".concat(params.status, " ").concat(params.method, ": ").concat(params.host).concat(params.pathname), 'ajax'));
+    if (!this.#canStoreNewNode()) return;
+    this.#storeSTN(new TraceNode('Ajax', metrics.time, metrics.time + metrics.duration, "".concat(params.status, " ").concat(params.method, ": ").concat(params.host).concat(params.pathname), 'ajax'));
   }
 
   /* Below are the interface expected & required of whatever storage is used across all features on an individual basis. This allows a common `.events` property on Trace shared with AggregateBase.
@@ -272,7 +287,12 @@ export class TraceStorage {
     this.latestTimeStamp = 0;
   }
   reloadSave() {
-    Object.values(this.#backupTrace).forEach(stnsArray => stnsArray.forEach(stn => this.storeSTN(stn)));
+    for (const stnsArray of Object.values(this.#backupTrace)) {
+      for (const stn of stnsArray) {
+        if (!this.#canStoreNewNode()) return; // stop attempting to re-store nodes
+        this.#storeSTN(stn);
+      }
+    }
   }
   clearSave() {
     this.#backupTrace = undefined;

package/dist/esm/loaders/api/addToTrace.js

@@ -4,6 +4,7 @@
  */
 import { originTime } from '../../common/constants/runtime';
 import { handle } from '../../common/event-emitter/handle';
+import { warn } from '../../common/util/console';
 import { FEATURE_NAMES } from '../features/features';
 import { ADD_TO_TRACE } from './constants';
 import { setupAPI } from './sharedHandlers';
@@ -17,6 +18,13 @@ export function setupAddToTraceAPI(agent) {
       o: evt.origin || '',
       t: 'api'
     };
+    if (report.s < 0 || report.e < 0 || report.e < report.s) {
+      warn(61, {
+        start: report.s,
+        end: report.e
+      });
+      return;
+    }
     handle('bstApi', [report], undefined, FEATURE_NAMES.sessionTrace, agent.ee);
   }, agent);
 }

package/dist/types/features/session_trace/aggregate/trace/storage.d.ts

@@ -7,8 +7,6 @@ export class TraceStorage {
     latestTimeStamp: number;
     prevStoredEvents: Set<any>;
     parent: any;
-    /** Central function called by all the other store__ & addToTrace API to append a trace node. */
-    storeSTN(stn: any): void;
     /**
      * Trim the collection of nodes awaiting harvest such that those seen outside a certain span of time are discarded.
      * @param {number} lookbackDuration Past length of time until now for which we care about nodes, in milliseconds
@@ -22,6 +20,7 @@ export class TraceStorage {
         latestTimeStamp: number;
     };
     smearEvtsByOrigin(name: any): (byOrigin: any, evtNode: any) => any;
+    storeNode(node: any): void;
     processPVT(name: any, value: any, attrs: any): void;
     storeTiming(timingEntry: any, isAbsoluteTimestamp?: boolean): void;
     storeEvent(currentEvent: any, target: any, start: any, end: any): void;

package/dist/types/features/session_trace/aggregate/trace/storage.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"storage.d.ts","sourceRoot":"","sources":["../../../../../../src/features/session_trace/aggregate/trace/storage.js"],"names":[],"mappings":"AA8BA,+HAA+H;AAC/H;IAQE,yBAEC;IATD,kBAAa;IACb,UAAU;IACV,0BAA4B;IAC5B,wBAAmB;IACnB,2BAA4B;IAI1B,YAAoB;IAGtB,gGAAgG;IAChG,yBAcC;IAED;;;;OAIG;IACH,2BAHW,MAAM,GACJ,MAAM,CAsBlB;IAED,oEAAoE;IACpE;;;;MAgBC;IAED,mEA6BC;IAED,oDAEC;IAED,mEAuBC;IAGD,uEAcC;IAED,oDAKC;IAED,wBAwBC;IAGD,gDAEC;IAID,qCAaC;IAGD,qEAGC;IAGD,mEAGC;IAID,mBAEC;IAED,aAEC;IAED;;;;;;;QAEC;IAED,cAMC;IAED,mBAEC;IAED,kBAEC;;CACF"}
+{"version":3,"file":"storage.d.ts","sourceRoot":"","sources":["../../../../../../src/features/session_trace/aggregate/trace/storage.js"],"names":[],"mappings":"AA8BA,+HAA+H;AAC/H;IAQE,yBAEC;IATD,kBAAa;IACb,UAAU;IACV,0BAA4B;IAC5B,wBAAmB;IACnB,2BAA4B;IAI1B,YAAoB;IAuBtB;;;;OAIG;IACH,2BAHW,MAAM,GACJ,MAAM,CAsBlB;IAED,oEAAoE;IACpE;;;;MAgBC;IAED,mEA6BC;IAED,2BAGC;IAED,oDAEC;IAED,mEAwBC;IAGD,uEAgBC;IAED,oDAKC;IAED,wBAwBC;IAGD,gDAGC;IAID,qCAgBC;IAGD,qEAIC;IAGD,mEAIC;IAID,mBAEC;IAED,aAEC;IAED;;;;;;;QAEC;IAED,cAMC;IAED,mBAOC;IAED,kBAEC;;CACF"}

package/dist/types/loaders/api/addToTrace.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"addToTrace.d.ts","sourceRoot":"","sources":["../../../../src/loaders/api/addToTrace.js"],"names":[],"mappings":"AAUA,qDAcC"}
+{"version":3,"file":"addToTrace.d.ts","sourceRoot":"","sources":["../../../../src/loaders/api/addToTrace.js"],"names":[],"mappings":"AAWA,qDAmBC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@newrelic/browser-agent",
-  "version": "1.291.0",
+  "version": "1.291.1",
   "private": false,
   "author": "New Relic Browser Agent Team <browser-agent@newrelic.com>",
   "description": "New Relic Browser Agent",

package/src/features/generic_events/aggregate/index.js

@@ -143,7 +143,7 @@ export class Aggregate extends AggregateBase {
                       ...detailObj,
                       eventType: 'BrowserPerformance',
                       timestamp: this.toEpoch(entry.startTime),
-                      entryName: cleanURL(entry.name),
+                      entryName: entry.name,
                       entryDuration: entry.duration,
                       entryType: type
                     })
@@ -208,7 +208,7 @@ export class Aggregate extends AggregateBase {
               ...entryObject,
               eventType: 'BrowserPerformance',
               timestamp: Math.floor(agentRef.runtime.timeKeeper.correctRelativeTimestamp(entryObject.startTime)),
-              entryName: name,
+              entryName: cleanURL(name),
               entryDuration: duration,
               firstParty
             }

package/src/features/session_trace/aggregate/index.js

@@ -86,7 +86,7 @@ export class Aggregate extends AggregateBase {
     registerHandler('bstResource', (...args) => this.events.storeResources(...args), this.featureName, this.ee)
     registerHandler('bstHist', (...args) => this.events.storeHist(...args), this.featureName, this.ee)
     registerHandler('bstXhrAgg', (...args) => this.events.storeXhrAgg(...args), this.featureName, this.ee)
-    registerHandler('bstApi', (...args) => this.events.storeSTN(...args), this.featureName, this.ee)
+    registerHandler('bstApi', (...args) => this.events.storeNode(...args), this.featureName, this.ee)
     registerHandler('trace-jserror', (...args) => this.events.storeErrorAgg(...args), this.featureName, this.ee)
     registerHandler('pvtAdded', (...args) => this.events.processPVT(...args), this.featureName, this.ee)
 

package/src/features/session_trace/aggregate/trace/storage.js

@@ -41,15 +41,18 @@ export class TraceStorage {
     this.parent = parent
   }
 
-  /** Central function called by all the other store__ & addToTrace API to append a trace node. */
-  storeSTN (stn) {
-    if (this.parent.blocked) return
+  #canStoreNewNode () {
+    if (this.parent.blocked) return false
     if (this.nodeCount >= MAX_NODES_PER_HARVEST) { // limit the amount of pending data awaiting next harvest
-      if (this.parent.mode !== MODE.ERROR) return
+      if (this.parent.mode !== MODE.ERROR) return false
       const openedSpace = this.trimSTNs(ERROR_MODE_SECONDS_WINDOW) // but maybe we could make some space by discarding irrelevant nodes if we're in sessioned Error mode
-      if (openedSpace === 0) return
+      if (openedSpace === 0) return false
     }
+    return true
+  }
 
+  /** Central internal function called by all the other store__ & addToTrace API to append a trace node. They MUST all have checked #canStoreNewNode before calling this func!! */
+  #storeSTN (stn) {
     if (this.trace[stn.n]) this.trace[stn.n].push(stn)
     else this.trace[stn.n] = [stn]
 
@@ -135,6 +138,11 @@ export class TraceStorage {
     }
   }
 
+  storeNode (node) {
+    if (!this.#canStoreNewNode()) return
+    this.#storeSTN(node)
+  }
+
   processPVT (name, value, attrs) {
     this.storeTiming({ [name]: value })
   }
@@ -160,13 +168,16 @@ export class TraceStorage {
           Math.floor(this.parent.timeKeeper.correctAbsoluteTimestamp(val))
         )
       }
-      this.storeSTN(new TraceNode(key, val, val, 'document', 'timing'))
+      if (!this.#canStoreNewNode()) return // at any point when no new nodes can be stored, there's no point in processing the rest of the timing entries
+      this.#storeSTN(new TraceNode(key, val, val, 'document', 'timing'))
     }
   }
 
   // Tracks the events and their listener's duration on objects wrapped by wrap-events.
   storeEvent (currentEvent, target, start, end) {
     if (this.shouldIgnoreEvent(currentEvent, target)) return
+    if (!this.#canStoreNewNode()) return // need to check if adding node will succeed BEFORE storing event ref below (*cli Jun'25 - addressing memory leak in aborted ST issue #NR-420780)
+
     if (this.prevStoredEvents.has(currentEvent)) return // prevent multiple listeners of an event from creating duplicate trace nodes per occurrence. Cleared every harvest. near-zero chance for re-duplication after clearing per harvest since the timestamps of the event are considered for uniqueness.
     this.prevStoredEvents.add(currentEvent)
 
@@ -178,7 +189,7 @@ export class TraceStorage {
     } catch (e) {
       evt.o = eventOrigin(null, target, this.parent.ee)
     }
-    this.storeSTN(evt)
+    this.#storeSTN(evt)
   }
 
   shouldIgnoreEvent (event, target) {
@@ -216,7 +227,8 @@ export class TraceStorage {
 
   // Tracks when the window history API specified by wrap-history is used.
   storeHist (path, old, time) {
-    this.storeSTN(new TraceNode('history.pushState', time, time, path, old))
+    if (!this.#canStoreNewNode()) return
+    this.#storeSTN(new TraceNode('history.pushState', time, time, path, old))
   }
 
   #laststart = 0
@@ -224,14 +236,17 @@ export class TraceStorage {
   storeResources (resources) {
     if (!resources || resources.length === 0) return
 
-    resources.forEach((currentResource) => {
-      if ((currentResource.fetchStart | 0) <= this.#laststart) return // don't recollect already-seen resources
+    for (let i = 0; i < resources.length; i++) {
+      const currentResource = resources[i]
+      if ((currentResource.fetchStart | 0) <= this.#laststart) continue // don't recollect already-seen resources
+      if (!this.#canStoreNewNode()) break // stop processing if we can't store any more resource nodes anyways
 
       const { initiatorType, fetchStart, responseEnd, entryType } = currentResource
       const { protocol, hostname, port, pathname } = parseUrl(currentResource.name)
       const res = new TraceNode(initiatorType, fetchStart | 0, responseEnd | 0, `${protocol}://${hostname}:${port}${pathname}`, entryType)
-      this.storeSTN(res)
-    })
+
+      this.#storeSTN(res)
+    }
 
     this.#laststart = resources[resources.length - 1].fetchStart | 0
   }
@@ -239,13 +254,15 @@ export class TraceStorage {
   // JavascriptError (FEATURE) events pipes into ST here.
   storeErrorAgg (type, name, params, metrics) {
     if (type !== 'err') return // internal errors are purposefully ignored
-    this.storeSTN(new TraceNode('error', metrics.time, metrics.time, params.message, params.stackHash))
+    if (!this.#canStoreNewNode()) return
+    this.#storeSTN(new TraceNode('error', metrics.time, metrics.time, params.message, params.stackHash))
   }
 
   // Ajax (FEATURE) events--XML & fetches--pipes into ST here.
   storeXhrAgg (type, name, params, metrics) {
     if (type !== 'xhr') return
-    this.storeSTN(new TraceNode('Ajax', metrics.time, metrics.time + metrics.duration, `${params.status} ${params.method}: ${params.host}${params.pathname}`, 'ajax'))
+    if (!this.#canStoreNewNode()) return
+    this.#storeSTN(new TraceNode('Ajax', metrics.time, metrics.time + metrics.duration, `${params.status} ${params.method}: ${params.host}${params.pathname}`, 'ajax'))
   }
 
   /* Below are the interface expected & required of whatever storage is used across all features on an individual basis. This allows a common `.events` property on Trace shared with AggregateBase.
@@ -271,7 +288,12 @@ export class TraceStorage {
   }
 
   reloadSave () {
-    Object.values(this.#backupTrace).forEach(stnsArray => stnsArray.forEach(stn => this.storeSTN(stn)))
+    for (const stnsArray of Object.values(this.#backupTrace)) {
+      for (const stn of stnsArray) {
+        if (!this.#canStoreNewNode()) return // stop attempting to re-store nodes
+        this.#storeSTN(stn)
+      }
+    }
   }
 
   clearSave () {

package/src/loaders/api/addToTrace.js

@@ -4,6 +4,7 @@
  */
 import { originTime } from '../../common/constants/runtime'
 import { handle } from '../../common/event-emitter/handle'
+import { warn } from '../../common/util/console'
 import { FEATURE_NAMES } from '../features/features'
 import { ADD_TO_TRACE } from './constants'
 import { setupAPI } from './sharedHandlers'
@@ -20,6 +21,11 @@ export function setupAddToTraceAPI (agent) {
       t: 'api'
     }
 
+    if (report.s < 0 || report.e < 0 || report.e < report.s) {
+      warn(61, { start: report.s, end: report.e })
+      return
+    }
+
     handle('bstApi', [report], undefined, FEATURE_NAMES.sessionTrace, agent.ee)
   }, agent)
 }