@newrelic/browser-agent 1.270.2 → 1.271.0

package/CHANGELOG.md

@@ -3,6 +3,20 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.271.0](https://github.com/newrelic/newrelic-browser-agent/compare/v1.270.3...v1.271.0) (2024-11-01)
+
+
+### Features
+
+* Ignore unhandled promise rejections that lack a valid reason ([#1233](https://github.com/newrelic/newrelic-browser-agent/issues/1233)) ([25a1fff](https://github.com/newrelic/newrelic-browser-agent/commit/25a1fffb91fa5936766a7bc89d735b3018aa62a2))
+
+## [1.270.3](https://github.com/newrelic/newrelic-browser-agent/compare/v1.270.2...v1.270.3) (2024-10-31)
+
+
+### Bug Fixes
+
+* Ensure all lazy loaded modules issue warning instead of errors ([#1234](https://github.com/newrelic/newrelic-browser-agent/issues/1234)) ([cdfdab7](https://github.com/newrelic/newrelic-browser-agent/commit/cdfdab701bda6266416ad27750e63e8e9e0e075b))
+
 ## [1.270.2](https://github.com/newrelic/newrelic-browser-agent/compare/v1.270.1...v1.270.2) (2024-10-28)
 
 

package/dist/cjs/common/constants/env.cdn.js

@@ -12,7 +12,7 @@ exports.VERSION = exports.RRWEB_VERSION = exports.DIST_METHOD = exports.BUILD_EN
 /**
  * Exposes the version of the agent
  */
-const VERSION = exports.VERSION = "1.270.2";
+const VERSION = exports.VERSION = "1.271.0";
 
 /**
  * Exposes the build type of the agent

package/dist/cjs/common/constants/env.npm.js

@@ -12,7 +12,7 @@ exports.VERSION = exports.RRWEB_VERSION = exports.DIST_METHOD = exports.BUILD_EN
 /**
  * Exposes the version of the agent
  */
-const VERSION = exports.VERSION = "1.270.2";
+const VERSION = exports.VERSION = "1.271.0";
 
 /**
  * Exposes the build type of the agent

package/dist/cjs/features/jserrors/shared/cast-error.js

@@ -32,8 +32,15 @@ function castError(error) {
    * @returns {Error} An Error object with the message as the casted reason
    */
 function castPromiseRejectionEvent(promiseRejectionEvent) {
-  let prefix = 'Unhandled Promise Rejection';
-  if (canTrustError(promiseRejectionEvent?.reason)) {
+  const prefix = 'Unhandled Promise Rejection';
+
+  /**
+   * If the casted return value is falsy like this, it will get dropped and not produce an error event for harvest.
+   * We drop promise rejections that could not form a valid error stack or message deriving from the .reason attribute
+   * -- such as a manually invoked rejection without an argument -- since they lack reproduction value and create confusion.
+   * */
+  if (!promiseRejectionEvent?.reason) return;
+  if (canTrustError(promiseRejectionEvent.reason)) {
     try {
       promiseRejectionEvent.reason.message = prefix + ': ' + promiseRejectionEvent.reason.message;
       return castError(promiseRejectionEvent.reason);
@@ -41,7 +48,6 @@ function castPromiseRejectionEvent(promiseRejectionEvent) {
       return castError(promiseRejectionEvent.reason);
     }
   }
-  if (typeof promiseRejectionEvent.reason === 'undefined') return castError(prefix);
   const error = castError(promiseRejectionEvent.reason);
   error.message = prefix + ': ' + error?.message;
   return error;

package/dist/cjs/features/utils/instrument-base.js

@@ -95,20 +95,20 @@ class InstrumentBase extends _featureBase.FeatureBase {
         if (this.featureName === _features.FEATURE_NAMES.sessionReplay) this.abortHandler?.(); // SR should stop recording if session DNE
       }
 
-      // Create a single Aggregator for this agent if DNE yet; to be used by jserror endpoint features.
-      if (!agentRef.sharedAggregator) {
-        agentRef.sharedAggregator = Promise.resolve().then(() => _interopRequireWildcard(require(/* webpackChunkName: "shared-aggregator" */'../../common/aggregate/aggregator')));
-        const {
-          Aggregator
-        } = await agentRef.sharedAggregator;
-        agentRef.sharedAggregator = new Aggregator();
-      } else await agentRef.sharedAggregator; // if another feature is already importing the aggregator, wait for it to finish
-
       /**
        * Note this try-catch differs from the one in Agent.run() in that it's placed later in a page's lifecycle and
        * it's only responsible for aborting its one specific feature, rather than all.
        */
       try {
+        // Create a single Aggregator for this agent if DNE yet; to be used by jserror endpoint features.
+        if (!agentRef.sharedAggregator) {
+          agentRef.sharedAggregator = Promise.resolve().then(() => _interopRequireWildcard(require(/* webpackChunkName: "shared-aggregator" */'../../common/aggregate/aggregator')));
+          const {
+            Aggregator
+          } = await agentRef.sharedAggregator;
+          agentRef.sharedAggregator = new Aggregator();
+        } else await agentRef.sharedAggregator; // if another feature is already importing the aggregator, wait for it to finish
+
         if (!this.#shouldImportAgg(this.featureName, session)) {
           (0, _drain.drain)(this.agentIdentifier, this.featureName);
           loadedSuccessfully(false); // aggregate module isn't loaded at all

package/dist/esm/common/constants/env.cdn.js

@@ -6,7 +6,7 @@
 /**
  * Exposes the version of the agent
  */
-export const VERSION = "1.270.2";
+export const VERSION = "1.271.0";
 
 /**
  * Exposes the build type of the agent

package/dist/esm/common/constants/env.npm.js

@@ -6,7 +6,7 @@
 /**
  * Exposes the version of the agent
  */
-export const VERSION = "1.270.2";
+export const VERSION = "1.271.0";
 
 /**
  * Exposes the build type of the agent

package/dist/esm/features/jserrors/shared/cast-error.js

@@ -25,8 +25,15 @@ export function castError(error) {
    * @returns {Error} An Error object with the message as the casted reason
    */
 export function castPromiseRejectionEvent(promiseRejectionEvent) {
-  let prefix = 'Unhandled Promise Rejection';
-  if (canTrustError(promiseRejectionEvent?.reason)) {
+  const prefix = 'Unhandled Promise Rejection';
+
+  /**
+   * If the casted return value is falsy like this, it will get dropped and not produce an error event for harvest.
+   * We drop promise rejections that could not form a valid error stack or message deriving from the .reason attribute
+   * -- such as a manually invoked rejection without an argument -- since they lack reproduction value and create confusion.
+   * */
+  if (!promiseRejectionEvent?.reason) return;
+  if (canTrustError(promiseRejectionEvent.reason)) {
     try {
       promiseRejectionEvent.reason.message = prefix + ': ' + promiseRejectionEvent.reason.message;
       return castError(promiseRejectionEvent.reason);
@@ -34,7 +41,6 @@ export function castPromiseRejectionEvent(promiseRejectionEvent) {
       return castError(promiseRejectionEvent.reason);
     }
   }
-  if (typeof promiseRejectionEvent.reason === 'undefined') return castError(prefix);
   const error = castError(promiseRejectionEvent.reason);
   error.message = prefix + ': ' + error?.message;
   return error;

package/dist/esm/features/utils/instrument-base.js

@@ -90,20 +90,20 @@ export class InstrumentBase extends FeatureBase {
         if (this.featureName === FEATURE_NAMES.sessionReplay) this.abortHandler?.(); // SR should stop recording if session DNE
       }
 
-      // Create a single Aggregator for this agent if DNE yet; to be used by jserror endpoint features.
-      if (!agentRef.sharedAggregator) {
-        agentRef.sharedAggregator = import(/* webpackChunkName: "shared-aggregator" */'../../common/aggregate/aggregator');
-        const {
-          Aggregator
-        } = await agentRef.sharedAggregator;
-        agentRef.sharedAggregator = new Aggregator();
-      } else await agentRef.sharedAggregator; // if another feature is already importing the aggregator, wait for it to finish
-
       /**
        * Note this try-catch differs from the one in Agent.run() in that it's placed later in a page's lifecycle and
        * it's only responsible for aborting its one specific feature, rather than all.
        */
       try {
+        // Create a single Aggregator for this agent if DNE yet; to be used by jserror endpoint features.
+        if (!agentRef.sharedAggregator) {
+          agentRef.sharedAggregator = import(/* webpackChunkName: "shared-aggregator" */'../../common/aggregate/aggregator');
+          const {
+            Aggregator
+          } = await agentRef.sharedAggregator;
+          agentRef.sharedAggregator = new Aggregator();
+        } else await agentRef.sharedAggregator; // if another feature is already importing the aggregator, wait for it to finish
+
         if (!this.#shouldImportAgg(this.featureName, session)) {
           drain(this.agentIdentifier, this.featureName);
           loadedSuccessfully(false); // aggregate module isn't loaded at all

package/dist/types/features/jserrors/shared/cast-error.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"cast-error.d.ts","sourceRoot":"","sources":["../../../../../src/features/jserrors/shared/cast-error.js"],"names":[],"mappings":"AAEA;;;;;KAKK;AACL,iCAHa,GAAG,GACD,KAAK,GAAC,aAAa,CAmBjC;AAED;;;;KAIK;AACL,uEAFe,KAAK,CAmBnB;AAED;;;;KAIK;AACL,2CAHa,UAAU,GACR,KAAK,GAAC,aAAa,CAUjC;8BAhE6B,kBAAkB"}
+{"version":3,"file":"cast-error.d.ts","sourceRoot":"","sources":["../../../../../src/features/jserrors/shared/cast-error.js"],"names":[],"mappings":"AAEA;;;;;KAKK;AACL,iCAHa,GAAG,GACD,KAAK,GAAC,aAAa,CAmBjC;AAED;;;;KAIK;AACL,uEAFe,KAAK,CAwBnB;AAED;;;;KAIK;AACL,2CAHa,UAAU,GACR,KAAK,GAAC,aAAa,CAUjC;8BArE6B,kBAAkB"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@newrelic/browser-agent",
-  "version": "1.270.2",
+  "version": "1.271.0",
   "private": false,
   "author": "New Relic Browser Agent Team <browser-agent@newrelic.com>",
   "description": "New Relic Browser Agent",

package/src/features/jserrors/shared/cast-error.js

@@ -31,9 +31,16 @@ export function castError (error) {
    * @returns {Error} An Error object with the message as the casted reason
    */
 export function castPromiseRejectionEvent (promiseRejectionEvent) {
-  let prefix = 'Unhandled Promise Rejection'
+  const prefix = 'Unhandled Promise Rejection'
 
-  if (canTrustError(promiseRejectionEvent?.reason)) {
+  /**
+   * If the casted return value is falsy like this, it will get dropped and not produce an error event for harvest.
+   * We drop promise rejections that could not form a valid error stack or message deriving from the .reason attribute
+   * -- such as a manually invoked rejection without an argument -- since they lack reproduction value and create confusion.
+   * */
+  if (!promiseRejectionEvent?.reason) return
+
+  if (canTrustError(promiseRejectionEvent.reason)) {
     try {
       promiseRejectionEvent.reason.message = prefix + ': ' + promiseRejectionEvent.reason.message
       return castError(promiseRejectionEvent.reason)
@@ -42,8 +49,6 @@ export function castPromiseRejectionEvent (promiseRejectionEvent) {
     }
   }
 
-  if (typeof promiseRejectionEvent.reason === 'undefined') return castError(prefix)
-
   const error = castError(promiseRejectionEvent.reason)
   error.message = prefix + ': ' + error?.message
   return error

package/src/features/utils/instrument-base.js

@@ -90,18 +90,18 @@ export class InstrumentBase extends FeatureBase {
         if (this.featureName === FEATURE_NAMES.sessionReplay) this.abortHandler?.() // SR should stop recording if session DNE
       }
 
-      // Create a single Aggregator for this agent if DNE yet; to be used by jserror endpoint features.
-      if (!agentRef.sharedAggregator) {
-        agentRef.sharedAggregator = import(/* webpackChunkName: "shared-aggregator" */ '../../common/aggregate/aggregator')
-        const { Aggregator } = await agentRef.sharedAggregator
-        agentRef.sharedAggregator = new Aggregator()
-      } else await agentRef.sharedAggregator // if another feature is already importing the aggregator, wait for it to finish
-
       /**
        * Note this try-catch differs from the one in Agent.run() in that it's placed later in a page's lifecycle and
        * it's only responsible for aborting its one specific feature, rather than all.
        */
       try {
+        // Create a single Aggregator for this agent if DNE yet; to be used by jserror endpoint features.
+        if (!agentRef.sharedAggregator) {
+          agentRef.sharedAggregator = import(/* webpackChunkName: "shared-aggregator" */ '../../common/aggregate/aggregator')
+          const { Aggregator } = await agentRef.sharedAggregator
+          agentRef.sharedAggregator = new Aggregator()
+        } else await agentRef.sharedAggregator // if another feature is already importing the aggregator, wait for it to finish
+
         if (!this.#shouldImportAgg(this.featureName, session)) {
           drain(this.agentIdentifier, this.featureName)
           loadedSuccessfully(false) // aggregate module isn't loaded at all