@newrelic/browser-agent 1.245.0 → 1.246.1

package/src/cdn/polyfills.js

@@ -21,3 +21,4 @@ import 'core-js/stable/weak-set'
 import 'core-js/stable/object/get-own-property-descriptors'
 import 'core-js/stable/url'
 import 'core-js/stable/url-search-params'
+import 'core-js/stable/string/starts-with'

package/src/common/config/state/configurable.js

@@ -13,7 +13,8 @@ export function getModeledObject (obj, model) {
     for (let key in target) {
       if (obj[key] !== undefined) {
         try {
-          if (typeof obj[key] === 'object' && typeof model[key] === 'object') output[key] = getModeledObject(obj[key], model[key])
+          if (Array.isArray(obj[key]) && Array.isArray(model[key])) output[key] = Array.from(new Set([...obj[key], ...model[key]]))
+          else if (typeof obj[key] === 'object' && typeof model[key] === 'object') output[key] = getModeledObject(obj[key], model[key])
           else output[key] = obj[key]
         } catch (e) {
           warn('An error occurred while setting a property of a Configurable', e)

package/src/common/config/state/init.js

@@ -29,6 +29,7 @@ const model = () => {
     }
   }
   return {
+    feature_flags: [],
     proxy: {
       assets: undefined, // if this value is set, it will be used to overwrite the webpack asset path used to fetch assets
       beacon: undefined // likewise for the url to which we send analytics

package/src/common/session/session-entity.js

@@ -25,9 +25,10 @@ const model = {
   inactiveAt: 0,
   expiresAt: 0,
   updatedAt: Date.now(),
-  sessionReplay: MODE.OFF,
+  sessionReplayMode: MODE.OFF,
   sessionReplaySentFirstChunk: false,
   sessionTraceMode: MODE.OFF,
+  traceHarvestStarted: false,
   custom: {}
 }
 export const SESSION_EVENTS = {
@@ -140,7 +141,7 @@ export class SessionEntity {
 
     // The fact that the session is "new" or pre-existing is used in some places in the agent.  Session Replay and Trace
     // can use this info to inform whether to trust a new sampling decision vs continue a previous tracking effort.
-    if (this.isNew === undefined) this.isNew = !Object.keys(initialRead).length
+    this.isNew = !Object.keys(initialRead).length
     // if its a "new" session, we write to storage API with the default values.  These values may change over the lifespan of the agent run.
     // we can use a modeled object here to help us know and manage what values are being used. -- see "model" above
     if (this.isNew) this.write(getModeledObject(this.state, model), true)

package/src/common/url/parse-url.js

@@ -3,15 +3,9 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import { globalScope, isBrowserScope } from '../constants/runtime'
-
-var stringsToParsedUrls = {}
+import { globalScope } from '../constants/runtime'
 
 export function parseUrl (url) {
-  if (url in stringsToParsedUrls) {
-    return stringsToParsedUrls[url]
-  }
-
   // Return if URL is a data URL, parseUrl assumes urls are http/https
   if ((url || '').indexOf('data:') === 0) {
     return {
@@ -19,54 +13,30 @@ export function parseUrl (url) {
     }
   }
 
-  let urlEl
-  var location = globalScope?.location
-  var ret = {}
-
   try {
-    urlEl = new URL(url, location.href)
-  } catch (err) {
-    if (isBrowserScope) {
-    // Use an anchor dom element to resolve the url natively.
-      urlEl = document.createElement('a')
-      urlEl.href = url
-    } else {
-      return ret
+    const parsedUrl = new URL(url, location.href)
+    const returnVal = {
+      port: parsedUrl.port,
+      hostname: parsedUrl.hostname,
+      pathname: parsedUrl.pathname,
+      search: parsedUrl.search,
+      protocol: parsedUrl.protocol.slice(0, parsedUrl.protocol.indexOf(':')),
+      sameOrigin: parsedUrl.protocol === globalScope?.location?.protocol && parsedUrl.host === globalScope?.location?.host
     }
-  }
-
-  ret.port = urlEl.port
-
-  ret.search = urlEl.search
 
-  var firstSplit = urlEl.href.split('://')
-
-  if (!ret.port && firstSplit[1]) {
-    ret.port = firstSplit[1].split('/')[0].split('@').pop().split(':')[1]
-  }
-  if (!ret.port || ret.port === '0') ret.port = (firstSplit[0] === 'https' ? '443' : '80')
-
-  // Host not provided in IE for relative urls
-  ret.hostname = (urlEl.hostname || location.hostname)
-
-  ret.pathname = urlEl.pathname
-
-  ret.protocol = firstSplit[0]
-
-  // Pathname sometimes doesn't have leading slash (IE 8 and 9)
-  if (ret.pathname.charAt(0) !== '/') ret.pathname = '/' + ret.pathname
-
-  // urlEl.protocol is ':' in old ie when protocol is not specified
-  var sameProtocol = !urlEl.protocol || urlEl.protocol === ':' || urlEl.protocol === location.protocol
-  var sameDomain = urlEl.hostname === location.hostname && urlEl.port === location.port
+    if (!returnVal.port || returnVal.port === '') {
+      if (parsedUrl.protocol === 'http:') returnVal.port = '80'
+      if (parsedUrl.protocol === 'https:') returnVal.port = '443'
+    }
 
-  // urlEl.hostname is not provided by IE for relative urls, but relative urls are also same-origin
-  ret.sameOrigin = sameProtocol && (!urlEl.hostname || sameDomain)
+    if (!returnVal.pathname || returnVal.pathname === '') {
+      returnVal.pathname = '/'
+    } else if (!returnVal.pathname.startsWith('/')) {
+      returnVal.pathname = `/${returnVal.pathname}`
+    }
 
-  // Only cache if url doesn't have a path
-  if (ret.pathname === '/') {
-    stringsToParsedUrls[url] = ret
+    return returnVal
+  } catch (err) {
+    return {}
   }
-
-  return ret
 }

package/src/common/vitals/first-input-delay.js

@@ -13,8 +13,7 @@ if (isBrowserScope) {
     firstInputDelay.update({
       value: entries[0].startTime,
       entries,
-      attrs: { type: entries[0].name, fid: Math.round(value) },
-      shouldAddConnectionAttributes: true
+      attrs: { type: entries[0].name, fid: Math.round(value) }
     })
   })
 }

package/src/common/vitals/largest-contentful-paint.js

@@ -22,8 +22,7 @@ if (isBrowserScope) {
           ...(!!lcpEntry.url && { elUrl: cleanURL(lcpEntry.url) }),
           ...(!!lcpEntry.element?.tagName && { elTag: lcpEntry.element.tagName })
         }
-      }),
-      shouldAddConnectionAttributes: true
+      })
     })
   })
 }

package/src/common/vitals/vital-metric.js

@@ -8,7 +8,7 @@ export class VitalMetric {
     this.roundingMethod = typeof roundingMethod === 'function' ? roundingMethod : Math.floor
   }
 
-  update ({ value, entries = [], attrs = {}, shouldAddConnectionAttributes = false }) {
+  update ({ value, entries = [], attrs = {} }) {
     if (value < 0) return
     const state = {
       value: this.roundingMethod(value),
@@ -16,7 +16,7 @@ export class VitalMetric {
       entries,
       attrs
     }
-    if (shouldAddConnectionAttributes) addConnectionAttributes(state.attrs)
+
     this.history.push(state)
     this.#subscribers.forEach(cb => {
       try {
@@ -48,13 +48,3 @@ export class VitalMetric {
     return () => { this.#subscribers.delete(callback) }
   }
 }
-
-function addConnectionAttributes (obj) {
-  var connection = navigator.connection || navigator.mozConnection || navigator.webkitConnection // to date, both window & worker shares the same support for connection
-  if (!connection) return
-
-  if (connection.type) obj['net-type'] = connection.type
-  if (connection.effectiveType) obj['net-etype'] = connection.effectiveType
-  if (connection.rtt) obj['net-rtt'] = connection.rtt
-  if (connection.downlink) obj['net-dlink'] = connection.downlink
-}

package/src/features/ajax/aggregate/index.js

@@ -126,6 +126,8 @@ export class Aggregate extends AggregateBase {
         query: this?.parsedOrigin?.search
       })
 
+      if (event.gql) handle(SUPPORTABILITY_METRIC_CHANNEL, ['Ajax/Events/GraphQL/Bytes-Added', stringify(event.gql).length], undefined, FEATURE_NAMES.metrics, ee)
+
       // if the ajax happened inside an interaction, hold it until the interaction finishes
       if (this.spaNode) {
         var interactionId = this.spaNode.interaction.id

package/src/features/jserrors/aggregate/index.js

@@ -191,7 +191,7 @@ export class Aggregate extends AggregateBase {
       this.pageviewReported[bucketHash] = true
     }
 
-    if (agentRuntime?.session?.state?.sessionReplay) params.hasReplay = true
+    if (agentRuntime?.session?.state?.sessionReplayMode) params.hasReplay = true
     params.firstOccurrenceTimestamp = this.observedAt[bucketHash]
 
     var type = internal ? 'ierr' : 'err'

package/src/features/page_view_event/aggregate/index.js

@@ -69,6 +69,8 @@ export class Aggregate extends AggregateBase {
       at: info.atts
     }
 
+    if (agentRuntime.session) queryParameters.fsh = Number(agentRuntime.session.isNew) // "first session harvest" aka RUM request or PageView event of a session
+
     let body
     if (typeof info.jsAttributes === 'object' && Object.keys(info.jsAttributes).length > 0) {
       body = { ja: info.jsAttributes }

package/src/features/page_view_timing/aggregate/index.js

@@ -94,6 +94,7 @@ export class Aggregate extends AggregateBase {
 
   addTiming (name, value, attrs) {
     attrs = attrs || {}
+    addConnectionAttributes(attrs) // network conditions may differ from the actual for VitalMetrics when they were captured
 
     // If cls was set to another value by `onCLS`, then it's supported and is attached onto any timing but is omitted until such time.
     /*
@@ -175,3 +176,13 @@ export class Aggregate extends AggregateBase {
     return payload
   }
 }
+
+function addConnectionAttributes (obj) {
+  var connection = navigator.connection || navigator.mozConnection || navigator.webkitConnection // to date, both window & worker shares the same support for connection
+  if (!connection) return
+
+  if (connection.type) obj['net-type'] = connection.type
+  if (connection.effectiveType) obj['net-etype'] = connection.effectiveType
+  if (connection.rtt) obj['net-rtt'] = connection.rtt
+  if (connection.downlink) obj['net-dlink'] = connection.downlink
+}

package/src/features/session_replay/aggregate/index.js

@@ -133,14 +133,14 @@ export class Aggregate extends AggregateBase {
       this.ee.on(SESSION_EVENTS.RESUME, () => {
         // if the mode changed on a different tab, it needs to update this instance to match
         const { session } = getRuntime(this.agentIdentifier)
-        this.mode = session.state.sessionReplay
+        this.mode = session.state.sessionReplayMode
         if (!this.initialized || this.mode === MODE.OFF) return
         this.startRecording()
       })
 
       this.ee.on(SESSION_EVENTS.UPDATE, (type, data) => {
         if (!this.initialized || this.blocked || type !== SESSION_EVENT_TYPES.CROSS_TAB) return
-        if (this.mode !== MODE.OFF && data.sessionReplay === MODE.OFF) this.abort(ABORT_REASONS.CROSS_TAB)
+        if (this.mode !== MODE.OFF && data.sessionReplayMode === MODE.OFF) this.abort(ABORT_REASONS.CROSS_TAB)
         this.mode = data.sessionReplay
       })
 
@@ -167,7 +167,7 @@ export class Aggregate extends AggregateBase {
 
             this.scheduler.startTimer(this.harvestTimeSeconds)
 
-            this.syncWithSessionManager({ sessionReplay: this.mode })
+            this.syncWithSessionManager({ sessionReplayMode: this.mode })
           }
         }
       }, this.featureName, this.ee)
@@ -201,7 +201,7 @@ export class Aggregate extends AggregateBase {
     // session replay samples can only be decided on the first load of a session
     // session replays can continue if already in progress
     if (!session.isNew) { // inherit the mode of the existing session
-      this.mode = session.state.sessionReplay
+      this.mode = session.state.sessionReplayMode
     } else {
       // The session is new... determine the mode the new session should start in
       if (fullSample) this.mode = MODE.FULL // full mode has precedence over error mode
@@ -241,7 +241,7 @@ export class Aggregate extends AggregateBase {
     }
     this.startRecording()
 
-    this.syncWithSessionManager({ sessionReplay: this.mode })
+    this.syncWithSessionManager({ sessionReplayMode: this.mode })
   }
 
   prepareHarvest () {
@@ -439,7 +439,7 @@ export class Aggregate extends AggregateBase {
     this.blocked = true
     this.mode = MODE.OFF
     this.stopRecording()
-    this.syncWithSessionManager({ sessionReplay: this.mode })
+    this.syncWithSessionManager({ sessionReplayMode: this.mode })
     this.clearTimestamps()
     this.ee.emit('REPLAY_ABORTED')
   }

package/src/features/session_trace/aggregate/index.js

@@ -125,7 +125,7 @@ export class Aggregate extends AggregateBase {
           this.ee.on(SESSION_EVENTS.PAUSE, () => { mostRecentModeKnown = sessionEntity.state.sessionTraceMode })
 
           if (!sessionEntity.isNew) { // inherit the same mode as existing session's Trace
-            if (sessionEntity.state.sessionReplay === MODE.OFF) this.isStandalone = true
+            if (sessionEntity.state.sessionReplayMode === MODE.OFF) this.isStandalone = true
             controlTraceOp(mostRecentModeKnown = sessionEntity.state.sessionTraceMode)
           } else { // for new sessions, see the truth table associated with NEWRELIC-8662 wrt the new Trace behavior under session management
             const replayMode = await getSessionReplayMode(agentIdentifier)
@@ -462,6 +462,13 @@ export class Aggregate extends AggregateBase {
     this.trace = {}
     this.nodeCount = 0
 
+    let firstHarvestOfSession
+    if (this.agentRuntime.session) {
+      const isFirstPayload = !this.agentRuntime.session.state.traceHarvestStarted
+      firstHarvestOfSession = { fsh: Number(isFirstPayload) } // converted to '0' | '1'
+      if (isFirstPayload) this.agentRuntime.session.write({ traceHarvestStarted: true })
+    }
+
     return {
       qs: {
         st: this.agentRuntime.offset,
@@ -472,7 +479,8 @@ export class Aggregate extends AggregateBase {
          * so that blob parsing doesn't need to happen to support UI/API functions  */
         fts: this.agentRuntime.offset + earliestTimeStamp,
         /** n === "nodeCount" in NR1, a count of nodes in the ST payload, so that blob parsing doesn't need to happen to support UI/API functions */
-        n: stns.length // node count
+        n: stns.length, // node count
+        ...firstHarvestOfSession
       },
       body: { res: stns }
     }

package/src/features/spa/aggregate/index.js

@@ -46,7 +46,9 @@ export class Aggregate extends AggregateBase {
       depth: 0,
       harvestTimeSeconds: getConfigurationValue(agentIdentifier, 'spa.harvestTimeSeconds') || 10,
       interactionsToHarvest: [],
-      interactionsSent: []
+      interactionsSent: [],
+      // The below feature flag is used to disable the SPA ajax fix for specific customers, see https://new-relic.atlassian.net/browse/NR-172169
+      disableSpaFix: (getConfigurationValue(agentIdentifier, 'feature_flags') || []).indexOf('disable-spa-fix') > -1
     }
 
     this.serializer = new Serializer(this)
@@ -279,7 +281,7 @@ export class Aggregate extends AggregateBase {
     // context is stored on the xhr and is shared with all callbacks associated
     // with the new xhr
     register('new-xhr', function () {
-      if (!state.currentNode && state.prevInteraction && !state.prevInteraction.ignored) {
+      if (!state.disableSpaFix && !state.currentNode && state.prevInteraction && !state.prevInteraction.ignored) {
         /*
          * The previous interaction was discarded before a route change. Restore the interaction
          * in case this XHR is associated with a route change.
@@ -382,7 +384,7 @@ export class Aggregate extends AggregateBase {
 
     register(FETCH_START, function (fetchArguments, dtPayload) {
       if (fetchArguments) {
-        if (!state.currentNode && state.prevInteraction && !state.prevInteraction.ignored) {
+        if (!state.disableSpaFix && !state.currentNode && state.prevInteraction && !state.prevInteraction.ignored) {
           /*
            * The previous interaction was discarded before a route change. Restore the interaction
            * in case this XHR is associated with a route change.

package/src/features/utils/feature-base.js

@@ -4,9 +4,9 @@ export class FeatureBase {
   constructor (agentIdentifier, aggregator, featureName) {
     /** @type {string} */
     this.agentIdentifier = agentIdentifier
-    /** @type {Aggregator} */
+    /** @type {import('../../common/aggregate/aggregator').Aggregator} */
     this.aggregator = aggregator
-    /** @type {ContextualEE} */
+    /** @type {import('../../common/event-emitter/contextual-ee').ee} */
     this.ee = ee.get(agentIdentifier)
     /** @type {string} */
     this.featureName = featureName

package/src/features/utils/instrument-base.js

@@ -20,7 +20,7 @@ export class InstrumentBase extends FeatureBase {
   /**
    * Instantiate InstrumentBase.
    * @param {string} agentIdentifier - The unique ID of the instantiated agent (relative to global scope).
-   * @param {Aggregator} aggregator - The shared Aggregator that will handle batching and reporting of data.
+   * @param {import('../../common/aggregate/aggregator').Aggregator} aggregator - The shared Aggregator that will handle batching and reporting of data.
    * @param {string} featureName - The name of the feature module (used to construct file path).
    * @param {boolean} [auto=true] - Determines whether the feature should automatically register to have the draining
    *     of its pooled instrumentation data handled by the agent's centralized drain functionality, rather than draining
@@ -34,7 +34,7 @@ export class InstrumentBase extends FeatureBase {
     this.abortHandler = undefined
 
     /**
-     * @type {Class} Holds the reference to the feature's aggregate module counterpart, if and after it has been initialized. This may not be assigned until after page loads!
+     * @type {import('./aggregate-base').AggregateBase} Holds the reference to the feature's aggregate module counterpart, if and after it has been initialized. This may not be assigned until after page loads!
      * The only purpose of this for now is to expose it to the NREUM interface, as the feature's instrument instance is already exposed.
     */
     this.featAggregate = undefined
@@ -122,14 +122,14 @@ export class InstrumentBase extends FeatureBase {
   /**
  * Make a determination if an aggregate class should even be imported
  * @param {string} featureName
- * @param {SessionEntity} session
+ * @param {import('../../common/session/session-entity').SessionEntity} session
  * @returns
  */
   shouldImportAgg (featureName, session) {
     if (featureName === FEATURE_NAMES.sessionReplay) {
       if (!originals.MO) return false // Session Replay cannot work without Mutation Observer
       if (getConfigurationValue(this.agentIdentifier, 'session_trace.enabled') === false) return false // Session Replay as of now is tightly coupled with Session Trace in the UI
-      return !!session?.isNew || !!session?.state.sessionReplay // Session Replay should only try to run if already running from a previous page, or at the beginning of a session
+      return !!session?.isNew || !!session?.state.sessionReplayMode // Session Replay should only try to run if already running from a previous page, or at the beginning of a session
     }
     return true
   }

package/src/loaders/configure/public-path.npm.js

@@ -1,4 +1,3 @@
-
 export const redefinePublicPath = () => {
   // We don't support setting public path in webpack via NPM build.
 }