@newrelic/browser-agent 1.237.1 → 1.239.0

package/package.json

@@ -1,9 +1,9 @@
 {
   "name": "@newrelic/browser-agent",
-  "version": "1.237.1",
+  "version": "1.239.0",
   "private": false,
   "author": "New Relic Browser Agent Team <browser-agent@newrelic.com>",
-  "description": "Tests for the New Relic JavaScript agent",
+  "description": "New Relic Browser Agent",
   "license": "Apache-2.0",
   "homepage": "https://docs.newrelic.com/docs/browser/browser-monitoring",
   "main": "./dist/cjs/index.js",
@@ -13,6 +13,45 @@
     ">=4.2": {
       "*": [
         "dist/types/*"
+      ],
+      "src/*": [
+        "dist/types/*"
+      ],
+      "loaders/agent": [
+        "dist/types/loaders/agent.d.ts"
+      ],
+      "loaders/browser-agent": [
+        "dist/types/loaders/browser-agent.d.ts"
+      ],
+      "loaders/micro-agent": [
+        "dist/types/loaders/micro-agent.d.ts"
+      ],
+      "loaders/worker-agent": [
+        "dist/types/loaders/worker-agent.d.ts"
+      ],
+      "features/ajax": [
+        "dist/types/features/ajax/index.d.ts"
+      ],
+      "features/jserrors": [
+        "dist/types/features/jserrors/index.d.ts"
+      ],
+      "features/metrics": [
+        "dist/types/features/metrics/index.d.ts"
+      ],
+      "features/page_action": [
+        "dist/types/features/page_action/index.d.ts"
+      ],
+      "features/page_view_event": [
+        "dist/types/features/page_view_event/index.d.ts"
+      ],
+      "features/page_view_timing": [
+        "dist/types/features/page_view_timing/index.d.ts"
+      ],
+      "features/session_trace": [
+        "dist/types/features/session_trace/index.d.ts"
+      ],
+      "features/spa": [
+        "dist/types/features/spa/index.d.ts"
       ]
     }
   },
@@ -92,35 +131,30 @@
     "node": ">=12.17.0 < 13.0.0 || >=13.7.0"
   },
   "scripts": {
-    "wdio": "node --max-old-space-size=8192 tools/wdio/bin/cli.js",
     "start": "npm-run-all --parallel cdn:watch test-server",
-    "test:unit": "jest",
-    "test:component": "jest --config jest.component-config.js",
+    "lint": "eslint -c .eslintrc.js --ext .js,.cjs,.mjs .",
+    "lint:fix": "npm run lint -- --fix",
+    "test": "jest",
+    "test:unit": "jest --selectProjects unit",
+    "test:component": "jest --selectProjects component",
+    "test:types": "tsd -f ./tests/dts/**/*.ts",
+    "wdio": "node --max-old-space-size=8192 tools/wdio/bin/cli.js",
+    "jil": "tools/jil/bin/cli.js",
     "build:all": "npm run cdn:build:local && npm run build:npm && npm run tools:test-builds",
     "build:npm": "npm run npm:build:esm && npm run npm:build:cjs && npm run npm:build:types && npm run npm:pack",
     "build:browser-tests": "npm --prefix ./tools/test-builds/browser-tests run build",
-    "lint": "eslint -c .eslintrc.js --ext .js,.cjs,.mjs .",
-    "lint:fix": "npm run lint -- --fix",
-    "test-jil": "tools/jil/bin/cli.js",
-    "ci-build": "npm ci --cache ./.npm",
-    "build-tar": "npm run ci-build && tar czf ./build/browser-agent.tar.gz --exclude=.git --exclude=.npm --exclude=build/browser-agent.tar.gz .",
-    "watch": "jung -D '\\.npm|.git|node_modules|build|tools|tests' --run -- npm run build:all",
+    "watch:browser-tests": "jung -r ./src -F '.*\\.test\\.js' --run -- npm run build:browser-tests",
     "cdn:build": "npm run cdn:build:prod",
-    "cdn:build:extension": "PUBLISH=EXTENSION rm -rf ./build && npm run cdn:webpack && npm run cdn:cleanup",
-    "cdn:build:local": "npm run cdn:webpack && npm run cdn:cleanup",
-    "cdn:build:prod": "npm run cdn:fresh-build && PUBLISH=PROD npm run cdn:webpack && npm run cdn:cleanup && npm run cdn:clone",
-    "cdn:build:dev": "npm run cdn:fresh-build && PUBLISH=DEV npm run cdn:webpack && npm run cdn:cleanup",
-    "cdn:build:current": "npm run cdn:fresh-build && PUBLISH=CURRENT npm run cdn:webpack && npm run cdn:cleanup",
-    "cdn:build:nr": "npm run cdn:fresh-build && PUBLISH=PROD SOURCEMAPS=false npm run cdn:webpack && npm run cdn:cleanup",
-    "cdn:build:pr": "npm run cdn:fresh-build && PUBLISH=PR npm run cdn:webpack && npm run cdn:cleanup",
-    "cdn:build:experiment": "npm run cdn:fresh-build && PUBLISH=EXPERIMENT npm run cdn:webpack && npm run cdn:cleanup",
-    "cdn:cleanup": "node ./tools/scripts/post-build-cleanup",
-    "cdn:clone": "node ./tools/scripts/clone",
-    "cdn:fresh-build": "rm -rf ./build",
+    "cdn:build:local": "npm run cdn:webpack",
+    "cdn:build:prod": "npm run cdn:webpack -- --env mode=prod",
+    "postcdn:build:prod": "npm run cdn:clone",
+    "cdn:build:dev": "npm run cdn:webpack -- --env mode=dev",
+    "cdn:build:experiment": "npm run cdn:webpack -- --env mode=experiment",
+    "cdn:webpack": "npx webpack --progress --config ./tools/webpack/index.mjs",
+    "postcdn:webpack": "npm run cdn:cleanup",
     "cdn:watch": "jung -r ./src -F '.*\\.test\\.js' --run -- npm run cdn:build:local",
-    "cdn:watch:extension": "jung -r ./src -F '.*\\.test\\.js' --run -- npm run cdn:build:extension",
-    "cdn:webpack": "npx webpack --progress --config ./webpack.config.js",
-    "packages:bundle": "webpack -c tools/jil/webpack.modular.js",
+    "cdn:cleanup": "node ./tools/webpack/scripts/cleanup.mjs",
+    "cdn:clone": "node ./tools/webpack/scripts/clone.mjs",
     "test-server": "node ./tools/wdio/bin/server",
     "sauce:connect": "node ./tools/saucelabs/bin.mjs",
     "sauce:get-browsers": "node ./tools/browsers-lists/sauce-browsers.mjs",
@@ -130,8 +164,7 @@
     "npm:build:esm": "npx babel --env-name npm-esm --out-dir dist/esm --out-file-extension .js ./src",
     "npm:build:cjs": "npx babel --env-name npm-cjs --out-dir dist/cjs --out-file-extension .js ./src",
     "npm:build:types": "npx tsc -b",
-    "npm:pack": "mkdir -p temp && export PKG_NAME=$(npm pack --pack-destination temp) && echo ./temp/$PKG_NAME",
-    "watch:browser-tests": "jung -r ./src -F '.*\\.test\\.js' --run -- npm run build:browser-tests"
+    "npm:pack": "mkdir -p temp && export PKG_NAME=$(npm pack --pack-destination temp) && echo ./temp/$PKG_NAME"
   },
   "config": {
     "unsafe-perm": true
@@ -147,7 +180,6 @@
     "web-vitals": "^3.1.0"
   },
   "devDependencies": {
-    "@actions/core": "^1.10.0",
     "@babel/cli": "^7.20.7",
     "@babel/core": "^7.20.12",
     "@babel/eslint-parser": "^7.19.1",
@@ -166,20 +198,17 @@
     "@fastify/static": "^6.10.1",
     "@newrelic/newrelic-oss-cli": "^0.1.2",
     "@newrelic/nr-querypack": "https://git@github.com/newrelic/nr-querypack",
-    "@octokit/rest": "^19.0.7",
     "@wdio/cli": "^8.10.5",
     "@wdio/local-runner": "^8.10.5",
     "@wdio/mocha-framework": "^8.10.4",
     "@wdio/sauce-service": "^8.10.5",
     "@wdio/selenium-standalone-service": "^8.10.4",
     "@wdio/spec-reporter": "^8.10.5",
-    "aws-sdk": "^2.894.0",
     "babel-jest": "^29.4.1",
     "babel-loader": "^8.2.5",
     "babel-plugin-transform-inline-environment-variables": "^0.4.4",
     "babelify": "^10.0.0",
     "browserify": "^13.3.0",
-    "chalk": "^5.1.2",
     "charm": "^1.0.1",
     "concat-stream": "^1.5.1",
     "deepmerge-ts": "^5.1.0",
@@ -193,11 +222,9 @@
     "eslint-plugin-sonarjs": "^0.19.0",
     "fastify": "^4.17.0",
     "fastify-plugin": "^4.5.0",
-    "filesize": "^10.0.7",
     "fs-extra": "^11.1.0",
     "function-bind": "^1.1.1",
     "glob": "^10.2.5",
-    "gzip-size": "^7.0.0",
     "html-webpack-plugin": "^5.5.0",
     "husky": "^8.0.0",
     "istanbul-lib-coverage": "^3.2.0",
@@ -209,26 +236,23 @@
     "jest-extended": "^3.2.4",
     "jung": "^2.1.0",
     "just-debounce": "^1.0.0",
-    "mime-types": "^2.1.11",
     "newrelic": "^9.7.5",
     "node-fetch": "^3.3.0",
     "npm-run-all": "^4.1.5",
     "object-inspect": "^1.5.0",
-    "octokit": "^2.0.14",
     "path-browserify": "^1.0.1",
     "preprocessify": "0.0.6",
     "process": "^0.11.10",
-    "request": "2.74.0",
     "saucelabs": "^7.2.1",
     "semver": "^5.3.0",
     "serialize-anything": "^1.2.3",
-    "sinon": "^2.4.1",
     "stream-browserify": "^3.0.0",
     "tap-parser": "^1.2.2",
     "tape": "^4.8.0",
     "through": "^2.3.8",
-    "through2": "^2.0.1",
+    "tsd": "^0.28.1",
     "typescript": "^5.0.3",
+    "util": "^0.12.5",
     "uuid": "^9.0.0",
     "wait-on": "^7.0.1",
     "wd": "^1.11.2",

package/src/common/aggregate/aggregator.test.js

@@ -0,0 +1,107 @@
+import { Aggregator } from './aggregator.js'
+
+let aggregator
+beforeEach(() => {
+  aggregator = new Aggregator({ agentIdentifier: 'blah' })
+})
+
+test('storing and getting buckets', () => {
+  let bucket = aggregator.store('abc', '123')
+  const expectedBucketPattern = { params: {}, metrics: { count: 1 } }
+  expect(bucket).toEqual(expectedBucketPattern)
+  expect(aggregator.get('abc', '123')).toEqual(expectedBucketPattern)
+
+  aggregator.store('abc', '456')
+  // check we can get all buckets under the same type
+  expect(aggregator.get('abc')).toEqual({ 123: expectedBucketPattern, 456: expectedBucketPattern })
+})
+
+describe('storing the same bucket again', () => {
+  test('increments the count', () => {
+    aggregator.store('abc', '123')
+    aggregator.store('abc', '123')
+    expect(aggregator.get('abc', '123')).toEqual({ params: {}, metrics: { count: 2 } })
+  })
+
+  test('does not overwrite params', () => {
+    aggregator.store('def', '123', { someParam: true })
+    aggregator.store('def', '123', { anotherParam: true })
+    expect(aggregator.get('def', '123')).toEqual({ params: { someParam: true }, metrics: { count: 2 } })
+  })
+
+  test('does not overwrite custom params either', () => {
+    aggregator.store('ghi', '123', undefined, undefined, { someCustomParam: true })
+    aggregator.store('ghi', '123', undefined, undefined, { someCustomParam: false })
+    expect(aggregator.get('ghi', '123')).toEqual({ params: {}, custom: { someCustomParam: true }, metrics: { count: 2 } })
+  })
+})
+
+describe('metrics are properly updated', () => {
+  test('when using store fn', () => {
+    const expectedBucketPattern = {
+      params: {},
+      metrics: {
+        count: 2,
+        met1: { t: 3, min: 1, max: 2, sos: 5, c: 2 },
+        met2: { t: 7, min: 3, max: 4, sos: 25, c: 2 }
+      }
+    }
+    aggregator.store('abc', '123', undefined, { met1: 1, met2: 3 })
+    aggregator.store('abc', '123', undefined, { met1: 2, met2: 4 })
+    expect(aggregator.get('abc', '123')).toEqual(expectedBucketPattern)
+  })
+
+  test('when using storeMetric fn', () => {
+    const expectedBucketPattern = {
+      params: {},
+      stats: { t: 6, min: 1, max: 3, sos: 14, c: 3 }
+    }
+    aggregator.storeMetric('abc', 'metric', undefined, 2)
+    aggregator.storeMetric('abc', 'metric', undefined, 1)
+    aggregator.storeMetric('abc', 'metric', undefined, 3)
+    expect(aggregator.get('abc', 'metric')).toEqual(expectedBucketPattern)
+  })
+})
+
+test('take fn gets and deletes correctly', () => {
+  aggregator.store('type1', 'a')
+  aggregator.store('type1', 'b')
+  aggregator.store('type2', 'a')
+  aggregator.store('type3', 'a')
+
+  expect(aggregator.take(['type0'])).toBeNull() // when type dne in aggregator
+  let obj = aggregator.take(['type1', 'type2'])
+  expect(obj.type1.length).toEqual(2)
+  expect(obj.type2.length).toEqual(1)
+  expect(aggregator.get('type1', 'a')).toBeUndefined() // should be gone now
+  expect(aggregator.get('type3', 'a')).toEqual(expect.any(Object))
+})
+
+test('merge fn combines metrics correctly', () => {
+  aggregator.store('abc', '123', undefined, { met1: 1, met2: 3 })
+  let bucket = aggregator.store('abc', '123', undefined, { met1: 2 })
+  const expectedMetrics = {
+    count: 2,
+    met1: { t: 3, min: 1, max: 2, sos: 5, c: 2 },
+    met2: { t: 3 }
+  }
+  expect(bucket.metrics).toEqual(expectedMetrics)
+
+  aggregator.merge('abc', '456', bucket.metrics)
+  expect(aggregator.get('abc', '456').metrics).toEqual(expectedMetrics)
+
+  aggregator.merge('abc', '123', {
+    count: 4,
+    met1: { t: 4, min: 0, max: 4, sos: 16, c: 2 },
+    met2: { t: 5 },
+    met3: { t: 6 },
+    met4: { t: 7, min: 3, max: 4, sos: 25, c: 2 }
+  })
+  expect(aggregator.get('abc', '123').metrics).toEqual({
+    count: 6,
+    met1: { t: 7, min: 0, max: 4, sos: 21, c: 4 },
+    met2: { t: 8, min: 3, max: 5, sos: 34, c: 2 },
+    met3: { t: 6 },
+    met4: { t: 7, min: 3, max: 4, sos: 25, c: 2 }
+  })
+})

package/src/common/config/state/configurable.test.js

@@ -0,0 +1,73 @@
+import { getModeledObject } from './configurable'
+
+test('if either params are not objects, function fails', () => {
+  let result = getModeledObject(123, {})
+  expect(result).toEqual(undefined)
+
+  result = getModeledObject({}, () => 'whatever')
+  expect(result).toEqual(undefined)
+})
+
+test('models are not mutated by function', () => {
+  const template = { dontchangethis: true }
+  getModeledObject({ dontchangethis: false, addthis: true }, template)
+  expect(template).toEqual({ dontchangethis: true })
+})
+
+const model = {
+  eat: true,
+  sleep: true,
+  rave: true,
+  repeat: {
+    eat: true,
+    sleep: true,
+    rave: true,
+    repeat: false
+  }
+}
+
+test('empty object does not change model output', () => {
+  expect(getModeledObject({}, model)).toEqual(model)
+})
+
+test('existing keys get their values changed', () => {
+  let obj = {
+    sleep: false,
+    repeat: {
+      eat: false
+    }
+  }
+  expect(getModeledObject(obj, model)).toEqual({
+    eat: true,
+    sleep: false,
+    rave: true,
+    repeat: {
+      eat: false, // should recurse
+      sleep: true,
+      rave: true,
+      repeat: false
+    }
+  })
+})
+
+test('existing keys can change types too, to/from object', () => {
+  // in other words, if replacement is not an object, it has no effect
+  let obj = {
+    rave: {},
+    repeat: 'just a sad lonely string now'
+  }
+  expect(getModeledObject(obj, model)).toEqual({
+    eat: true,
+    sleep: true,
+    rave: {},
+    repeat: 'just a sad lonely string now'
+  })
+})
+
+test('keys not in model are ignored', () => {
+  expect(getModeledObject({ game: 'allnight' }, model)).toEqual(model)
+})
+
+test('but if model is empty, then keys are not ignored', () => {
+  expect(getModeledObject({ game: 'allnight' }, {})).toEqual({ game: 'allnight' })
+})

package/src/common/config/state/info.test.js

@@ -0,0 +1,31 @@
+let isValid, getInfo, setInfo
+beforeEach(async () => {
+  jest.resetModules()
+  ;({ isValid, getInfo, setInfo } = await import('./info.js'))
+})
+
+test('set/getInfo should throw on an invalid agent id', () => {
+  // currently only checks if it's a truthy value
+  expect(() => setInfo(undefined, {})).toThrow('require an agent id')
+  expect(() => getInfo(undefined)).toThrow('require an agent id')
+  expect(() => setInfo('', {})).toThrow('require an agent id')
+  expect(() => getInfo('')).toThrow('require an agent id')
+})
+
+test('set/getInfo works correctly', () => {
+  expect(() => setInfo(123, { beacon: 'im here' })).not.toThrow() // notice setInfo accepts numbers
+  let cachedObj = getInfo('123')
+  expect(Object.keys(cachedObj).length).toBeGreaterThan(1)
+  expect(cachedObj.beacon).toEqual('im here')
+  expect(cachedObj.licenseKey).toEqual(undefined) // this should mirror default in info.js
+})
+
+test('isValid is correct', () => {
+  setInfo('ab', { errorBeacon: 'some value' })
+  setInfo('cd', { errorBeacon: 'some value', licenseKey: 'cereal box' })
+  expect(isValid('ab')).toBeFalsy()
+  expect(isValid('cd')).toBeFalsy()
+
+  setInfo('ef', { errorBeacon: 'some value', licenseKey: 'cereal box', applicationID: '25' })
+  expect(isValid('ef')).toBeTruthy()
+})

package/src/common/config/state/init.js

@@ -8,9 +8,8 @@ const model = () => {
     maskInputOptions: { password: true }
   }
   return {
-    allow_bfcache: true, // *cli - temporary feature flag for BFCache work
     privacy: { cookies_enabled: true }, // *cli - per discussion, default should be true
-    ajax: { deny_list: undefined, block_internal: true, enabled: true, harvestTimeSeconds: 10 },
+    ajax: { deny_list: undefined, block_internal: true, enabled: true, harvestTimeSeconds: 10, autoStart: true },
     distributed_tracing: {
       enabled: undefined,
       exclude_newrelic_header: undefined,
@@ -25,15 +24,16 @@ const model = () => {
     },
     ssl: undefined,
     obfuscate: undefined,
-    jserrors: { enabled: true, harvestTimeSeconds: 10 },
-    metrics: { enabled: true },
-    page_action: { enabled: true, harvestTimeSeconds: 30 },
-    page_view_event: { enabled: true },
-    page_view_timing: { enabled: true, harvestTimeSeconds: 30, long_task: false },
-    session_trace: { enabled: true, harvestTimeSeconds: 10 },
+    jserrors: { enabled: true, harvestTimeSeconds: 10, autoStart: true },
+    metrics: { enabled: true, autoStart: true },
+    page_action: { enabled: true, harvestTimeSeconds: 30, autoStart: true },
+    page_view_event: { enabled: true, autoStart: true },
+    page_view_timing: { enabled: true, harvestTimeSeconds: 30, long_task: false, autoStart: true },
+    session_trace: { enabled: true, harvestTimeSeconds: 10, autoStart: true },
     harvest: { tooManyRequestsDelay: 60 },
     session_replay: {
       // feature settings
+      autoStart: true,
       enabled: false,
       harvestTimeSeconds: 60,
       sampleRate: 0.1,
@@ -61,26 +61,27 @@ const model = () => {
         hiddenState.maskInputOptions = { ...val, password: true }
       }
     },
-    spa: { enabled: true, harvestTimeSeconds: 10 }
+    spa: { enabled: true, harvestTimeSeconds: 10, autoStart: true }
   }
 }
 
 const _cache = {}
+const missingAgentIdError = 'All configuration objects require an agent identifier!'
 
 export function getConfiguration (id) {
-  if (!id) throw new Error('All configuration objects require an agent identifier!')
+  if (!id) throw new Error(missingAgentIdError)
   if (!_cache[id]) throw new Error(`Configuration for ${id} was never set`)
   return _cache[id]
 }
 
 export function setConfiguration (id, obj) {
-  if (!id) throw new Error('All configuration objects require an agent identifier!')
+  if (!id) throw new Error(missingAgentIdError)
   _cache[id] = getModeledObject(obj, model())
   gosNREUMInitializedAgents(id, _cache[id], 'config')
 }
 
 export function getConfigurationValue (id, path) {
-  if (!id) throw new Error('All configuration objects require an agent identifier!')
+  if (!id) throw new Error(missingAgentIdError)
   var val = getConfiguration(id)
   if (val) {
     var parts = path.split('.')

package/src/common/config/state/init.test.js

@@ -0,0 +1,28 @@
+let getConfiguration, setConfiguration, getConfigurationValue
+beforeEach(async () => {
+  jest.resetModules()
+  ;({ getConfiguration, setConfiguration, getConfigurationValue } = await import('./init.js'))
+})
+
+test('set/getConfiguration should throw on an invalid agent id', () => {
+  // currently only checks if it's a truthy value
+  expect(() => setConfiguration(undefined, {})).toThrow('require an agent id')
+  expect(() => getConfiguration(undefined)).toThrow('require an agent id')
+  expect(() => setConfiguration('', {})).toThrow('require an agent id')
+  expect(() => getConfiguration('')).toThrow('require an agent id')
+})
+
+test('set/getConfiguration works correctly', () => {
+  expect(() => setConfiguration(123, { jserrors: { enabled: false } })).not.toThrow() // notice setConfiguration accepts numbers
+  let cachedObj = getConfiguration('123')
+  expect(Object.keys(cachedObj).length).toBeGreaterThan(1)
+  expect(cachedObj.jserrors.enabled).toEqual(false)
+  expect(cachedObj.page_action.enabled).toEqual(true) // this should mirror default in init.js
+})
+
+test('getConfigurationValue parses path correctly', () => {
+  setConfiguration('ab', { page_action: { harvestTimeSeconds: 1000 } })
+  expect(getConfigurationValue('ab', '')).toBeUndefined()
+  expect(getConfigurationValue('ab', 'page_action')).toEqual({ enabled: true, harvestTimeSeconds: 1000, autoStart: true })
+  expect(getConfigurationValue('ab', 'page_action.harvestTimeSeconds')).toEqual(1000)
+})

package/src/common/config/state/loader-config.test.js

@@ -0,0 +1,21 @@
+let getLoaderConfig, setLoaderConfig
+beforeEach(async () => {
+  jest.resetModules()
+  ;({ getLoaderConfig, setLoaderConfig } = await import('./loader-config.js'))
+})
+
+test('set/getLoaderConfig should throw on an invalid agent id', () => {
+  // currently only checks if it's a truthy value
+  expect(() => setLoaderConfig(undefined, {})).toThrow('require an agent id')
+  expect(() => getLoaderConfig(undefined)).toThrow('require an agent id')
+  expect(() => setLoaderConfig('', {})).toThrow('require an agent id')
+  expect(() => getLoaderConfig('')).toThrow('require an agent id')
+})
+
+test('set/getLoaderConfig works correctly', () => {
+  expect(() => setLoaderConfig(123, { trustKey: 1 })).not.toThrow() // notice setLoaderConfig accepts numbers
+  let cachedObj = getLoaderConfig('123')
+  expect(Object.keys(cachedObj).length).toBeGreaterThan(1)
+  expect(cachedObj.trustKey).toEqual(1)
+  expect(cachedObj.xpid).toBeUndefined() // this should mirror default in loader-config.js
+})

package/src/common/config/state/runtime.js

@@ -5,8 +5,6 @@ import { BUILD_ENV, DIST_METHOD, VERSION } from '../../constants/env'
 
 const model = {
   buildEnv: BUILD_ENV,
-  bytesSent: {}, // Used for SM to capture body bytes sent per endpoint
-  queryBytesSent: {}, // Used for SM to capture query parameter bytes sent per endpoint
   customTransaction: undefined,
   disabled: false,
   distMethod: DIST_METHOD,

package/src/common/config/state/runtime.test.js

@@ -0,0 +1,21 @@
+let getRuntime, setRuntime
+beforeEach(async () => {
+  jest.resetModules()
+  ;({ getRuntime, setRuntime } = await import('./runtime.js'))
+})
+
+test('set/getRuntime should throw on an invalid agent id', () => {
+  // currently only checks if it's a truthy value
+  expect(() => setRuntime(undefined, {})).toThrow('require an agent id')
+  expect(() => getRuntime(undefined)).toThrow('require an agent id')
+  expect(() => setRuntime('', {})).toThrow('require an agent id')
+  expect(() => getRuntime('')).toThrow('require an agent id')
+})
+
+test('set/getRuntime works correctly', () => {
+  expect(() => setRuntime(123, { session: 1 })).not.toThrow() // notice setRuntime accepts numbers
+  let cachedObj = getRuntime('123')
+  expect(Object.keys(cachedObj).length).toBeGreaterThan(1)
+  expect(cachedObj.session).toEqual(1)
+  expect(cachedObj.maxBytes).toEqual(30000) // this should mirror default in runtime.js
+})

package/src/common/constants/__mocks__/runtime.js

@@ -3,6 +3,6 @@ export const isWorkerScope = false
 export const globalScope = window
 export const initialLocation = '' + globalScope?.location
 export const isiOS = false
-export const iOS_below16 = false
+export const iOSBelow16 = false
 export const ffVersion = 0
 export const supportsSendBeacon = true

package/src/common/constants/runtime.js

@@ -55,7 +55,7 @@ export const isiOS = /iPad|iPhone|iPod/.test(navigator.userAgent)
  * did not work. This affects our onFCP metric in particular since web-vitals uses that flag to retrieve paint timing entries.
  * This was fixed in v16+.
  */
-export const iOS_below16 = (isiOS && typeof SharedWorker === 'undefined')
+export const iOSBelow16 = (isiOS && typeof SharedWorker === 'undefined')
 
 export const ffVersion = (() => {
   const match = navigator.userAgent.match(/Firefox[/\s](\d+\.\d+)/)

package/src/common/constants/runtime.test.js

@@ -122,7 +122,7 @@ test.each([
   { userAgent: 'Mozilla/5.0 (Macintosh; Intel Mac OS X 13_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.5 Safari/605.1.15', expected: false },
   { userAgent: 'Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/114.0', expected: false },
   { userAgent: 'Mozilla/5.0 (Macintosh; Intel Mac OS X 13.4; rv:109.0) Gecko/20100101 Firefox/114.0', expected: false }
-])('should set iOS_below16 to $expected for $userAgent', async ({ userAgent, expected }) => {
+])('should set iOSBelow16 to $expected for $userAgent', async ({ userAgent, expected }) => {
   if (!expected) {
     global.SharedWorker = class SharedWorker {}
   }
@@ -132,7 +132,7 @@ test.each([
 
   delete global.SharedWorker
 
-  expect(runtime.iOS_below16).toEqual(expected)
+  expect(runtime.iOSBelow16).toEqual(expected)
 })
 
 test.each([

package/src/common/constants/shared-channel.js

@@ -5,7 +5,7 @@
  */
 
 let onReplayReady
-const sessionReplayInitialized = new Promise(resolve => onReplayReady = resolve)
+const sessionReplayInitialized = new Promise(resolve => { onReplayReady = resolve })
 
 export const sharedChannel = Object.freeze({
   onReplayReady,

package/src/common/deny-list/deny-list.js

@@ -65,7 +65,7 @@ export function setDenyList (denyListConfig) {
       host = url
       pathname = ''
     }
-    let [hostname, port] = host.split(':')
+    let [hostname] = host.split(':')
 
     denyList.push({ hostname, pathname })
   }
@@ -81,11 +81,7 @@ function domainMatchesPattern (pattern, domain) {
     return false
   }
 
-  if (domain.indexOf(pattern) === (domain.length - pattern.length)) {
-    return true
-  }
-
-  return false
+  return domain.indexOf(pattern) === (domain.length - pattern.length)
 }
 
 /**
@@ -108,9 +104,5 @@ function comparePath (pattern, path) {
     return true
   }
 
-  if (pattern === path) {
-    return true
-  }
-
-  return false
+  return pattern === path
 }