@newly/cli 0.2.203 → 0.2.204

package/dist/commands/appStoreEvaluate.js

@@ -1,8 +1,14 @@
 import { existsSync, readFileSync, readdirSync, statSync, } from 'node:fs';
+import { createHash } from 'node:crypto';
 import path from 'node:path';
 const PREVIEW_APP_ID = 'app.newly.preview';
 const SCAFFOLD_SCHEME = 'expobase';
 const INBOUND_LINK = /Linking\.createURL|makeRedirectUri|emailRedirectTo|\bredirectTo\s*:|expobase:\/\//;
+const SCAFFOLD_APP_NAME = 'expo-base';
+export const SCAFFOLD_ICON_SHA256 = '7a667804bb80a6a424a5daf18a2599c4f32237cf06fe78fc0de45dbb09e0eccf';
+const SCAFFOLD_ICON_COMPOSER_MARK = path.join('Assets', 'expo-symbol 2.svg');
+const STARTER_SCREEN = /@newly\/welcome|Welcome to Newly|Made with Newly/;
+const PLACEHOLDER_ID = /com\.placeholder\./;
 const PLACEHOLDER_COPY = /lorem ipsum|example\.com|\bTBD\b|\bTODO\b|\bplaceholder\b/i;
 const INPUT_PLACEHOLDER = /\bplaceholder\??\s*[=:]\s*(\{[^}]*\}|"[^"]*"|'[^']*'|`[^`]*`|[\w.$]+)/gi;
 const PLACEHOLDER_NAME = /\.placeholder\b|\bplaceholder\b(?=\s*[,})\]])/gi;
@@ -86,6 +92,7 @@ const TEXT_EXTENSIONS = new Set([
     '.cc',
     '.cpp',
     '.cxx',
+    '.entitlements',
     '.h',
     '.hpp',
     '.java',
@@ -216,6 +223,8 @@ function evaluateLocalItem(root, appJson, item) {
             return makeItem(item, 'pass', 'Expo Router adds a layout where a directory has none.', 'expo-router getRoutesCore.js');
         case 'expo_duplicate_route':
             return evaluateDuplicateRoutes(root, item);
+        case 'starter_leftovers':
+            return evaluateStarterLeftovers(root, appJson, item);
         case 'ios_encryption':
             return evaluateEncryption(appJson, item);
         case 'plugin_permission_missing':
@@ -297,6 +306,67 @@ function evaluateExternalPayment(root, item) {
         return makeItem(item, 'pass', 'No external payment SDK patterns found.', 'scan: no Stripe/PayPal/Braintree patterns found');
     return makeItem(item, 'warning', 'External payment SDK found; verify it is not used for digital goods on iOS.', evidence(matches));
 }
+function isScaffoldIconPng(root, icon) {
+    try {
+        return createHash('sha256').update(readFileSync(path.join(root, icon))).digest('hex') === SCAFFOLD_ICON_SHA256;
+    }
+    catch {
+        return false;
+    }
+}
+function hasStarterIcon(root, appJson) {
+    const iosIcon = getPath(appJson, ['expo', 'ios', 'icon']);
+    if (iosIcon && typeof iosIcon === 'object') {
+        return Object.values(iosIcon).some((icon) => typeof icon === 'string' && isScaffoldIconPng(root, icon));
+    }
+    const iosPath = stringValue(iosIcon);
+    if (iosPath && !/\.png$/i.test(iosPath))
+        return existsSync(path.join(root, iosPath, SCAFFOLD_ICON_COMPOSER_MARK));
+    return isScaffoldIconPng(root, iosPath ?? stringValue(getPath(appJson, ['expo', 'icon'])) ?? './assets/images/icon.png');
+}
+function evaluateStarterLeftovers(root, appJson, item) {
+    const fromConfig = [];
+    const fromSource = [];
+    const proof = [];
+    if (stringValue(getPath(appJson, ['expo', 'name'])) === SCAFFOLD_APP_NAME) {
+        fromConfig.push(`the app is still named ${SCAFFOLD_APP_NAME}`);
+        proof.push(`app.json expo.name = "${SCAFFOLD_APP_NAME}"`);
+    }
+    const starterIcon = hasStarterIcon(root, appJson);
+    if (starterIcon)
+        proof.push('icon: the scaffold default');
+    const config = structuredClone(getPath(appJson, ['expo']) ?? {});
+    delete config.ios?.bundleIdentifier;
+    delete config.android?.package;
+    if (PLACEHOLDER_ID.test(JSON.stringify(config))) {
+        fromConfig.push('app.json still has a com.placeholder identifier');
+        proof.push('app.json: com.placeholder outside the store ids');
+    }
+    const screen = scan(root, STARTER_SCREEN, { dirs: ['app', 'src', 'components', 'ios'] });
+    if (screen.length) {
+        fromSource.push('the Newly welcome screen or branding is still in the app');
+        proof.push(evidence(screen));
+    }
+    const ids = scan(root, PLACEHOLDER_ID, { dirs: ['app', 'src', 'components', 'contexts', 'ios', 'plugins', 'targets'] });
+    if (ids.length) {
+        fromSource.push('a com.placeholder identifier is still in the code');
+        proof.push(evidence(ids));
+    }
+    const dynamicConfig = dynamicExpoConfig(root);
+    const blocking = dynamicConfig ? fromSource : [...fromConfig, ...fromSource];
+    const icon = starterIcon && !dynamicConfig ? ' The app icon is also still the starter icon.' : '';
+    const consequence = 'A reviewer reads the starter as an unfinished app (Guideline 2.1), and apps that look alike are rejected as spam (4.3), so replace it before you submit.';
+    if (blocking.length)
+        return makeItem(item, 'fail', `Left over from the Newly starter: ${blocking.join('; ')}.${icon} ${consequence}`, proof.join('\n'));
+    if (starterIcon && !dynamicConfig) {
+        return makeItem(item, 'warning', 'The app icon is still the starter icon, the same in every new Newly app. Give the app its own before you submit.', proof.join('\n'));
+    }
+    if (dynamicConfig && (fromConfig.length || starterIcon)) {
+        const found = [...fromConfig, ...(starterIcon ? ['the app icon is the starter icon'] : [])];
+        return makeItem(item, 'info', uncheckedUnder(dynamicConfig, `Left over from the Newly starter: ${found.join('; ')}.`), proof.join('\n'));
+    }
+    return makeItem(item, 'pass', 'Nothing left over from the Newly starter.', 'name, icon, welcome screen and placeholder ids checked');
+}
 function evaluateDuplicateRoutes(root, item) {
     const appDir = routerDir(root);
     if (!existsSync(appDir))

package/dist/version.js

@@ -1 +1 @@
-export const CLI_VERSION = '0.2.203';
+export const CLI_VERSION = '0.2.204';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@newly/cli",
-  "version": "0.2.203",
+  "version": "0.2.204",
   "description": "Develop, provision, and deploy Newly backends from your terminal",
   "homepage": "https://newly.app",
   "repository": {