@newheap/platform-ai-chat 0.16.0 → 0.17.0

package/fesm2022/newheap-platform-ai-chat-testing.mjs

@@ -25,6 +25,7 @@ const statusTable = {
         'assistant-run-filter-invalid',
         'assistant-board-scope-invalid',
         'assistant-feedback-invalid',
+        'assistant-trigger-filter-not-found',
         'assistant-replay-not-shadow',
         'assistant-evaluation-not-variant',
         'assistant-instructions-too-long',
@@ -2222,6 +2223,9 @@ const maxDescription$1 = 300;
 const maxInstructions = 20_000;
 const maxMessage$1 = 2_000;
 const maxReason$1 = 500;
+/** A data trigger applies at most this many filters of its event, each named in lowercase dash-case. */
+const maxTriggerFilters = 10;
+const filterName = /^[a-z0-9]+(?:-[a-z0-9]+)*$/;
 /** The platform's default file limits (`NhAssistantLimits`). */
 const defaultFileLimits = {
     maxFileBytes: 20 * 1024 * 1024,
@@ -2249,7 +2253,8 @@ class NhAssistantMockRunConfiguration {
         this.triggers = new Map();
         const approvalPolicies = scenario.runCatalog?.approvalPolicies ?? scenario.policies ?? [];
         this.catalog = {
-            triggerEvents: scenario.runCatalog?.triggerEvents ?? [],
+            // A trigger event lists its named filters, none unless the scenario's application registers some.
+            triggerEvents: (scenario.runCatalog?.triggerEvents ?? []).map(event => ({ ...event, filters: event.filters ?? [] })),
             subjectSets: scenario.runCatalog?.subjectSets ?? [],
             ruleHandlers: scenario.runCatalog?.ruleHandlers ?? [],
             approvalPolicies,
@@ -2375,8 +2380,13 @@ class NhAssistantMockRunConfiguration {
      */
     triggerProblem(agent, trigger) {
         if (trigger.source === 'event') {
-            const subjectType = this.catalog.triggerEvents.find(item => item.name === trigger.event)?.subjectType;
-            return subjectType && !mockWorksOnCovers(agent, subjectType) ? 'not-worked-on' : null;
+            const event = this.catalog.triggerEvents.find(item => item.name === trigger.event);
+            if (event?.subjectType && !mockWorksOnCovers(agent, event.subjectType)) {
+                return 'not-worked-on';
+            }
+            // A filter the event no longer offers keeps the trigger from firing.
+            const offered = (event?.filters ?? []).map(filter => filter.name);
+            return (trigger.filters ?? []).some(name => !offered.includes(name)) ? 'unknown-filter' : null;
         }
         return trigger.subjectSet === null && !mockWorksOnCovers(agent, mockSystemSubjectType) ? 'not-worked-on' : null;
     }
@@ -2706,9 +2716,20 @@ class NhAssistantMockRunConfiguration {
         if (skill !== null && !this.skillIds(agent).includes(skill)) {
             errors['skill'] = ['not-found'];
         }
+        // The filters in the order chosen, each once; only an event trigger takes them.
+        const filters = [...new Set((request.filters ?? []).map(name => (typeof name === 'string' ? name.trim() : '')))];
+        if (filters.length > maxTriggerFilters || filters.some(name => name.length > 64 || !filterName.test(name)) || (schedule && filters.length > 0)) {
+            errors['filters'] = ['invalid'];
+        }
         if (Object.keys(errors).length > 0) {
             return mockFailure('assistant-validation', errors);
         }
+        if (request.source === 'event') {
+            const offered = (this.catalog.triggerEvents.find(item => item.name === text(request.event))?.filters ?? []).map(filter => filter.name);
+            if (filters.some(name => !offered.includes(name))) {
+                return mockFailure('assistant-trigger-filter-not-found', { filters: ['not-found'] });
+            }
+        }
         if ((request.expectedVersion ?? null) !== (existing?.version ?? null)) {
             return mockFailure('assistant-version-conflict');
         }
@@ -2729,7 +2750,8 @@ class NhAssistantMockRunConfiguration {
             changedBy: 'current-user',
             reason: text(request.reason),
             inEffect: true,
-            problem: null
+            problem: null,
+            filters: schedule ? [] : filters
         };
         this.triggers.set(triggerId, Object.assign(saved, { [ownerKey]: agent.id }));
         return { status: 200, body: withoutOwner(saved) };
@@ -3653,7 +3675,7 @@ class NhAssistantMockAgentRuns {
             result: this.answerOf(found.run.id, language),
             resultTruncated: this.truncated.has(found.run.id),
             summary: found.run.summary,
-            proposals: [],
+            proposals: this.context.runProposals?.(found.run.id) ?? [],
             hiddenProposals: 0,
             artifacts: [],
             canOpenConversation: this.mayView(found.thread, language)
@@ -4388,7 +4410,7 @@ const maxGroupId = 64;
 const maxGroups = 100;
 const maxName = 100;
 const maxDescription = 300;
-const guid = /^[0-9a-f]{8}-?[0-9a-f]{4}-?[0-9a-f]{4}-?[0-9a-f]{4}-?[0-9a-f]{12}$/i;
+const guid$1 = /^[0-9a-f]{8}-?[0-9a-f]{4}-?[0-9a-f]{4}-?[0-9a-f]{4}-?[0-9a-f]{12}$/i;
 /**
  * Groups and boards of the mock API (K15, K16), as the server serves them: the scenario's
  * `agentGroups` are the groups in code with their names per language, checked as the server checks
@@ -4515,7 +4537,7 @@ class NhAssistantMockBoards {
         }
         const groupId = segments[1];
         const divisionId = query.get('divisionId');
-        if (divisionId !== null && divisionId !== '' && !guid.test(divisionId)) {
+        if (divisionId !== null && divisionId !== '' && !guid$1.test(divisionId)) {
             return mockFailure('assistant-board-scope-invalid');
         }
         const division = divisionId ? this.division(divisionId, requested) : null;
@@ -4656,6 +4678,7 @@ const dashCase = /^[a-z][a-z0-9]*(?:-[a-z0-9]+)*$/;
 const maxReason = 500;
 const maxItemsPerPage = 100;
 const maxBulkDecisions = 50;
+const guid = /^[0-9a-f]{8}-?[0-9a-f]{4}-?[0-9a-f]{4}-?[0-9a-f]{4}-?[0-9a-f]{12}$/i;
 const lifetimeMs = 3 * 24 * 60 * 60 * 1000;
 /** The platform's subject type of the whole application. */
 const systemType = 'nh-system';
@@ -4671,12 +4694,15 @@ const systemType = 'nh-system';
  * answers `404` and deciding it `404 assistant-approval-not-found`.
  */
 class NhAssistantMockProposals {
-    constructor(scenario = [], actorId, now, mayDecideApplication = () => true, decided = () => undefined) {
+    constructor(scenario = [], actorId, now, mayDecideApplication = () => true, decided = () => undefined, mayWorkIn = () => true) {
         this.actorId = actorId;
         this.now = now;
         this.mayDecideApplication = mayDecideApplication;
         this.decided = decided;
+        this.mayWorkIn = mayWorkIn;
         this.proposals = new Map();
+        /** When the caller last looked at the inbox, by scope key. */
+        this.visits = new Map();
         const created = new Date(now()).getTime();
         for (const item of scenario) {
             if (this.proposals.has(item.approvalId)) {
@@ -4707,8 +4733,8 @@ class NhAssistantMockProposals {
                     mode: 'deferred',
                     policyId: null,
                     grantSource: 'agent',
-                    createdAt: new Date(created).toISOString(),
-                    expiresAt: new Date(created + lifetimeMs).toISOString(),
+                    createdAt: item.createdAt ?? new Date(created).toISOString(),
+                    expiresAt: item.expiresAt ?? new Date(Date.parse(item.createdAt ?? new Date(created).toISOString()) + lifetimeMs).toISOString(),
                     initiatorActorId: null,
                     decidedByActorId: null,
                     decidedAt: null,
@@ -4716,8 +4742,10 @@ class NhAssistantMockProposals {
                     executedAt: null,
                     rationale: item.rationale ?? null,
                     placedBy: item.placedBy ?? null,
+                    parent: item.parent ?? null,
                     canGiveFeedback: false
                 },
+                divisionId: item.divisionId ?? null,
                 canDecide: item.canDecide ?? true,
                 reasonCode: item.canDecide === false ? item.reasonCode ?? 'assistant-approval-policy-denied' : null
             });
@@ -4728,6 +4756,9 @@ class NhAssistantMockProposals {
         if (segments.length === 2 && segments[1] === 'inbox') {
             return method === 'GET' ? this.inbox(query) : { status: 405 };
         }
+        if (segments.length === 3 && segments[1] === 'inbox' && segments[2] === 'visit') {
+            return method === 'POST' ? this.visit(query) : { status: 405 };
+        }
         if (segments.length === 2 && segments[1] === 'lookup') {
             return method === 'POST' ? this.lookup(body) : { status: 405 };
         }
@@ -4750,6 +4781,12 @@ class NhAssistantMockProposals {
             .reverse();
         return items.length === 0 ? null : items;
     }
+    /** The proposals of a run the caller may see, in the order the scenario lists them. */
+    ofRun(runId) {
+        return this.visible()
+            .filter(item => item.proposal.runId === runId)
+            .map(item => item.proposal);
+    }
     /** The pending proposals on a subject with the caller's right to decide each, earliest expiry first. */
     openOfSubject(subjectType, subjectId) {
         return this.visible()
@@ -4779,19 +4816,49 @@ class NhAssistantMockProposals {
         }
         const agentId = query.get('agentId');
         const runId = query.get('runId');
+        const divisionId = query.get('divisionId');
+        if (divisionId !== null && !guid.test(divisionId)) {
+            return { status: 400 };
+        }
+        const grouped = query.get('grouped') === 'true';
         const items = this.visible()
             .filter(item => item.proposal.status === 'pending' && item.canDecide)
+            .filter(item => divisionId === null || sameGuid(item.divisionId, divisionId))
             .map(item => item.proposal)
             .filter(proposal => (subjectType === null || proposal.subjectType === subjectType)
             && (agentId === null || proposal.agentId === agentId)
             && (runId === null || proposal.runId === runId))
             .sort((left, right) => left.expiresAt.localeCompare(right.expiresAt) || left.approvalId.localeCompare(right.approvalId));
+        const ordered = grouped ? groupedOrder(items) : items;
+        const offset = (page - 1) * itemsPerPage;
+        const pageItems = ordered.slice(offset, offset + itemsPerPage);
+        const scopeKey = scopeKeyOf(divisionId);
+        const lastVisitedAt = this.visits.get(scopeKey) ?? null;
         const body = {
-            items: items.slice((page - 1) * itemsPerPage, page * itemsPerPage),
-            total: items.length
+            items: pageItems,
+            total: items.length,
+            scopeKey,
+            lastVisitedAt,
+            newApprovalIds: pageItems
+                .filter(proposal => lastVisitedAt === null || Date.parse(proposal.createdAt) > Date.parse(lastVisitedAt))
+                .map(proposal => proposal.approvalId),
+            groups: grouped ? groupsOf(ordered, offset, pageItems.length) : null
         };
         return { status: 200, body };
     }
+    /** `POST approvals/inbox/visit`: the whole inbox, or that of a division the caller works in. */
+    visit(query) {
+        const divisionId = query.get('divisionId');
+        if (divisionId !== null && !guid.test(divisionId)) {
+            return { status: 400 };
+        }
+        if (divisionId !== null && !this.mayWorkIn(divisionId)) {
+            return mockFailure('assistant-subject-not-found');
+        }
+        const body = { scopeKey: scopeKeyOf(divisionId), visitedAt: this.now() };
+        this.visits.set(body.scopeKey, body.visitedAt);
+        return { status: 200, body };
+    }
     read(approvalId) {
         const stored = this.find(approvalId);
         return stored ? { status: 200, body: this.withRight(stored) } : mockFailure('assistant-approval-not-found');
@@ -4879,6 +4946,99 @@ class NhAssistantMockProposals {
         };
     }
 }
+/** The scope of the inbox's visits: `global`, or the scope key of a division. */
+function scopeKeyOf(divisionId) {
+    return divisionId === null ? 'global' : `division:${divisionId.replaceAll('-', '').toLowerCase()}`;
+}
+function sameGuid(left, right) {
+    return left !== null && left.replaceAll('-', '').toLowerCase() === right.replaceAll('-', '').toLowerCase();
+}
+/** The group a proposal belongs to: its parent, or its own subject without one. */
+function groupKeyOf(proposal) {
+    return proposal.parent
+        ? `${proposal.parent.subjectType}|${proposal.parent.subjectId}`
+        : `${proposal.subjectType}|${proposal.subjectId}`;
+}
+function subjectKeyOf(proposal) {
+    return `${groupKeyOf(proposal)}|${proposal.subjectType}|${proposal.subjectId}`;
+}
+function firstExpiries(items, key) {
+    const first = new Map();
+    for (const proposal of items) {
+        const current = first.get(key(proposal));
+        if (current === undefined || proposal.expiresAt < current) {
+            first.set(key(proposal), proposal.expiresAt);
+        }
+    }
+    return first;
+}
+/**
+ * The order of the grouped inbox, as the server sorts: groups by their first expiry, a group's own
+ * subject first, then its other subjects by their first expiry, one run's proposals together, then by
+ * expiry.
+ */
+function groupedOrder(items) {
+    const groups = firstExpiries(items, groupKeyOf);
+    const subjects = firstExpiries(items, subjectKeyOf);
+    const compare = (left, right) => (left < right ? -1 : left > right ? 1 : 0);
+    return [...items].sort((left, right) => compare(groups.get(groupKeyOf(left)), groups.get(groupKeyOf(right)))
+        || compare(groupKeyOf(left), groupKeyOf(right))
+        || (left.parent ? 1 : 0) - (right.parent ? 1 : 0)
+        || compare(subjects.get(subjectKeyOf(left)), subjects.get(subjectKeyOf(right)))
+        || compare(subjectKeyOf(left), subjectKeyOf(right))
+        || (left.runId === null ? 1 : 0) - (right.runId === null ? 1 : 0)
+        || compare(left.runId ?? '', right.runId ?? '')
+        || compare(left.expiresAt, right.expiresAt)
+        || compare(left.approvalId, right.approvalId));
+}
+/** The groups of the page `ordered[offset, offset + count)`, with their totals and continuation. */
+function groupsOf(ordered, offset, count) {
+    const page = ordered.slice(offset, offset + count);
+    const previous = offset > 0 ? ordered[offset - 1] : undefined;
+    const next = ordered[offset + count];
+    const groups = [];
+    for (let index = 0; index < page.length;) {
+        const key = groupKeyOf(page[index]);
+        let end = index;
+        while (end < page.length && groupKeyOf(page[end]) === key) {
+            end++;
+        }
+        const members = page.slice(index, end);
+        const own = members.find(proposal => !proposal.parent);
+        const parent = members.find(proposal => proposal.parent)?.parent ?? null;
+        const subjects = [];
+        for (let at = 0; at < members.length;) {
+            const subjectKey = subjectKeyOf(members[at]);
+            let stop = at;
+            while (stop < members.length && subjectKeyOf(members[stop]) === subjectKey) {
+                stop++;
+            }
+            subjects.push({
+                subjectType: members[at].subjectType,
+                subjectId: members[at].subjectId,
+                count: stop - at,
+                total: ordered.filter(proposal => subjectKeyOf(proposal) === subjectKey).length,
+                continuesFromPreviousPage: index === 0 && at === 0 && previous !== undefined && subjectKeyOf(previous) === subjectKey,
+                continuesOnNextPage: end === page.length && stop === members.length && next !== undefined && subjectKeyOf(next) === subjectKey
+            });
+            at = stop;
+        }
+        groups.push({
+            subjectType: own?.subjectType ?? parent.subjectType,
+            subjectId: own?.subjectId ?? parent.subjectId,
+            displayName: own ? own.subjectDisplayName : parent.displayName,
+            subjectTypeName: own ? own.subjectTypeName ?? null : parent.subjectTypeName ?? null,
+            subjectLink: own ? own.subjectLink ?? null : parent.subjectLink ?? null,
+            count: members.length,
+            total: ordered.filter(proposal => groupKeyOf(proposal) === key).length,
+            continuesFromPreviousPage: index === 0 && previous !== undefined && groupKeyOf(previous) === key,
+            continuesOnNextPage: end === page.length && next !== undefined && groupKeyOf(next) === key,
+            subjects
+        });
+        index = end;
+    }
+    return groups;
+}
 function validDecision(request) {
     return !!request
         && (request.decision === 'approve' || request.decision === 'reject')
@@ -4946,12 +5106,13 @@ class NhAssistantMockBackend {
             runId: proposal.runId,
             subjectType: proposal.subjectType,
             subjectId: proposal.subjectId
-        }, proposal.agentId));
+        }, proposal.agentId), (divisionId) => this.subjects.describe(mockSystemSubjectType, divisionSubjectId({ id: divisionId, name: '' }), null, this.admin.administers) != null);
         this.subjects = new NhAssistantMockSubjects(this.scenario.subjectTypes, this.scenario.divisions, (type, id) => this.proposals.openOfSubject(type, id));
         this.agentRuns = new NhAssistantMockAgentRuns(this.scenario, this.subjects, {
             agents: () => this.admin.allAgents(),
             administers: () => this.admin.administers,
             threadProposals: conversationId => this.proposals.ofThread(conversationId),
+            runProposals: runId => this.proposals.ofRun(runId),
             workChanged: (change, agentId) => this.publishAgentWork(change, agentId)
         }, () => new Date().toISOString());
         this.boards = new NhAssistantMockBoards(this.scenario, this.subjects, this.agentRuns, {