@neverinfamous/mysql-mcp 2.1.0 → 2.2.0

package/src/adapters/mysql/tools/__tests__/replication.test.ts

@@ -1,478 +1,782 @@
 /**
  * mysql-mcp - Replication Tools Unit Tests
- * 
+ *
  * Tests for replication and partitioning tool definitions and handler execution.
  */
 
-import { describe, it, expect, vi, beforeEach } from 'vitest';
-import { getReplicationTools } from '../replication.js';
-import { getPartitioningTools } from '../partitioning.js';
-import type { MySQLAdapter } from '../../MySQLAdapter.js';
-import { createMockMySQLAdapter, createMockRequestContext, createMockQueryResult } from '../../../../__tests__/mocks/index.js';
+import { describe, it, expect, vi, beforeEach } from "vitest";
+import { getReplicationTools } from "../replication.js";
+import { getPartitioningTools } from "../partitioning.js";
+import type { MySQLAdapter } from "../../MySQLAdapter.js";
+import {
+  createMockMySQLAdapter,
+  createMockRequestContext,
+  createMockQueryResult,
+} from "../../../../__tests__/mocks/index.js";
+
+describe("getReplicationTools", () => {
+  let tools: ReturnType<typeof getReplicationTools>;
+
+  beforeEach(() => {
+    vi.clearAllMocks();
+    tools = getReplicationTools(
+      createMockMySQLAdapter() as unknown as MySQLAdapter,
+    );
+  });
+
+  it("should return 5 replication tools", () => {
+    expect(tools).toHaveLength(5);
+  });
+
+  it("should have replication group for all tools", () => {
+    for (const tool of tools) {
+      expect(tool.group).toBe("replication");
+    }
+  });
+
+  it("should have handler functions for all tools", () => {
+    for (const tool of tools) {
+      expect(typeof tool.handler).toBe("function");
+    }
+  });
+
+  it("should have inputSchema for all tools", () => {
+    for (const tool of tools) {
+      expect(tool.inputSchema).toBeDefined();
+    }
+  });
+
+  it("should include expected tool names", () => {
+    const names = tools.map((t) => t.name);
+    expect(names).toContain("mysql_master_status");
+    expect(names).toContain("mysql_slave_status");
+    expect(names).toContain("mysql_binlog_events");
+    expect(names).toContain("mysql_gtid_status");
+    expect(names).toContain("mysql_replication_lag");
+  });
+});
 
-describe('getReplicationTools', () => {
-    let tools: ReturnType<typeof getReplicationTools>;
+describe("getPartitioningTools", () => {
+  let tools: ReturnType<typeof getPartitioningTools>;
+
+  beforeEach(() => {
+    vi.clearAllMocks();
+    tools = getPartitioningTools(
+      createMockMySQLAdapter() as unknown as MySQLAdapter,
+    );
+  });
+
+  it("should return 4 partitioning tools", () => {
+    expect(tools).toHaveLength(4);
+  });
+
+  it("should have partitioning group for all tools", () => {
+    for (const tool of tools) {
+      expect(tool.group).toBe("partitioning");
+    }
+  });
+
+  it("should have handler functions for all tools", () => {
+    for (const tool of tools) {
+      expect(typeof tool.handler).toBe("function");
+    }
+  });
+
+  it("should have inputSchema for all tools", () => {
+    for (const tool of tools) {
+      expect(tool.inputSchema).toBeDefined();
+    }
+  });
+
+  it("should include expected tool names", () => {
+    const names = tools.map((t) => t.name);
+    expect(names).toContain("mysql_partition_info");
+    expect(names).toContain("mysql_add_partition");
+    expect(names).toContain("mysql_drop_partition");
+    expect(names).toContain("mysql_reorganize_partition");
+  });
+});
 
-    beforeEach(() => {
-        vi.clearAllMocks();
-        tools = getReplicationTools(createMockMySQLAdapter() as unknown as MySQLAdapter);
+describe("Replication Handler Execution", () => {
+  let mockAdapter: ReturnType<typeof createMockMySQLAdapter>;
+  let tools: ReturnType<typeof getReplicationTools>;
+  let mockContext: ReturnType<typeof createMockRequestContext>;
+
+  beforeEach(() => {
+    vi.clearAllMocks();
+    mockAdapter = createMockMySQLAdapter();
+    tools = getReplicationTools(mockAdapter as unknown as MySQLAdapter);
+    mockContext = createMockRequestContext();
+  });
+
+  describe("mysql_master_status", () => {
+    it("should query master status", async () => {
+      mockAdapter.executeQuery.mockResolvedValue(
+        createMockQueryResult([{ File: "mysql-bin.000001", Position: 12345 }]),
+      );
+
+      const tool = tools.find((t) => t.name === "mysql_master_status")!;
+      const result = await tool.handler({}, mockContext);
+
+      expect(mockAdapter.executeQuery).toHaveBeenCalled();
+      expect(result).toBeDefined();
     });
+  });
 
-    it('should return 5 replication tools', () => {
-        expect(tools).toHaveLength(5);
-    });
+  describe("mysql_slave_status", () => {
+    it("should query replica status", async () => {
+      mockAdapter.executeQuery.mockResolvedValue(
+        createMockQueryResult([
+          { Replica_IO_Running: "Yes", Replica_SQL_Running: "Yes" },
+        ]),
+      );
 
-    it('should have replication group for all tools', () => {
-        for (const tool of tools) {
-            expect(tool.group).toBe('replication');
-        }
-    });
+      const tool = tools.find((t) => t.name === "mysql_slave_status")!;
+      const result = await tool.handler({}, mockContext);
 
-    it('should have handler functions for all tools', () => {
-        for (const tool of tools) {
-            expect(typeof tool.handler).toBe('function');
-        }
+      expect(mockAdapter.executeQuery).toHaveBeenCalled();
+      expect(result).toBeDefined();
     });
-
-    it('should have inputSchema for all tools', () => {
-        for (const tool of tools) {
-            expect(tool.inputSchema).toBeDefined();
-        }
+  });
+
+  describe("mysql_binlog_events", () => {
+    it("should query binlog events with explicit logFile", async () => {
+      mockAdapter.executeQuery.mockResolvedValue(
+        createMockQueryResult([
+          { Log_name: "mysql-bin.000001", Event_type: "Query" },
+        ]),
+      );
+
+      const tool = tools.find((t) => t.name === "mysql_binlog_events")!;
+      await tool.handler({ logFile: "mysql-bin.000001" }, mockContext);
+
+      // With explicit logFile, no master status query needed
+      const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
+      expect(call).toContain("BINLOG EVENTS");
+      expect(call).toContain("IN 'mysql-bin.000001'");
     });
 
-    it('should include expected tool names', () => {
-        const names = tools.map(t => t.name);
-        expect(names).toContain('mysql_master_status');
-        expect(names).toContain('mysql_slave_status');
-        expect(names).toContain('mysql_binlog_events');
-        expect(names).toContain('mysql_gtid_status');
-        expect(names).toContain('mysql_replication_lag');
-    });
-});
+    it("should limit events", async () => {
+      mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
 
-describe('getPartitioningTools', () => {
-    let tools: ReturnType<typeof getPartitioningTools>;
+      const tool = tools.find((t) => t.name === "mysql_binlog_events")!;
+      await tool.handler(
+        { logFile: "mysql-bin.000001", limit: 10 },
+        mockContext,
+      );
 
-    beforeEach(() => {
-        vi.clearAllMocks();
-        tools = getPartitioningTools(createMockMySQLAdapter() as unknown as MySQLAdapter);
+      const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
+      expect(call).toContain("LIMIT 10");
     });
 
-    it('should return 4 partitioning tools', () => {
-        expect(tools).toHaveLength(4);
+    it("should auto-resolve current binlog file when logFile is omitted", async () => {
+      // First call: SHOW BINARY LOG STATUS, second call: SHOW BINLOG EVENTS
+      mockAdapter.executeQuery
+        .mockResolvedValueOnce(
+          createMockQueryResult([{ File: "mysql-bin.000010", Position: 154 }]),
+        )
+        .mockResolvedValueOnce(
+          createMockQueryResult([
+            { Log_name: "mysql-bin.000010", Event_type: "Query" },
+          ]),
+        );
+
+      const tool = tools.find((t) => t.name === "mysql_binlog_events")!;
+      await tool.handler({}, mockContext);
+
+      expect(mockAdapter.executeQuery).toHaveBeenCalledTimes(2);
+      const binlogCall = mockAdapter.executeQuery.mock.calls[1][0] as string;
+      expect(binlogCall).toContain("IN 'mysql-bin.000010'");
     });
+  });
 
-    it('should have partitioning group for all tools', () => {
-        for (const tool of tools) {
-            expect(tool.group).toBe('partitioning');
-        }
-    });
+  describe("mysql_gtid_status", () => {
+    it("should query GTID status", async () => {
+      mockAdapter.executeQuery.mockResolvedValue(
+        createMockQueryResult([
+          { Variable_name: "gtid_executed", Value: "uuid:1-100" },
+        ]),
+      );
 
-    it('should have handler functions for all tools', () => {
-        for (const tool of tools) {
-            expect(typeof tool.handler).toBe('function');
-        }
-    });
+      const tool = tools.find((t) => t.name === "mysql_gtid_status")!;
+      const result = await tool.handler({}, mockContext);
 
-    it('should have inputSchema for all tools', () => {
-        for (const tool of tools) {
-            expect(tool.inputSchema).toBeDefined();
-        }
+      expect(mockAdapter.executeQuery).toHaveBeenCalled();
+      expect(result).toBeDefined();
     });
+  });
 
-    it('should include expected tool names', () => {
-        const names = tools.map(t => t.name);
-        expect(names).toContain('mysql_partition_info');
-        expect(names).toContain('mysql_add_partition');
-        expect(names).toContain('mysql_drop_partition');
-        expect(names).toContain('mysql_reorganize_partition');
-    });
-});
+  describe("mysql_replication_lag", () => {
+    it("should calculate replication lag", async () => {
+      mockAdapter.executeQuery.mockResolvedValue(
+        createMockQueryResult([{ Seconds_Behind_Master: 5 }]),
+      );
 
-describe('Replication Handler Execution', () => {
-    let mockAdapter: ReturnType<typeof createMockMySQLAdapter>;
-    let tools: ReturnType<typeof getReplicationTools>;
-    let mockContext: ReturnType<typeof createMockRequestContext>;
+      const tool = tools.find((t) => t.name === "mysql_replication_lag")!;
+      const result = await tool.handler({}, mockContext);
 
-    beforeEach(() => {
-        vi.clearAllMocks();
-        mockAdapter = createMockMySQLAdapter();
-        tools = getReplicationTools(mockAdapter as unknown as MySQLAdapter);
-        mockContext = createMockRequestContext();
+      expect(mockAdapter.executeQuery).toHaveBeenCalled();
+      expect(result).toBeDefined();
     });
+  });
+});
 
-    describe('mysql_master_status', () => {
-        it('should query master status', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(
-                createMockQueryResult([{ File: 'mysql-bin.000001', Position: 12345 }])
-            );
-
-            const tool = tools.find(t => t.name === 'mysql_master_status')!;
-            const result = await tool.handler({}, mockContext);
-
-            expect(mockAdapter.executeQuery).toHaveBeenCalled();
-            expect(result).toBeDefined();
-        });
+describe("Partitioning Handler Execution", () => {
+  let mockAdapter: ReturnType<typeof createMockMySQLAdapter>;
+  let tools: ReturnType<typeof getPartitioningTools>;
+  let mockContext: ReturnType<typeof createMockRequestContext>;
+
+  beforeEach(() => {
+    vi.clearAllMocks();
+    mockAdapter = createMockMySQLAdapter();
+    tools = getPartitioningTools(mockAdapter as unknown as MySQLAdapter);
+    mockContext = createMockRequestContext();
+  });
+
+  describe("mysql_partition_info", () => {
+    it("should query partition info", async () => {
+      // First call: existence check, second call: partition query
+      mockAdapter.executeQuery
+        .mockResolvedValueOnce(createMockQueryResult([{ TABLE_NAME: "logs" }]))
+        .mockResolvedValueOnce(
+          createMockQueryResult([
+            {
+              PARTITION_NAME: "p0",
+              TABLE_ROWS: 1000,
+              PARTITION_METHOD: "RANGE",
+            },
+          ]),
+        );
+
+      const tool = tools.find((t) => t.name === "mysql_partition_info")!;
+      await tool.handler({ table: "logs" }, mockContext);
+
+      expect(mockAdapter.executeQuery).toHaveBeenCalledTimes(2);
+      const call = mockAdapter.executeQuery.mock.calls[1][0] as string;
+      expect(call).toContain("PARTITIONS");
     });
 
-    describe('mysql_slave_status', () => {
-        it('should query replica status', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([
-                { Replica_IO_Running: 'Yes', Replica_SQL_Running: 'Yes' }
-            ]));
+    it("should detect non-partitioned table", async () => {
+      mockAdapter.executeQuery
+        .mockResolvedValueOnce(createMockQueryResult([{ TABLE_NAME: "users" }]))
+        .mockResolvedValueOnce(
+          createMockQueryResult([{ PARTITION_NAME: null, TABLE_ROWS: 1000 }]),
+        );
 
-            const tool = tools.find(t => t.name === 'mysql_slave_status')!;
-            const result = await tool.handler({}, mockContext);
+      const tool = tools.find((t) => t.name === "mysql_partition_info")!;
+      const result = (await tool.handler({ table: "users" }, mockContext)) as {
+        partitioned: boolean;
+      };
 
-            expect(mockAdapter.executeQuery).toHaveBeenCalled();
-            expect(result).toBeDefined();
-        });
+      expect(result.partitioned).toBe(false);
     });
 
-    describe('mysql_binlog_events', () => {
-        it('should query binlog events', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([
-                { Log_name: 'mysql-bin.000001', Event_type: 'Query' }
-            ]));
+    it("should detect partitioned table with method and expression", async () => {
+      mockAdapter.executeQuery
+        .mockResolvedValueOnce(createMockQueryResult([{ TABLE_NAME: "logs" }]))
+        .mockResolvedValueOnce(
+          createMockQueryResult([
+            {
+              PARTITION_NAME: "p0",
+              PARTITION_METHOD: "RANGE",
+              PARTITION_EXPRESSION: "TO_DAYS(created_at)",
+            },
+          ]),
+        );
+
+      const tool = tools.find((t) => t.name === "mysql_partition_info")!;
+      const result = (await tool.handler({ table: "logs" }, mockContext)) as {
+        partitioned: boolean;
+        method: string;
+      };
+
+      expect(result.partitioned).toBe(true);
+      expect(result.method).toBe("RANGE");
+    });
+  });
+
+  describe("mysql_add_partition", () => {
+    it("should add a RANGE partition", async () => {
+      mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
+
+      const tool = tools.find((t) => t.name === "mysql_add_partition")!;
+      const result = await tool.handler(
+        {
+          table: "logs",
+          partitionName: "p2024",
+          partitionType: "RANGE",
+          value: "2024",
+        },
+        mockContext,
+      );
+
+      expect(mockAdapter.executeQuery).toHaveBeenCalled();
+      const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
+      expect(call).toContain("ADD PARTITION");
+      expect(call).toContain("VALUES LESS THAN");
+      expect(result).toHaveProperty("success", true);
+    });
 
-            const tool = tools.find(t => t.name === 'mysql_binlog_events')!;
-            await tool.handler({ logName: 'mysql-bin.000001' }, mockContext);
+    it("should add a LIST partition", async () => {
+      mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
+
+      const tool = tools.find((t) => t.name === "mysql_add_partition")!;
+      await tool.handler(
+        {
+          table: "regions",
+          partitionName: "p_east",
+          partitionType: "LIST",
+          value: "'NY', 'NJ', 'PA'",
+        },
+        mockContext,
+      );
+
+      const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
+      expect(call).toContain("VALUES IN");
+    });
 
-            expect(mockAdapter.executeQuery).toHaveBeenCalled();
-            const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
-            expect(call).toContain('BINLOG EVENTS');
-        });
+    it("should add HASH partitions", async () => {
+      mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
+
+      const tool = tools.find((t) => t.name === "mysql_add_partition")!;
+      await tool.handler(
+        {
+          table: "data",
+          partitionName: "hash_p",
+          partitionType: "HASH",
+          value: "4",
+        },
+        mockContext,
+      );
+
+      const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
+      expect(call).toContain("PARTITIONS 4");
+    });
 
-        it('should limit events', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
+    it("should add KEY partitions", async () => {
+      mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
+
+      const tool = tools.find((t) => t.name === "mysql_add_partition")!;
+      await tool.handler(
+        {
+          table: "data",
+          partitionName: "key_p",
+          partitionType: "KEY",
+          value: "8",
+        },
+        mockContext,
+      );
+
+      const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
+      expect(call).toContain("PARTITIONS 8");
+    });
+  });
+
+  describe("mysql_drop_partition", () => {
+    it("should drop a partition", async () => {
+      mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
+
+      const tool = tools.find((t) => t.name === "mysql_drop_partition")!;
+      const result = await tool.handler(
+        {
+          table: "logs",
+          partitionName: "p2020",
+        },
+        mockContext,
+      );
+
+      expect(mockAdapter.executeQuery).toHaveBeenCalled();
+      const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
+      expect(call).toContain("DROP PARTITION");
+      expect(result).toHaveProperty("success", true);
+    });
+  });
+
+  describe("mysql_reorganize_partition", () => {
+    it("should reorganize partitions", async () => {
+      mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
+
+      const tool = tools.find((t) => t.name === "mysql_reorganize_partition")!;
+      const result = await tool.handler(
+        {
+          table: "logs",
+          fromPartitions: ["p2023"],
+          partitionType: "RANGE",
+          toPartitions: [
+            { name: "p2023_h1", value: "202307" },
+            { name: "p2023_h2", value: "202401" },
+          ],
+        },
+        mockContext,
+      );
+
+      expect(mockAdapter.executeQuery).toHaveBeenCalled();
+      const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
+      expect(call).toContain("REORGANIZE PARTITION");
+      expect(result).toHaveProperty("success", true);
+    });
 
-            const tool = tools.find(t => t.name === 'mysql_binlog_events')!;
-            await tool.handler({ logName: 'mysql-bin.000001', limit: 10 }, mockContext);
+    it("should return structured error for non-partitioned table", async () => {
+      mockAdapter.executeQuery.mockRejectedValue(
+        new Error(
+          "Partition management on a not partitioned table is not possible",
+        ),
+      );
+
+      const tool = tools.find((t) => t.name === "mysql_reorganize_partition")!;
+      const result = (await tool.handler(
+        {
+          table: "users",
+          fromPartitions: ["p1"],
+          partitionType: "RANGE",
+          toPartitions: [{ name: "p1a", value: "50" }],
+        },
+        mockContext,
+      )) as { success: boolean; error: string };
+
+      expect(result.success).toBe(false);
+      expect(result.error).toContain("not partitioned");
+    });
 
-            const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
-            expect(call).toContain('LIMIT 10');
-        });
+    it("should return structured error for nonexistent partition", async () => {
+      mockAdapter.executeQuery.mockRejectedValue(
+        new Error("Error in list of partitions to REORGANIZE"),
+      );
+
+      const tool = tools.find((t) => t.name === "mysql_reorganize_partition")!;
+      const result = (await tool.handler(
+        {
+          table: "logs",
+          fromPartitions: ["nonexistent"],
+          partitionType: "RANGE",
+          toPartitions: [{ name: "p_new", value: "2030" }],
+        },
+        mockContext,
+      )) as { success: boolean; fromPartitions: string[]; error: string };
+
+      expect(result.success).toBe(false);
+      expect(result.fromPartitions).toEqual(["nonexistent"]);
+      expect(result.error).toContain("do not exist");
     });
+  });
 
-    describe('mysql_gtid_status', () => {
-        it('should query GTID status', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([
-                { Variable_name: 'gtid_executed', Value: 'uuid:1-100' }
-            ]));
+  describe("mysql_partition_info existence check", () => {
+    it("should return exists: false for nonexistent table", async () => {
+      mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
 
-            const tool = tools.find(t => t.name === 'mysql_gtid_status')!;
-            const result = await tool.handler({}, mockContext);
+      const tool = tools.find((t) => t.name === "mysql_partition_info")!;
+      const result = (await tool.handler(
+        { table: "nonexistent" },
+        mockContext,
+      )) as { exists: boolean; table: string };
 
-            expect(mockAdapter.executeQuery).toHaveBeenCalled();
-            expect(result).toBeDefined();
-        });
+      expect(result.exists).toBe(false);
+      expect(result.table).toBe("nonexistent");
+    });
+  });
+
+  describe("mysql_add_partition error handling", () => {
+    it("should return structured error for non-partitioned table", async () => {
+      mockAdapter.executeQuery.mockRejectedValue(
+        new Error(
+          "Partition management on a not partitioned table is not possible",
+        ),
+      );
+
+      const tool = tools.find((t) => t.name === "mysql_add_partition")!;
+      const result = (await tool.handler(
+        {
+          table: "users",
+          partitionName: "p1",
+          partitionType: "RANGE",
+          value: "100",
+        },
+        mockContext,
+      )) as { success: boolean; error: string };
+
+      expect(result.success).toBe(false);
+      expect(result.error).toContain("not partitioned");
     });
 
-    describe('mysql_replication_lag', () => {
-        it('should calculate replication lag', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([
-                { Seconds_Behind_Master: 5 }
-            ]));
-
-            const tool = tools.find(t => t.name === 'mysql_replication_lag')!;
-            const result = await tool.handler({}, mockContext);
+    it("should return structured error for MAXVALUE conflict", async () => {
+      mockAdapter.executeQuery.mockRejectedValue(
+        new Error("MAXVALUE can only be used in last partition definition"),
+      );
+
+      const tool = tools.find((t) => t.name === "mysql_add_partition")!;
+      const result = (await tool.handler(
+        {
+          table: "logs",
+          partitionName: "p2025",
+          partitionType: "RANGE",
+          value: "2026",
+        },
+        mockContext,
+      )) as { success: boolean; error: string };
+
+      expect(result.success).toBe(false);
+      expect(result.error).toContain("MAXVALUE");
+      expect(result.error).toContain("mysql_reorganize_partition");
+    });
 
-            expect(mockAdapter.executeQuery).toHaveBeenCalled();
-            expect(result).toBeDefined();
-        });
+    it("should return structured error for duplicate partition values", async () => {
+      mockAdapter.executeQuery.mockRejectedValue(
+        new Error("Multiple definition of same constant in list partitioning"),
+      );
+
+      const tool = tools.find((t) => t.name === "mysql_add_partition")!;
+      const result = (await tool.handler(
+        {
+          table: "regions",
+          partitionName: "p_dup",
+          partitionType: "LIST",
+          value: "'east'",
+        },
+        mockContext,
+      )) as { success: boolean; error: string };
+
+      expect(result.success).toBe(false);
+      expect(result.error).toContain("already exist");
+    });
+  });
+
+  describe("mysql_drop_partition error handling", () => {
+    it("should return structured error for non-partitioned table", async () => {
+      mockAdapter.executeQuery.mockRejectedValue(
+        new Error(
+          "Partition management on a not partitioned table is not possible",
+        ),
+      );
+
+      const tool = tools.find((t) => t.name === "mysql_drop_partition")!;
+      const result = (await tool.handler(
+        { table: "users", partitionName: "p1" },
+        mockContext,
+      )) as { success: boolean; error: string };
+
+      expect(result.success).toBe(false);
+      expect(result.error).toContain("not partitioned");
     });
-});
 
-describe('Partitioning Handler Execution', () => {
-    let mockAdapter: ReturnType<typeof createMockMySQLAdapter>;
-    let tools: ReturnType<typeof getPartitioningTools>;
-    let mockContext: ReturnType<typeof createMockRequestContext>;
-
-    beforeEach(() => {
-        vi.clearAllMocks();
-        mockAdapter = createMockMySQLAdapter();
-        tools = getPartitioningTools(mockAdapter as unknown as MySQLAdapter);
-        mockContext = createMockRequestContext();
-    });
-
-    describe('mysql_partition_info', () => {
-        it('should query partition info', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([
-                { PARTITION_NAME: 'p0', TABLE_ROWS: 1000, PARTITION_METHOD: 'RANGE' }
-            ]));
-
-            const tool = tools.find(t => t.name === 'mysql_partition_info')!;
-            await tool.handler({ table: 'logs' }, mockContext);
-
-            expect(mockAdapter.executeQuery).toHaveBeenCalled();
-            const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
-            expect(call).toContain('PARTITIONS');
-        });
-
-        it('should detect non-partitioned table', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([
-                { PARTITION_NAME: null, TABLE_ROWS: 1000 }
-            ]));
-
-            const tool = tools.find(t => t.name === 'mysql_partition_info')!;
-            const result = await tool.handler({ table: 'users' }, mockContext) as { partitioned: boolean };
-
-            expect(result.partitioned).toBe(false);
-        });
-
-        it('should detect partitioned table with method and expression', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([
-                { PARTITION_NAME: 'p0', PARTITION_METHOD: 'RANGE', PARTITION_EXPRESSION: 'TO_DAYS(created_at)' }
-            ]));
-
-            const tool = tools.find(t => t.name === 'mysql_partition_info')!;
-            const result = await tool.handler({ table: 'logs' }, mockContext) as { partitioned: boolean; method: string };
-
-            expect(result.partitioned).toBe(true);
-            expect(result.method).toBe('RANGE');
-        });
-    });
-
-    describe('mysql_add_partition', () => {
-        it('should add a RANGE partition', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
-
-            const tool = tools.find(t => t.name === 'mysql_add_partition')!;
-            const result = await tool.handler({
-                table: 'logs',
-                partitionName: 'p2024',
-                partitionType: 'RANGE',
-                value: '2024'
-            }, mockContext);
-
-            expect(mockAdapter.executeQuery).toHaveBeenCalled();
-            const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
-            expect(call).toContain('ADD PARTITION');
-            expect(call).toContain('VALUES LESS THAN');
-            expect(result).toHaveProperty('success', true);
-        });
-
-        it('should add a LIST partition', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
-
-            const tool = tools.find(t => t.name === 'mysql_add_partition')!;
-            await tool.handler({
-                table: 'regions',
-                partitionName: 'p_east',
-                partitionType: 'LIST',
-                value: "'NY', 'NJ', 'PA'"
-            }, mockContext);
-
-            const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
-            expect(call).toContain('VALUES IN');
-        });
-
-        it('should add HASH partitions', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
-
-            const tool = tools.find(t => t.name === 'mysql_add_partition')!;
-            await tool.handler({
-                table: 'data',
-                partitionName: 'hash_p',
-                partitionType: 'HASH',
-                value: '4'
-            }, mockContext);
-
-            const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
-            expect(call).toContain('PARTITIONS 4');
-        });
-
-        it('should add KEY partitions', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
-
-            const tool = tools.find(t => t.name === 'mysql_add_partition')!;
-            await tool.handler({
-                table: 'data',
-                partitionName: 'key_p',
-                partitionType: 'KEY',
-                value: '8'
-            }, mockContext);
-
-            const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
-            expect(call).toContain('PARTITIONS 8');
-        });
-    });
-
-    describe('mysql_drop_partition', () => {
-        it('should drop a partition', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
-
-            const tool = tools.find(t => t.name === 'mysql_drop_partition')!;
-            const result = await tool.handler({
-                table: 'logs',
-                partitionName: 'p2020'
-            }, mockContext);
-
-            expect(mockAdapter.executeQuery).toHaveBeenCalled();
-            const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
-            expect(call).toContain('DROP PARTITION');
-            expect(result).toHaveProperty('success', true);
-        });
-    });
-
-    describe('mysql_reorganize_partition', () => {
-        it('should reorganize partitions', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
-
-            const tool = tools.find(t => t.name === 'mysql_reorganize_partition')!;
-            const result = await tool.handler({
-                table: 'logs',
-                fromPartitions: ['p2023'],
-                partitionType: 'RANGE',
-                toPartitions: [
-                    { name: 'p2023_h1', value: '202307' },
-                    { name: 'p2023_h2', value: '202401' }
-                ]
-            }, mockContext);
-
-            expect(mockAdapter.executeQuery).toHaveBeenCalled();
-            const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
-            expect(call).toContain('REORGANIZE PARTITION');
-            expect(result).toHaveProperty('success', true);
-        });
+    it("should return structured error for nonexistent partition", async () => {
+      mockAdapter.executeQuery.mockRejectedValue(
+        new Error("Error in list of partitions to DROP"),
+      );
+
+      const tool = tools.find((t) => t.name === "mysql_drop_partition")!;
+      const result = (await tool.handler(
+        { table: "logs", partitionName: "nonexistent" },
+        mockContext,
+      )) as {
+        success: boolean;
+        partitionName: string;
+        error: string;
+      };
+
+      expect(result.success).toBe(false);
+      expect(result.partitionName).toBe("nonexistent");
+      expect(result.error).toContain("does not exist");
     });
+  });
 });
 
-describe('Replication Fallback Handling', () => {
-    let mockAdapter: ReturnType<typeof createMockMySQLAdapter>;
-    let tools: ReturnType<typeof getReplicationTools>;
-    let mockContext: ReturnType<typeof createMockRequestContext>;
-
-    beforeEach(() => {
-        vi.clearAllMocks();
-        mockAdapter = createMockMySQLAdapter();
-        tools = getReplicationTools(mockAdapter as unknown as MySQLAdapter);
-        mockContext = createMockRequestContext();
+describe("Replication Fallback Handling", () => {
+  let mockAdapter: ReturnType<typeof createMockMySQLAdapter>;
+  let tools: ReturnType<typeof getReplicationTools>;
+  let mockContext: ReturnType<typeof createMockRequestContext>;
+
+  beforeEach(() => {
+    vi.clearAllMocks();
+    mockAdapter = createMockMySQLAdapter();
+    tools = getReplicationTools(mockAdapter as unknown as MySQLAdapter);
+    mockContext = createMockRequestContext();
+  });
+
+  describe("mysql_master_status fallback", () => {
+    it("should fallback to SHOW MASTER STATUS on error", async () => {
+      // First call fails (new syntax), second succeeds (old syntax)
+      mockAdapter.executeQuery
+        .mockRejectedValueOnce(new Error("Unknown command"))
+        .mockResolvedValueOnce(
+          createMockQueryResult([{ File: "mysql-bin.000001" }]),
+        );
+
+      const tool = tools.find((t) => t.name === "mysql_master_status")!;
+      const result = await tool.handler({}, mockContext);
+
+      expect(mockAdapter.executeQuery).toHaveBeenCalledTimes(2);
+      expect(result).toHaveProperty("status");
     });
 
-    describe('mysql_master_status fallback', () => {
-        it('should fallback to SHOW MASTER STATUS on error', async () => {
-            // First call fails (new syntax), second succeeds (old syntax)
-            mockAdapter.executeQuery
-                .mockRejectedValueOnce(new Error('Unknown command'))
-                .mockResolvedValueOnce(createMockQueryResult([{ File: 'mysql-bin.000001' }]));
+    it("should return error when binary logging is disabled", async () => {
+      mockAdapter.executeQuery
+        .mockRejectedValueOnce(new Error("Unknown command"))
+        .mockRejectedValueOnce(new Error("Binary logging not enabled"));
 
-            const tool = tools.find(t => t.name === 'mysql_master_status')!;
-            const result = await tool.handler({}, mockContext);
+      const tool = tools.find((t) => t.name === "mysql_master_status")!;
+      const result = (await tool.handler({}, mockContext)) as { error: string };
 
-            expect(mockAdapter.executeQuery).toHaveBeenCalledTimes(2);
-            expect(result).toHaveProperty('status');
-        });
+      expect(result.error).toContain("Binary logging");
+    });
+  });
 
-        it('should return error when binary logging is disabled', async () => {
-            mockAdapter.executeQuery
-                .mockRejectedValueOnce(new Error('Unknown command'))
-                .mockRejectedValueOnce(new Error('Binary logging not enabled'));
+  describe("mysql_slave_status fallback", () => {
+    it("should fallback to SHOW SLAVE STATUS on error", async () => {
+      mockAdapter.executeQuery
+        .mockRejectedValueOnce(new Error("Unknown command"))
+        .mockResolvedValueOnce(
+          createMockQueryResult([{ Slave_IO_Running: "Yes" }]),
+        );
 
-            const tool = tools.find(t => t.name === 'mysql_master_status')!;
-            const result = await tool.handler({}, mockContext) as { error: string };
+      const tool = tools.find((t) => t.name === "mysql_slave_status")!;
+      const result = await tool.handler({}, mockContext);
 
-            expect(result.error).toContain('Binary logging');
-        });
+      expect(mockAdapter.executeQuery).toHaveBeenCalledTimes(2);
+      expect(result).toHaveProperty("status");
     });
 
-    describe('mysql_slave_status fallback', () => {
-        it('should fallback to SHOW SLAVE STATUS on error', async () => {
-            mockAdapter.executeQuery
-                .mockRejectedValueOnce(new Error('Unknown command'))
-                .mockResolvedValueOnce(createMockQueryResult([{ Slave_IO_Running: 'Yes' }]));
+    it("should return message when not configured as replica", async () => {
+      mockAdapter.executeQuery
+        .mockRejectedValueOnce(new Error("Unknown command"))
+        .mockRejectedValueOnce(new Error("Not configured"));
 
-            const tool = tools.find(t => t.name === 'mysql_slave_status')!;
-            const result = await tool.handler({}, mockContext);
+      const tool = tools.find((t) => t.name === "mysql_slave_status")!;
+      const result = (await tool.handler({}, mockContext)) as {
+        message: string;
+      };
 
-            expect(mockAdapter.executeQuery).toHaveBeenCalledTimes(2);
-            expect(result).toHaveProperty('status');
-        });
+      expect(result.message).toContain("not configured");
+    });
+  });
 
-        it('should return message when not configured as replica', async () => {
-            mockAdapter.executeQuery
-                .mockRejectedValueOnce(new Error('Unknown command'))
-                .mockRejectedValueOnce(new Error('Not configured'));
+  describe("mysql_binlog_events options", () => {
+    it("should include log file when specified", async () => {
+      mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
 
-            const tool = tools.find(t => t.name === 'mysql_slave_status')!;
-            const result = await tool.handler({}, mockContext) as { message: string };
+      const tool = tools.find((t) => t.name === "mysql_binlog_events")!;
+      await tool.handler({ logFile: "mysql-bin.000005" }, mockContext);
 
-            expect(result.message).toContain('not configured');
-        });
+      // With explicit logFile, first call is the binlog query itself
+      const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
+      expect(call).toContain("IN 'mysql-bin.000005'");
     });
 
-    describe('mysql_binlog_events options', () => {
-        it('should include log file when specified', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
+    it("should include position when specified", async () => {
+      // First call: master status (logFile not provided), second: binlog events
+      mockAdapter.executeQuery
+        .mockResolvedValueOnce(
+          createMockQueryResult([{ File: "mysql-bin.000001", Position: 4 }]),
+        )
+        .mockResolvedValueOnce(createMockQueryResult([]));
 
-            const tool = tools.find(t => t.name === 'mysql_binlog_events')!;
-            await tool.handler({ logFile: 'mysql-bin.000005' }, mockContext);
+      const tool = tools.find((t) => t.name === "mysql_binlog_events")!;
+      await tool.handler({ position: 12345 }, mockContext);
 
-            const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
-            expect(call).toContain("IN 'mysql-bin.000005'");
-        });
+      // Second call is the actual SHOW BINLOG EVENTS query
+      const call = mockAdapter.executeQuery.mock.calls[1][0] as string;
+      expect(call).toContain("FROM 12345");
+    });
 
-        it('should include position when specified', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
+    it("should return graceful error for nonexistent binlog file", async () => {
+      mockAdapter.executeQuery.mockRejectedValue(
+        new Error("Could not find target log"),
+      );
 
-            const tool = tools.find(t => t.name === 'mysql_binlog_events')!;
-            await tool.handler({ position: 12345 }, mockContext);
+      const tool = tools.find((t) => t.name === "mysql_binlog_events")!;
+      const result = (await tool.handler(
+        { logFile: "nonexistent.000001" },
+        mockContext,
+      )) as { success: boolean; logFile: string; error: string };
 
-            const call = mockAdapter.executeQuery.mock.calls[0][0] as string;
-            expect(call).toContain('FROM 12345');
-        });
+      expect(result.success).toBe(false);
+      expect(result.logFile).toBe("nonexistent.000001");
+      expect(result.error).toContain("not found");
     });
 
-    describe('mysql_replication_lag fallback', () => {
-        it('should return lag from replica status', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([{
-                Seconds_Behind_Source: 5,
-                Replica_IO_Running: 'Yes',
-                Replica_SQL_Running: 'Yes',
-                Last_Error: ''
-            }]));
-
-            const tool = tools.find(t => t.name === 'mysql_replication_lag')!;
-            const result = await tool.handler({}, mockContext) as { lagSeconds: number };
-
-            expect(result.lagSeconds).toBe(5);
-        });
+    it("should return graceful error for generic binlog query failure", async () => {
+      // All calls fail (master status and binlog events)
+      mockAdapter.executeQuery.mockRejectedValue(
+        new Error("Binary logging not enabled"),
+      );
 
-        it('should fallback to SHOW SLAVE STATUS on error', async () => {
-            mockAdapter.executeQuery
-                .mockRejectedValueOnce(new Error('Unknown command'))
-                .mockResolvedValueOnce(createMockQueryResult([{
-                    Seconds_Behind_Master: 10,
-                    Slave_IO_Running: 'Yes',
-                    Slave_SQL_Running: 'Yes',
-                    Last_Error: ''
-                }]));
+      const tool = tools.find((t) => t.name === "mysql_binlog_events")!;
+      const result = (await tool.handler({}, mockContext)) as {
+        success: boolean;
+        error: string;
+      };
 
-            const tool = tools.find(t => t.name === 'mysql_replication_lag')!;
-            const result = await tool.handler({}, mockContext) as { lagSeconds: number };
+      expect(result.success).toBe(false);
+      expect(result.error).toContain("Failed to read binlog events");
+    });
+  });
+
+  describe("mysql_replication_lag fallback", () => {
+    it("should return lag from replica status", async () => {
+      mockAdapter.executeQuery.mockResolvedValue(
+        createMockQueryResult([
+          {
+            Seconds_Behind_Source: 5,
+            Replica_IO_Running: "Yes",
+            Replica_SQL_Running: "Yes",
+            Last_Error: "",
+          },
+        ]),
+      );
+
+      const tool = tools.find((t) => t.name === "mysql_replication_lag")!;
+      const result = (await tool.handler({}, mockContext)) as {
+        lagSeconds: number;
+      };
+
+      expect(result.lagSeconds).toBe(5);
+    });
 
-            expect(result.lagSeconds).toBe(10);
-        });
+    it("should fallback to SHOW SLAVE STATUS on error", async () => {
+      mockAdapter.executeQuery
+        .mockRejectedValueOnce(new Error("Unknown command"))
+        .mockResolvedValueOnce(
+          createMockQueryResult([
+            {
+              Seconds_Behind_Master: 10,
+              Slave_IO_Running: "Yes",
+              Slave_SQL_Running: "Yes",
+              Last_Error: "",
+            },
+          ]),
+        );
+
+      const tool = tools.find((t) => t.name === "mysql_replication_lag")!;
+      const result = (await tool.handler({}, mockContext)) as {
+        lagSeconds: number;
+      };
+
+      expect(result.lagSeconds).toBe(10);
+    });
 
-        it('should return message when not a replica after both fail', async () => {
-            mockAdapter.executeQuery
-                .mockRejectedValueOnce(new Error('Unknown command'))
-                .mockRejectedValueOnce(new Error('Not configured'));
+    it("should return message when not a replica after both fail", async () => {
+      mockAdapter.executeQuery
+        .mockRejectedValueOnce(new Error("Unknown command"))
+        .mockRejectedValueOnce(new Error("Not configured"));
 
-            const tool = tools.find(t => t.name === 'mysql_replication_lag')!;
-            const result = await tool.handler({}, mockContext) as { lagSeconds: null; message: string };
+      const tool = tools.find((t) => t.name === "mysql_replication_lag")!;
+      const result = (await tool.handler({}, mockContext)) as {
+        lagSeconds: null;
+        message: string;
+      };
 
-            expect(result.lagSeconds).toBeNull();
-            expect(result.message).toContain('not configured');
-        });
+      expect(result.lagSeconds).toBeNull();
+      expect(result.message).toContain("not configured");
+    });
 
-        it('should return null lag when replica status returns empty', async () => {
-            mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
+    it("should return null lag when replica status returns empty", async () => {
+      mockAdapter.executeQuery.mockResolvedValue(createMockQueryResult([]));
 
-            const tool = tools.find(t => t.name === 'mysql_replication_lag')!;
-            const result = await tool.handler({}, mockContext) as { lagSeconds: null };
+      const tool = tools.find((t) => t.name === "mysql_replication_lag")!;
+      const result = (await tool.handler({}, mockContext)) as {
+        lagSeconds: null;
+      };
 
-            expect(result.lagSeconds).toBeNull();
-        });
+      expect(result.lagSeconds).toBeNull();
     });
+  });
 });