npm - @neurodevs/node-lsl - Versions diffs - 22.0.0 → 22.1.0 - Mend

@neurodevs/node-lsl 22.0.0 → 22.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (9) hide show

package/build/__tests__/impl/BleObserverController.test.d.ts CHANGED Viewed

@@ -1,11 +1,21 @@
 import AbstractPackageTest from '../AbstractPackageTest.js';
 export default class BleObserverControllerTest extends AbstractPackageTest {
     private static instance;
+    private static passedAdvertisements;
+    private static readonly fakeError;
+    private static readonly data;
+    private static readonly length;
+    private static readonly timestampSec;
     protected static beforeEach(): Promise<void>;
     protected static createsInstance(): Promise<void>;
     protected static startObservingCreatesBleObserverBackend(): Promise<void>;
     protected static startObservingStartsBleObserverBackend(): Promise<void>;
+    protected static passesExpectedArgsToOnAdvertisement(): Promise<void>;
     protected static stopObservingStopsBleObserverBackend(): Promise<void>;
+    protected static createBleObserverBackendThrowsOnError(): Promise<void>;
+    protected static startObservingThrowsOnError(): Promise<void>;
+    protected static stopObservingThrowsOnError(): Promise<void>;
+    private static setFakeErrorResult;
     private static startObserving;
     private static stopObserving;
     private static BleObserverController;

package/build/__tests__/impl/BleObserverController.test.js CHANGED Viewed

@@ -10,8 +10,14 @@ import AbstractPackageTest from '../AbstractPackageTest.js';
 import { FakeLibndx } from '@neurodevs/ndx-native';
 export default class BleObserverControllerTest extends AbstractPackageTest {
     static instance;
+    static passedAdvertisements;
+    static fakeError = this.generateId();
+    static data = Buffer.from([0x01, 0x02, 0x03]);
+    static length = 3;
+    static timestampSec = 1234.5;
     static async beforeEach() {
         await super.beforeEach();
+        this.passedAdvertisements = [];
         this.instance = this.BleObserverController();
     }
     static async createsInstance() {
@@ -29,12 +35,41 @@ export default class BleObserverControllerTest extends AbstractPackageTest {
         assert.isEqual(deviceUuid, this.deviceUuid, 'Did not pass deviceUuid to startBleObserverBackend!');
         assert.isFunction(onAdvertisement, 'Did not pass onAdvertisement to startBleObserverBackend!');
     }
+    static async passesExpectedArgsToOnAdvertisement() {
+        await this.startObserving();
+        FakeLibndx.callsToStartBleObserver[0]?.onAdvertisement(this.data, this.length, this.timestampSec);
+        assert.isEqualDeep(this.passedAdvertisements[0], {
+            data: this.data,
+            length: this.length,
+            timestampSec: this.timestampSec,
+        }, 'Did not pass expected args to onAdvertisement!');
+    }
     static async stopObservingStopsBleObserverBackend() {
         await this.stopObserving();
         assert.isEqualDeep(FakeLibndx.callsToStopBleObserver[0], {
             deviceUuid: this.deviceUuid,
         });
     }
+    static async createBleObserverBackendThrowsOnError() {
+        this.setFakeErrorResult();
+        //@ts-ignore
+        this.instance.startBleObserverBackend = () => { };
+        await assert.doesThrowAsync(async () => await this.startObserving(), this.fakeError, 'Did not throw error!');
+    }
+    static async startObservingThrowsOnError() {
+        this.setFakeErrorResult();
+        await assert.doesThrowAsync(async () => await this.startObserving(), this.fakeError, 'Did not throw error!');
+    }
+    static async stopObservingThrowsOnError() {
+        this.setFakeErrorResult();
+        await assert.doesThrowAsync(async () => await this.stopObserving(), this.fakeError, 'Did not throw error!');
+    }
+    static setFakeErrorResult() {
+        FakeLibndx.fakeResult = {
+            status: 400,
+            error: this.fakeError,
+        };
+    }
     static async startObserving() {
         await this.instance.startObserving();
     }
@@ -44,6 +79,9 @@ export default class BleObserverControllerTest extends AbstractPackageTest {
     static BleObserverController() {
         return BleObserverController.Create({
             deviceUuid: this.deviceUuid,
+            onAdvertisement: (data, length, timestampSec) => {
+                this.passedAdvertisements.push({ data, length, timestampSec });
+            },
         });
     }
 }
@@ -56,7 +94,19 @@ __decorate([
 __decorate([
     test()
 ], BleObserverControllerTest, "startObservingStartsBleObserverBackend", null);
+__decorate([
+    test()
+], BleObserverControllerTest, "passesExpectedArgsToOnAdvertisement", null);
 __decorate([
     test()
 ], BleObserverControllerTest, "stopObservingStopsBleObserverBackend", null);
+__decorate([
+    test()
+], BleObserverControllerTest, "createBleObserverBackendThrowsOnError", null);
+__decorate([
+    test()
+], BleObserverControllerTest, "startObservingThrowsOnError", null);
+__decorate([
+    test()
+], BleObserverControllerTest, "stopObservingThrowsOnError", null);
 //# sourceMappingURL=BleObserverController.test.js.map

package/build/__tests__/impl/BleObserverController.test.js.map CHANGED Viewed

	@@ -1 +1 @@
1	- {"version":3,"file":"BleObserverController.test.js","sourceRoot":"","sources":["../../../src/__tests__/impl/BleObserverController.test.ts"],"names":[],"mappings":";;;;;;AAAA,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,MAAM,qBAAqB,CAAA;AAElD,OAAO,qBAEN,MAAM,iDAAiD,CAAA;AACxD,OAAO,mBAAmB,MAAM,2BAA2B,CAAA;AAC3D,OAAO,EAAE,UAAU,EAAE,MAAM,uBAAuB,CAAA;AAElD,MAAM,CAAC,OAAO,OAAO,yBAA0B,SAAQ,mBAAmB;IAC9D,MAAM,CAAC,QAAQ,CAAa;~~IAE1B~~,MAAM,CAAC,KAAK,CAAC,UAAU;QAC7B,MAAM,KAAK,CAAC,UAAU,EAAE,CAAA;QAExB,IAAI,CAAC,QAAQ,GAAG,IAAI,CAAC,qBAAqB,EAAE,CAAA;IAChD,CAAC;IAGsB,AAAb,MAAM,CAAC,KAAK,CAAC,eAAe;QAClC,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,QAAQ,EAAE,4BAA4B,CAAC,CAAA;IAChE,CAAC;IAGsB,AAAb,MAAM,CAAC,KAAK,CAAC,uCAAuC;QAC1D,MAAM,IAAI,CAAC,cAAc,EAAE,CAAA;QAE3B,MAAM,CAAC,WAAW,CAAC,UAAU,CAAC,wBAAwB,CAAC,CAAC,CAAC,EAAE;YACvD,UAAU,EAAE,IAAI,CAAC,UAAU;SAC9B,CAAC,CAAA;IACN,CAAC;IAGsB,AAAb,MAAM,CAAC,KAAK,CAAC,sCAAsC;QACzD,MAAM,IAAI,CAAC,cAAc,EAAE,CAAA;QAE3B,MAAM,EAAE,UAAU,EAAE,eAAe,EAAE,GACjC,UAAU,CAAC,uBAAuB,CAAC,CAAC,CAAC,CAAA;QAEzC,MAAM,CAAC,OAAO,CACV,UAAU,EACV,IAAI,CAAC,UAAU,EACf,qDAAqD,CACxD,CAAA;QACD,MAAM,CAAC,UAAU,CACb,eAAe,EACf,0DAA0D,CAC7D,CAAA;IACL,CAAC;IAGsB,AAAb,MAAM,CAAC,KAAK,CAAC,oCAAoC;QACvD,MAAM,IAAI,CAAC,aAAa,EAAE,CAAA;QAE1B,MAAM,CAAC,WAAW,CAAC,UAAU,CAAC,sBAAsB,CAAC,CAAC,CAAC,EAAE;YACrD,UAAU,EAAE,IAAI,CAAC,UAAU;SAC9B,CAAC,CAAA;IACN,CAAC;IAEO,MAAM,CAAC,KAAK,CAAC,cAAc;QAC/B,MAAM,IAAI,CAAC,QAAQ,CAAC,cAAc,EAAE,CAAA;IACxC,CAAC;IAEO,MAAM,CAAC,KAAK,CAAC,aAAa;QAC9B,MAAM,IAAI,CAAC,QAAQ,CAAC,aAAa,EAAE,CAAA;IACvC,CAAC;IAEO,MAAM,CAAC,qBAAqB;QAChC,OAAO,qBAAqB,CAAC,MAAM,CAAC;YAChC,UAAU,EAAE,IAAI,CAAC,UAAU;~~SAC9B~~,CAAC,CAAA;~~IACN~~,CAAC;~~CACJ~~;~~AArD0B~~;IADtB,IAAI,EAAE;sDAGN;AAGsB;IADtB,IAAI,EAAE;8EAON;AAGsB;IADtB,IAAI,EAAE;6EAgBN;AAGsB;IADtB,IAAI,EAAE;2EAON"}
1	+ {"version":3,"file":"BleObserverController.test.js","sourceRoot":"","sources":["../../../src/__tests__/impl/BleObserverController.test.ts"],"names":[],"mappings":";;;;;;AAAA,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,MAAM,qBAAqB,CAAA;AAElD,OAAO,qBAEN,MAAM,iDAAiD,CAAA;AACxD,OAAO,mBAAmB,MAAM,2BAA2B,CAAA;AAC3D,OAAO,EAAE,UAAU,EAAE,MAAM,uBAAuB,CAAA;AAElD,MAAM,CAAC,OAAO,OAAO,yBAA0B,SAAQ,mBAAmB;IAC9D,MAAM,CAAC,QAAQ,CAAa;IAC5B,MAAM,CAAC,oBAAoB,CAAuB;IAElD,MAAM,CAAU,SAAS,GAAG,IAAI,CAAC,UAAU,EAAE,CAAA;IAE7C,MAAM,CAAU,IAAI,GAAG,MAAM,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,IAAI,EAAE,IAAI,CAAC,CAAC,CAAA;IACtD,MAAM,CAAU,MAAM,GAAG,CAAC,CAAA;IAC1B,MAAM,CAAU,YAAY,GAAG,MAAM,CAAA;IAEnC,MAAM,CAAC,KAAK,CAAC,UAAU;QAC7B,MAAM,KAAK,CAAC,UAAU,EAAE,CAAA;QAExB,IAAI,CAAC,oBAAoB,GAAG,EAAE,CAAA;QAE9B,IAAI,CAAC,QAAQ,GAAG,IAAI,CAAC,qBAAqB,EAAE,CAAA;IAChD,CAAC;IAGsB,AAAb,MAAM,CAAC,KAAK,CAAC,eAAe;QAClC,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,QAAQ,EAAE,4BAA4B,CAAC,CAAA;IAChE,CAAC;IAGsB,AAAb,MAAM,CAAC,KAAK,CAAC,uCAAuC;QAC1D,MAAM,IAAI,CAAC,cAAc,EAAE,CAAA;QAE3B,MAAM,CAAC,WAAW,CAAC,UAAU,CAAC,wBAAwB,CAAC,CAAC,CAAC,EAAE;YACvD,UAAU,EAAE,IAAI,CAAC,UAAU;SAC9B,CAAC,CAAA;IACN,CAAC;IAGsB,AAAb,MAAM,CAAC,KAAK,CAAC,sCAAsC;QACzD,MAAM,IAAI,CAAC,cAAc,EAAE,CAAA;QAE3B,MAAM,EAAE,UAAU,EAAE,eAAe,EAAE,GACjC,UAAU,CAAC,uBAAuB,CAAC,CAAC,CAAC,CAAA;QAEzC,MAAM,CAAC,OAAO,CACV,UAAU,EACV,IAAI,CAAC,UAAU,EACf,qDAAqD,CACxD,CAAA;QACD,MAAM,CAAC,UAAU,CACb,eAAe,EACf,0DAA0D,CAC7D,CAAA;IACL,CAAC;IAGsB,AAAb,MAAM,CAAC,KAAK,CAAC,mCAAmC;QACtD,MAAM,IAAI,CAAC,cAAc,EAAE,CAAA;QAE3B,UAAU,CAAC,uBAAuB,CAAC,CAAC,CAAC,EAAE,eAAe,CAClD,IAAI,CAAC,IAAI,EACT,IAAI,CAAC,MAAM,EACX,IAAI,CAAC,YAAY,CACpB,CAAA;QAED,MAAM,CAAC,WAAW,CACd,IAAI,CAAC,oBAAoB,CAAC,CAAC,CAAC,EAC5B;YACI,IAAI,EAAE,IAAI,CAAC,IAAI;YACf,MAAM,EAAE,IAAI,CAAC,MAAM;YACnB,YAAY,EAAE,IAAI,CAAC,YAAY;SAClC,EACD,gDAAgD,CACnD,CAAA;IACL,CAAC;IAGsB,AAAb,MAAM,CAAC,KAAK,CAAC,oCAAoC;QACvD,MAAM,IAAI,CAAC,aAAa,EAAE,CAAA;QAE1B,MAAM,CAAC,WAAW,CAAC,UAAU,CAAC,sBAAsB,CAAC,CAAC,CAAC,EAAE;YACrD,UAAU,EAAE,IAAI,CAAC,UAAU;SAC9B,CAAC,CAAA;IACN,CAAC;IAGsB,AAAb,MAAM,CAAC,KAAK,CAAC,qCAAqC;QACxD,IAAI,CAAC,kBAAkB,EAAE,CAAA;QAEzB,YAAY;QACZ,IAAI,CAAC,QAAQ,CAAC,uBAAuB,GAAG,GAAG,EAAE,GAAE,CAAC,CAAA;QAEhD,MAAM,MAAM,CAAC,cAAc,CACvB,KAAK,IAAI,EAAE,CAAC,MAAM,IAAI,CAAC,cAAc,EAAE,EACvC,IAAI,CAAC,SAAS,EACd,sBAAsB,CACzB,CAAA;IACL,CAAC;IAGsB,AAAb,MAAM,CAAC,KAAK,CAAC,2BAA2B;QAC9C,IAAI,CAAC,kBAAkB,EAAE,CAAA;QAEzB,MAAM,MAAM,CAAC,cAAc,CACvB,KAAK,IAAI,EAAE,CAAC,MAAM,IAAI,CAAC,cAAc,EAAE,EACvC,IAAI,CAAC,SAAS,EACd,sBAAsB,CACzB,CAAA;IACL,CAAC;IAGsB,AAAb,MAAM,CAAC,KAAK,CAAC,0BAA0B;QAC7C,IAAI,CAAC,kBAAkB,EAAE,CAAA;QAEzB,MAAM,MAAM,CAAC,cAAc,CACvB,KAAK,IAAI,EAAE,CAAC,MAAM,IAAI,CAAC,aAAa,EAAE,EACtC,IAAI,CAAC,SAAS,EACd,sBAAsB,CACzB,CAAA;IACL,CAAC;IAEO,MAAM,CAAC,kBAAkB;QAC7B,UAAU,CAAC,UAAU,GAAG;YACpB,MAAM,EAAE,GAAG;YACX,KAAK,EAAE,IAAI,CAAC,SAAS;SACxB,CAAA;IACL,CAAC;IAEO,MAAM,CAAC,KAAK,CAAC,cAAc;QAC/B,MAAM,IAAI,CAAC,QAAQ,CAAC,cAAc,EAAE,CAAA;IACxC,CAAC;IAEO,MAAM,CAAC,KAAK,CAAC,aAAa;QAC9B,MAAM,IAAI,CAAC,QAAQ,CAAC,aAAa,EAAE,CAAA;IACvC,CAAC;IAEO,MAAM,CAAC,qBAAqB;QAChC,OAAO,qBAAqB,CAAC,MAAM,CAAC;YAChC,UAAU,EAAE,IAAI,CAAC,UAAU;YAC3B,eAAe,EAAE,CACb,IAAY,EACZ,MAAc,EACd,YAAoB,EACtB,EAAE;gBACA,IAAI,CAAC,oBAAoB,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,YAAY,EAAE,CAAC,CAAA;YAClE,CAAC;SACJ,CAAC,CAAA;IACN,CAAC;;AA3HsB;IADtB,IAAI,EAAE;sDAGN;AAGsB;IADtB,IAAI,EAAE;8EAON;AAGsB;IADtB,IAAI,EAAE;6EAgBN;AAGsB;IADtB,IAAI,EAAE;0EAmBN;AAGsB;IADtB,IAAI,EAAE;2EAON;AAGsB;IADtB,IAAI,EAAE;4EAYN;AAGsB;IADtB,IAAI,EAAE;kEASN;AAGsB;IADtB,IAAI,EAAE;iEASN"}

package/build/impl/controllers/BleObserverController.d.ts CHANGED Viewed

@@ -1,6 +1,7 @@
 export default class BleObserverController implements BleObserver {
     static Class?: BleObserverConstructor;
     private readonly deviceUuid;
+    private readonly onAdvertisement?;
     private readonly ndx;
     protected constructor(options: BleObserverOptions);
     static Create(options: BleObserverOptions): BleObserver;
@@ -9,6 +10,7 @@ export default class BleObserverController implements BleObserver {
     private startBleObserverBackend;
     stopObserving(): Promise<void>;
     private stopBleObserverBackend;
+    private throwIfError;
 }
 export interface BleObserver {
     startObserving(): Promise<void>;
@@ -17,4 +19,6 @@ export interface BleObserver {
 export type BleObserverConstructor = new (options: BleObserverOptions) => BleObserver;
 export type BleObserverOptions = {
     deviceUuid: string;
+    onAdvertisement?: OnAdvertisement;
 };
+export type OnAdvertisement = (data: Buffer, length: number, timestampSec: number) => void;

package/build/impl/controllers/BleObserverController.js CHANGED Viewed

@@ -2,10 +2,12 @@ import { LibndxAdapter } from '@neurodevs/ndx-native';
 export default class BleObserverController {
     static Class;
     deviceUuid;
+    onAdvertisement;
     ndx = LibndxAdapter.getInstance();
     constructor(options) {
-        const { deviceUuid } = options;
+        const { deviceUuid, onAdvertisement } = options;
         this.deviceUuid = deviceUuid ?? '';
+        this.onAdvertisement = onAdvertisement;
     }
     static Create(options) {
         return new (this.Class ?? this)(options);
@@ -15,23 +17,33 @@ export default class BleObserverController {
         this.startBleObserverBackend();
     }
     createBleObserverBackend() {
-        this.ndx.createBleObserverBackend({
+        const { status, error } = this.ndx.createBleObserverBackend({
             deviceUuid: this.deviceUuid,
         });
+        this.throwIfError(status, error);
     }
     startBleObserverBackend() {
-        this.ndx.startBleObserverBackend({
+        const { status, error } = this.ndx.startBleObserverBackend({
             deviceUuid: this.deviceUuid,
-            onAdvertisement: (_data, _length, _timestampSec) => { },
+            onAdvertisement: (data, length, timestampSec) => {
+                this.onAdvertisement?.(data, length, timestampSec);
+            },
         });
+        this.throwIfError(status, error);
     }
     async stopObserving() {
         this.stopBleObserverBackend();
     }
     stopBleObserverBackend() {
-        this.ndx.stopBleObserverBackend({
+        const { status, error } = this.ndx.stopBleObserverBackend({
             deviceUuid: this.deviceUuid,
         });
+        this.throwIfError(status, error);
+    }
+    throwIfError(status, error) {
+        if (status !== 200) {
+            throw new Error(`${status} error: ${error ?? 'Unknown error'}`);
+        }
     }
 }
 //# sourceMappingURL=BleObserverController.js.map

package/build/impl/controllers/BleObserverController.js.map CHANGED Viewed

	@@ -1 +1 @@
1	- {"version":3,"file":"BleObserverController.js","sourceRoot":"","sources":["../../../src/impl/controllers/BleObserverController.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,aAAa,EAAE,MAAM,uBAAuB,CAAA;AAErD,MAAM,CAAC,OAAO,OAAO,qBAAqB;IAC/B,MAAM,CAAC,KAAK,CAAyB;IAE3B,UAAU,CAAQ;IAClB,GAAG,GAAG,aAAa,CAAC,WAAW,EAAE,CAAA;IAElD,YAAsB,OAA2B;QAC7C,MAAM,EAAE,UAAU,EAAE,GAAG,OAAO,CAAA;~~QAE9B~~,IAAI,CAAC,UAAU,GAAG,UAAU,IAAI,EAAE,CAAA;~~IACtC~~,CAAC;IAEM,MAAM,CAAC,MAAM,CAAC,OAA2B;QAC5C,OAAO,IAAI,CAAC,IAAI,CAAC,KAAK,IAAI,IAAI,CAAC,CAAC,OAAO,CAAC,CAAA;IAC5C,CAAC;IAEM,KAAK,CAAC,cAAc;QACvB,IAAI,CAAC,wBAAwB,EAAE,CAAA;QAC/B,IAAI,CAAC,uBAAuB,EAAE,CAAA;IAClC,CAAC;IAEO,wBAAwB;QAC5B,IAAI,CAAC,GAAG,CAAC,wBAAwB,CAAC;~~YAC9B~~,UAAU,EAAE,IAAI,CAAC,UAAU;SAC9B,CAAC,CAAA;~~IACN~~,CAAC;IAEO,uBAAuB;QAC3B,IAAI,CAAC,GAAG,CAAC,uBAAuB,CAAC;~~YAC7B~~,UAAU,EAAE,IAAI,CAAC,UAAU;YAC3B,eAAe,EAAE,CACb,~~KAAa~~,~~EACb~~,~~OAAe~~,~~EACf~~,~~aAAqB~~,~~EACvB~~,EAAE,~~GAAE~~,CAAC;~~SACV~~,CAAC,CAAA;~~IACN~~,CAAC;IAEM,KAAK,CAAC,aAAa;QACtB,IAAI,CAAC,sBAAsB,EAAE,CAAA;IACjC,CAAC;IAEO,sBAAsB;QAC1B,IAAI,CAAC,GAAG,CAAC,sBAAsB,CAAC;~~YAC5B~~,UAAU,EAAE,IAAI,CAAC,UAAU;SAC9B,CAAC,CAAA;~~IACN~~,CAAC;CACJ"}
1	+ {"version":3,"file":"BleObserverController.js","sourceRoot":"","sources":["../../../src/impl/controllers/BleObserverController.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,aAAa,EAAE,MAAM,uBAAuB,CAAA;AAErD,MAAM,CAAC,OAAO,OAAO,qBAAqB;IAC/B,MAAM,CAAC,KAAK,CAAyB;IAE3B,UAAU,CAAQ;IAClB,eAAe,CAAkB;IACjC,GAAG,GAAG,aAAa,CAAC,WAAW,EAAE,CAAA;IAElD,YAAsB,OAA2B;QAC7C,MAAM,EAAE,UAAU,EAAE,eAAe,EAAE,GAAG,OAAO,CAAA;QAE/C,IAAI,CAAC,UAAU,GAAG,UAAU,IAAI,EAAE,CAAA;QAClC,IAAI,CAAC,eAAe,GAAG,eAAe,CAAA;IAC1C,CAAC;IAEM,MAAM,CAAC,MAAM,CAAC,OAA2B;QAC5C,OAAO,IAAI,CAAC,IAAI,CAAC,KAAK,IAAI,IAAI,CAAC,CAAC,OAAO,CAAC,CAAA;IAC5C,CAAC;IAEM,KAAK,CAAC,cAAc;QACvB,IAAI,CAAC,wBAAwB,EAAE,CAAA;QAC/B,IAAI,CAAC,uBAAuB,EAAE,CAAA;IAClC,CAAC;IAEO,wBAAwB;QAC5B,MAAM,EAAE,MAAM,EAAE,KAAK,EAAE,GAAG,IAAI,CAAC,GAAG,CAAC,wBAAwB,CAAC;YACxD,UAAU,EAAE,IAAI,CAAC,UAAU;SAC9B,CAAC,CAAA;QAEF,IAAI,CAAC,YAAY,CAAC,MAAM,EAAE,KAAK,CAAC,CAAA;IACpC,CAAC;IAEO,uBAAuB;QAC3B,MAAM,EAAE,MAAM,EAAE,KAAK,EAAE,GAAG,IAAI,CAAC,GAAG,CAAC,uBAAuB,CAAC;YACvD,UAAU,EAAE,IAAI,CAAC,UAAU;YAC3B,eAAe,EAAE,CACb,IAAY,EACZ,MAAc,EACd,YAAoB,EACtB,EAAE;gBACA,IAAI,CAAC,eAAe,EAAE,CAAC,IAAI,EAAE,MAAM,EAAE,YAAY,CAAC,CAAA;YACtD,CAAC;SACJ,CAAC,CAAA;QAEF,IAAI,CAAC,YAAY,CAAC,MAAM,EAAE,KAAK,CAAC,CAAA;IACpC,CAAC;IAEM,KAAK,CAAC,aAAa;QACtB,IAAI,CAAC,sBAAsB,EAAE,CAAA;IACjC,CAAC;IAEO,sBAAsB;QAC1B,MAAM,EAAE,MAAM,EAAE,KAAK,EAAE,GAAG,IAAI,CAAC,GAAG,CAAC,sBAAsB,CAAC;YACtD,UAAU,EAAE,IAAI,CAAC,UAAU;SAC9B,CAAC,CAAA;QAEF,IAAI,CAAC,YAAY,CAAC,MAAM,EAAE,KAAK,CAAC,CAAA;IACpC,CAAC;IAEO,YAAY,CAAC,MAAc,EAAE,KAAyB;QAC1D,IAAI,MAAM,KAAK,GAAG,EAAE,CAAC;YACjB,MAAM,IAAI,KAAK,CAAC,GAAG,MAAM,WAAW,KAAK,IAAI,eAAe,EAAE,CAAC,CAAA;QACnE,CAAC;IACL,CAAC;CACJ"}

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@neurodevs/node-lsl",
-  "version": "22.0.0",
+  "version": "22.1.0",
   "description": "Lab Streaming Layer (LSL) bindings for Node",
   "type": "module",
   "keywords": [

package/src/__tests__/impl/BleObserverController.test.ts CHANGED Viewed

@@ -8,10 +8,19 @@ import { FakeLibndx } from '@neurodevs/ndx-native'
 export default class BleObserverControllerTest extends AbstractPackageTest {
     private static instance: BleObserver
+    private static passedAdvertisements: PassedAdvertisement[]
+    private static readonly fakeError = this.generateId()
+    private static readonly data = Buffer.from([0x01, 0x02, 0x03])
+    private static readonly length = 3
+    private static readonly timestampSec = 1234.5
     protected static async beforeEach() {
         await super.beforeEach()
+        this.passedAdvertisements = []
         this.instance = this.BleObserverController()
     }
@@ -47,6 +56,27 @@ export default class BleObserverControllerTest extends AbstractPackageTest {
         )
     }
+    @test()
+    protected static async passesExpectedArgsToOnAdvertisement() {
+        await this.startObserving()
+        FakeLibndx.callsToStartBleObserver[0]?.onAdvertisement(
+            this.data,
+            this.length,
+            this.timestampSec
+        )
+        assert.isEqualDeep(
+            this.passedAdvertisements[0],
+            {
+                data: this.data,
+                length: this.length,
+                timestampSec: this.timestampSec,
+            },
+            'Did not pass expected args to onAdvertisement!'
+        )
+    }
     @test()
     protected static async stopObservingStopsBleObserverBackend() {
         await this.stopObserving()
@@ -56,6 +86,49 @@ export default class BleObserverControllerTest extends AbstractPackageTest {
         })
     }
+    @test()
+    protected static async createBleObserverBackendThrowsOnError() {
+        this.setFakeErrorResult()
+        //@ts-ignore
+        this.instance.startBleObserverBackend = () => {}
+        await assert.doesThrowAsync(
+            async () => await this.startObserving(),
+            this.fakeError,
+            'Did not throw error!'
+        )
+    }
+    @test()
+    protected static async startObservingThrowsOnError() {
+        this.setFakeErrorResult()
+        await assert.doesThrowAsync(
+            async () => await this.startObserving(),
+            this.fakeError,
+            'Did not throw error!'
+        )
+    }
+    @test()
+    protected static async stopObservingThrowsOnError() {
+        this.setFakeErrorResult()
+        await assert.doesThrowAsync(
+            async () => await this.stopObserving(),
+            this.fakeError,
+            'Did not throw error!'
+        )
+    }
+    private static setFakeErrorResult() {
+        FakeLibndx.fakeResult = {
+            status: 400,
+            error: this.fakeError,
+        }
+    }
     private static async startObserving() {
         await this.instance.startObserving()
     }
@@ -67,6 +140,19 @@ export default class BleObserverControllerTest extends AbstractPackageTest {
     private static BleObserverController() {
         return BleObserverController.Create({
             deviceUuid: this.deviceUuid,
+            onAdvertisement: (
+                data: Buffer,
+                length: number,
+                timestampSec: number
+            ) => {
+                this.passedAdvertisements.push({ data, length, timestampSec })
+            },
         })
     }
 }
+type PassedAdvertisement = {
+    data: Buffer
+    length: number
+    timestampSec: number
+}

package/src/impl/controllers/BleObserverController.ts CHANGED Viewed

@@ -4,12 +4,14 @@ export default class BleObserverController implements BleObserver {
     public static Class?: BleObserverConstructor
     private readonly deviceUuid: string
+    private readonly onAdvertisement?: OnAdvertisement
     private readonly ndx = LibndxAdapter.getInstance()
     protected constructor(options: BleObserverOptions) {
-        const { deviceUuid } = options
+        const { deviceUuid, onAdvertisement } = options
         this.deviceUuid = deviceUuid ?? ''
+        this.onAdvertisement = onAdvertisement
     }
     public static Create(options: BleObserverOptions) {
@@ -22,20 +24,26 @@ export default class BleObserverController implements BleObserver {
     }
     private createBleObserverBackend() {
-        this.ndx.createBleObserverBackend({
+        const { status, error } = this.ndx.createBleObserverBackend({
             deviceUuid: this.deviceUuid,
         })
+        this.throwIfError(status, error)
     }
     private startBleObserverBackend() {
-        this.ndx.startBleObserverBackend({
+        const { status, error } = this.ndx.startBleObserverBackend({
             deviceUuid: this.deviceUuid,
             onAdvertisement: (
-                _data: Buffer,
-                _length: number,
-                _timestampSec: number
-            ) => {},
+                data: Buffer,
+                length: number,
+                timestampSec: number
+            ) => {
+                this.onAdvertisement?.(data, length, timestampSec)
+            },
         })
+        this.throwIfError(status, error)
     }
     public async stopObserving() {
@@ -43,9 +51,17 @@ export default class BleObserverController implements BleObserver {
     }
     private stopBleObserverBackend() {
-        this.ndx.stopBleObserverBackend({
+        const { status, error } = this.ndx.stopBleObserverBackend({
             deviceUuid: this.deviceUuid,
         })
+        this.throwIfError(status, error)
+    }
+    private throwIfError(status: number, error: string | undefined) {
+        if (status !== 200) {
+            throw new Error(`${status} error: ${error ?? 'Unknown error'}`)
+        }
     }
 }
 export interface BleObserver {
@@ -59,4 +75,11 @@ export type BleObserverConstructor = new (
 export type BleObserverOptions = {
     deviceUuid: string
+    onAdvertisement?: OnAdvertisement
 }
+export type OnAdvertisement = (
+    data: Buffer,
+    length: number,
+    timestampSec: number
+) => void