@neurocode-ai/core 1.18.8

package/test/tool-skill.test.ts

@@ -0,0 +1,149 @@
+import fs from "fs/promises"
+import path from "path"
+import { describe, expect } from "bun:test"
+import { Effect, Layer } from "effect"
+import { AppNodeBuilder } from "@neurocode-ai/core/effect/app-node-builder"
+import { LayerNode } from "@neurocode-ai/core/effect/layer-node"
+import { PermissionV2 } from "@neurocode-ai/core/permission"
+import { AbsolutePath } from "@neurocode-ai/core/schema"
+import { SessionV2 } from "@neurocode-ai/core/session"
+import { SkillV2 } from "@neurocode-ai/core/skill"
+import { SkillTool } from "@neurocode-ai/core/tool/skill"
+import { ToolRegistry } from "@neurocode-ai/core/tool/registry"
+import { ToolOutputStore } from "@neurocode-ai/core/tool-output-store"
+import { tmpdir } from "./fixture/tmpdir"
+import { it } from "./lib/effect"
+import { toolIdentity, executeTool, settleTool, toolDefinitions } from "./lib/tool"
+
+const sessionID = SessionV2.ID.make("ses_skill_tool_test")
+
+describe("SkillTool", () => {
+  it.live("lists available skills, authorizes the selected name, and loads model-facing content", () =>
+    Effect.acquireRelease(
+      Effect.promise(() => tmpdir()),
+      (tmp) => Effect.promise(() => tmp[Symbol.asyncDispose]()),
+    ).pipe(
+      Effect.flatMap((tmp) =>
+        Effect.gen(function* () {
+          const directory = path.join(tmp.path, "effect")
+          const location = path.join(directory, "SKILL.md")
+          const reference = path.join(directory, "reference.md")
+          yield* Effect.promise(() => fs.mkdir(directory, { recursive: true }))
+          yield* Effect.promise(() =>
+            Promise.all([fs.writeFile(location, "unused"), fs.writeFile(reference, "reference")]),
+          )
+
+          const info: SkillV2.Info = {
+            name: "effect",
+            description: "Use Effect",
+            location: AbsolutePath.make(location),
+            content: "# Effect\n\nGuidance",
+          }
+          let current = [info]
+          const assertions: PermissionV2.AssertInput[] = []
+          let deny = false
+          const permission = Layer.succeed(
+            PermissionV2.Service,
+            PermissionV2.Service.of({
+              assert: (input) =>
+                Effect.sync(() => assertions.push(input)).pipe(
+                  Effect.andThen(deny ? Effect.fail(new PermissionV2.BlockedError({ rules: [] })) : Effect.void),
+                ),
+              ask: () => Effect.die("unused"),
+              reply: () => Effect.die("unused"),
+              get: () => Effect.die("unused"),
+              forSession: () => Effect.die("unused"),
+              list: () => Effect.die("unused"),
+            }),
+          )
+          const skills = Layer.succeed(
+            SkillV2.Service,
+            SkillV2.Service.of({
+              transform: (_transform) => Effect.die("unused"),
+              reload: () => Effect.die("unused"),
+              sources: () => Effect.die("unused"),
+              list: () => Effect.succeed(current),
+            }),
+          )
+          const skillToolLayer = AppNodeBuilder.build(
+            LayerNode.group([ToolRegistry.node, ToolRegistry.toolsNode, SkillTool.node]),
+            [
+              [PermissionV2.node, permission],
+              [SkillV2.node, skills],
+              [ToolOutputStore.node, ToolOutputStore.nodeWithoutConfig],
+            ],
+          )
+
+          return yield* Effect.gen(function* () {
+            const registry = yield* ToolRegistry.Service
+            expect((yield* toolDefinitions(registry))[0]).toMatchObject({
+              name: "skill",
+              description: SkillTool.description,
+            })
+            expect(
+              yield* executeTool(registry, {
+                sessionID,
+                ...toolIdentity,
+                call: { type: "tool-call", id: "call-skill", name: "skill", input: { name: "effect" } },
+              }),
+            ).toEqual({
+              type: "text",
+              value: SkillTool.toModelOutput(info, [reference]),
+            })
+            expect(SkillTool.toModelOutput(info, [reference])).toContain(`Base directory for this skill: ${directory}`)
+            expect(
+              yield* settleTool(registry, {
+                sessionID,
+                ...toolIdentity,
+                call: { type: "tool-call", id: "call-skill-overflow", name: "skill", input: { name: "effect" } },
+              }),
+            ).toMatchObject({
+              result: { type: "text", value: SkillTool.toModelOutput(info, [reference]) },
+              output: { structured: { name: "effect" } },
+            })
+            expect(assertions).toMatchObject([
+              { sessionID, action: "skill", resources: ["effect"], save: ["effect"] },
+              { sessionID, action: "skill", resources: ["effect"], save: ["effect"] },
+            ])
+            expect(
+              yield* executeTool(registry, {
+                sessionID,
+                ...toolIdentity,
+                call: { type: "tool-call", id: "call-missing-skill", name: "skill", input: { name: "missing" } },
+              }),
+            ).toEqual({ type: "error", value: "Unable to load skill missing" })
+            deny = true
+            expect(
+              yield* executeTool(registry, {
+                sessionID,
+                ...toolIdentity,
+                call: { type: "tool-call", id: "call-denied-skill", name: "skill", input: { name: "effect" } },
+              }),
+            ).toEqual({ type: "error", value: "Unable to load skill effect" })
+            deny = false
+            const flat = SkillV2.Info.make({
+              name: "public",
+              description: "Public guidance",
+              location: AbsolutePath.make(path.join(tmp.path, "public.md")),
+              content: "Public",
+            })
+            yield* Effect.promise(() =>
+              Promise.all([
+                fs.writeFile(flat.location, "public"),
+                fs.writeFile(path.join(tmp.path, "secret.md"), "secret"),
+              ]),
+            )
+            current = [flat]
+            expect(
+              yield* executeTool(registry, {
+                sessionID,
+                ...toolIdentity,
+                call: { type: "tool-call", id: "call-flat-skill", name: "skill", input: { name: "public" } },
+              }),
+            ).toEqual({ type: "text", value: SkillTool.toModelOutput(flat, []) })
+          }).pipe(Effect.provide(skillToolLayer))
+        }),
+      ),
+    ),
+  )
+})

package/test/tool-todowrite.test.ts

@@ -0,0 +1,125 @@
+import { describe, expect } from "bun:test"
+import { Effect, Layer } from "effect"
+import { Database } from "@neurocode-ai/core/database/database"
+import { AppNodeBuilder } from "@neurocode-ai/core/effect/app-node-builder"
+import { LayerNode } from "@neurocode-ai/core/effect/layer-node"
+import { EventV2 } from "@neurocode-ai/core/event"
+import { PermissionV2 } from "@neurocode-ai/core/permission"
+import { Project } from "@neurocode-ai/core/project"
+import { ProjectTable } from "@neurocode-ai/core/project/sql"
+import { AbsolutePath } from "@neurocode-ai/core/schema"
+import { SessionV2 } from "@neurocode-ai/core/session"
+import { SessionTable } from "@neurocode-ai/core/session/sql"
+import { SessionTodo } from "@neurocode-ai/core/session/todo"
+import { TodoWriteTool } from "@neurocode-ai/core/tool/todowrite"
+import { ToolRegistry } from "@neurocode-ai/core/tool/registry"
+import { ToolOutputStore } from "@neurocode-ai/core/tool-output-store"
+import { testEffect } from "./lib/effect"
+import { toolIdentity, executeTool, settleTool, toolDefinitions } from "./lib/tool"
+
+const sessionID = SessionV2.ID.make("ses_todowrite_tool_test")
+const assertions: PermissionV2.AssertInput[] = []
+let deny = false
+
+const permission = Layer.succeed(
+  PermissionV2.Service,
+  PermissionV2.Service.of({
+    assert: (input) =>
+      Effect.sync(() => assertions.push(input)).pipe(
+        Effect.andThen(deny ? Effect.fail(new PermissionV2.BlockedError({ rules: [] })) : Effect.void),
+      ),
+    ask: () => Effect.die("unused"),
+    reply: () => Effect.die("unused"),
+    get: () => Effect.die("unused"),
+    forSession: () => Effect.die("unused"),
+    list: () => Effect.die("unused"),
+  }),
+)
+const it = testEffect(
+  AppNodeBuilder.build(
+    LayerNode.group([
+      Database.node,
+      EventV2.node,
+      SessionTodo.node,
+      ToolRegistry.node,
+      ToolRegistry.toolsNode,
+      TodoWriteTool.node,
+    ]),
+    [
+      [PermissionV2.node, permission],
+      [ToolOutputStore.node, ToolOutputStore.nodeWithoutConfig],
+    ],
+  ),
+)
+
+const setup = Effect.gen(function* () {
+  assertions.length = 0
+  deny = false
+  const { db } = yield* Database.Service
+  yield* db
+    .insert(ProjectTable)
+    .values({ id: Project.ID.global, worktree: AbsolutePath.make("/project"), sandboxes: [] })
+    .run()
+    .pipe(Effect.orDie)
+  yield* db
+    .insert(SessionTable)
+    .values({
+      id: sessionID,
+      project_id: Project.ID.global,
+      slug: "todowrite",
+      directory: "/project",
+      title: "todowrite",
+      version: "test",
+    })
+    .run()
+    .pipe(Effect.orDie)
+})
+
+const call = (todos: ReadonlyArray<SessionTodo.Info>, id = "call-todowrite") => ({
+  sessionID,
+  ...toolIdentity,
+  call: { type: "tool-call" as const, id, name: TodoWriteTool.name, input: { todos } },
+})
+
+describe("TodoWriteTool", () => {
+  it.effect("registers, approves the wildcard resource, persists todos, and returns typed output", () =>
+    Effect.gen(function* () {
+      yield* setup
+      const registry = yield* ToolRegistry.Service
+      const service = yield* SessionTodo.Service
+      const todoList: ReadonlyArray<SessionTodo.Info> = [
+        { content: "Implement slice", status: "in_progress", priority: "high" },
+      ]
+
+      expect((yield* toolDefinitions(registry)).map((tool) => tool.name)).toEqual([TodoWriteTool.name])
+      expect(yield* settleTool(registry, call(todoList))).toEqual({
+        result: { type: "text", value: JSON.stringify(todoList, null, 2) },
+        output: {
+          structured: { todos: todoList },
+          content: [{ type: "text", text: JSON.stringify(todoList, null, 2) }],
+        },
+      })
+      expect(assertions).toMatchObject([{ sessionID, action: "todowrite", resources: ["*"], save: ["*"] }])
+      expect(yield* service.get(sessionID)).toEqual(todoList)
+    }),
+  )
+
+  it.effect("does not update persisted todos when permission is denied", () =>
+    Effect.gen(function* () {
+      yield* setup
+      const registry = yield* ToolRegistry.Service
+      const service = yield* SessionTodo.Service
+      yield* service.update({ sessionID, todos: [{ content: "keep", status: "pending", priority: "low" }] })
+      deny = true
+
+      expect(
+        yield* executeTool(registry, call([{ content: "blocked", status: "completed", priority: "high" }])),
+      ).toEqual({
+        type: "error",
+        value: "Unable to update todos",
+      })
+      expect(yield* service.get(sessionID)).toEqual([{ content: "keep", status: "pending", priority: "low" }])
+      expect(assertions).toMatchObject([{ sessionID, action: "todowrite", resources: ["*"], save: ["*"] }])
+    }),
+  )
+})

package/test/tool-webfetch.test.ts

@@ -0,0 +1,281 @@
+import { describe, expect, test } from "bun:test"
+import { Duration, Effect, Fiber, Layer, Schema } from "effect"
+import * as TestClock from "effect/testing/TestClock"
+import { HttpClient, HttpClientRequest, HttpClientResponse } from "effect/unstable/http"
+import { AppNodeBuilder } from "@neurocode-ai/core/effect/app-node-builder"
+import { LayerNode } from "@neurocode-ai/core/effect/layer-node"
+import { LayerNodePlatform } from "@neurocode-ai/core/effect/app-node-platform"
+import { PermissionV2 } from "@neurocode-ai/core/permission"
+import { SessionV2 } from "@neurocode-ai/core/session"
+import { ToolRegistry } from "@neurocode-ai/core/tool/registry"
+import { WebFetchTool } from "@neurocode-ai/core/tool/webfetch"
+import { ToolOutputStore } from "@neurocode-ai/core/tool-output-store"
+import { testEffect } from "./lib/effect"
+import { toolIdentity, executeTool, settleTool, toolDefinitions } from "./lib/tool"
+
+const sessionID = SessionV2.ID.make("ses_webfetch_test")
+const requests: Array<{ readonly url: string; readonly headers: Record<string, string> }> = []
+const assertions: PermissionV2.AssertInput[] = []
+let respond = (_request: HttpClientRequest.HttpClientRequest) =>
+  Effect.succeed(new Response("hello", { headers: { "content-type": "text/plain" } }))
+
+const http = Layer.succeed(
+  HttpClient.HttpClient,
+  HttpClient.make((request) =>
+    Effect.sync(() => requests.push({ url: request.url, headers: request.headers })).pipe(
+      Effect.andThen(respond(request)),
+      Effect.map((response) => HttpClientResponse.fromWeb(request, response)),
+    ),
+  ),
+)
+const permission = Layer.succeed(
+  PermissionV2.Service,
+  PermissionV2.Service.of({
+    assert: (input) => Effect.sync(() => assertions.push(input)),
+    ask: () => Effect.die("unused"),
+    reply: () => Effect.die("unused"),
+    get: () => Effect.die("unused"),
+    forSession: () => Effect.die("unused"),
+    list: () => Effect.die("unused"),
+  }),
+)
+const toolLayer = (replacements: LayerNode.Replacements = []) =>
+  AppNodeBuilder.build(LayerNode.group([ToolRegistry.node, ToolRegistry.toolsNode, WebFetchTool.node]), [
+    [PermissionV2.node, permission],
+    [ToolOutputStore.node, ToolOutputStore.nodeWithoutConfig],
+    ...replacements,
+  ])
+const it = testEffect(toolLayer([[LayerNodePlatform.httpClient, http]]))
+const live = testEffect(toolLayer())
+
+const reset = () => {
+  requests.length = 0
+  assertions.length = 0
+  respond = () => Effect.succeed(new Response("hello", { headers: { "content-type": "text/plain" } }))
+}
+
+const call = (input: typeof WebFetchTool.Input.Type, id = "call-webfetch") => ({
+  sessionID,
+  ...toolIdentity,
+  call: { type: "tool-call" as const, id, name: "webfetch", input },
+})
+
+describe("WebFetchTool helpers", () => {
+  test("defaults format and rejects invalid timeout controls", () => {
+    const decode = Schema.decodeUnknownSync(WebFetchTool.Input)
+    expect(decode({ url: "https://example.com" })).toEqual({ url: "https://example.com", format: "markdown" })
+    expect(() => decode({ url: "https://example.com", timeout: 0 })).toThrow()
+    expect(() => decode({ url: "https://example.com", timeout: WebFetchTool.MAX_TIMEOUT_SECONDS + 1 })).toThrow()
+  })
+
+  test("ports HTML text and markdown conversions without active content", () => {
+    const html = "<h1>Hello</h1><script>bad()</script><p>world <strong>wide</strong></p><style>.bad {}</style>"
+    expect(WebFetchTool.extractTextFromHTML(html)).toBe("Helloworld wide")
+    expect(WebFetchTool.convertHTMLToMarkdown(html)).toBe("# Hello\n\nworld **wide**")
+  })
+})
+
+describe("WebFetchTool registration", () => {
+  it.effect("registers and fetches an ordinary hostname HTTP URL without rewriting it", () =>
+    Effect.gen(function* () {
+      reset()
+      const registry = yield* ToolRegistry.Service
+      const url = "http://example.com/public"
+
+      expect((yield* toolDefinitions(registry)).map((tool) => tool.name)).toEqual(["webfetch"])
+      expect(yield* settleTool(registry, call({ url, format: "text", timeout: 4 }))).toEqual({
+        result: { type: "text", value: "hello" },
+        output: {
+          structured: { url, contentType: "text/plain", format: "text", output: "hello" },
+          content: [{ type: "text", text: "hello" }],
+        },
+      })
+      expect(assertions).toMatchObject([
+        { sessionID, action: "webfetch", resources: [url], save: ["*"], metadata: { url, format: "text", timeout: 4 } },
+      ])
+      expect(requests).toMatchObject([{ url, headers: { accept: expect.stringContaining("text/plain;q=1.0") } }])
+    }),
+  )
+
+  it.effect("accepts localhost URLs with the same requested-URL permission check", () =>
+    Effect.gen(function* () {
+      reset()
+      const registry = yield* ToolRegistry.Service
+      const url = "http://localhost/private"
+
+      expect(yield* executeTool(registry, call({ url, format: "text" }))).toEqual({
+        type: "text",
+        value: "hello",
+      })
+      expect(assertions).toMatchObject([
+        { sessionID, action: "webfetch", resources: [url], save: ["*"], metadata: { url, format: "text" } },
+      ])
+      expect(requests.map((request) => request.url)).toEqual([url])
+    }),
+  )
+
+  live.effect("follows redirects while approving only the requested URL", () =>
+    Effect.acquireUseRelease(
+      Effect.sync(() =>
+        Bun.serve({
+          port: 0,
+          fetch: (request) =>
+            new URL(request.url).pathname === "/redirect"
+              ? new Response("", { status: 302, headers: { location: "/target" } })
+              : new Response("redirected", { headers: { "content-type": "text/plain" } }),
+        }),
+      ),
+      (server) =>
+        Effect.gen(function* () {
+          reset()
+          const registry = yield* ToolRegistry.Service
+          const url = new URL("/redirect", server.url).toString()
+
+          expect(yield* executeTool(registry, call({ url, format: "text" }))).toEqual({
+            type: "text",
+            value: "redirected",
+          })
+          expect(assertions).toMatchObject([
+            { sessionID, action: "webfetch", resources: [url], save: ["*"], metadata: { url, format: "text" } },
+          ])
+        }),
+      (server) => Effect.promise(() => server.stop(true)),
+    ),
+  )
+
+  it.effect("rejects non-HTTP schemes before permission or transport", () =>
+    Effect.gen(function* () {
+      reset()
+      const registry = yield* ToolRegistry.Service
+
+      expect(yield* executeTool(registry, call({ url: "file:///etc/passwd", format: "text" }))).toEqual({
+        type: "error",
+        value: "Unable to fetch file:///etc/passwd",
+      })
+      expect(assertions).toEqual([])
+      expect(requests).toEqual([])
+    }),
+  )
+
+  it.effect("converts HTML to requested markdown and text", () =>
+    Effect.gen(function* () {
+      reset()
+      respond = () =>
+        Effect.succeed(
+          new Response("<h1>Hello</h1><p>world</p><script>bad()</script>", {
+            headers: { "content-type": "text/html; charset=utf-8" },
+          }),
+        )
+      const registry = yield* ToolRegistry.Service
+
+      expect(yield* executeTool(registry, call({ url: "https://1.1.1.1", format: "markdown" }))).toEqual({
+        type: "text",
+        value: "# Hello\n\nworld",
+      })
+      expect(yield* executeTool(registry, call({ url: "https://1.1.1.1", format: "text" }))).toEqual({
+        type: "text",
+        value: "Helloworld",
+      })
+    }),
+  )
+
+  it.effect("returns an error result when HTML-to-Markdown conversion throws", () =>
+    Effect.gen(function* () {
+      reset()
+      respond = () =>
+        Effect.succeed(
+          new Response("<div>".repeat(10_000) + "content" + "</div>".repeat(10_000), {
+            headers: { "content-type": "text/html" },
+          }),
+        )
+      const registry = yield* ToolRegistry.Service
+      const url = "https://1.1.1.1/deep-html"
+
+      expect(yield* executeTool(registry, call({ url, format: "markdown" }))).toEqual({
+        type: "error",
+        value: `Unable to fetch ${url}`,
+      })
+    }),
+  )
+
+  it.effect("rejects declared and streamed oversized bodies", () =>
+    Effect.gen(function* () {
+      reset()
+      const registry = yield* ToolRegistry.Service
+      respond = () =>
+        Effect.succeed(
+          new Response("small", {
+            headers: { "content-type": "text/plain", "content-length": String(WebFetchTool.MAX_RESPONSE_BYTES + 1) },
+          }),
+        )
+      expect(yield* executeTool(registry, call({ url: "https://1.1.1.1/declared", format: "text" }))).toEqual({
+        type: "error",
+        value: "Unable to fetch https://1.1.1.1/declared",
+      })
+
+      respond = () =>
+        Effect.succeed(
+          new Response("x".repeat(WebFetchTool.MAX_RESPONSE_BYTES + 1), { headers: { "content-type": "text/plain" } }),
+        )
+      expect(yield* executeTool(registry, call({ url: "https://1.1.1.1/streamed", format: "text" }))).toEqual({
+        type: "error",
+        value: "Unable to fetch https://1.1.1.1/streamed",
+      })
+    }),
+  )
+
+  it.effect("keeps images and files unsupported until typed settlement can carry attachments", () =>
+    Effect.gen(function* () {
+      reset()
+      const registry = yield* ToolRegistry.Service
+      respond = () => Effect.succeed(new Response("png", { headers: { "content-type": "image/png" } }))
+      expect(yield* executeTool(registry, call({ url: "https://1.1.1.1/image", format: "html" }))).toEqual({
+        type: "error",
+        value: "Unable to fetch https://1.1.1.1/image",
+      })
+
+      respond = () => Effect.succeed(new Response("pdf", { headers: { "content-type": "application/pdf" } }))
+      expect(yield* executeTool(registry, call({ url: "https://1.1.1.1/file", format: "html" }))).toEqual({
+        type: "error",
+        value: "Unable to fetch https://1.1.1.1/file",
+      })
+    }),
+  )
+
+  it.effect("retries Cloudflare challenges with an honest user agent", () =>
+    Effect.gen(function* () {
+      reset()
+      let count = 0
+      respond = () =>
+        Effect.succeed(
+          ++count === 1
+            ? new Response("challenge", { status: 403, headers: { "cf-mitigated": "challenge" } })
+            : new Response("ok", { headers: { "content-type": "text/plain" } }),
+        )
+      const registry = yield* ToolRegistry.Service
+
+      expect(yield* executeTool(registry, call({ url: "https://1.1.1.1", format: "text" }))).toEqual({
+        type: "text",
+        value: "ok",
+      })
+      expect(requests).toHaveLength(2)
+      expect(requests[0]?.headers["user-agent"]).toContain("Mozilla/5.0")
+      expect(requests[1]?.headers["user-agent"]).toBe("neurocode")
+    }),
+  )
+
+  it.effect("times out stalled requests", () =>
+    Effect.gen(function* () {
+      reset()
+      respond = () => Effect.never
+      const registry = yield* ToolRegistry.Service
+      const fiber = yield* executeTool(
+        registry,
+        call({ url: "https://1.1.1.1/slow", format: "text", timeout: 1 }),
+      ).pipe(Effect.forkChild)
+      yield* TestClock.adjust(Duration.seconds(1))
+
+      expect(yield* Fiber.join(fiber)).toEqual({ type: "error", value: "Unable to fetch https://1.1.1.1/slow" })
+    }),
+  )
+})