@neuraiproject/neurai-assets 1.8.1 → 1.8.2

package/README.md

@@ -37,6 +37,18 @@ Complete asset management library for Neurai blockchain. Supports creation, reis
 > (full name, owner `!` included: 31 mainnet / 121 testnet-regtest, validated
 > against a regtest node); peer `neurai-rpc ^0.6.0`.
 
+## 1.8.2: Transfer amounts given as decimal strings
+
+`transferAsset` failed with `Invalid parameter, missing or invalid quantity`
+on nodes before Neurai-DePIN `9834b03` (mainnet and testnet at the time of
+writing) when a recipient `amount` was a decimal string such as `"5"`, or when
+the asset change back to the sender was one that no JavaScript number carries
+exactly (the builder writes those as text). Those nodes read the amounts of
+`transfer` and `transferwithmessage` only from JSON numbers, like
+`asset_quantity`. They are now converted the same way as in 1.8.1, on the copy
+sent to the node; `message` and `expire_time` are left untouched. Numeric
+amounts are unchanged.
+
 ## 1.8.1: Issue quantities given as decimal strings
 
 `createRootAsset`, `createSubAsset`, `createDepinAsset` and
@@ -98,12 +110,13 @@ via `CheckAmountWithUnits`. Because the chain already does the ×10⁸ scaling
 itself, **the library must NOT pre-multiply** the value. Sending the raw
 display number is the only correct behavior; any extra factor on the wire
 either silently inflates the minted supply (`× 10⁸ → 100,000,000` tokens
-where the user asked for 1) or trips the daemon's
-`ParseFixedPoint` cap with `Invalid amount (3): …`.
+where the user asked for 1) or falls outside the range the daemon's amount
+parser accepts, with `Invalid amount (3): …`.
 
-A quantity can be a number or a plain decimal string (`"1000.25"`). A string
-keeps every digit; it is sent to the node as a JSON number, which is the only
-form `createrawtransaction` accepts for `asset_quantity`. A decimal that no
+A quantity or transfer amount can be a number or a plain decimal string
+(`"1000.25"`). A string keeps every digit; it is sent to the node as a JSON
+number, the only form nodes before Neurai-DePIN `9834b03` accept for asset
+amounts in `createrawtransaction` (newer nodes accept both). A decimal that no
 JavaScript number carries exactly is sent as an exact token, which requires
 the RPC function to serialize with `@neuraiproject/neurai-rpc` (its
 `getRPC()` does); any other serializer makes the node reject the call instead

package/dist/NeuraiAssets.global.js

@@ -8302,13 +8302,17 @@ var NeuraiAssetsBundle = (function (exports) {
 	/**
 	 * Asset amounts as `createrawtransaction` must receive them.
 	 *
-	 * The node reads `asset_quantity` (issue, issue_restricted, issue_qualifier,
-	 * reissue, reissue_restricted) and `change_quantity` (qualifier and tag
-	 * operations) only from JSON numbers: a quoted value fails `isNum()` and the
-	 * call is rejected with "missing asset data for key: asset_quantity". The
-	 * builders accept these amounts as decimal strings, which keep every digit the
-	 * caller wrote, so they are turned into JSON numbers here, on the copy of the
-	 * outputs sent to the node. The outputs returned to the caller keep the value
+	 * Nodes before Neurai-DePIN 9834b03 read every asset amount of
+	 * `createrawtransaction` only from JSON numbers: `asset_quantity` (issue,
+	 * issue_restricted, issue_qualifier, reissue, reissue_restricted),
+	 * `change_quantity` (qualifier and tag operations) and the amounts of
+	 * `transfer` and `transferwithmessage`. A quoted value fails `isNum()` and the
+	 * call is rejected ("missing asset data for key: asset_quantity", "missing or
+	 * invalid quantity"). The builders accept these amounts as decimal strings,
+	 * which keep every digit the caller wrote, and produce some themselves (an
+	 * asset change that no JavaScript number carries exactly), so they are turned
+	 * into JSON numbers here, on the copy of the outputs sent to the node. Newer
+	 * nodes accept both forms. The outputs returned to the caller keep the value
 	 * as it was given.
 	 */
 
@@ -8328,6 +8332,14 @@ var NeuraiAssetsBundle = (function (exports) {
 		/** Fields the node parses with `isNum()` inside an asset operation object. */
 		const NUMERIC_OPERATION_FIELDS = ['asset_quantity', 'change_quantity'];
 
+		/**
+		 * Operations whose keys are asset names mapped to amounts. `transferwithmessage`
+		 * also carries `message` (a string) and `expire_time` (an integer), which are
+		 * not amounts and are left alone.
+		 */
+		const TRANSFER_OPERATIONS = ['transfer', 'transferwithmessage'];
+		const TRANSFER_NON_AMOUNT_KEYS = ['message', 'expire_time'];
+
 		/** The largest magnitude whose 8-decimal values a double still names exactly. */
 		const MAX_EXACT_FRACTIONAL = Number.MAX_SAFE_INTEGER / 1e8;
 
@@ -8384,10 +8396,11 @@ var NeuraiAssetsBundle = (function (exports) {
 		}
 
 		/**
-		 * Copy of `createrawtransaction` outputs with the numeric asset fields
-		 * converted by {@link toRpcAmount}. XNA amounts and every other field are left
-		 * as they are: the node reads those with `AmountFromValue`, which also accepts
-		 * strings.
+		 * Copy of `createrawtransaction` outputs with the asset amounts converted by
+		 * {@link toRpcAmount}: `asset_quantity` and `change_quantity`, and the amounts
+		 * of `transfer` / `transferwithmessage`. XNA amounts and every other field are
+		 * left as they are: the node reads XNA amounts with `AmountFromValue`, which
+		 * also accepts strings.
 		 *
 		 * @param {Array<object>|object} outputs - Outputs as built (array of single-key objects, or one object)
 		 * @returns {Array<object>|object} Outputs to send, same shape
@@ -8404,9 +8417,17 @@ var NeuraiAssetsBundle = (function (exports) {
 		        continue;
 		      }
 		      const copy = { ...params };
-		      for (const field of NUMERIC_OPERATION_FIELDS) {
-		        if (copy[field] !== undefined && copy[field] !== null) {
-		          copy[field] = toRpcAmount(copy[field], field);
+		      if (TRANSFER_OPERATIONS.includes(operation)) {
+		        for (const [key, value] of Object.entries(copy)) {
+		          if (!TRANSFER_NON_AMOUNT_KEYS.includes(key) && value !== undefined && value !== null) {
+		            copy[key] = toRpcAmount(value, `${operation} amount of ${key}`);
+		          }
+		        }
+		      } else {
+		        for (const field of NUMERIC_OPERATION_FIELDS) {
+		          if (copy[field] !== undefined && copy[field] !== null) {
+		            copy[field] = toRpcAmount(copy[field], field);
+		          }
 		        }
 		      }
 		      converted[operation] = copy;
@@ -8790,8 +8811,9 @@ var NeuraiAssetsBundle = (function (exports) {
 		        vout: input.vout !== undefined ? input.vout : input.outputIndex
 		      }));
 
-		      // Call createrawtransaction. The node only accepts the asset quantities
-		      // as JSON numbers; the caller's outputs keep the values as given.
+		      // Call createrawtransaction. Nodes before Neurai-DePIN 9834b03 only
+		      // accept asset amounts as JSON numbers; the caller's outputs keep the
+		      // values as given.
 		      const rawTx = await this.rpc('createrawtransaction', [
 		        formattedInputs,
 		        prepareOutputsForRpc(outputs)
@@ -8926,8 +8948,8 @@ var NeuraiAssetsBundle = (function (exports) {
 		   *     (e.g. "1" for one token, "1.5" for one and a half tokens).
 		   *   - The lib must NOT pre-multiply by 10^8 or 10^units; the daemon
 		   *     does the 10^8 scaling itself, and any extra factor here lands
-		   *     duplicated and inflates the minted supply (or trips the
-		   *     ParseFixedPoint `exponent >= 18` cap → "Invalid amount (3)").
+		   *     duplicated and inflates the minted supply (or falls outside the
+		   *     range the node's amount parser accepts → "Invalid amount (3)").
 		   *
 		   * History: pre-1.2.2 multiplied by 10^units (correct only for units=0
 		   * assets, inflated everything else by 10^units). v1.2.2 changed to