@neuraiproject/neurai-assets 1.5.0 → 1.5.2

package/README.md

@@ -613,12 +613,26 @@ rejects with `unit must be larger than current unit selection`.
 The value read from the chain is still used, to check that the requested
 `quantity` fits the asset's precision.
 
-One consequence worth knowing: the **node-built** `rawTx` cannot reissue an
-asset whose `units` are above zero at all. `createrawtransaction`'s `reissue`
-object has no field for units and the node fills in `0`, so it refuses. That is
-a limitation of the RPC interface, not of the operation — build those offline
-with `createFromOperation(result.createTransactionBuild)`. The error message
-says so when you hit it.
+### Reissue is built locally
+
+`createrawtransaction`'s `reissue` object has no field for units, so the node
+fills in `0` and refuses any asset whose units are above zero
+(`unit must be larger than current unit selection`). Since 1.5.0 the two
+reissue operations therefore skip that RPC and build their `rawTx` with
+`createFromOperation`, which can say "keep the current units". They report
+`buildStrategy: 'local-builder'`; every other operation still reports
+`'rpc-node'`.
+
+This is why `@neuraiproject/neurai-create-transaction` is a runtime
+**dependency**, not just a dev one.
+
+One consequence to know about: on the local path `result.outputs` and `rawTx`
+describe the same operation but not the same output list. The node
+auto-generates the owner-token return while processing a reissue entry, so the
+RPC envelope omits it, while the locally built transaction carries it
+explicitly — three entries in `outputs` against four vouts in `rawTx`. Both are
+valid; parse `rawTx` when you need the outputs the chain will see, and do not
+index `outputs` against its vouts.
 
 ## Owner Tokens - IMPORTANT
 

package/dist/NeuraiAssets.global.js

@@ -6020,7 +6020,12 @@ var NeuraiAssetsBundle = (function (exports) {
 		    return 0;
 		  }
 
-		  const nameLength = Buffer.byteLength(String(descriptor.assetName), 'ascii');
+		  // One byte per character, matching how the payload encodes the name
+		  // (`serializeString` -> `asciiBytes`, which writes a single byte per char).
+		  // Node's byte-length helper would be equivalent here, but it hangs off a
+		  // global that browsers do not have: using it broke the extension bundle with
+		  // "Buffer is not defined", and this library does much of its work there.
+		  const nameLength = String(descriptor.assetName).length;
 		  const kind = descriptor.kind || 'transfer';
 
 		  // marker(3) + type(1) + CompactSize name length(1) + name
@@ -6304,11 +6309,14 @@ var NeuraiAssetsBundle = (function (exports) {
 		   * @throws {InsufficientFundsError} If not enough funds
 		   */
 		  async selectBaseCurrencyUTXOs(addresses, requiredAmount, buffer = 0.1, options = {}) {
-		    // Get all XNA UTXOs
-		    const allUTXOs = await this.getUTXOs(addresses, null);
-
-		    // Get mempool and filter
-		    const mempool = await this.getMempoolEntries(addresses);
+		    // Both reads describe the same addresses and neither feeds the other: the
+		    // mempool result only filters the UTXO result afterwards. Awaiting them in
+		    // sequence spent one extra network round trip per selection, which on a
+		    // remote RPC proxy is most of the time a wallet spends building anything.
+		    const [allUTXOs, mempool] = await Promise.all([
+		      this.getUTXOs(addresses, null),
+		      this.getMempoolEntries(addresses)
+		    ]);
 		    const unspentUTXOs = this.filterMempoolSpentUTXOs(allUTXOs, mempool);
 
 		    // Drop outpoints the caller already spends elsewhere in this transaction
@@ -6374,11 +6382,14 @@ var NeuraiAssetsBundle = (function (exports) {
 		      throw new Error('Asset name is required');
 		    }
 
-		    // Get all asset UTXOs
-		    const allUTXOs = await this.getUTXOs(addresses, assetName);
-
-		    // Get mempool and filter
-		    const mempool = await this.getMempoolEntries(addresses);
+		    // Both reads describe the same addresses and neither feeds the other: the
+		    // mempool result only filters the UTXO result afterwards. Awaiting them in
+		    // sequence spent one extra network round trip per selection, which on a
+		    // remote RPC proxy is most of the time a wallet spends building anything.
+		    const [allUTXOs, mempool] = await Promise.all([
+		      this.getUTXOs(addresses, assetName),
+		      this.getMempoolEntries(addresses)
+		    ]);
 		    const unspentUTXOs = this.filterMempoolSpentUTXOs(allUTXOs, mempool);
 
 		    const excluded = toOutpointSet(options.exclude);
@@ -6500,8 +6511,10 @@ var NeuraiAssetsBundle = (function (exports) {
 		   * @returns {Promise<bigint>} Total balance in 10^8-scaled units
 		   */
 		  async getBalanceRaw(addresses, assetName = null) {
-		    const utxos = await this.getUTXOs(addresses, assetName);
-		    const mempool = await this.getMempoolEntries(addresses);
+		    const [utxos, mempool] = await Promise.all([
+		      this.getUTXOs(addresses, assetName),
+		      this.getMempoolEntries(addresses)
+		    ]);
 		    const availableUTXOs = this.filterMempoolSpentUTXOs(utxos, mempool);
 
 		    return sumProtocolIntegers(availableUTXOs, 'satoshis', `${assetName || 'XNA'} utxo.satoshis`);
@@ -7989,6 +8002,44 @@ var NeuraiAssetsBundle = (function (exports) {
 		    throw new Error('build must be implemented by subclass');
 		  }
 
+		  /**
+		   * Start the fee-rate lookup without waiting for it.
+		   *
+		   * Every build needs the fee rate, and it depends on nothing the build
+		   * computes, so there is no reason for it to wait its turn behind the reads
+		   * that come first. Kicking it off early lets it share a round trip with
+		   * them; `estimateFee`/`estimateFeeSats` await the same memoised promise, so
+		   * the call still happens exactly once and a failure still surfaces there.
+		   *
+		   * The trailing `catch` only marks the promise as handled while nothing is
+		   * awaiting it — it attaches to a derived promise, so the original still
+		   * rejects for whoever awaits it later.
+		   *
+		   * @returns {void}
+		   */
+		  warmFeeRate() {
+		    if (this._feeRatePromise) {
+		      return;
+		    }
+		    this._feeRatePromise = this.utxoSelector.getFeeRate();
+		    this._feeRatePromise.catch(() => {});
+		  }
+
+		  /**
+		   * Start every read a build needs but that depends on nothing the build
+		   * computes: the fee rate and the NIP-040 asset marker.
+		   *
+		   * Both are memoised, so warming them costs no extra call — it only moves
+		   * them off the critical path. Every builder that reaches here goes on to
+		   * stamp a marker, so neither read is ever speculative.
+		   *
+		   * @returns {void}
+		   */
+		  warmChainReads() {
+		    this.warmFeeRate();
+		    this.resolveAssetMarker().catch(() => {});
+		  }
+
 		  /**
 		   * Estimate transaction fee.
 		   *
@@ -8002,9 +8053,7 @@ var NeuraiAssetsBundle = (function (exports) {
 		   * @returns {Promise<number>} Estimated fee in XNA
 		   */
 		  async estimateFee(inputs, outputs) {
-		    if (!this._feeRatePromise) {
-		      this._feeRatePromise = this.utxoSelector.getFeeRate();
-		    }
+		    this.warmFeeRate();
 		    const feeRate = await this._feeRatePromise;
 		    return this.utxoSelector.estimateFee(inputs, outputs, feeRate);
 		  }
@@ -8035,9 +8084,7 @@ var NeuraiAssetsBundle = (function (exports) {
 		   * @returns {Promise<bigint>} Estimated fee in satoshis
 		   */
 		  async estimateFeeSats(inputs, outputs) {
-		    if (!this._feeRatePromise) {
-		      this._feeRatePromise = this.utxoSelector.getFeeRate();
-		    }
+		    this.warmFeeRate();
 		    const feeRate = await this._feeRatePromise;
 		    return this.utxoSelector.estimateFeeSats(inputs, outputs, feeRate);
 		  }
@@ -8080,6 +8127,10 @@ var NeuraiAssetsBundle = (function (exports) {
 		      initialInputHint = 1
 		    } = options;
 
+		    // Covers the builders that never call assetExists, whose first read is
+		    // this one.
+		    this.warmChainReads();
+
 		    const addresses = await this._getAddresses();
 		    const excluded = UTXOSelector.toOutpointSet(exclude);
 		    // toOutpointSet returns the caller's Set untouched when it already is one;
@@ -8709,6 +8760,9 @@ var NeuraiAssetsBundle = (function (exports) {
 		   * @returns {Promise<boolean>} True if exists
 		   */
 		  async assetExists(assetName) {
+		    // This is the first read a build performs and its answer gates nothing but
+		    // the guard below, so let the build's other chain reads travel alongside it.
+		    this.warmChainReads();
 		    try {
 		      const assetData = await this.rpc('getassetdata', [assetName]);
 		      return assetData !== null && assetData !== undefined;
@@ -8728,6 +8782,9 @@ var NeuraiAssetsBundle = (function (exports) {
 		   * @returns {Promise<object|null>} Asset data or null if not found
 		   */
 		  async getAssetData(assetName) {
+		    // This is the first read a build performs and its answer gates nothing but
+		    // the guard below, so let the build's other chain reads travel alongside it.
+		    this.warmChainReads();
 		    try {
 		      return await this.rpc('getassetdata', [assetName]);
 		    } catch (error) {