@netlify/plugin-nextjs 4.9.3 → 4.11.0

package/lib/helpers/edge.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.updateConfig = exports.writeEdgeFunctions = void 0;
+exports.updateConfig = exports.writeEdgeFunctions = exports.loadMiddlewareManifest = void 0;
 const fs_1 = require("fs");
 const path_1 = require("path");
 const fs_extra_1 = require("fs-extra");
@@ -11,6 +11,7 @@ const loadMiddlewareManifest = (netlifyConfig) => {
     }
     return (0, fs_extra_1.readJson)(middlewarePath);
 };
+exports.loadMiddlewareManifest = loadMiddlewareManifest;
 /**
  * Convert the Next middleware name into a valid Edge Function name
  */
@@ -69,35 +70,30 @@ const writeEdgeFunction = async ({ edgeFunctionDefinition, edgeFunctionRoot, net
  * Writes Edge Functions for the Next middleware
  */
 const writeEdgeFunctions = async (netlifyConfig) => {
-    const middlewareManifest = await loadMiddlewareManifest(netlifyConfig);
-    if (!middlewareManifest) {
-        console.error("Couldn't find the middleware manifest");
-        return;
-    }
     const manifest = {
         functions: [],
         version: 1,
     };
     const edgeFunctionRoot = (0, path_1.resolve)('.netlify', 'edge-functions');
     await (0, fs_extra_1.emptyDir)(edgeFunctionRoot);
-    await copyEdgeSourceFile({ edgeFunctionDir: edgeFunctionRoot, file: 'ipx.ts' });
-    manifest.functions.push({
-        function: 'ipx',
-        path: '/_next/image*',
-    });
-    for (const middleware of middlewareManifest.sortedMiddleware) {
-        const edgeFunctionDefinition = middlewareManifest.middleware[middleware];
-        const functionDefinition = await writeEdgeFunction({
-            edgeFunctionDefinition,
-            edgeFunctionRoot,
-            netlifyConfig,
+    if (!process.env.NEXT_DISABLE_EDGE_IMAGES) {
+        if (!process.env.NEXT_USE_NETLIFY_EDGE) {
+            console.log('Using Netlify Edge Functions for image format detection. Set env var "NEXT_DISABLE_EDGE_IMAGES=true" to disable.');
+        }
+        await copyEdgeSourceFile({ edgeFunctionDir: edgeFunctionRoot, file: 'ipx.ts' });
+        manifest.functions.push({
+            function: 'ipx',
+            path: '/_next/image*',
         });
-        manifest.functions.push(functionDefinition);
     }
-    // Older versions of the manifest format don't have the functions field
-    // No, the version field was not incremented
-    if (typeof middlewareManifest.functions === 'object') {
-        for (const edgeFunctionDefinition of Object.values(middlewareManifest.functions)) {
+    if (process.env.NEXT_USE_NETLIFY_EDGE) {
+        const middlewareManifest = await (0, exports.loadMiddlewareManifest)(netlifyConfig);
+        if (!middlewareManifest) {
+            console.error("Couldn't find the middleware manifest");
+            return;
+        }
+        for (const middleware of middlewareManifest.sortedMiddleware) {
+            const edgeFunctionDefinition = middlewareManifest.middleware[middleware];
             const functionDefinition = await writeEdgeFunction({
                 edgeFunctionDefinition,
                 edgeFunctionRoot,
@@ -105,6 +101,18 @@ const writeEdgeFunctions = async (netlifyConfig) => {
             });
             manifest.functions.push(functionDefinition);
         }
+        // Older versions of the manifest format don't have the functions field
+        // No, the version field was not incremented
+        if (typeof middlewareManifest.functions === 'object') {
+            for (const edgeFunctionDefinition of Object.values(middlewareManifest.functions)) {
+                const functionDefinition = await writeEdgeFunction({
+                    edgeFunctionDefinition,
+                    edgeFunctionRoot,
+                    netlifyConfig,
+                });
+                manifest.functions.push(functionDefinition);
+            }
+        }
     }
     await (0, fs_extra_1.writeJson)((0, path_1.join)(edgeFunctionRoot, 'manifest.json'), manifest);
 };

package/lib/helpers/functions.js

@@ -52,15 +52,14 @@ const setupImageFunction = async ({ constants: { INTERNAL_FUNCTIONS_SRC, FUNCTIO
     });
     await (0, fs_extra_1.copyFile)((0, pathe_1.join)(__dirname, '..', '..', 'lib', 'templates', 'ipx.js'), (0, pathe_1.join)(functionDirectory, functionName));
     const imagePath = imageconfig.path || '/_next/image';
-    // If we have edge, we use content negotiation instead of the redirect
-    if (!process.env.NEXT_USE_NETLIFY_EDGE) {
-        netlifyConfig.redirects.push({
-            from: `${imagePath}*`,
-            query: { url: ':url', w: ':width', q: ':quality' },
-            to: `${basePath}/${constants_1.IMAGE_FUNCTION_NAME}/w_:width,q_:quality/:url`,
-            status: 301,
-        });
-    }
+    // If we have edge functions then the request will have already been rewritten
+    // so this won't match. This is matched if edge is disabled or unavailable.
+    netlifyConfig.redirects.push({
+        from: `${imagePath}*`,
+        query: { url: ':url', w: ':width', q: ':quality' },
+        to: `${basePath}/${constants_1.IMAGE_FUNCTION_NAME}/w_:width,q_:quality/:url`,
+        status: 301,
+    });
     netlifyConfig.redirects.push({
         from: `${basePath}/${constants_1.IMAGE_FUNCTION_NAME}/*`,
         to: `/.netlify/builders/${constants_1.IMAGE_FUNCTION_NAME}`,

package/lib/index.js

@@ -34,6 +34,7 @@ const plugin = {
         netlifyConfig.build.environment.NEXT_PRIVATE_TARGET = 'server';
     },
     async onBuild({ constants, netlifyConfig, utils: { build: { failBuild }, }, }) {
+        var _a;
         if ((0, utils_1.shouldSkip)()) {
             return;
         }
@@ -85,14 +86,23 @@ const plugin = {
             nextConfig: { basePath, i18n, trailingSlash, appDir },
             buildId,
         });
+        // We call this even if we don't have edge functions enabled because we still use it for images
+        await (0, edge_1.writeEdgeFunctions)(netlifyConfig);
         if (process.env.NEXT_USE_NETLIFY_EDGE) {
             console.log((0, outdent_1.outdent) `
         ✨ Deploying to ${(0, chalk_1.greenBright) `Netlify Edge Functions`} ✨
         This feature is in beta. Please share your feedback here: https://ntl.fyi/next-netlify-edge
       `);
-            await (0, edge_1.writeEdgeFunctions)(netlifyConfig);
             await (0, edge_1.updateConfig)(publish);
         }
+        const middlewareManifest = await (0, edge_1.loadMiddlewareManifest)(netlifyConfig);
+        if (!process.env.NEXT_USE_NETLIFY_EDGE && ((_a = middlewareManifest === null || middlewareManifest === void 0 ? void 0 : middlewareManifest.sortedMiddleware) === null || _a === void 0 ? void 0 : _a.length)) {
+            console.log((0, chalk_1.yellowBright)((0, outdent_1.outdent) `
+          You are using Next.js Middleware without Netlify Edge Functions.
+          This will soon be deprecated because it negatively affects performance and will disable ISR and static rendering.
+          To get the best performance and use Netlify Edge Functions, set the env var ${(0, chalk_1.bold) `NEXT_USE_NETLIFY_EDGE=true`}.
+        `));
+        }
     },
     async onPostBuild({ netlifyConfig: { build: { publish }, redirects, headers, }, utils: { status, cache, functions, build: { failBuild }, }, constants: { FUNCTIONS_DIST }, }) {
         await (0, cache_1.saveCache)({ cache, publish });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@netlify/plugin-nextjs",
-  "version": "4.9.3",
+  "version": "4.11.0",
   "description": "Run Next.js seamlessly on Netlify",
   "main": "lib/index.js",
   "files": [
@@ -28,11 +28,11 @@
   },
   "devDependencies": {
     "@delucis/if-env": "^1.1.2",
-    "@netlify/build": "^27.2.0",
+    "@netlify/build": "^27.3.1",
     "@types/fs-extra": "^9.0.13",
     "@types/jest": "^27.4.1",
     "@types/node": "^17.0.25",
-    "next": "^12.1.7-canary.33",
+    "next": "^12.2.0",
     "npm-run-all": "^4.1.5",
     "typescript": "^4.6.3"
   },

package/src/templates/edge/ipx.ts

@@ -1,32 +1,52 @@
-import { Accepts } from 'https://deno.land/x/accepts/mod.ts'
-import type { Context } from 'netlify:edge'
+import { Accepts } from "https://deno.land/x/accepts@2.1.1/mod.ts";
+import type { Context } from "netlify:edge";
+import imageconfig from "../functions-internal/_ipx/imageconfig.json" assert {
+  type: "json",
+};
+
+const defaultFormat = "webp"
 
 /**
  * Implement content negotiation for images
  */
 
+// deno-lint-ignore require-await
 const handler = async (req: Request, context: Context) => {
-  const { searchParams } = new URL(req.url)
-  const accept = new Accepts(req.headers)
-  const type = accept.types(['avif', 'webp'])
+  const { searchParams } = new URL(req.url);
+  const accept = new Accepts(req.headers);
+  const { formats = [defaultFormat] } = imageconfig;
+  if (formats.length === 0) {
+    formats.push(defaultFormat);
+  }
+  let type = accept.types(formats) || defaultFormat;
+  if(Array.isArray(type)) {
+    type = type[0];
+  }
 
-  const source = searchParams.get('url')
-  const width = searchParams.get('w')
-  const quality = searchParams.get('q') ?? 75
+
+  const source = searchParams.get("url");
+  const width = searchParams.get("w");
+  const quality = searchParams.get("q") ?? 75;
 
   if (!source || !width) {
-    return new Response('Invalid request', {
+    return new Response("Invalid request", {
       status: 400,
-    })
+    });
   }
 
-  const modifiers = [`w_${width}`, `q_${quality}`]
+  const modifiers = [`w_${width}`, `q_${quality}`];
 
   if (type) {
-    modifiers.push(`f_${type}`)
+    if(type.includes('/')) {
+      // If this is a mimetype, strip "image/"
+      type = type.split('/')[1];
+    }
+    modifiers.push(`f_${type}`);
   }
+  const target = `/_ipx/${modifiers.join(",")}/${encodeURIComponent(source)}`;
+  return context.rewrite(
+    target,
+  );
+};
 
-  return context.rewrite(`/_ipx/${modifiers.join(',')}/${encodeURIComponent(source)}`)
-}
-
-export default handler
+export default handler;